From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2713DC433ED for ; Wed, 7 Apr 2021 22:44:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EBE9C61182 for ; Wed, 7 Apr 2021 22:44:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229564AbhDGWoa (ORCPT ); Wed, 7 Apr 2021 18:44:30 -0400 Received: from mga01.intel.com ([192.55.52.88]:54289 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229497AbhDGWo3 (ORCPT ); Wed, 7 Apr 2021 18:44:29 -0400 IronPort-SDR: RdDDrUc3NVaQzzand2+Dmrlm0xk++cKV05nAfKxKeOy8mEIsQ1LixF6EAC7jjPpqBmy9gXPxoZ hClXri22hUkQ== X-IronPort-AV: E=McAfee;i="6000,8403,9947"; a="213810714" X-IronPort-AV: E=Sophos;i="5.82,204,1613462400"; d="scan'208";a="213810714" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Apr 2021 15:44:19 -0700 IronPort-SDR: o/HA7QaNy0S9YnUOxIdHHJ51jKs6oUG02IMh2U1axoSxnuNSchd7Qt6tov6LPOhExrxBmE3wOY NtJydVSHQm9w== X-IronPort-AV: E=Sophos;i="5.82,204,1613462400"; d="scan'208";a="441496506" Received: from tkokeray-mobl.amr.corp.intel.com (HELO khuang2-desk.gar.corp.intel.com) ([10.254.113.100]) by fmsmga004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Apr 2021 15:44:16 -0700 Date: Thu, 8 Apr 2021 10:44:14 +1200 From: Kai Huang To: Sean Christopherson Cc: kvm@vger.kernel.org, linux-sgx@vger.kernel.org, pbonzini@redhat.com, bp@alien8.de, jarkko@kernel.org, dave.hansen@intel.com, luto@kernel.org, rick.p.edgecombe@intel.com, haitao.huang@intel.com Subject: Re: [PATCH v4 06/11] KVM: VMX: Frame in ENCLS handler for SGX virtualization Message-Id: <20210408104414.29e93147fdd93305846a6ee6@intel.com> In-Reply-To: References: <4be4b49f63a6c66911683d0f093ca5ef0d3996d5.1617825858.git.kai.huang@intel.com> <20210408103349.c98c3adc94efa66ca048ce2c@intel.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-sgx@vger.kernel.org On Wed, 7 Apr 2021 22:35:32 +0000 Sean Christopherson wrote: > On Thu, Apr 08, 2021, Kai Huang wrote: > > On Wed, 7 Apr 2021 22:16:59 +0000 Sean Christopherson wrote: > > > On Thu, Apr 08, 2021, Kai Huang wrote: > > > > +int handle_encls(struct kvm_vcpu *vcpu) > > > > +{ > > > > + u32 leaf = (u32)vcpu->arch.regs[VCPU_REGS_RAX]; > > > > > > Please use kvm_rax_read(), I've been trying to discourage direct access to the > > > array. Which is ironic because I'm 100% certain I'm to blame for this. :-) > > > > Sure. But I think still, we should convert it to (u32) explicitly, so: > > > > u32 leaf = (u32)kvm_rax_read(vcpu); > > > > ? > > Ya, agreed, it helps document that it's deliberate. Do you have any other comments regarding to other patches? If no I can send another version rather quickly :)