From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73492C43461 for ; Thu, 8 Apr 2021 13:12:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3B96161074 for ; Thu, 8 Apr 2021 13:12:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231294AbhDHNM3 (ORCPT ); Thu, 8 Apr 2021 09:12:29 -0400 Received: from mail.kernel.org ([198.145.29.99]:34610 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229741AbhDHNM1 (ORCPT ); Thu, 8 Apr 2021 09:12:27 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 4745061164; Thu, 8 Apr 2021 13:12:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1617887535; bh=UkxxqNBKlJ55P8VMwpXP5sFNvpwUPW3grgDAns1lO+g=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=WT3GUcizBOlv68oy+sFxNpCQJMxP770siIVhSiAa3PcSwRRCCt5UYCA+kqinyniyL 8dfoHqwNkzOAI0FWD23WqA5u2Oii5zAAKh0egy/xjx2RG9qd3PgdoSCRhaE6UXrO6u TQg1/ArMGf7gTMoyXGa/LITy+gYNmv9gUOASkGboVdnaP7dL6KI6jCmIpY31Q0AbVD OpiPkBO5Gkd1GP4FFr5BxTCBC7wnMkiFBHRX0nyFThv6j51E+x4mPkXno6jIKlwnIn 0qJUOWTar82hUo1BOwgoyqIdIA6fCsng39Mhf4yBaE2FjES5bIMwnxUeGCDgfv+Dq+ kX6yqUDjCxhWQ== Date: Thu, 8 Apr 2021 14:11:57 +0100 From: Mark Brown To: "William A. Kennington III" Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, Joel Stanley Subject: Re: [PATCH] spi: Fix use-after-free with devm_spi_alloc_* Message-ID: <20210408131157.GD4516@sirena.org.uk> References: <20210407095527.2771582-1-wak@google.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="oj4kGyHlBMXGt3Le" Content-Disposition: inline In-Reply-To: <20210407095527.2771582-1-wak@google.com> X-Cookie: Editing is a rewording activity. User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --oj4kGyHlBMXGt3Le Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Apr 07, 2021 at 02:55:27AM -0700, William A. Kennington III wrote: > ------------[ cut here ]------------ > WARNING: CPU: 1 PID: 660 at lib/refcount.c:28 refcount_warn_saturate+0x108/0x174 > [] (refcount_warn_saturate) from [] (kobject_put+0x90/0x98) > [] (kobject_put) from [] (put_device+0x20/0x24) > r4:b6700140 Please think hard before including complete backtraces in upstream reports, they are very large and contain almost no useful information relative to their size so often obscure the relevant content in your message. If part of the backtrace is usefully illustrative (it often is for search engines if nothing else) then it's usually better to pull out the relevant sections. --oj4kGyHlBMXGt3Le Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmBvAR0ACgkQJNaLcl1U h9DWxQf9FuZoEVNDQAMRserLJRVhn6/DB//c7KRBHDyxactPwrQJIEenVgurmpUs KhSp0yV0H4AuM71aorlegp0JlDX54jLmkvTm7FiM17/qA26eOlVQOZeRiJiP7eb2 5gD/gumnUIHJZ/HMxP1WmFmxULLAChdlBrHw8Jje70JdageWSBVunvKhc8QqiKXb of6WO8XWjKH43Cc9yVxTFFNi1XoPy6TktCq6sMNaISoQ3dgNrXhsetEPCLquFopj BOw2ogS9fg7PJ7Y+QCgh5f/rnUQZvXSsCoL7XMki4bsOcWUdt9oUpRfiqnFG0H0L HZhG4AVVwDUh4lq89ljAXqjcAlD2wg== =sWeT -----END PGP SIGNATURE----- --oj4kGyHlBMXGt3Le--