From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0BD6C43461 for ; Thu, 8 Apr 2021 14:05:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A0B9B6102A for ; Thu, 8 Apr 2021 14:05:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231910AbhDHOFz (ORCPT ); Thu, 8 Apr 2021 10:05:55 -0400 Received: from mail.kernel.org ([198.145.29.99]:52714 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231901AbhDHOFw (ORCPT ); Thu, 8 Apr 2021 10:05:52 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id D048461130; Thu, 8 Apr 2021 14:05:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1617890741; bh=c/qgNDwkcocIuy/eJhJGCaujFtddkd4baMyo7n1aums=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Ns7+gXE2w1OZn9jYpdIJWjit9ZZNsYeSuJW0uCfDubH9WxaFHMVJu/sURWi8vPrIG 4TmLX//CxkxFWmTGiaWRe+PTju1ZXj9KhlpJVqWCB9UaivlPp4ogyv9yxzz8shn5kv uPSEu6a5H0bmsZYK/MDxQS5qQvVtqifBt7W3JuRcpRbmF7ASA2cNA+zcwryyTThAZ+ nnxOtJUw/XW6Fy0WR55AURmpMMhkRNSEatsiwIwul4BexTwPkgzswndY6HWic5sGoM 6TuIfWoUs8RSsmFf6/7goM9nJ/HxPYdfoDBKjQcljR5sR4Tbos9NzVsNWTilzPEBJe T1R/fLC3ktdPQ== Date: Thu, 8 Apr 2021 15:05:23 +0100 From: Mark Brown To: Clark Wang Cc: shawnguo@kernel.org, s.hauer@pengutronix.de, festevam@gmail.com, kernel@pengutronix.de, linux-imx@nxp.com, linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] spi: imx: add a check for speed_hz before calculating the clock Message-ID: <20210408140523.GH4516@sirena.org.uk> References: <20210408103347.244313-1-xiaoning.wang@nxp.com> <20210408103347.244313-2-xiaoning.wang@nxp.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="dMyqICaxQaaUjrCL" Content-Disposition: inline In-Reply-To: <20210408103347.244313-2-xiaoning.wang@nxp.com> X-Cookie: Editing is a rewording activity. User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --dMyqICaxQaaUjrCL Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Apr 08, 2021 at 06:33:47PM +0800, Clark Wang wrote: > When some drivers use spi to send data, spi_transfer->speed_hz is > not assigned. If spidev->max_speed_hz is not assigned as well, it > will cause an error in configuring the clock. Please don't send new patches in reply to other threads, this makes it harder to follow what current versions of things are and causes problems for tools. --dMyqICaxQaaUjrCL Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmBvDaIACgkQJNaLcl1U h9DpFwgAhu6kubADli5uS9eG0/RYPI4U2CNpsUZ+kwYdfdoNvEecSr9Qi16J+BG3 /UB7gUUx0vszDmJoECWgeuJjRw05iAJJgyZmmo6V3V+0AwcdhDTaNxAZOJy3eYUF Lt/R/Prz3KFS8PReOGJ6tlZWjZ3FdSF7nzyQBcqkHqGAyLEBgE6j/r/2oeY6KSps L7BXJrOHrzZL6K8ahmtD5cm69uIg3M74f21Un+ndGVoZf8m0XpZR16ivf0G1zfLg Ci+301tdOHk/UjbBQkhlVO80WQyr9U+e8daNV2WwxPLUdR4tY9ZvQxqWKM2/uNQa zTOJu2uF2otRJ8SDqrXs6MIlIDhJMA== =58bV -----END PGP SIGNATURE----- --dMyqICaxQaaUjrCL-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45B40C433B4 for ; Thu, 8 Apr 2021 14:07:18 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D44686113D for ; Thu, 8 Apr 2021 14:07:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D44686113D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Qe+k5lOLS5yeWFSA9uxX/BF77PI3eyB7TgHahh9LXqk=; b=hBUZ1CM2Jirilhp+uKF1woO/d EO6O4PwI9I39Ko/rnEe/OTjOxKzk2ycJ97pkX9EuMZuYNQxRDa30UjlKEx4x9df5VCyJrbs3Fg5zr i9zoZyEmUX6tIu4ZHnmYkkuKXPyw0JDmgXz2naBN5l6rxTUw34bRvtxFgdIPM9JqVNdKcT3WqO3uF TcD4heuNikuPc21RMcswewiRILDyjo6yhmQUqoCmrj9hy+hS3xJxfrdRdF7NfcCyiNE/ssAruTWw9 PxeyFcYWzPvRuEFT3H9iplQDEt8wVOiweMLNQRbD8JTIsOy7m9fOlWym/HJw4sDSDq4gJiyW384OP 69jdvQT6g==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lUVI3-008DVh-U6; Thu, 08 Apr 2021 14:05:48 +0000 Received: from mail.kernel.org ([198.145.29.99]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lUVHy-008DUy-TC for linux-arm-kernel@lists.infradead.org; Thu, 08 Apr 2021 14:05:44 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id D048461130; Thu, 8 Apr 2021 14:05:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1617890741; bh=c/qgNDwkcocIuy/eJhJGCaujFtddkd4baMyo7n1aums=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Ns7+gXE2w1OZn9jYpdIJWjit9ZZNsYeSuJW0uCfDubH9WxaFHMVJu/sURWi8vPrIG 4TmLX//CxkxFWmTGiaWRe+PTju1ZXj9KhlpJVqWCB9UaivlPp4ogyv9yxzz8shn5kv uPSEu6a5H0bmsZYK/MDxQS5qQvVtqifBt7W3JuRcpRbmF7ASA2cNA+zcwryyTThAZ+ nnxOtJUw/XW6Fy0WR55AURmpMMhkRNSEatsiwIwul4BexTwPkgzswndY6HWic5sGoM 6TuIfWoUs8RSsmFf6/7goM9nJ/HxPYdfoDBKjQcljR5sR4Tbos9NzVsNWTilzPEBJe T1R/fLC3ktdPQ== Date: Thu, 8 Apr 2021 15:05:23 +0100 From: Mark Brown To: Clark Wang Cc: shawnguo@kernel.org, s.hauer@pengutronix.de, festevam@gmail.com, kernel@pengutronix.de, linux-imx@nxp.com, linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] spi: imx: add a check for speed_hz before calculating the clock Message-ID: <20210408140523.GH4516@sirena.org.uk> References: <20210408103347.244313-1-xiaoning.wang@nxp.com> <20210408103347.244313-2-xiaoning.wang@nxp.com> MIME-Version: 1.0 In-Reply-To: <20210408103347.244313-2-xiaoning.wang@nxp.com> X-Cookie: Editing is a rewording activity. User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210408_150543_261910_9215D3F1 X-CRM114-Status: GOOD ( 10.89 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============4583919396792137445==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============4583919396792137445== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="dMyqICaxQaaUjrCL" Content-Disposition: inline --dMyqICaxQaaUjrCL Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Apr 08, 2021 at 06:33:47PM +0800, Clark Wang wrote: > When some drivers use spi to send data, spi_transfer->speed_hz is > not assigned. If spidev->max_speed_hz is not assigned as well, it > will cause an error in configuring the clock. Please don't send new patches in reply to other threads, this makes it harder to follow what current versions of things are and causes problems for tools. --dMyqICaxQaaUjrCL Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmBvDaIACgkQJNaLcl1U h9DpFwgAhu6kubADli5uS9eG0/RYPI4U2CNpsUZ+kwYdfdoNvEecSr9Qi16J+BG3 /UB7gUUx0vszDmJoECWgeuJjRw05iAJJgyZmmo6V3V+0AwcdhDTaNxAZOJy3eYUF Lt/R/Prz3KFS8PReOGJ6tlZWjZ3FdSF7nzyQBcqkHqGAyLEBgE6j/r/2oeY6KSps L7BXJrOHrzZL6K8ahmtD5cm69uIg3M74f21Un+ndGVoZf8m0XpZR16ivf0G1zfLg Ci+301tdOHk/UjbBQkhlVO80WQyr9U+e8daNV2WwxPLUdR4tY9ZvQxqWKM2/uNQa zTOJu2uF2otRJ8SDqrXs6MIlIDhJMA== =58bV -----END PGP SIGNATURE----- --dMyqICaxQaaUjrCL-- --===============4583919396792137445== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============4583919396792137445==--