From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9E32C433B4 for ; Thu, 8 Apr 2021 14:19:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B65756024A for ; Thu, 8 Apr 2021 14:19:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231727AbhDHOTZ (ORCPT ); Thu, 8 Apr 2021 10:19:25 -0400 Received: from mail.kernel.org ([198.145.29.99]:32778 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232084AbhDHOTL (ORCPT ); Thu, 8 Apr 2021 10:19:11 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id B87866024A; Thu, 8 Apr 2021 14:18:57 +0000 (UTC) Date: Thu, 8 Apr 2021 15:18:55 +0100 From: Catalin Marinas To: Steven Price Cc: David Hildenbrand , Mark Rutland , Peter Maydell , "Dr. David Alan Gilbert" , Andrew Jones , Haibo Xu , Suzuki K Poulose , qemu-devel@nongnu.org, Marc Zyngier , Juan Quintela , Richard Henderson , linux-kernel@vger.kernel.org, Dave Martin , James Morse , linux-arm-kernel@lists.infradead.org, Thomas Gleixner , Will Deacon , kvmarm@lists.cs.columbia.edu, Julien Thierry Subject: Re: [PATCH v10 2/6] arm64: kvm: Introduce MTE VM feature Message-ID: <20210408141853.GA7676@arm.com> References: <20210330103013.GD18075@arm.com> <8977120b-841d-4882-2472-6e403bc9c797@redhat.com> <20210331092109.GA21921@arm.com> <86a968c8-7a0e-44a4-28c3-bac62c2b7d65@arm.com> <20210331184311.GA10737@arm.com> <20210407151458.GC21451@arm.com> <5e5bf772-1e4d-ca59-a9d8-058a72dfad4f@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5e5bf772-1e4d-ca59-a9d8-058a72dfad4f@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 07, 2021 at 04:52:54PM +0100, Steven Price wrote: > On 07/04/2021 16:14, Catalin Marinas wrote: > > On Wed, Apr 07, 2021 at 11:20:18AM +0100, Steven Price wrote: > > > On 31/03/2021 19:43, Catalin Marinas wrote: > > > > When a slot is added by the VMM, if it asked for MTE in guest (I guess > > > > that's an opt-in by the VMM, haven't checked the other patches), can we > > > > reject it if it's is going to be mapped as Normal Cacheable but it is a > > > > ZONE_DEVICE (i.e. !kvm_is_device_pfn() + one of David's suggestions to > > > > check for ZONE_DEVICE)? This way we don't need to do more expensive > > > > checks in set_pte_at(). > > > > > > The problem is that KVM allows the VMM to change the memory backing a slot > > > while the guest is running. This is obviously useful for the likes of > > > migration, but ultimately means that even if you were to do checks at the > > > time of slot creation, you would need to repeat the checks at set_pte_at() > > > time to ensure a mischievous VMM didn't swap the page for a problematic one. > > > > Does changing the slot require some KVM API call? Can we intercept it > > and do the checks there? > > As David has already replied - KVM uses MMU notifiers, so there's not really > a good place to intercept this before the fault. > > > Maybe a better alternative for the time being is to add a new > > kvm_is_zone_device_pfn() and force KVM_PGTABLE_PROT_DEVICE if it returns > > true _and_ the VMM asked for MTE in guest. We can then only set > > PG_mte_tagged if !device. > > KVM already has a kvm_is_device_pfn(), and yes I agree restricting the MTE > checks to only !kvm_is_device_pfn() makes sense (I have the fix in my branch > locally). Indeed, you can skip it if kvm_is_device_pfn(). In addition, with MTE, I'd also mark a pfn as 'device' in user_mem_abort() if pfn_to_online_page() is NULL as we don't want to map it as Cacheable in Stage 2. It's unlikely that we'll trip over this path but just in case. (can we have a ZONE_DEVICE _online_ pfn or by definition they are considered offline?) > > BTW, after a page is restored from swap, how long do we keep the > > metadata around? I think we can delete it as soon as it was restored and > > PG_mte_tagged was set. Currently it looks like we only do this when the > > actual page was freed or swapoff. I haven't convinced myself that it's > > safe to do this for swapoff unless it guarantees that all the ptes > > sharing a page have been restored. > > My initial thought was to free the metadata immediately. However it turns > out that the following sequence can happen: > > 1. Swap out a page > 2. Swap the page in *read only* > 3. Discard the page > 4. Swap the page in again > > So there's no writing of the swap data again before (3). This works nicely > with a swap device because after writing a page it stays there forever, so > if you know it hasn't been modified it's pointless rewriting it. Sadly it's > not quite so ideal with the MTE tags which are currently kept in RAM. I missed this scenario. So we need to keep it around as long as the corresponding swap storage is still valid. -- Catalin From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C959AC433ED for ; Thu, 8 Apr 2021 14:21:23 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6E8ED610A3 for ; Thu, 8 Apr 2021 14:21:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6E8ED610A3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:38338 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lUVX8-000099-DA for qemu-devel@archiver.kernel.org; Thu, 08 Apr 2021 10:21:22 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42752) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lUVUx-0007L0-Vi for qemu-devel@nongnu.org; Thu, 08 Apr 2021 10:19:08 -0400 Received: from mail.kernel.org ([198.145.29.99]:49710) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lUVUt-0006UB-Al for qemu-devel@nongnu.org; Thu, 08 Apr 2021 10:19:07 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id B87866024A; Thu, 8 Apr 2021 14:18:57 +0000 (UTC) Date: Thu, 8 Apr 2021 15:18:55 +0100 From: Catalin Marinas To: Steven Price Subject: Re: [PATCH v10 2/6] arm64: kvm: Introduce MTE VM feature Message-ID: <20210408141853.GA7676@arm.com> References: <20210330103013.GD18075@arm.com> <8977120b-841d-4882-2472-6e403bc9c797@redhat.com> <20210331092109.GA21921@arm.com> <86a968c8-7a0e-44a4-28c3-bac62c2b7d65@arm.com> <20210331184311.GA10737@arm.com> <20210407151458.GC21451@arm.com> <5e5bf772-1e4d-ca59-a9d8-058a72dfad4f@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5e5bf772-1e4d-ca59-a9d8-058a72dfad4f@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) Received-SPF: pass client-ip=198.145.29.99; envelope-from=cmarinas@kernel.org; helo=mail.kernel.org X-Spam_score_int: -66 X-Spam_score: -6.7 X-Spam_bar: ------ X-Spam_report: (-6.7 / 5.0 requ) BAYES_00=-1.9, HEADER_FROM_DIFFERENT_DOMAINS=0.25, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Peter Maydell , Andrew Jones , Haibo Xu , David Hildenbrand , Marc Zyngier , Suzuki K Poulose , Richard Henderson , "Dr. David Alan Gilbert" , qemu-devel@nongnu.org, Juan Quintela , James Morse , linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, Thomas Gleixner , Julien Thierry , Will Deacon , Dave Martin , linux-kernel@vger.kernel.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Wed, Apr 07, 2021 at 04:52:54PM +0100, Steven Price wrote: > On 07/04/2021 16:14, Catalin Marinas wrote: > > On Wed, Apr 07, 2021 at 11:20:18AM +0100, Steven Price wrote: > > > On 31/03/2021 19:43, Catalin Marinas wrote: > > > > When a slot is added by the VMM, if it asked for MTE in guest (I guess > > > > that's an opt-in by the VMM, haven't checked the other patches), can we > > > > reject it if it's is going to be mapped as Normal Cacheable but it is a > > > > ZONE_DEVICE (i.e. !kvm_is_device_pfn() + one of David's suggestions to > > > > check for ZONE_DEVICE)? This way we don't need to do more expensive > > > > checks in set_pte_at(). > > > > > > The problem is that KVM allows the VMM to change the memory backing a slot > > > while the guest is running. This is obviously useful for the likes of > > > migration, but ultimately means that even if you were to do checks at the > > > time of slot creation, you would need to repeat the checks at set_pte_at() > > > time to ensure a mischievous VMM didn't swap the page for a problematic one. > > > > Does changing the slot require some KVM API call? Can we intercept it > > and do the checks there? > > As David has already replied - KVM uses MMU notifiers, so there's not really > a good place to intercept this before the fault. > > > Maybe a better alternative for the time being is to add a new > > kvm_is_zone_device_pfn() and force KVM_PGTABLE_PROT_DEVICE if it returns > > true _and_ the VMM asked for MTE in guest. We can then only set > > PG_mte_tagged if !device. > > KVM already has a kvm_is_device_pfn(), and yes I agree restricting the MTE > checks to only !kvm_is_device_pfn() makes sense (I have the fix in my branch > locally). Indeed, you can skip it if kvm_is_device_pfn(). In addition, with MTE, I'd also mark a pfn as 'device' in user_mem_abort() if pfn_to_online_page() is NULL as we don't want to map it as Cacheable in Stage 2. It's unlikely that we'll trip over this path but just in case. (can we have a ZONE_DEVICE _online_ pfn or by definition they are considered offline?) > > BTW, after a page is restored from swap, how long do we keep the > > metadata around? I think we can delete it as soon as it was restored and > > PG_mte_tagged was set. Currently it looks like we only do this when the > > actual page was freed or swapoff. I haven't convinced myself that it's > > safe to do this for swapoff unless it guarantees that all the ptes > > sharing a page have been restored. > > My initial thought was to free the metadata immediately. However it turns > out that the following sequence can happen: > > 1. Swap out a page > 2. Swap the page in *read only* > 3. Discard the page > 4. Swap the page in again > > So there's no writing of the swap data again before (3). This works nicely > with a swap device because after writing a page it stays there forever, so > if you know it hasn't been modified it's pointless rewriting it. Sadly it's > not quite so ideal with the MTE tags which are currently kept in RAM. I missed this scenario. So we need to keep it around as long as the corresponding swap storage is still valid. -- Catalin From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46169C433B4 for ; Thu, 8 Apr 2021 14:19:06 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id B164A61151 for ; Thu, 8 Apr 2021 14:19:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B164A61151 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvmarm-bounces@lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 381544B94A; Thu, 8 Apr 2021 10:19:05 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 2GcqtgQWWJFI; Thu, 8 Apr 2021 10:19:04 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 1A3814B968; Thu, 8 Apr 2021 10:19:04 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 244C84B94A for ; Thu, 8 Apr 2021 10:19:03 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id d8gjPC2JQrRu for ; Thu, 8 Apr 2021 10:19:02 -0400 (EDT) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id CF8BA4B74C for ; Thu, 8 Apr 2021 10:19:01 -0400 (EDT) Received: by mail.kernel.org (Postfix) with ESMTPSA id B87866024A; Thu, 8 Apr 2021 14:18:57 +0000 (UTC) Date: Thu, 8 Apr 2021 15:18:55 +0100 From: Catalin Marinas To: Steven Price Subject: Re: [PATCH v10 2/6] arm64: kvm: Introduce MTE VM feature Message-ID: <20210408141853.GA7676@arm.com> References: <20210330103013.GD18075@arm.com> <8977120b-841d-4882-2472-6e403bc9c797@redhat.com> <20210331092109.GA21921@arm.com> <86a968c8-7a0e-44a4-28c3-bac62c2b7d65@arm.com> <20210331184311.GA10737@arm.com> <20210407151458.GC21451@arm.com> <5e5bf772-1e4d-ca59-a9d8-058a72dfad4f@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <5e5bf772-1e4d-ca59-a9d8-058a72dfad4f@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) Cc: David Hildenbrand , Marc Zyngier , Richard Henderson , "Dr. David Alan Gilbert" , qemu-devel@nongnu.org, Juan Quintela , linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, Thomas Gleixner , Will Deacon , Dave Martin , linux-kernel@vger.kernel.org X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu On Wed, Apr 07, 2021 at 04:52:54PM +0100, Steven Price wrote: > On 07/04/2021 16:14, Catalin Marinas wrote: > > On Wed, Apr 07, 2021 at 11:20:18AM +0100, Steven Price wrote: > > > On 31/03/2021 19:43, Catalin Marinas wrote: > > > > When a slot is added by the VMM, if it asked for MTE in guest (I guess > > > > that's an opt-in by the VMM, haven't checked the other patches), can we > > > > reject it if it's is going to be mapped as Normal Cacheable but it is a > > > > ZONE_DEVICE (i.e. !kvm_is_device_pfn() + one of David's suggestions to > > > > check for ZONE_DEVICE)? This way we don't need to do more expensive > > > > checks in set_pte_at(). > > > > > > The problem is that KVM allows the VMM to change the memory backing a slot > > > while the guest is running. This is obviously useful for the likes of > > > migration, but ultimately means that even if you were to do checks at the > > > time of slot creation, you would need to repeat the checks at set_pte_at() > > > time to ensure a mischievous VMM didn't swap the page for a problematic one. > > > > Does changing the slot require some KVM API call? Can we intercept it > > and do the checks there? > > As David has already replied - KVM uses MMU notifiers, so there's not really > a good place to intercept this before the fault. > > > Maybe a better alternative for the time being is to add a new > > kvm_is_zone_device_pfn() and force KVM_PGTABLE_PROT_DEVICE if it returns > > true _and_ the VMM asked for MTE in guest. We can then only set > > PG_mte_tagged if !device. > > KVM already has a kvm_is_device_pfn(), and yes I agree restricting the MTE > checks to only !kvm_is_device_pfn() makes sense (I have the fix in my branch > locally). Indeed, you can skip it if kvm_is_device_pfn(). In addition, with MTE, I'd also mark a pfn as 'device' in user_mem_abort() if pfn_to_online_page() is NULL as we don't want to map it as Cacheable in Stage 2. It's unlikely that we'll trip over this path but just in case. (can we have a ZONE_DEVICE _online_ pfn or by definition they are considered offline?) > > BTW, after a page is restored from swap, how long do we keep the > > metadata around? I think we can delete it as soon as it was restored and > > PG_mte_tagged was set. Currently it looks like we only do this when the > > actual page was freed or swapoff. I haven't convinced myself that it's > > safe to do this for swapoff unless it guarantees that all the ptes > > sharing a page have been restored. > > My initial thought was to free the metadata immediately. However it turns > out that the following sequence can happen: > > 1. Swap out a page > 2. Swap the page in *read only* > 3. Discard the page > 4. Swap the page in again > > So there's no writing of the swap data again before (3). This works nicely > with a swap device because after writing a page it stays there forever, so > if you know it hasn't been modified it's pointless rewriting it. Sadly it's > not quite so ideal with the MTE tags which are currently kept in RAM. I missed this scenario. So we need to keep it around as long as the corresponding swap storage is still valid. -- Catalin _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9371DC433B4 for ; Thu, 8 Apr 2021 14:20:37 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3B71F6024A for ; Thu, 8 Apr 2021 14:20:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3B71F6024A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=h5Ep/+02NNPTYI/BoUQDzIC1ZxDHYmgO7UppZyxiphU=; b=XK6AROAYUK6cmagZ/aaMHDy4m b6ObkF0nV38yMFeNEcPWzjYVR4M6WI8EV3n5wdVosjkP78I38+igkTN+r2d21f34mU9Y0A+gbEOZ6 0EOsHrcRMzAFONMf754cPRPCiybwfnE6Nzf0FiwmduIo/tYUUPgYxZ3MGpcKefm1zSPZpgZX/D/kl U6NSnCDk1IgzCLbfpnZ52X3t7A9rR2d0tOtPjpkTq3EfLjSXe30XGJtibSMgWfeEWPBMsQIHgDsTX VC4ZHlfhtPKEgLNXJSdcToejMqaXiUUeJHhHkOEDgmh3jzrbMP96fxr628PFb84ZgmEaXhugQ+EXf MpPONcBmA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lUVUy-008EbI-2A; Thu, 08 Apr 2021 14:19:09 +0000 Received: from mail.kernel.org ([198.145.29.99]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lUVUt-008Ea4-Sx for linux-arm-kernel@lists.infradead.org; Thu, 08 Apr 2021 14:19:05 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id B87866024A; Thu, 8 Apr 2021 14:18:57 +0000 (UTC) Date: Thu, 8 Apr 2021 15:18:55 +0100 From: Catalin Marinas To: Steven Price Cc: David Hildenbrand , Mark Rutland , Peter Maydell , "Dr. David Alan Gilbert" , Andrew Jones , Haibo Xu , Suzuki K Poulose , qemu-devel@nongnu.org, Marc Zyngier , Juan Quintela , Richard Henderson , linux-kernel@vger.kernel.org, Dave Martin , James Morse , linux-arm-kernel@lists.infradead.org, Thomas Gleixner , Will Deacon , kvmarm@lists.cs.columbia.edu, Julien Thierry Subject: Re: [PATCH v10 2/6] arm64: kvm: Introduce MTE VM feature Message-ID: <20210408141853.GA7676@arm.com> References: <20210330103013.GD18075@arm.com> <8977120b-841d-4882-2472-6e403bc9c797@redhat.com> <20210331092109.GA21921@arm.com> <86a968c8-7a0e-44a4-28c3-bac62c2b7d65@arm.com> <20210331184311.GA10737@arm.com> <20210407151458.GC21451@arm.com> <5e5bf772-1e4d-ca59-a9d8-058a72dfad4f@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <5e5bf772-1e4d-ca59-a9d8-058a72dfad4f@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210408_151904_331672_3F9C849F X-CRM114-Status: GOOD ( 37.21 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Apr 07, 2021 at 04:52:54PM +0100, Steven Price wrote: > On 07/04/2021 16:14, Catalin Marinas wrote: > > On Wed, Apr 07, 2021 at 11:20:18AM +0100, Steven Price wrote: > > > On 31/03/2021 19:43, Catalin Marinas wrote: > > > > When a slot is added by the VMM, if it asked for MTE in guest (I guess > > > > that's an opt-in by the VMM, haven't checked the other patches), can we > > > > reject it if it's is going to be mapped as Normal Cacheable but it is a > > > > ZONE_DEVICE (i.e. !kvm_is_device_pfn() + one of David's suggestions to > > > > check for ZONE_DEVICE)? This way we don't need to do more expensive > > > > checks in set_pte_at(). > > > > > > The problem is that KVM allows the VMM to change the memory backing a slot > > > while the guest is running. This is obviously useful for the likes of > > > migration, but ultimately means that even if you were to do checks at the > > > time of slot creation, you would need to repeat the checks at set_pte_at() > > > time to ensure a mischievous VMM didn't swap the page for a problematic one. > > > > Does changing the slot require some KVM API call? Can we intercept it > > and do the checks there? > > As David has already replied - KVM uses MMU notifiers, so there's not really > a good place to intercept this before the fault. > > > Maybe a better alternative for the time being is to add a new > > kvm_is_zone_device_pfn() and force KVM_PGTABLE_PROT_DEVICE if it returns > > true _and_ the VMM asked for MTE in guest. We can then only set > > PG_mte_tagged if !device. > > KVM already has a kvm_is_device_pfn(), and yes I agree restricting the MTE > checks to only !kvm_is_device_pfn() makes sense (I have the fix in my branch > locally). Indeed, you can skip it if kvm_is_device_pfn(). In addition, with MTE, I'd also mark a pfn as 'device' in user_mem_abort() if pfn_to_online_page() is NULL as we don't want to map it as Cacheable in Stage 2. It's unlikely that we'll trip over this path but just in case. (can we have a ZONE_DEVICE _online_ pfn or by definition they are considered offline?) > > BTW, after a page is restored from swap, how long do we keep the > > metadata around? I think we can delete it as soon as it was restored and > > PG_mte_tagged was set. Currently it looks like we only do this when the > > actual page was freed or swapoff. I haven't convinced myself that it's > > safe to do this for swapoff unless it guarantees that all the ptes > > sharing a page have been restored. > > My initial thought was to free the metadata immediately. However it turns > out that the following sequence can happen: > > 1. Swap out a page > 2. Swap the page in *read only* > 3. Discard the page > 4. Swap the page in again > > So there's no writing of the swap data again before (3). This works nicely > with a swap device because after writing a page it stays there forever, so > if you know it hasn't been modified it's pointless rewriting it. Sadly it's > not quite so ideal with the MTE tags which are currently kept in RAM. I missed this scenario. So we need to keep it around as long as the corresponding swap storage is still valid. -- Catalin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel