From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11B2EC43460 for ; Thu, 8 Apr 2021 16:20:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DEEFC610CF for ; Thu, 8 Apr 2021 16:20:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232174AbhDHQUd (ORCPT ); Thu, 8 Apr 2021 12:20:33 -0400 Received: from mail-ot1-f49.google.com ([209.85.210.49]:41580 "EHLO mail-ot1-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231655AbhDHQUa (ORCPT ); Thu, 8 Apr 2021 12:20:30 -0400 Received: by mail-ot1-f49.google.com with SMTP id l12-20020a9d6a8c0000b0290238e0f9f0d8so2824302otq.8; Thu, 08 Apr 2021 09:20:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=FKQCy9mHVcIx4jvHTvGbM4mIzIxWpaBAJhioAHr5gKo=; b=jbBJxxchdkUWHboWgSu7qRPh9GhYxz405cFyejIzLjI7HoVekrRUwwheMwaKqFUyrQ mYeEDcDyLbMYM9ams1fV7mg0gtCkkHIZBFnvfL7sDOEGgzikQmNG1BGDolwc5KomSagS a2NMWm+4TIRJcQ0fFb/gkMfyZ1Um9hi05NFAVIFeO/cRwRmpzmjb8Id6CdveuyqW9A13 Fz3rzJFxcuViFjBULhR8aXZNwUJ7c5Lr217Z7isMaeZEaz2GKlXyjtZPZHJGye0/D2Gi uz6QsNvLAFT0mVTF4tz1WyZHEGd/ILSlfq1W8/WU6fLdaBA6OKApuFXy1msC4FCY9Sls uQ/A== X-Gm-Message-State: AOAM531PMqkb8iPwNINwPeoEJBGSQE3yGRyZ+xqomoB13sigAvgFXJUU mBIiYBRDRmUhp8FWlW7p3Q== X-Google-Smtp-Source: ABdhPJyazfhgeCNMMJuWdCCjpOP9wOvUKcWMvObpNRssw198EqpTMe/uJHgbk73ctYTJ50zqvVR1gQ== X-Received: by 2002:a9d:6f02:: with SMTP id n2mr1215732otq.268.1617898818735; Thu, 08 Apr 2021 09:20:18 -0700 (PDT) Received: from robh.at.kernel.org (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id m19sm5444036oop.6.2021.04.08.09.20.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Apr 2021 09:20:17 -0700 (PDT) Received: (nullmailer pid 1581488 invoked by uid 1000); Thu, 08 Apr 2021 16:20:16 -0000 Date: Thu, 8 Apr 2021 11:20:16 -0500 From: Rob Herring To: Jim Quinlan Cc: Mark Brown , linux-pci , Nicolas Saenz Julienne , bcm-kernel-feedback-list , Jim Quinlan , Florian Fainelli , Bjorn Helgaas , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , open list Subject: Re: [PATCH v4 2/6] dt-bindings: PCI: Add bindings for Brcmstb endpoint device voltage regulators Message-ID: <20210408162016.GA1556444@robh.at.kernel.org> References: <20210401212148.47033-1-jim2101024@gmail.com> <20210401212148.47033-3-jim2101024@gmail.com> <20210406164708.GM6443@sirena.org.uk> <20210406173211.GP6443@sirena.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 06, 2021 at 02:25:49PM -0400, Jim Quinlan wrote: > On Tue, Apr 6, 2021 at 1:32 PM Mark Brown wrote: > > > > On Tue, Apr 06, 2021 at 01:26:51PM -0400, Jim Quinlan wrote: > > > On Tue, Apr 6, 2021 at 12:47 PM Mark Brown wrote: > > > > > > No great problem with having these in the controller node (assming it > > > > accurately describes the hardware) but I do think we ought to also be > > > > able to describe these per slot. PCIe is effectively point to point, so there's only 1 slot unless there's a PCIe switch in the middle. If that's the case, then it's all more complicated. > > > Can you explain what you think that would look like in the DT? > > > > I *think* that's just some properties on the nodes for the endpoints, > > note that the driver could just ignore them for now. Not sure where or > > if we document any extensions but child nodes are in section 4 of the > > v2.1 PCI bus binding. > > Hi Mark, > > I'm a little confused -- here is how I remember the chronology of the > "DT bindings" commit reviews, please correct me if I'm wrong: > > o JimQ submitted a pullreq for using voltage regulators in the same > style as the existing "rockport" PCIe driver. > o After some deliberation, RobH preferred that the voltage regulators > should go into the PCIe subnode device's DT node. IIRC, that's because you said there isn't a standard slot. > o JimQ put the voltage regulators in the subnode device's DT node. > o MarkB didn't like the fact that the code did a global search for the > regulator since it could not provide the owning struct device* handle. > o RobH relented, and said that if it is just two specific and standard > voltage regulators, perhaps they can go in the parent DT node after > all. > o JimQ put the regulators back in the PCIe node. > o MarkB now wants the regulators to go back into the child node again? > > Folks, please advise. > > Regards, > Jim Quinlan > Broadcom STB From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D52AC433B4 for ; Thu, 8 Apr 2021 16:21:59 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1B0E2610E8 for ; Thu, 8 Apr 2021 16:21:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1B0E2610E8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=HsEvl5q4aSd3lFR96KprmPg6kdjdiDguKG9ZDQ63xzE=; b=ecw5qsveJcoEuD1TK/Ci9cd2q AwpcrNbX8ZYYgaFFVjDThOyj19HSUidRzlHogKnjjgrj3R4gv/Ca3tVVIbucrevVy6mdZiUbMe54g h9YiBPUYad9VQdJ6RNjbsDF6ZXIE9gUFtKPTe4aA3Ti6Sooch7jmwlg3l5kiPRro3DOJGGV9sIJox +1brjq5SWIzxb2U0xTczO88IR74xV8KOaNmzw/88KrJqQrWYMCWFmEo6N9LsUX/vz8JPB0SP3NSJP NPuscQ1LhW+WxNPQNRLn5U97w3x3BlpySY+7BSVqdQku3ppvutfRnIQIxqIH+fXaNdJWFbxVmTNvf j6xuCaZGw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lUXOJ-008bSV-Qo; Thu, 08 Apr 2021 16:20:25 +0000 Received: from mail-ot1-f42.google.com ([209.85.210.42]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lUXOF-008bOn-Rn; Thu, 08 Apr 2021 16:20:21 +0000 Received: by mail-ot1-f42.google.com with SMTP id d3-20020a9d29030000b029027e8019067fso924069otb.13; Thu, 08 Apr 2021 09:20:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=FKQCy9mHVcIx4jvHTvGbM4mIzIxWpaBAJhioAHr5gKo=; b=VHuXr3Tk6LlNSC1Ii2UIgZvRCC878H0uzMTFXDwoUI75nSH6htowCAO92DSdItnJnu LiDBU9KeTTo3FTBGaZPMWxQg6kLt+EQ+4u7Mw0EwBghsy8cNNyDboacgbri2/yKVzj5H wGX+/1Nb4zntNjvTyfuNxOkDOZFQBZg9KNNVunrp4jj8+Py/p7W6vrkAViJsblwjpQvl FYIiYyJ8dtHiPAIDEOT6/qnVtOUCrjBdFG0wp7ZW4UiFcxu87tq4G4/MFGq3Zybo5Nwf XPUEK1wy90/xjavmNkKBg+JQZKnBR4svv/R4KNi6wHQSuccbCVWmdCoNIWBygyPYRUJS lu8A== X-Gm-Message-State: AOAM532QxjU7Ukm9Q7ZEzyztin6XkDbMsJpW4/s7Ac5DTDiVdZJdU4Vu xszRwEGpBREVj17v0DuD0A== X-Google-Smtp-Source: ABdhPJyazfhgeCNMMJuWdCCjpOP9wOvUKcWMvObpNRssw198EqpTMe/uJHgbk73ctYTJ50zqvVR1gQ== X-Received: by 2002:a9d:6f02:: with SMTP id n2mr1215732otq.268.1617898818735; Thu, 08 Apr 2021 09:20:18 -0700 (PDT) Received: from robh.at.kernel.org (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id m19sm5444036oop.6.2021.04.08.09.20.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Apr 2021 09:20:17 -0700 (PDT) Received: (nullmailer pid 1581488 invoked by uid 1000); Thu, 08 Apr 2021 16:20:16 -0000 Date: Thu, 8 Apr 2021 11:20:16 -0500 From: Rob Herring To: Jim Quinlan Cc: Mark Brown , linux-pci , Nicolas Saenz Julienne , bcm-kernel-feedback-list , Jim Quinlan , Florian Fainelli , Bjorn Helgaas , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , open list Subject: Re: [PATCH v4 2/6] dt-bindings: PCI: Add bindings for Brcmstb endpoint device voltage regulators Message-ID: <20210408162016.GA1556444@robh.at.kernel.org> References: <20210401212148.47033-1-jim2101024@gmail.com> <20210401212148.47033-3-jim2101024@gmail.com> <20210406164708.GM6443@sirena.org.uk> <20210406173211.GP6443@sirena.org.uk> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210408_172019_977668_6F63EEBE X-CRM114-Status: GOOD ( 25.11 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Apr 06, 2021 at 02:25:49PM -0400, Jim Quinlan wrote: > On Tue, Apr 6, 2021 at 1:32 PM Mark Brown wrote: > > > > On Tue, Apr 06, 2021 at 01:26:51PM -0400, Jim Quinlan wrote: > > > On Tue, Apr 6, 2021 at 12:47 PM Mark Brown wrote: > > > > > > No great problem with having these in the controller node (assming it > > > > accurately describes the hardware) but I do think we ought to also be > > > > able to describe these per slot. PCIe is effectively point to point, so there's only 1 slot unless there's a PCIe switch in the middle. If that's the case, then it's all more complicated. > > > Can you explain what you think that would look like in the DT? > > > > I *think* that's just some properties on the nodes for the endpoints, > > note that the driver could just ignore them for now. Not sure where or > > if we document any extensions but child nodes are in section 4 of the > > v2.1 PCI bus binding. > > Hi Mark, > > I'm a little confused -- here is how I remember the chronology of the > "DT bindings" commit reviews, please correct me if I'm wrong: > > o JimQ submitted a pullreq for using voltage regulators in the same > style as the existing "rockport" PCIe driver. > o After some deliberation, RobH preferred that the voltage regulators > should go into the PCIe subnode device's DT node. IIRC, that's because you said there isn't a standard slot. > o JimQ put the voltage regulators in the subnode device's DT node. > o MarkB didn't like the fact that the code did a global search for the > regulator since it could not provide the owning struct device* handle. > o RobH relented, and said that if it is just two specific and standard > voltage regulators, perhaps they can go in the parent DT node after > all. > o JimQ put the regulators back in the PCIe node. > o MarkB now wants the regulators to go back into the child node again? > > Folks, please advise. > > Regards, > Jim Quinlan > Broadcom STB _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel