From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9695AC433B4 for ; Thu, 8 Apr 2021 18:19:04 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DF28361108 for ; Thu, 8 Apr 2021 18:19:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DF28361108 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=net-space.pl Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.107492.205473 (Exim 4.92) (envelope-from ) id 1lUZEs-0006wO-Oa; Thu, 08 Apr 2021 18:18:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 107492.205473; Thu, 08 Apr 2021 18:18:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lUZEs-0006wH-LG; Thu, 08 Apr 2021 18:18:46 +0000 Received: by outflank-mailman (input) for mailman id 107492; Thu, 08 Apr 2021 17:32:20 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lUYVw-000379-Qb for xen-devel@lists.xenproject.org; Thu, 08 Apr 2021 17:32:20 +0000 Received: from dibed.net-space.pl (unknown [84.10.22.86]) by us1-amaz-eas2.inumbo.com (Halon) with SMTP id 60efd386-e1e1-4491-b657-6c2078e537b2; Thu, 08 Apr 2021 17:32:19 +0000 (UTC) Received: from router-fw.i.net-space.pl ([192.168.52.1]:58848 "EHLO tomti.i.net-space.pl") by router-fw-old.i.net-space.pl with ESMTP id S2096011AbhDHQsq convert rfc822-to-quoted-printable (ORCPT ); Thu, 8 Apr 2021 18:48:46 +0200 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 60efd386-e1e1-4491-b657-6c2078e537b2 X-Comment: RFC 2476 MSA function at dibed.net-space.pl logged sender identity as: dkiper Date: Thu, 8 Apr 2021 18:48:39 +0200 From: Daniel Kiper To: Roman Shaposhnik Cc: grub-devel@gnu.org, Roger Pau =?iso-8859-1?Q?Monn=E9?= , Jan Beulich , Andrew Cooper , Xen-devel Subject: Re: multiboot2 and module2 boot issues via GRUB2 Message-ID: <20210408164839.t5ulhjswnypbqpnz@tomti.i.net-space.pl> References: <23baec07-a3ae-949a-a1fb-09100efd53e5@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: QUOTED-PRINTABLE In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) On Thu, Apr 01, 2021 at 08:43:46PM +0100, Andrew Cooper via Grub-devel = wrote: > On 01/04/2021 09:44, Roger Pau Monn=E9 wrote: > > On Thu, Apr 01, 2021 at 09:31:07AM +0200, Jan Beulich wrote: > >> On 01.04.2021 03:06, Roman Shaposhnik wrote: > >>> And the obvious next question: is my EVE usecase esoteric enough = that > >>> I should just go ahead and do a custom GRUB patch or is there a m= ore > >>> general interest in this? > >> Not sure if it ought to be a grub patch - the issue could as well > >> be dealt with in Xen, by concatenating modules to form a monolithi= c > >> initrd. > > I would rather have it done in the loader than Xen, mostly because > > it's a Linux boot specific format, and hence I don't think Xen shou= ld > > have any knowledge about it. > > > > If it turns out to be impossible to implement on the loader side we > > should consider doing it in Xen, but that's not my first option. > > Concatenating random things which may or may not be initrds is > absolutely not something Xen should do.=A0 We don't have enough conte= xt to > do it safely/sensibly. > > Honestly, I like the idea of supporting something like this generally= in > grub.=A0 Linux already commonly has initrd preparation prepending an > uncompressed microcode CPIO archive, and I can see a usability advant= age > from maintaining the initrd fragments separately. > > Looking at the grub manual, this behaviour of the `initrd` command is= n't > even documented.=A0 Perhaps that should be fixed first, and then mayb= e > `module2_multi` added too? I am OK with additional Multiboot2 command. Though I would do s/module2_multi/module2_concat/. Additionally, it should look for "--" and interpret everything after it as a command line argument for a concatenated module. Daniel