From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8988EC433B4 for ; Thu, 8 Apr 2021 17:00:50 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BDB35610A2 for ; Thu, 8 Apr 2021 17:00:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BDB35610A2 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=jDvqL3fIo6zfbPWPqWCR75ab7LHcEOkpSlofo5EJesg=; b=R9i5+pdtVKuXlngFpdwXglMAG 5xo3308Awfeo6AgenMgbwiIMc+5Xskc8+GVVRohcNHQVA2YFcXU3v2AZOeogMyCdNCvkUXFXwBANK MsyaI64UmZtHhWhNvFk5PsdyTqXZWloakjIgH1S1UyiRFa+yJL2mJpduEKV6wyMgHzAkzDaqRwyKA zRq7GM7iRcsx9Uf5fOi4B8S6y++5EDZDKhXBZtrmsBxtd3uqWG+bkAq0l1MHljbxUp1iLhH4IsXMe HFPgGr6RdpB8/06NsQyfAOrQIFMsMI2X2LKAEAqkkexTRQhWVL1uPEmDHX9ni/o/YP97DJFf1oui5 ZhZqrjRRA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lUY1E-008iMz-4B; Thu, 08 Apr 2021 17:00:36 +0000 Received: from verein.lst.de ([213.95.11.211]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lUY0x-008iI7-HJ for linux-nvme@lists.infradead.org; Thu, 08 Apr 2021 17:00:21 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id C735768BEB; Thu, 8 Apr 2021 19:00:14 +0200 (CEST) Date: Thu, 8 Apr 2021 19:00:14 +0200 From: Christoph Hellwig To: Keith Busch Cc: Christoph Hellwig , Minwoo Im , Sagi Grimberg , Kanchan Joshi , Javier Gonz??lez , linux-nvme@lists.infradead.org Subject: Re: [PATCH 13/13] nvme: introduce generic per-namespace chardev Message-ID: <20210408170014.GA2418@lst.de> References: <20210408120842.1450092-1-hch@lst.de> <20210408120842.1450092-14-hch@lst.de> <20210408165613.GA3774@redsun51.ssa.fujisawa.hgst.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210408165613.GA3774@redsun51.ssa.fujisawa.hgst.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210408_180019_676290_9EA0AEE3 X-CRM114-Status: GOOD ( 13.97 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Fri, Apr 09, 2021 at 01:56:13AM +0900, Keith Busch wrote: > On Thu, Apr 08, 2021 at 02:08:42PM +0200, Christoph Hellwig wrote: > > +int nvme_cdev_add(struct cdev *cdev, struct device *cdev_device, > > + const struct file_operations *fops, struct module *owner) > > +{ > > + int minor, ret; > > + > > + minor = ida_simple_get(&nvme_ns_chr_minor_ida, 0, 0, GFP_KERNEL); > > Do we really need to allocate a minor specific for this char dev? It > looks like the ns->head->instance can provide the unique value. Indeed. I think we can just kill off this IDA, let me give that a spin. _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme