From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1BCD3C433ED for ; Thu, 8 Apr 2021 20:38:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DA29F6113C for ; Thu, 8 Apr 2021 20:38:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232278AbhDHUiT (ORCPT ); Thu, 8 Apr 2021 16:38:19 -0400 Received: from elvis.franken.de ([193.175.24.41]:35356 "EHLO elvis.franken.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231676AbhDHUiR (ORCPT ); Thu, 8 Apr 2021 16:38:17 -0400 Received: from uucp (helo=alpha) by elvis.franken.de with local-bsmtp (Exim 3.36 #1) id 1lUbPg-0007g1-00; Thu, 08 Apr 2021 22:38:04 +0200 Received: by alpha.franken.de (Postfix, from userid 1000) id 0AB84C24DB; Thu, 8 Apr 2021 22:37:45 +0200 (CEST) Date: Thu, 8 Apr 2021 22:37:44 +0200 From: Thomas Bogendoerfer To: Christoph Hellwig Cc: linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] MIPS: uaccess: Reduce number of nested macros Message-ID: <20210408203744.GA18538@alpha.franken.de> References: <20210408181437.19570-1-tsbogend@alpha.franken.de> <20210408194611.GA16189@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210408194611.GA16189@lst.de> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 08, 2021 at 09:46:11PM +0200, Christoph Hellwig wrote: > > +#define put_user(x, ptr) \ > > +({ \ > > + __typeof__(*(ptr)) __user *__p = (ptr); \ > > + \ > > + might_fault(); \ > > + access_ok(__p, sizeof(*__p)) ? \ > > + __put_user((x), __p) : \ > > + -EFAULT; \ > > Why not merge this into a single line, which seems a little more > readable: > > access_ok(__p, sizeof(*__p)) ? __put_user((x), __p) : -EFAULT; \ I just copied the riscv version ;-) I'll make it one line before applying. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]