All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Tian Tao <tiantao6@hisilicon.com>
Cc: <christian.brauner@ubuntu.com>, <masahiroy@kernel.org>,
	<ktkhai@virtuozzo.com>, <linux-kernel@vger.kernel.org>,
	"Zhiqi Song" <songzhiqi1@huawei.com>
Subject: Re: [PATCH] init/version.c: remove unused including <linux/version.h>
Date: Thu, 8 Apr 2021 22:05:08 -0700	[thread overview]
Message-ID: <20210408220508.c7ce7b1b90202a19223ed1f4@linux-foundation.org> (raw)
In-Reply-To: <1617863218-14905-1-git-send-email-tiantao6@hisilicon.com>

On Thu, 8 Apr 2021 14:26:58 +0800 Tian Tao <tiantao6@hisilicon.com> wrote:

> Remove including <linux/version.h> that don't need it.
> 

Um, how can version.c possibly not include version.h?

Sure, it may obtain access to version.h via some other include, but
that's plain luck and nonsense.  And it's unreliable and it requires
whichever-header-is-doing-this to continue to include version.h on
behalf of some .c file which should be including it directly!



  reply	other threads:[~2021-04-09  5:05 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-08  6:26 [PATCH] init/version.c: remove unused including <linux/version.h> Tian Tao
2021-04-09  5:05 ` Andrew Morton [this message]
  -- strict thread matches above, loose matches on Subject: below --
2021-01-23  1:22 Ye Bin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210408220508.c7ce7b1b90202a19223ed1f4@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=christian.brauner@ubuntu.com \
    --cc=ktkhai@virtuozzo.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=masahiroy@kernel.org \
    --cc=songzhiqi1@huawei.com \
    --cc=tiantao6@hisilicon.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.