All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ARM: dts: stm32: Rework LAN8710Ai PHY reset on DHCOM SoM
@ 2021-04-08 23:00 Marek Vasut
  2021-06-01  6:50 ` Alexandre TORGUE
  2021-06-28 10:44   ` Marek Vasut
  0 siblings, 2 replies; 16+ messages in thread
From: Marek Vasut @ 2021-04-08 23:00 UTC (permalink / raw)
  To: linux-arm-kernel
  Cc: Marek Vasut, Alexandre Torgue, Patrice Chotard, Patrick Delaunay,
	linux-stm32

The Microchip LAN8710Ai PHY requires XTAL1/CLKIN external clock to be
enabled when the nRST is toggled according to datasheet Microchip
LAN8710A/LAN8710Ai DS00002164B page 35 section 3.8.5.1 Hardware Reset:
  "
  A Hardware reset is asserted by driving the nRST input pin low. When
  driven, nRST should be held low for the minimum time detailed in
  Section 5.5.3, "Power-On nRST & Configuration Strap Timing," on page
  59 to ensure a proper transceiver reset. During a Hardware reset, an
  external clock must be supplied to the XTAL1/CLKIN signal.
  "
This is accidentally fulfilled in the current setup, where ETHCK_K is used
to supply both PHY XTAL1/CLKIN and is also fed back through eth_clk_fb to
supply ETHRX clock of the DWMAC. Hence, the DWMAC enables ETHRX clock,
that has ETHCK_K as parent, so ETHCK_K clock are also enabled, and then
the PHY reset toggles.

However, this is not always the case, e.g. in case the PHY XTAL1/CLKIN
clock are supplied by some other clock source than ETHCK_K or in case
ETHRX clock are not supplied by ETHCK_K. In the later case, ETHCK_K would
be kept disabled, while ETHRX clock would be enabled, so the PHY would
not be receiving XTAL1/CLKIN clock and the reset would fail.

Improve the DT by adding the PHY clock phandle into the PHY node, which
then also requires moving the PHY reset GPIO specifier in the same place
and that then also requires correct PHY reset GPIO timing, so add that
too.

A brief note regarding the timing, the datasheet says the reset should
stay asserted for at least 100uS and software should wait at least 200nS
after deassertion. Set both delays to 500uS which should be plenty.

Fixes: 34e0c7847dcf ("ARM: dts: stm32: Add DH Electronics DHCOM STM32MP1 SoM and PDK2 board")
Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Alexandre Torgue <alexandre.torgue@st.com>
Cc: Patrice Chotard <patrice.chotard@st.com>
Cc: Patrick Delaunay <patrick.delaunay@st.com>
Cc: linux-stm32@st-md-mailman.stormreply.com
To: linux-arm-kernel@lists.infradead.org
---
 arch/arm/boot/dts/stm32mp15xx-dhcom-som.dtsi | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/stm32mp15xx-dhcom-som.dtsi b/arch/arm/boot/dts/stm32mp15xx-dhcom-som.dtsi
index 272a1a67a9ad..31d08423a32f 100644
--- a/arch/arm/boot/dts/stm32mp15xx-dhcom-som.dtsi
+++ b/arch/arm/boot/dts/stm32mp15xx-dhcom-som.dtsi
@@ -123,7 +123,6 @@ &ethernet0 {
 	max-speed = <100>;
 	phy-handle = <&phy0>;
 	st,eth-ref-clk-sel;
-	phy-reset-gpios = <&gpioh 3 GPIO_ACTIVE_LOW>;
 
 	mdio0 {
 		#address-cells = <1>;
@@ -132,6 +131,13 @@ mdio0 {
 
 		phy0: ethernet-phy@1 {
 			reg = <1>;
+			/* LAN8710Ai */
+			compatible = "ethernet-phy-id0007.c0f0",
+				     "ethernet-phy-ieee802.3-c22";
+			clocks = <&rcc ETHCK_K>;
+			reset-gpios = <&gpioh 3 GPIO_ACTIVE_LOW>;
+			reset-assert-us = <500>;
+			reset-deassert-us = <500>;
 			interrupt-parent = <&gpioi>;
 			interrupts = <11 IRQ_TYPE_LEVEL_LOW>;
 		};
-- 
2.30.2


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 16+ messages in thread

* Re: [PATCH] ARM: dts: stm32: Rework LAN8710Ai PHY reset on DHCOM SoM
  2021-04-08 23:00 [PATCH] ARM: dts: stm32: Rework LAN8710Ai PHY reset on DHCOM SoM Marek Vasut
@ 2021-06-01  6:50 ` Alexandre TORGUE
  2021-06-28 10:44   ` Marek Vasut
  1 sibling, 0 replies; 16+ messages in thread
From: Alexandre TORGUE @ 2021-06-01  6:50 UTC (permalink / raw)
  To: Marek Vasut, linux-arm-kernel
  Cc: Alexandre Torgue, Patrice Chotard, Patrick Delaunay, linux-stm32

On 4/9/21 1:00 AM, Marek Vasut wrote:
> The Microchip LAN8710Ai PHY requires XTAL1/CLKIN external clock to be
> enabled when the nRST is toggled according to datasheet Microchip
> LAN8710A/LAN8710Ai DS00002164B page 35 section 3.8.5.1 Hardware Reset:
>    "
>    A Hardware reset is asserted by driving the nRST input pin low. When
>    driven, nRST should be held low for the minimum time detailed in
>    Section 5.5.3, "Power-On nRST & Configuration Strap Timing," on page
>    59 to ensure a proper transceiver reset. During a Hardware reset, an
>    external clock must be supplied to the XTAL1/CLKIN signal.
>    "
> This is accidentally fulfilled in the current setup, where ETHCK_K is used
> to supply both PHY XTAL1/CLKIN and is also fed back through eth_clk_fb to
> supply ETHRX clock of the DWMAC. Hence, the DWMAC enables ETHRX clock,
> that has ETHCK_K as parent, so ETHCK_K clock are also enabled, and then
> the PHY reset toggles.
> 
> However, this is not always the case, e.g. in case the PHY XTAL1/CLKIN
> clock are supplied by some other clock source than ETHCK_K or in case
> ETHRX clock are not supplied by ETHCK_K. In the later case, ETHCK_K would
> be kept disabled, while ETHRX clock would be enabled, so the PHY would
> not be receiving XTAL1/CLKIN clock and the reset would fail.
> 
> Improve the DT by adding the PHY clock phandle into the PHY node, which
> then also requires moving the PHY reset GPIO specifier in the same place
> and that then also requires correct PHY reset GPIO timing, so add that
> too.
> 
> A brief note regarding the timing, the datasheet says the reset should
> stay asserted for at least 100uS and software should wait at least 200nS
> after deassertion. Set both delays to 500uS which should be plenty.
> 
> Fixes: 34e0c7847dcf ("ARM: dts: stm32: Add DH Electronics DHCOM STM32MP1 SoM and PDK2 board")
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Alexandre Torgue <alexandre.torgue@st.com>
> Cc: Patrice Chotard <patrice.chotard@st.com>
> Cc: Patrick Delaunay <patrick.delaunay@st.com>
> Cc: linux-stm32@st-md-mailman.stormreply.com
> To: linux-arm-kernel@lists.infradead.org
> ---
>   arch/arm/boot/dts/stm32mp15xx-dhcom-som.dtsi | 8 +++++++-
>   1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/stm32mp15xx-dhcom-som.dtsi b/arch/arm/boot/dts/stm32mp15xx-dhcom-som.dtsi
> index 272a1a67a9ad..31d08423a32f 100644
> --- a/arch/arm/boot/dts/stm32mp15xx-dhcom-som.dtsi
> +++ b/arch/arm/boot/dts/stm32mp15xx-dhcom-som.dtsi
> @@ -123,7 +123,6 @@ &ethernet0 {
>   	max-speed = <100>;
>   	phy-handle = <&phy0>;
>   	st,eth-ref-clk-sel;
> -	phy-reset-gpios = <&gpioh 3 GPIO_ACTIVE_LOW>;
>   
>   	mdio0 {
>   		#address-cells = <1>;
> @@ -132,6 +131,13 @@ mdio0 {
>   
>   		phy0: ethernet-phy@1 {
>   			reg = <1>;
> +			/* LAN8710Ai */
> +			compatible = "ethernet-phy-id0007.c0f0",
> +				     "ethernet-phy-ieee802.3-c22";
> +			clocks = <&rcc ETHCK_K>;
> +			reset-gpios = <&gpioh 3 GPIO_ACTIVE_LOW>;
> +			reset-assert-us = <500>;
> +			reset-deassert-us = <500>;
>   			interrupt-parent = <&gpioi>;
>   			interrupts = <11 IRQ_TYPE_LEVEL_LOW>;
>   		};
> 
Applied on stm32-next.

Thanks.
Alex

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH] ARM: dts: stm32: Rework LAN8710Ai PHY reset on DHCOM SoM
  2021-04-08 23:00 [PATCH] ARM: dts: stm32: Rework LAN8710Ai PHY reset on DHCOM SoM Marek Vasut
@ 2021-06-28 10:44   ` Marek Vasut
  2021-06-28 10:44   ` Marek Vasut
  1 sibling, 0 replies; 16+ messages in thread
From: Marek Vasut @ 2021-06-28 10:44 UTC (permalink / raw)
  To: linux-arm-kernel, linux-stable
  Cc: Alexandre Torgue, Patrice Chotard, Patrick Delaunay, linux-stm32,
	Sasha Levin

On 4/9/21 1:00 AM, Marek Vasut wrote:
> The Microchip LAN8710Ai PHY requires XTAL1/CLKIN external clock to be
> enabled when the nRST is toggled according to datasheet Microchip
> LAN8710A/LAN8710Ai DS00002164B page 35 section 3.8.5.1 Hardware Reset:

[...]

> Fixes: 34e0c7847dcf ("ARM: dts: stm32: Add DH Electronics DHCOM STM32MP1 SoM and PDK2 board")

Adding stable to CC.

Patch is now part of Linux 5.13 as commit

1cebcf9932ab ("ARM: dts: stm32: Rework LAN8710Ai PHY reset on DHCOM SoM")

It would be nice to pick it into stable, since it fixes ethernet 
stability issues on the device.

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH] ARM: dts: stm32: Rework LAN8710Ai PHY reset on DHCOM SoM
@ 2021-06-28 10:44   ` Marek Vasut
  0 siblings, 0 replies; 16+ messages in thread
From: Marek Vasut @ 2021-06-28 10:44 UTC (permalink / raw)
  To: linux-arm-kernel, linux-stable
  Cc: Alexandre Torgue, Patrice Chotard, Patrick Delaunay, linux-stm32,
	Sasha Levin

On 4/9/21 1:00 AM, Marek Vasut wrote:
> The Microchip LAN8710Ai PHY requires XTAL1/CLKIN external clock to be
> enabled when the nRST is toggled according to datasheet Microchip
> LAN8710A/LAN8710Ai DS00002164B page 35 section 3.8.5.1 Hardware Reset:

[...]

> Fixes: 34e0c7847dcf ("ARM: dts: stm32: Add DH Electronics DHCOM STM32MP1 SoM and PDK2 board")

Adding stable to CC.

Patch is now part of Linux 5.13 as commit

1cebcf9932ab ("ARM: dts: stm32: Rework LAN8710Ai PHY reset on DHCOM SoM")

It would be nice to pick it into stable, since it fixes ethernet 
stability issues on the device.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH] ARM: dts: stm32: Rework LAN8710Ai PHY reset on DHCOM SoM
  2021-06-28 10:44   ` Marek Vasut
@ 2021-06-28 12:29     ` Greg KH
  -1 siblings, 0 replies; 16+ messages in thread
From: Greg KH @ 2021-06-28 12:29 UTC (permalink / raw)
  To: Marek Vasut
  Cc: linux-arm-kernel, linux-stable, Alexandre Torgue,
	Patrice Chotard, Patrick Delaunay, linux-stm32, Sasha Levin

On Mon, Jun 28, 2021 at 12:44:37PM +0200, Marek Vasut wrote:
> On 4/9/21 1:00 AM, Marek Vasut wrote:
> > The Microchip LAN8710Ai PHY requires XTAL1/CLKIN external clock to be
> > enabled when the nRST is toggled according to datasheet Microchip
> > LAN8710A/LAN8710Ai DS00002164B page 35 section 3.8.5.1 Hardware Reset:
> 
> [...]
> 
> > Fixes: 34e0c7847dcf ("ARM: dts: stm32: Add DH Electronics DHCOM STM32MP1 SoM and PDK2 board")
> 
> Adding stable to CC.
> 
> Patch is now part of Linux 5.13 as commit
> 
> 1cebcf9932ab ("ARM: dts: stm32: Rework LAN8710Ai PHY reset on DHCOM SoM")

$ git show 1cebcf9932ab
fatal: ambiguous argument '1cebcf9932ab': unknown revision or path not in the working tree.
Use '--' to separate paths from revisions, like this:
'git <command> [<revision>...] -- [<file>...]'

Are you sure?

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH] ARM: dts: stm32: Rework LAN8710Ai PHY reset on DHCOM SoM
@ 2021-06-28 12:29     ` Greg KH
  0 siblings, 0 replies; 16+ messages in thread
From: Greg KH @ 2021-06-28 12:29 UTC (permalink / raw)
  To: Marek Vasut
  Cc: linux-arm-kernel, linux-stable, Alexandre Torgue,
	Patrice Chotard, Patrick Delaunay, linux-stm32, Sasha Levin

On Mon, Jun 28, 2021 at 12:44:37PM +0200, Marek Vasut wrote:
> On 4/9/21 1:00 AM, Marek Vasut wrote:
> > The Microchip LAN8710Ai PHY requires XTAL1/CLKIN external clock to be
> > enabled when the nRST is toggled according to datasheet Microchip
> > LAN8710A/LAN8710Ai DS00002164B page 35 section 3.8.5.1 Hardware Reset:
> 
> [...]
> 
> > Fixes: 34e0c7847dcf ("ARM: dts: stm32: Add DH Electronics DHCOM STM32MP1 SoM and PDK2 board")
> 
> Adding stable to CC.
> 
> Patch is now part of Linux 5.13 as commit
> 
> 1cebcf9932ab ("ARM: dts: stm32: Rework LAN8710Ai PHY reset on DHCOM SoM")

$ git show 1cebcf9932ab
fatal: ambiguous argument '1cebcf9932ab': unknown revision or path not in the working tree.
Use '--' to separate paths from revisions, like this:
'git <command> [<revision>...] -- [<file>...]'

Are you sure?

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH] ARM: dts: stm32: Rework LAN8710Ai PHY reset on DHCOM SoM
  2021-06-28 12:29     ` Greg KH
@ 2021-06-28 12:32       ` Marek Vasut
  -1 siblings, 0 replies; 16+ messages in thread
From: Marek Vasut @ 2021-06-28 12:32 UTC (permalink / raw)
  To: Greg KH
  Cc: linux-arm-kernel, linux-stable, Alexandre Torgue,
	Patrice Chotard, Patrick Delaunay, linux-stm32, Sasha Levin

On 6/28/21 2:29 PM, Greg KH wrote:
> On Mon, Jun 28, 2021 at 12:44:37PM +0200, Marek Vasut wrote:
>> On 4/9/21 1:00 AM, Marek Vasut wrote:
>>> The Microchip LAN8710Ai PHY requires XTAL1/CLKIN external clock to be
>>> enabled when the nRST is toggled according to datasheet Microchip
>>> LAN8710A/LAN8710Ai DS00002164B page 35 section 3.8.5.1 Hardware Reset:
>>
>> [...]
>>
>>> Fixes: 34e0c7847dcf ("ARM: dts: stm32: Add DH Electronics DHCOM STM32MP1 SoM and PDK2 board")
>>
>> Adding stable to CC.
>>
>> Patch is now part of Linux 5.13 as commit
>>
>> 1cebcf9932ab ("ARM: dts: stm32: Rework LAN8710Ai PHY reset on DHCOM SoM")
> 
> $ git show 1cebcf9932ab
> fatal: ambiguous argument '1cebcf9932ab': unknown revision or path not in the working tree.
> Use '--' to separate paths from revisions, like this:
> 'git <command> [<revision>...] -- [<file>...]'
> 
> Are you sure?

This would seem to indicate so:

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=1cebcf9932ab76102e8cfc555879574693ba8956

linux-2.6$ git describe 1cebcf9932ab76102e8cfc555879574693ba8956
v5.13-rc1-1-g1cebcf9932ab

Did the commit get abbreviated too much ?

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH] ARM: dts: stm32: Rework LAN8710Ai PHY reset on DHCOM SoM
@ 2021-06-28 12:32       ` Marek Vasut
  0 siblings, 0 replies; 16+ messages in thread
From: Marek Vasut @ 2021-06-28 12:32 UTC (permalink / raw)
  To: Greg KH
  Cc: linux-arm-kernel, linux-stable, Alexandre Torgue,
	Patrice Chotard, Patrick Delaunay, linux-stm32, Sasha Levin

On 6/28/21 2:29 PM, Greg KH wrote:
> On Mon, Jun 28, 2021 at 12:44:37PM +0200, Marek Vasut wrote:
>> On 4/9/21 1:00 AM, Marek Vasut wrote:
>>> The Microchip LAN8710Ai PHY requires XTAL1/CLKIN external clock to be
>>> enabled when the nRST is toggled according to datasheet Microchip
>>> LAN8710A/LAN8710Ai DS00002164B page 35 section 3.8.5.1 Hardware Reset:
>>
>> [...]
>>
>>> Fixes: 34e0c7847dcf ("ARM: dts: stm32: Add DH Electronics DHCOM STM32MP1 SoM and PDK2 board")
>>
>> Adding stable to CC.
>>
>> Patch is now part of Linux 5.13 as commit
>>
>> 1cebcf9932ab ("ARM: dts: stm32: Rework LAN8710Ai PHY reset on DHCOM SoM")
> 
> $ git show 1cebcf9932ab
> fatal: ambiguous argument '1cebcf9932ab': unknown revision or path not in the working tree.
> Use '--' to separate paths from revisions, like this:
> 'git <command> [<revision>...] -- [<file>...]'
> 
> Are you sure?

This would seem to indicate so:

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=1cebcf9932ab76102e8cfc555879574693ba8956

linux-2.6$ git describe 1cebcf9932ab76102e8cfc555879574693ba8956
v5.13-rc1-1-g1cebcf9932ab

Did the commit get abbreviated too much ?

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH] ARM: dts: stm32: Rework LAN8710Ai PHY reset on DHCOM SoM
  2021-06-28 12:32       ` Marek Vasut
@ 2021-06-28 13:02         ` Greg KH
  -1 siblings, 0 replies; 16+ messages in thread
From: Greg KH @ 2021-06-28 13:02 UTC (permalink / raw)
  To: Marek Vasut
  Cc: linux-arm-kernel, linux-stable, Alexandre Torgue,
	Patrice Chotard, Patrick Delaunay, linux-stm32, Sasha Levin

On Mon, Jun 28, 2021 at 02:32:50PM +0200, Marek Vasut wrote:
> On 6/28/21 2:29 PM, Greg KH wrote:
> > On Mon, Jun 28, 2021 at 12:44:37PM +0200, Marek Vasut wrote:
> > > On 4/9/21 1:00 AM, Marek Vasut wrote:
> > > > The Microchip LAN8710Ai PHY requires XTAL1/CLKIN external clock to be
> > > > enabled when the nRST is toggled according to datasheet Microchip
> > > > LAN8710A/LAN8710Ai DS00002164B page 35 section 3.8.5.1 Hardware Reset:
> > > 
> > > [...]
> > > 
> > > > Fixes: 34e0c7847dcf ("ARM: dts: stm32: Add DH Electronics DHCOM STM32MP1 SoM and PDK2 board")
> > > 
> > > Adding stable to CC.
> > > 
> > > Patch is now part of Linux 5.13 as commit
> > > 
> > > 1cebcf9932ab ("ARM: dts: stm32: Rework LAN8710Ai PHY reset on DHCOM SoM")
> > 
> > $ git show 1cebcf9932ab
> > fatal: ambiguous argument '1cebcf9932ab': unknown revision or path not in the working tree.
> > Use '--' to separate paths from revisions, like this:
> > 'git <command> [<revision>...] -- [<file>...]'
> > 
> > Are you sure?
> 
> This would seem to indicate so:
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=1cebcf9932ab76102e8cfc555879574693ba8956
> 
> linux-2.6$ git describe 1cebcf9932ab76102e8cfc555879574693ba8956
> v5.13-rc1-1-g1cebcf9932ab
> 
> Did the commit get abbreviated too much ?

Something is really odd, as that commit _is_ in linux-next, but it is
not in my local copy of Linus's tree.

So how it is showing up in that link above is beyond me.  Can you see it
locally on your machine?

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH] ARM: dts: stm32: Rework LAN8710Ai PHY reset on DHCOM SoM
@ 2021-06-28 13:02         ` Greg KH
  0 siblings, 0 replies; 16+ messages in thread
From: Greg KH @ 2021-06-28 13:02 UTC (permalink / raw)
  To: Marek Vasut
  Cc: linux-arm-kernel, linux-stable, Alexandre Torgue,
	Patrice Chotard, Patrick Delaunay, linux-stm32, Sasha Levin

On Mon, Jun 28, 2021 at 02:32:50PM +0200, Marek Vasut wrote:
> On 6/28/21 2:29 PM, Greg KH wrote:
> > On Mon, Jun 28, 2021 at 12:44:37PM +0200, Marek Vasut wrote:
> > > On 4/9/21 1:00 AM, Marek Vasut wrote:
> > > > The Microchip LAN8710Ai PHY requires XTAL1/CLKIN external clock to be
> > > > enabled when the nRST is toggled according to datasheet Microchip
> > > > LAN8710A/LAN8710Ai DS00002164B page 35 section 3.8.5.1 Hardware Reset:
> > > 
> > > [...]
> > > 
> > > > Fixes: 34e0c7847dcf ("ARM: dts: stm32: Add DH Electronics DHCOM STM32MP1 SoM and PDK2 board")
> > > 
> > > Adding stable to CC.
> > > 
> > > Patch is now part of Linux 5.13 as commit
> > > 
> > > 1cebcf9932ab ("ARM: dts: stm32: Rework LAN8710Ai PHY reset on DHCOM SoM")
> > 
> > $ git show 1cebcf9932ab
> > fatal: ambiguous argument '1cebcf9932ab': unknown revision or path not in the working tree.
> > Use '--' to separate paths from revisions, like this:
> > 'git <command> [<revision>...] -- [<file>...]'
> > 
> > Are you sure?
> 
> This would seem to indicate so:
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=1cebcf9932ab76102e8cfc555879574693ba8956
> 
> linux-2.6$ git describe 1cebcf9932ab76102e8cfc555879574693ba8956
> v5.13-rc1-1-g1cebcf9932ab
> 
> Did the commit get abbreviated too much ?

Something is really odd, as that commit _is_ in linux-next, but it is
not in my local copy of Linus's tree.

So how it is showing up in that link above is beyond me.  Can you see it
locally on your machine?

thanks,

greg k-h

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH] ARM: dts: stm32: Rework LAN8710Ai PHY reset on DHCOM SoM
  2021-06-28 13:02         ` Greg KH
@ 2021-06-28 13:10           ` Marek Vasut
  -1 siblings, 0 replies; 16+ messages in thread
From: Marek Vasut @ 2021-06-28 13:10 UTC (permalink / raw)
  To: Greg KH
  Cc: linux-arm-kernel, linux-stable, Alexandre Torgue,
	Patrice Chotard, Patrick Delaunay, linux-stm32, Sasha Levin

On 6/28/21 3:02 PM, Greg KH wrote:
> On Mon, Jun 28, 2021 at 02:32:50PM +0200, Marek Vasut wrote:
>> On 6/28/21 2:29 PM, Greg KH wrote:
>>> On Mon, Jun 28, 2021 at 12:44:37PM +0200, Marek Vasut wrote:
>>>> On 4/9/21 1:00 AM, Marek Vasut wrote:
>>>>> The Microchip LAN8710Ai PHY requires XTAL1/CLKIN external clock to be
>>>>> enabled when the nRST is toggled according to datasheet Microchip
>>>>> LAN8710A/LAN8710Ai DS00002164B page 35 section 3.8.5.1 Hardware Reset:
>>>>
>>>> [...]
>>>>
>>>>> Fixes: 34e0c7847dcf ("ARM: dts: stm32: Add DH Electronics DHCOM STM32MP1 SoM and PDK2 board")
>>>>
>>>> Adding stable to CC.
>>>>
>>>> Patch is now part of Linux 5.13 as commit
>>>>
>>>> 1cebcf9932ab ("ARM: dts: stm32: Rework LAN8710Ai PHY reset on DHCOM SoM")
>>>
>>> $ git show 1cebcf9932ab
>>> fatal: ambiguous argument '1cebcf9932ab': unknown revision or path not in the working tree.
>>> Use '--' to separate paths from revisions, like this:
>>> 'git <command> [<revision>...] -- [<file>...]'
>>>
>>> Are you sure?
>>
>> This would seem to indicate so:
>>
>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=1cebcf9932ab76102e8cfc555879574693ba8956
>>
>> linux-2.6$ git describe 1cebcf9932ab76102e8cfc555879574693ba8956
>> v5.13-rc1-1-g1cebcf9932ab
>>
>> Did the commit get abbreviated too much ?
> 
> Something is really odd, as that commit _is_ in linux-next, but it is
> not in my local copy of Linus's tree.
> 
> So how it is showing up in that link above is beyond me.  Can you see it
> locally on your machine?

Yes, that's where the git describe came from. And I used a different 
repo than the one from which I submitted the patch originally, so the 
commit must've come from fetching origin (i.e. linus tree).

Could it be this "ambiguous argument '1cebcf9932ab'" , which would 
indicate the commit hash got abbreviated too much ?

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH] ARM: dts: stm32: Rework LAN8710Ai PHY reset on DHCOM SoM
@ 2021-06-28 13:10           ` Marek Vasut
  0 siblings, 0 replies; 16+ messages in thread
From: Marek Vasut @ 2021-06-28 13:10 UTC (permalink / raw)
  To: Greg KH
  Cc: linux-arm-kernel, linux-stable, Alexandre Torgue,
	Patrice Chotard, Patrick Delaunay, linux-stm32, Sasha Levin

On 6/28/21 3:02 PM, Greg KH wrote:
> On Mon, Jun 28, 2021 at 02:32:50PM +0200, Marek Vasut wrote:
>> On 6/28/21 2:29 PM, Greg KH wrote:
>>> On Mon, Jun 28, 2021 at 12:44:37PM +0200, Marek Vasut wrote:
>>>> On 4/9/21 1:00 AM, Marek Vasut wrote:
>>>>> The Microchip LAN8710Ai PHY requires XTAL1/CLKIN external clock to be
>>>>> enabled when the nRST is toggled according to datasheet Microchip
>>>>> LAN8710A/LAN8710Ai DS00002164B page 35 section 3.8.5.1 Hardware Reset:
>>>>
>>>> [...]
>>>>
>>>>> Fixes: 34e0c7847dcf ("ARM: dts: stm32: Add DH Electronics DHCOM STM32MP1 SoM and PDK2 board")
>>>>
>>>> Adding stable to CC.
>>>>
>>>> Patch is now part of Linux 5.13 as commit
>>>>
>>>> 1cebcf9932ab ("ARM: dts: stm32: Rework LAN8710Ai PHY reset on DHCOM SoM")
>>>
>>> $ git show 1cebcf9932ab
>>> fatal: ambiguous argument '1cebcf9932ab': unknown revision or path not in the working tree.
>>> Use '--' to separate paths from revisions, like this:
>>> 'git <command> [<revision>...] -- [<file>...]'
>>>
>>> Are you sure?
>>
>> This would seem to indicate so:
>>
>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=1cebcf9932ab76102e8cfc555879574693ba8956
>>
>> linux-2.6$ git describe 1cebcf9932ab76102e8cfc555879574693ba8956
>> v5.13-rc1-1-g1cebcf9932ab
>>
>> Did the commit get abbreviated too much ?
> 
> Something is really odd, as that commit _is_ in linux-next, but it is
> not in my local copy of Linus's tree.
> 
> So how it is showing up in that link above is beyond me.  Can you see it
> locally on your machine?

Yes, that's where the git describe came from. And I used a different 
repo than the one from which I submitted the patch originally, so the 
commit must've come from fetching origin (i.e. linus tree).

Could it be this "ambiguous argument '1cebcf9932ab'" , which would 
indicate the commit hash got abbreviated too much ?

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH] ARM: dts: stm32: Rework LAN8710Ai PHY reset on DHCOM SoM
  2021-06-28 13:10           ` Marek Vasut
@ 2021-06-28 13:38             ` Greg KH
  -1 siblings, 0 replies; 16+ messages in thread
From: Greg KH @ 2021-06-28 13:38 UTC (permalink / raw)
  To: Marek Vasut
  Cc: linux-arm-kernel, linux-stable, Alexandre Torgue,
	Patrice Chotard, Patrick Delaunay, linux-stm32, Sasha Levin

On Mon, Jun 28, 2021 at 03:10:36PM +0200, Marek Vasut wrote:
> On 6/28/21 3:02 PM, Greg KH wrote:
> > On Mon, Jun 28, 2021 at 02:32:50PM +0200, Marek Vasut wrote:
> > > On 6/28/21 2:29 PM, Greg KH wrote:
> > > > On Mon, Jun 28, 2021 at 12:44:37PM +0200, Marek Vasut wrote:
> > > > > On 4/9/21 1:00 AM, Marek Vasut wrote:
> > > > > > The Microchip LAN8710Ai PHY requires XTAL1/CLKIN external clock to be
> > > > > > enabled when the nRST is toggled according to datasheet Microchip
> > > > > > LAN8710A/LAN8710Ai DS00002164B page 35 section 3.8.5.1 Hardware Reset:
> > > > > 
> > > > > [...]
> > > > > 
> > > > > > Fixes: 34e0c7847dcf ("ARM: dts: stm32: Add DH Electronics DHCOM STM32MP1 SoM and PDK2 board")
> > > > > 
> > > > > Adding stable to CC.
> > > > > 
> > > > > Patch is now part of Linux 5.13 as commit
> > > > > 
> > > > > 1cebcf9932ab ("ARM: dts: stm32: Rework LAN8710Ai PHY reset on DHCOM SoM")
> > > > 
> > > > $ git show 1cebcf9932ab
> > > > fatal: ambiguous argument '1cebcf9932ab': unknown revision or path not in the working tree.
> > > > Use '--' to separate paths from revisions, like this:
> > > > 'git <command> [<revision>...] -- [<file>...]'
> > > > 
> > > > Are you sure?
> > > 
> > > This would seem to indicate so:
> > > 
> > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=1cebcf9932ab76102e8cfc555879574693ba8956
> > > 
> > > linux-2.6$ git describe 1cebcf9932ab76102e8cfc555879574693ba8956
> > > v5.13-rc1-1-g1cebcf9932ab
> > > 
> > > Did the commit get abbreviated too much ?
> > 
> > Something is really odd, as that commit _is_ in linux-next, but it is
> > not in my local copy of Linus's tree.
> > 
> > So how it is showing up in that link above is beyond me.  Can you see it
> > locally on your machine?
> 
> Yes, that's where the git describe came from. And I used a different repo
> than the one from which I submitted the patch originally, so the commit
> must've come from fetching origin (i.e. linus tree).
> 
> Could it be this "ambiguous argument '1cebcf9932ab'" , which would indicate
> the commit hash got abbreviated too much ?

The web site "lies" it has a shared backend.  Trust your local copy of
the tree, that shows that this commit is NOT in Linus's tree just yet.
Please let stable@vger know when it does hit Linus's tree and we will be
glad to take it.

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH] ARM: dts: stm32: Rework LAN8710Ai PHY reset on DHCOM SoM
@ 2021-06-28 13:38             ` Greg KH
  0 siblings, 0 replies; 16+ messages in thread
From: Greg KH @ 2021-06-28 13:38 UTC (permalink / raw)
  To: Marek Vasut
  Cc: linux-arm-kernel, linux-stable, Alexandre Torgue,
	Patrice Chotard, Patrick Delaunay, linux-stm32, Sasha Levin

On Mon, Jun 28, 2021 at 03:10:36PM +0200, Marek Vasut wrote:
> On 6/28/21 3:02 PM, Greg KH wrote:
> > On Mon, Jun 28, 2021 at 02:32:50PM +0200, Marek Vasut wrote:
> > > On 6/28/21 2:29 PM, Greg KH wrote:
> > > > On Mon, Jun 28, 2021 at 12:44:37PM +0200, Marek Vasut wrote:
> > > > > On 4/9/21 1:00 AM, Marek Vasut wrote:
> > > > > > The Microchip LAN8710Ai PHY requires XTAL1/CLKIN external clock to be
> > > > > > enabled when the nRST is toggled according to datasheet Microchip
> > > > > > LAN8710A/LAN8710Ai DS00002164B page 35 section 3.8.5.1 Hardware Reset:
> > > > > 
> > > > > [...]
> > > > > 
> > > > > > Fixes: 34e0c7847dcf ("ARM: dts: stm32: Add DH Electronics DHCOM STM32MP1 SoM and PDK2 board")
> > > > > 
> > > > > Adding stable to CC.
> > > > > 
> > > > > Patch is now part of Linux 5.13 as commit
> > > > > 
> > > > > 1cebcf9932ab ("ARM: dts: stm32: Rework LAN8710Ai PHY reset on DHCOM SoM")
> > > > 
> > > > $ git show 1cebcf9932ab
> > > > fatal: ambiguous argument '1cebcf9932ab': unknown revision or path not in the working tree.
> > > > Use '--' to separate paths from revisions, like this:
> > > > 'git <command> [<revision>...] -- [<file>...]'
> > > > 
> > > > Are you sure?
> > > 
> > > This would seem to indicate so:
> > > 
> > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=1cebcf9932ab76102e8cfc555879574693ba8956
> > > 
> > > linux-2.6$ git describe 1cebcf9932ab76102e8cfc555879574693ba8956
> > > v5.13-rc1-1-g1cebcf9932ab
> > > 
> > > Did the commit get abbreviated too much ?
> > 
> > Something is really odd, as that commit _is_ in linux-next, but it is
> > not in my local copy of Linus's tree.
> > 
> > So how it is showing up in that link above is beyond me.  Can you see it
> > locally on your machine?
> 
> Yes, that's where the git describe came from. And I used a different repo
> than the one from which I submitted the patch originally, so the commit
> must've come from fetching origin (i.e. linus tree).
> 
> Could it be this "ambiguous argument '1cebcf9932ab'" , which would indicate
> the commit hash got abbreviated too much ?

The web site "lies" it has a shared backend.  Trust your local copy of
the tree, that shows that this commit is NOT in Linus's tree just yet.
Please let stable@vger know when it does hit Linus's tree and we will be
glad to take it.

thanks,

greg k-h

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH] ARM: dts: stm32: Rework LAN8710Ai PHY reset on DHCOM SoM
  2021-06-28 13:38             ` Greg KH
@ 2021-06-28 13:58               ` Marek Vasut
  -1 siblings, 0 replies; 16+ messages in thread
From: Marek Vasut @ 2021-06-28 13:58 UTC (permalink / raw)
  To: Greg KH
  Cc: linux-arm-kernel, linux-stable, Alexandre Torgue,
	Patrice Chotard, Patrick Delaunay, linux-stm32, Sasha Levin

On 6/28/21 3:38 PM, Greg KH wrote:
> On Mon, Jun 28, 2021 at 03:10:36PM +0200, Marek Vasut wrote:
>> On 6/28/21 3:02 PM, Greg KH wrote:
>>> On Mon, Jun 28, 2021 at 02:32:50PM +0200, Marek Vasut wrote:
>>>> On 6/28/21 2:29 PM, Greg KH wrote:
>>>>> On Mon, Jun 28, 2021 at 12:44:37PM +0200, Marek Vasut wrote:
>>>>>> On 4/9/21 1:00 AM, Marek Vasut wrote:
>>>>>>> The Microchip LAN8710Ai PHY requires XTAL1/CLKIN external clock to be
>>>>>>> enabled when the nRST is toggled according to datasheet Microchip
>>>>>>> LAN8710A/LAN8710Ai DS00002164B page 35 section 3.8.5.1 Hardware Reset:
>>>>>>
>>>>>> [...]
>>>>>>
>>>>>>> Fixes: 34e0c7847dcf ("ARM: dts: stm32: Add DH Electronics DHCOM STM32MP1 SoM and PDK2 board")
>>>>>>
>>>>>> Adding stable to CC.
>>>>>>
>>>>>> Patch is now part of Linux 5.13 as commit
>>>>>>
>>>>>> 1cebcf9932ab ("ARM: dts: stm32: Rework LAN8710Ai PHY reset on DHCOM SoM")
>>>>>
>>>>> $ git show 1cebcf9932ab
>>>>> fatal: ambiguous argument '1cebcf9932ab': unknown revision or path not in the working tree.
>>>>> Use '--' to separate paths from revisions, like this:
>>>>> 'git <command> [<revision>...] -- [<file>...]'
>>>>>
>>>>> Are you sure?
>>>>
>>>> This would seem to indicate so:
>>>>
>>>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=1cebcf9932ab76102e8cfc555879574693ba8956
>>>>
>>>> linux-2.6$ git describe 1cebcf9932ab76102e8cfc555879574693ba8956
>>>> v5.13-rc1-1-g1cebcf9932ab
>>>>
>>>> Did the commit get abbreviated too much ?
>>>
>>> Something is really odd, as that commit _is_ in linux-next, but it is
>>> not in my local copy of Linus's tree.
>>>
>>> So how it is showing up in that link above is beyond me.  Can you see it
>>> locally on your machine?
>>
>> Yes, that's where the git describe came from. And I used a different repo
>> than the one from which I submitted the patch originally, so the commit
>> must've come from fetching origin (i.e. linus tree).
>>
>> Could it be this "ambiguous argument '1cebcf9932ab'" , which would indicate
>> the commit hash got abbreviated too much ?
> 
> The web site "lies" it has a shared backend.  Trust your local copy of
> the tree, that shows that this commit is NOT in Linus's tree just yet.
> Please let stable@vger know when it does hit Linus's tree and we will be
> glad to take it.

Doh, of course, it is in next and not linus tree, now it makes sense.
I'll wait a bit until it is there and revisit this, unless it gets 
picked automatically by the Fixes tag.

Sorry for the noise.

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH] ARM: dts: stm32: Rework LAN8710Ai PHY reset on DHCOM SoM
@ 2021-06-28 13:58               ` Marek Vasut
  0 siblings, 0 replies; 16+ messages in thread
From: Marek Vasut @ 2021-06-28 13:58 UTC (permalink / raw)
  To: Greg KH
  Cc: linux-arm-kernel, linux-stable, Alexandre Torgue,
	Patrice Chotard, Patrick Delaunay, linux-stm32, Sasha Levin

On 6/28/21 3:38 PM, Greg KH wrote:
> On Mon, Jun 28, 2021 at 03:10:36PM +0200, Marek Vasut wrote:
>> On 6/28/21 3:02 PM, Greg KH wrote:
>>> On Mon, Jun 28, 2021 at 02:32:50PM +0200, Marek Vasut wrote:
>>>> On 6/28/21 2:29 PM, Greg KH wrote:
>>>>> On Mon, Jun 28, 2021 at 12:44:37PM +0200, Marek Vasut wrote:
>>>>>> On 4/9/21 1:00 AM, Marek Vasut wrote:
>>>>>>> The Microchip LAN8710Ai PHY requires XTAL1/CLKIN external clock to be
>>>>>>> enabled when the nRST is toggled according to datasheet Microchip
>>>>>>> LAN8710A/LAN8710Ai DS00002164B page 35 section 3.8.5.1 Hardware Reset:
>>>>>>
>>>>>> [...]
>>>>>>
>>>>>>> Fixes: 34e0c7847dcf ("ARM: dts: stm32: Add DH Electronics DHCOM STM32MP1 SoM and PDK2 board")
>>>>>>
>>>>>> Adding stable to CC.
>>>>>>
>>>>>> Patch is now part of Linux 5.13 as commit
>>>>>>
>>>>>> 1cebcf9932ab ("ARM: dts: stm32: Rework LAN8710Ai PHY reset on DHCOM SoM")
>>>>>
>>>>> $ git show 1cebcf9932ab
>>>>> fatal: ambiguous argument '1cebcf9932ab': unknown revision or path not in the working tree.
>>>>> Use '--' to separate paths from revisions, like this:
>>>>> 'git <command> [<revision>...] -- [<file>...]'
>>>>>
>>>>> Are you sure?
>>>>
>>>> This would seem to indicate so:
>>>>
>>>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=1cebcf9932ab76102e8cfc555879574693ba8956
>>>>
>>>> linux-2.6$ git describe 1cebcf9932ab76102e8cfc555879574693ba8956
>>>> v5.13-rc1-1-g1cebcf9932ab
>>>>
>>>> Did the commit get abbreviated too much ?
>>>
>>> Something is really odd, as that commit _is_ in linux-next, but it is
>>> not in my local copy of Linus's tree.
>>>
>>> So how it is showing up in that link above is beyond me.  Can you see it
>>> locally on your machine?
>>
>> Yes, that's where the git describe came from. And I used a different repo
>> than the one from which I submitted the patch originally, so the commit
>> must've come from fetching origin (i.e. linus tree).
>>
>> Could it be this "ambiguous argument '1cebcf9932ab'" , which would indicate
>> the commit hash got abbreviated too much ?
> 
> The web site "lies" it has a shared backend.  Trust your local copy of
> the tree, that shows that this commit is NOT in Linus's tree just yet.
> Please let stable@vger know when it does hit Linus's tree and we will be
> glad to take it.

Doh, of course, it is in next and not linus tree, now it makes sense.
I'll wait a bit until it is there and revisit this, unless it gets 
picked automatically by the Fixes tag.

Sorry for the noise.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 16+ messages in thread

end of thread, other threads:[~2021-06-28 14:00 UTC | newest]

Thread overview: 16+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-08 23:00 [PATCH] ARM: dts: stm32: Rework LAN8710Ai PHY reset on DHCOM SoM Marek Vasut
2021-06-01  6:50 ` Alexandre TORGUE
2021-06-28 10:44 ` Marek Vasut
2021-06-28 10:44   ` Marek Vasut
2021-06-28 12:29   ` Greg KH
2021-06-28 12:29     ` Greg KH
2021-06-28 12:32     ` Marek Vasut
2021-06-28 12:32       ` Marek Vasut
2021-06-28 13:02       ` Greg KH
2021-06-28 13:02         ` Greg KH
2021-06-28 13:10         ` Marek Vasut
2021-06-28 13:10           ` Marek Vasut
2021-06-28 13:38           ` Greg KH
2021-06-28 13:38             ` Greg KH
2021-06-28 13:58             ` Marek Vasut
2021-06-28 13:58               ` Marek Vasut

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.