From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f52.google.com (mail-ej1-f52.google.com [209.85.218.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AB2FB70 for ; Thu, 8 Apr 2021 23:45:31 +0000 (UTC) Received: by mail-ej1-f52.google.com with SMTP id r9so5812673ejj.3 for ; Thu, 08 Apr 2021 16:45:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:mime-version:content-disposition; bh=QhXqjewBtncdOCVUU5t44rbala3/r6RlbCvxFUCu3+M=; b=uA8WrQ0N22+iR9oeA1h8gASKkARO7xU5WR15k/IhN6w0VmVzJ/ctMncOyRSvrlawmZ 9Y9hl3rY+3Jt7KcxhL3ZSceFm8fBZHSj8K65ahVdhaTobmUIOZHZOitOwaJsW+yIMGAG 2sz1T44y5XyRbs3PPbMLJE0Ceo76TWUxE4/yueSRUHbhfg666K4d3NpEYsJS0LhQa0nK YEGTocAOSadgCqAfQReKpwIcs11SRclfg+DEbr3MHlsVCZDIXPTJmPYVuogeoft0TvOk od6I0utFQKakFwmn7R7i0teJ7kP9q37qU6++zTPpnV4pjJGxqkUPIKwIcDg58lQbWSgP VXnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition; bh=QhXqjewBtncdOCVUU5t44rbala3/r6RlbCvxFUCu3+M=; b=kFeZUpPpSN6+a3kWzaO0kBzsoEh3lw4pwN34j2wiBBdt4bdq4Yk31o9cdfuAVG75k0 Kmt8wmQxjdsaiRr7Z/Jeyso+6nMeFJNuucw5YchPjHZnPAzkaNFaE3OdYlqpsrGzrN8E PzH42Ej5h4RI+zjIVA1f1MS8BWgFSWh9lhmEzr2nBib+OBTIvVWWeQfPdGPFLUNGhuSL 6b+LI7osdRzuP0NiIoNJwbIQmulkrXLY4HS8Dqcrb2IiYa7INzhBEpk4/9HDQirpnH8F YgTuhrWJexNv93tNiw7Rb4HJIwAfET9Brh0qAhWuuXwoOqNmHY8RzX8q+y1GkdeMn88O gFhQ== X-Gm-Message-State: AOAM533bA1CG0pn1FGGbMIG5kykRCUEgbKHesKWHHgwWjzGhL1nofSxh 7iDyriDF/E4bOz0y4P2xAaE= X-Google-Smtp-Source: ABdhPJxlmqZFXITOX8f8zYmoxVtOp+YhPyDdDgCXRVxxqPyk51MqeXJsMlFlQJT7QmBqwpsecshSwQ== X-Received: by 2002:a17:906:3a94:: with SMTP id y20mr13368380ejd.35.1617925530313; Thu, 08 Apr 2021 16:45:30 -0700 (PDT) Received: from test-VirtualBox ([87.116.181.227]) by smtp.gmail.com with ESMTPSA id h25sm383175ejx.105.2021.04.08.16.45.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Apr 2021 16:45:30 -0700 (PDT) Date: Fri, 9 Apr 2021 01:45:27 +0200 From: Sergei Krainov To: Larry.Finger@lwfinger.net, florian.c.schilhabel@googlemail.com, gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH] staging: rtl8712: fix wrong function output Message-ID: <20210408234527.GA6893@test-VirtualBox> X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Function r8712_find_network() were returning wlan_network even if it didn't match required address. This happened due to not checking if list end was reached and returning last processed wlan_network. Signed-off-by: Sergei Krainov --- drivers/staging/rtl8712/rtl871x_mlme.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/staging/rtl8712/rtl871x_mlme.c b/drivers/staging/rtl8712/rtl871x_mlme.c index 8a97307fbbd6..c38161114b80 100644 --- a/drivers/staging/rtl8712/rtl871x_mlme.c +++ b/drivers/staging/rtl8712/rtl871x_mlme.c @@ -146,6 +146,8 @@ static struct wlan_network *r8712_find_network(struct __queue *scanned_queue, if (!memcmp(addr, pnetwork->network.MacAddress, ETH_ALEN)) break; } + if (plist == phead) + pnetwork = NULL; spin_unlock_irqrestore(&scanned_queue->lock, irqL); return pnetwork; } -- 2.25.1