* [PATCH] drm/vc4: Fix PM reference leak in vc4_vec_encoder_enable()
@ 2021-04-09 0:38 ` Bixuan Cui
0 siblings, 0 replies; 2+ messages in thread
From: Bixuan Cui @ 2021-04-09 0:38 UTC (permalink / raw)
To: linux-kernel
Cc: john.wanghui, eric, mripard, airlied, daniel, dri-devel, Bixuan Cui
The pm_runtime_get_sync will increment pm usage counter even it failed.Thus a
pairing decrement is needed.
Change pm_runtime_get_sync to pm_runtime_resume_and_get for keeping usage counter
balanced.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Bixuan Cui <cuibixuan@huawei.com>
---
drivers/gpu/drm/vc4/vc4_vec.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/vc4/vc4_vec.c b/drivers/gpu/drm/vc4/vc4_vec.c
index bd5b8eb58b18..924e03050dd4 100644
--- a/drivers/gpu/drm/vc4/vc4_vec.c
+++ b/drivers/gpu/drm/vc4/vc4_vec.c
@@ -403,7 +403,7 @@ static void vc4_vec_encoder_enable(struct drm_encoder *encoder)
struct vc4_vec *vec = vc4_vec_encoder->vec;
int ret;
- ret = pm_runtime_get_sync(&vec->pdev->dev);
+ ret = pm_runtime_resume_and_get(&vec->pdev->dev);
if (ret < 0) {
DRM_ERROR("Failed to retain power domain: %d\n", ret);
return;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH] drm/vc4: Fix PM reference leak in vc4_vec_encoder_enable()
@ 2021-04-09 0:38 ` Bixuan Cui
0 siblings, 0 replies; 2+ messages in thread
From: Bixuan Cui @ 2021-04-09 0:38 UTC (permalink / raw)
To: linux-kernel; +Cc: airlied, john.wanghui, dri-devel, Bixuan Cui
The pm_runtime_get_sync will increment pm usage counter even it failed.Thus a
pairing decrement is needed.
Change pm_runtime_get_sync to pm_runtime_resume_and_get for keeping usage counter
balanced.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Bixuan Cui <cuibixuan@huawei.com>
---
drivers/gpu/drm/vc4/vc4_vec.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/vc4/vc4_vec.c b/drivers/gpu/drm/vc4/vc4_vec.c
index bd5b8eb58b18..924e03050dd4 100644
--- a/drivers/gpu/drm/vc4/vc4_vec.c
+++ b/drivers/gpu/drm/vc4/vc4_vec.c
@@ -403,7 +403,7 @@ static void vc4_vec_encoder_enable(struct drm_encoder *encoder)
struct vc4_vec *vec = vc4_vec_encoder->vec;
int ret;
- ret = pm_runtime_get_sync(&vec->pdev->dev);
+ ret = pm_runtime_resume_and_get(&vec->pdev->dev);
if (ret < 0) {
DRM_ERROR("Failed to retain power domain: %d\n", ret);
return;
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-04-09 6:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-09 0:38 [PATCH] drm/vc4: Fix PM reference leak in vc4_vec_encoder_enable() Bixuan Cui
2021-04-09 0:38 ` Bixuan Cui
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.