Re: [PATCH v3] powerpc/traps: Enhance readability for trap types

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 5804 bytes --]

Hi Xiongwei,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on powerpc/next]
[also build test ERROR on next-20210408]
[cannot apply to hnaz-linux-mm/master v5.12-rc6]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Xiongwei-Song/powerpc-traps-Enhance-readability-for-trap-types/20210408-221152
base:   https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next
config: powerpc64-randconfig-r004-20210408 (attached as .config)
compiler: powerpc-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/d9dd965937ed76338a90b73b94190499a98cb5d1
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Xiongwei-Song/powerpc-traps-Enhance-readability-for-trap-types/20210408-221152
        git checkout d9dd965937ed76338a90b73b94190499a98cb5d1
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=powerpc64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   In file included from include/linux/kernel.h:10,
                    from include/linux/list.h:9,
                    from include/linux/rculist.h:10,
                    from include/linux/pid.h:5,
                    from include/linux/sched.h:14,
                    from arch/powerpc/kernel/process.c:14:
   arch/powerpc/kernel/process.c: In function '__show_regs':
>> arch/powerpc/kernel/process.c:1473:14: error: 'INTERRUPT_MACHINE_CHECK' undeclared (first use in this function); did you mean 'TAINT_MACHINE_CHECK'?
    1473 |  if (trap == INTERRUPT_MACHINE_CHECK ||
         |              ^~~~~~~~~~~~~~~~~~~~~~~
   include/linux/compiler.h:58:52: note: in definition of macro '__trace_if_var'
      58 | #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond))
         |                                                    ^~~~
   arch/powerpc/kernel/process.c:1473:2: note: in expansion of macro 'if'
    1473 |  if (trap == INTERRUPT_MACHINE_CHECK ||
         |  ^~
   arch/powerpc/kernel/process.c:1473:14: note: each undeclared identifier is reported only once for each function it appears in
    1473 |  if (trap == INTERRUPT_MACHINE_CHECK ||
         |              ^~~~~~~~~~~~~~~~~~~~~~~
   include/linux/compiler.h:58:52: note: in definition of macro '__trace_if_var'
      58 | #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond))
         |                                                    ^~~~
   arch/powerpc/kernel/process.c:1473:2: note: in expansion of macro 'if'
    1473 |  if (trap == INTERRUPT_MACHINE_CHECK ||
         |  ^~
--
   In file included from include/linux/kernel.h:10,
                    from arch/powerpc/xmon/xmon.c:10:
   arch/powerpc/xmon/xmon.c: In function 'excprint':
>> arch/powerpc/xmon/xmon.c:1778:14: error: 'INTERRUPT_MACHINE_CHECK' undeclared (first use in this function); did you mean 'TAINT_MACHINE_CHECK'?
    1778 |      trap == INTERRUPT_MACHINE_CHECK) {
         |              ^~~~~~~~~~~~~~~~~~~~~~~
   include/linux/compiler.h:58:52: note: in definition of macro '__trace_if_var'
      58 | #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond))
         |                                                    ^~~~
   arch/powerpc/xmon/xmon.c:1773:2: note: in expansion of macro 'if'
    1773 |  if (trap == INTERRUPT_DATA_STORAGE ||
         |  ^~
   arch/powerpc/xmon/xmon.c:1778:14: note: each undeclared identifier is reported only once for each function it appears in
    1778 |      trap == INTERRUPT_MACHINE_CHECK) {
         |              ^~~~~~~~~~~~~~~~~~~~~~~
   include/linux/compiler.h:58:52: note: in definition of macro '__trace_if_var'
      58 | #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond))
         |                                                    ^~~~
   arch/powerpc/xmon/xmon.c:1773:2: note: in expansion of macro 'if'
    1773 |  if (trap == INTERRUPT_DATA_STORAGE ||
         |  ^~


vim +1473 arch/powerpc/kernel/process.c

  1458	
  1459	static void __show_regs(struct pt_regs *regs)
  1460	{
  1461		int i, trap;
  1462	
  1463		printk("NIP:  "REG" LR: "REG" CTR: "REG"\n",
  1464		       regs->nip, regs->link, regs->ctr);
  1465		printk("REGS: %px TRAP: %04lx   %s  (%s)\n",
  1466		       regs, regs->trap, print_tainted(), init_utsname()->release);
  1467		printk("MSR:  "REG" ", regs->msr);
  1468		print_msr_bits(regs->msr);
  1469		pr_cont("  CR: %08lx  XER: %08lx\n", regs->ccr, regs->xer);
  1470		trap = TRAP(regs);
  1471		if (!trap_is_syscall(regs) && cpu_has_feature(CPU_FTR_CFAR))
  1472			pr_cont("CFAR: "REG" ", regs->orig_gpr3);
> 1473		if (trap == INTERRUPT_MACHINE_CHECK ||
  1474		    trap == INTERRUPT_DATA_STORAGE ||
  1475		    trap == INTERRUPT_ALIGNMENT) {
  1476			if (IS_ENABLED(CONFIG_4xx) || IS_ENABLED(CONFIG_BOOKE))
  1477				pr_cont("DEAR: "REG" ESR: "REG" ", regs->dar, regs->dsisr);
  1478			else
  1479				pr_cont("DAR: "REG" DSISR: %08lx ", regs->dar, regs->dsisr);
  1480		}
  1481	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 27902 bytes --]