* [PATCH -next] powerpc/pseries: Make symbol '__pcpu_scope_hcall_stats' static
@ 2021-04-09 9:01 ` Bixuan Cui
0 siblings, 0 replies; 4+ messages in thread
From: Bixuan Cui @ 2021-04-09 9:01 UTC (permalink / raw)
To: cuibixuan, Michael Ellerman, Liu Shixin
Cc: linuxppc-dev, linux-kernel, kernel-janitors
The sparse tool complains as follows:
arch/powerpc/platforms/pseries/hvCall_inst.c:29:1: warning:
symbol '__pcpu_scope_hcall_stats' was not declared. Should it be static?
This symbol is not used outside of hvCall_inst.c, so this
commit marks it static.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Bixuan Cui <cuibixuan@huawei.com>
---
arch/powerpc/platforms/pseries/hvCall_inst.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/platforms/pseries/hvCall_inst.c b/arch/powerpc/platforms/pseries/hvCall_inst.c
index 2c59b4986ea5..3a50612a78db 100644
--- a/arch/powerpc/platforms/pseries/hvCall_inst.c
+++ b/arch/powerpc/platforms/pseries/hvCall_inst.c
@@ -26,7 +26,7 @@ struct hcall_stats {
};
#define HCALL_STAT_ARRAY_SIZE ((MAX_HCALL_OPCODE >> 2) + 1)
-DEFINE_PER_CPU(struct hcall_stats[HCALL_STAT_ARRAY_SIZE], hcall_stats);
+static DEFINE_PER_CPU(struct hcall_stats[HCALL_STAT_ARRAY_SIZE], hcall_stats);
/*
* Routines for displaying the statistics in debugfs
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH -next] powerpc/pseries: Make symbol '__pcpu_scope_hcall_stats' static
@ 2021-04-09 9:01 ` Bixuan Cui
0 siblings, 0 replies; 4+ messages in thread
From: Bixuan Cui @ 2021-04-09 9:01 UTC (permalink / raw)
To: cuibixuan, Michael Ellerman, Liu Shixin
Cc: kernel-janitors, linuxppc-dev, linux-kernel
The sparse tool complains as follows:
arch/powerpc/platforms/pseries/hvCall_inst.c:29:1: warning:
symbol '__pcpu_scope_hcall_stats' was not declared. Should it be static?
This symbol is not used outside of hvCall_inst.c, so this
commit marks it static.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Bixuan Cui <cuibixuan@huawei.com>
---
arch/powerpc/platforms/pseries/hvCall_inst.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/platforms/pseries/hvCall_inst.c b/arch/powerpc/platforms/pseries/hvCall_inst.c
index 2c59b4986ea5..3a50612a78db 100644
--- a/arch/powerpc/platforms/pseries/hvCall_inst.c
+++ b/arch/powerpc/platforms/pseries/hvCall_inst.c
@@ -26,7 +26,7 @@ struct hcall_stats {
};
#define HCALL_STAT_ARRAY_SIZE ((MAX_HCALL_OPCODE >> 2) + 1)
-DEFINE_PER_CPU(struct hcall_stats[HCALL_STAT_ARRAY_SIZE], hcall_stats);
+static DEFINE_PER_CPU(struct hcall_stats[HCALL_STAT_ARRAY_SIZE], hcall_stats);
/*
* Routines for displaying the statistics in debugfs
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH -next] powerpc/pseries: Make symbol '__pcpu_scope_hcall_stats' static
2021-04-09 9:01 ` Bixuan Cui
@ 2021-04-19 3:59 ` Michael Ellerman
-1 siblings, 0 replies; 4+ messages in thread
From: Michael Ellerman @ 2021-04-19 3:59 UTC (permalink / raw)
To: Michael Ellerman, Bixuan Cui, Liu Shixin
Cc: kernel-janitors, linuxppc-dev, linux-kernel
On Fri, 9 Apr 2021 17:01:09 +0800, Bixuan Cui wrote:
> The sparse tool complains as follows:
>
> arch/powerpc/platforms/pseries/hvCall_inst.c:29:1: warning:
> symbol '__pcpu_scope_hcall_stats' was not declared. Should it be static?
>
> This symbol is not used outside of hvCall_inst.c, so this
> commit marks it static.
Applied to powerpc/next.
[1/1] powerpc/pseries: Make symbol '__pcpu_scope_hcall_stats' static
https://git.kernel.org/powerpc/c/193e4cd8ed9dd01092d01df7706a6b344c946af4
cheers
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH -next] powerpc/pseries: Make symbol '__pcpu_scope_hcall_stats' static
@ 2021-04-19 3:59 ` Michael Ellerman
0 siblings, 0 replies; 4+ messages in thread
From: Michael Ellerman @ 2021-04-19 3:59 UTC (permalink / raw)
To: Michael Ellerman, Bixuan Cui, Liu Shixin
Cc: linuxppc-dev, kernel-janitors, linux-kernel
On Fri, 9 Apr 2021 17:01:09 +0800, Bixuan Cui wrote:
> The sparse tool complains as follows:
>
> arch/powerpc/platforms/pseries/hvCall_inst.c:29:1: warning:
> symbol '__pcpu_scope_hcall_stats' was not declared. Should it be static?
>
> This symbol is not used outside of hvCall_inst.c, so this
> commit marks it static.
Applied to powerpc/next.
[1/1] powerpc/pseries: Make symbol '__pcpu_scope_hcall_stats' static
https://git.kernel.org/powerpc/c/193e4cd8ed9dd01092d01df7706a6b344c946af4
cheers
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-04-19 4:07 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-09 9:01 [PATCH -next] powerpc/pseries: Make symbol '__pcpu_scope_hcall_stats' static Bixuan Cui
2021-04-09 9:01 ` Bixuan Cui
2021-04-19 3:59 ` Michael Ellerman
2021-04-19 3:59 ` Michael Ellerman
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.