* [PATCH -next] powerpc/pseries/pmem: Make symbol 'drc_pmem_match' static
@ 2021-04-09 9:01 Bixuan Cui
2021-04-19 3:59 ` Michael Ellerman
0 siblings, 1 reply; 3+ messages in thread
From: Bixuan Cui @ 2021-04-09 9:01 UTC (permalink / raw)
To: cuibixuan, Michael Ellerman, Gautham R. Shenoy, Nathan Lynch,
Aneesh Kumar K.V
Cc: kernel-janitors, linuxppc-dev, linux-kernel
The sparse tool complains as follows:
arch/powerpc/platforms/pseries/pmem.c:142:27: warning:
symbol 'drc_pmem_match' was not declared. Should it be static?
This symbol is not used outside of pmem.c, so this
commit marks it static.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Bixuan Cui <cuibixuan@huawei.com>
---
arch/powerpc/platforms/pseries/pmem.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/platforms/pseries/pmem.c b/arch/powerpc/platforms/pseries/pmem.c
index e1dc5d3254df..439ac72c2470 100644
--- a/arch/powerpc/platforms/pseries/pmem.c
+++ b/arch/powerpc/platforms/pseries/pmem.c
@@ -139,7 +139,7 @@ int dlpar_hp_pmem(struct pseries_hp_errorlog *hp_elog)
return rc;
}
-const struct of_device_id drc_pmem_match[] = {
+static const struct of_device_id drc_pmem_match[] = {
{ .type = "ibm,persistent-memory", },
{}
};
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH -next] powerpc/pseries/pmem: Make symbol 'drc_pmem_match' static
2021-04-09 9:01 [PATCH -next] powerpc/pseries/pmem: Make symbol 'drc_pmem_match' static Bixuan Cui
@ 2021-04-19 3:59 ` Michael Ellerman
0 siblings, 0 replies; 3+ messages in thread
From: Michael Ellerman @ 2021-04-19 3:59 UTC (permalink / raw)
To: Bixuan Cui, Nathan Lynch, Michael Ellerman, Aneesh Kumar K.V,
Gautham R. Shenoy
Cc: kernel-janitors, linuxppc-dev, linux-kernel
On Fri, 9 Apr 2021 17:01:14 +0800, Bixuan Cui wrote:
> The sparse tool complains as follows:
>
> arch/powerpc/platforms/pseries/pmem.c:142:27: warning:
> symbol 'drc_pmem_match' was not declared. Should it be static?
>
> This symbol is not used outside of pmem.c, so this
> commit marks it static.
Applied to powerpc/next.
[1/1] powerpc/pseries/pmem: Make symbol 'drc_pmem_match' static
https://git.kernel.org/powerpc/c/2235dea17d56238642121a8085b71d68598534bb
cheers
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] powerpc/pseries/pmem: Make symbol 'drc_pmem_match' static
@ 2021-04-19 3:59 ` Michael Ellerman
0 siblings, 0 replies; 3+ messages in thread
From: Michael Ellerman @ 2021-04-19 3:59 UTC (permalink / raw)
To: Bixuan Cui, Nathan Lynch, Michael Ellerman, Aneesh Kumar K.V,
Gautham R. Shenoy
Cc: linuxppc-dev, kernel-janitors, linux-kernel
On Fri, 9 Apr 2021 17:01:14 +0800, Bixuan Cui wrote:
> The sparse tool complains as follows:
>
> arch/powerpc/platforms/pseries/pmem.c:142:27: warning:
> symbol 'drc_pmem_match' was not declared. Should it be static?
>
> This symbol is not used outside of pmem.c, so this
> commit marks it static.
Applied to powerpc/next.
[1/1] powerpc/pseries/pmem: Make symbol 'drc_pmem_match' static
https://git.kernel.org/powerpc/c/2235dea17d56238642121a8085b71d68598534bb
cheers
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-04-19 4:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-09 9:01 [PATCH -next] powerpc/pseries/pmem: Make symbol 'drc_pmem_match' static Bixuan Cui
2021-04-19 3:59 ` Michael Ellerman
2021-04-19 3:59 ` Michael Ellerman
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.