All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Peter Morrow" <pemorrow@linux.microsoft.com>
To: Khem Raj <raj.khem@gmail.com>
Cc: openembedded-core@lists.openembedded.org, peter.morrow@microsoft.com
Subject: Re: [dunfell][PATCH 1/2] goarch: map target os to windows for mingw* TARGET_OS
Date: Fri, 9 Apr 2021 02:31:24 -0700	[thread overview]
Message-ID: <20210409093124.GA32252@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> (raw)
In-Reply-To: <CAMKF1spzWbNYUOSNkwExTRF4H1dc7H7+1Yb3QQfNt_hWo-Qrgg@mail.gmail.com>

On Tue, Apr 06, 2021 at 08:21:59AM -0700, Khem Raj wrote:
> Lgtm

Thanks Khem!

Peter.


> 
> On Tue, Apr 6, 2021 at 6:08 AM Peter Morrow <pemorrow@linux.microsoft.com>
> wrote:
> 
> > mingw32/mingw64 is not a supported value for GOOS, so map from 'mingw*' to
> > 'windows' to enable building for windows targets.
> >
> > Signed-off-by: Peter Morrow <pemorrow@linux.microsoft.com>
> > ---
> >  meta/classes/goarch.bbclass | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/meta/classes/goarch.bbclass b/meta/classes/goarch.bbclass
> > index 1099b95..ecd3044 100644
> > --- a/meta/classes/goarch.bbclass
> > +++ b/meta/classes/goarch.bbclass
> > @@ -114,6 +114,8 @@ def go_map_mips(a, f, d):
> >  def go_map_os(o, d):
> >      if o.startswith('linux'):
> >          return 'linux'
> > +    elif o.startswith('mingw'):
> > +        return 'windows'
> >      return o
> >
> >
> > --
> > 1.8.3.1
> >
> >

      reply	other threads:[~2021-04-09  9:31 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-06 13:07 [dunfell][PATCH 1/2] goarch: map target os to windows for mingw* TARGET_OS Peter Morrow
2021-04-06 13:07 ` [dunfell][PATCH 2/2] go_1.14: don't set -buildmode=pie when building for windows targets Peter Morrow
2021-04-06 15:21   ` Khem Raj
2021-04-06 15:21 ` [dunfell][PATCH 1/2] goarch: map target os to windows for mingw* TARGET_OS Khem Raj
2021-04-09  9:31   ` Peter Morrow [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210409093124.GA32252@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net \
    --to=pemorrow@linux.microsoft.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=peter.morrow@microsoft.com \
    --cc=raj.khem@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.