From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C26CC433B4 for ; Fri, 9 Apr 2021 11:31:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5D3D2610A7 for ; Fri, 9 Apr 2021 11:31:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233592AbhDILbf (ORCPT ); Fri, 9 Apr 2021 07:31:35 -0400 Received: from mail.kernel.org ([198.145.29.99]:46788 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233532AbhDILbc (ORCPT ); Fri, 9 Apr 2021 07:31:32 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 59CDA6113A; Fri, 9 Apr 2021 11:31:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1617967879; bh=fUp0KpjNQFEeNM0zf+0A70wkSLLCHLMN8TUpFFkE/Ck=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=trVdlCtfHEy41zGKMjob9ykuUD1Qjq3pGi4wPcrTsBrFrBpoFV4awRihVWa74ZlUO X8kaF5+9MazVIiXDLCW92DCjcVcZhoDXenOHyyH8bDyOy/4tZt+xBDGsJI36vTfVnp dtPmATsLtylovnLwq/Qhe4BxlcaKrL+UcXG7xFxmrb1U+FMYLHlqXxug7EcXWAiPN/ CW3vRWtgmbSTOe2BfHgpeNOODK74yeOtJYAcLf2e7NFmxBNbK8a6Fg/rA0FkeitLoy veTNJZoy0kbq0iKhae8l+lS7xLcGeHBDFkpUAvmmKlydcStoSjq5o47c4jzqFElZPA X95ZXrN1eLITw== Date: Fri, 9 Apr 2021 12:31:01 +0100 From: Mark Brown To: "Madhavan T. Venkataraman" Cc: mark.rutland@arm.com, jpoimboe@redhat.com, jthierry@redhat.com, catalin.marinas@arm.com, will@kernel.org, linux-arm-kernel@lists.infradead.org, live-patching@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH v2 3/4] arm64: Detect FTRACE cases that make the stack trace unreliable Message-ID: <20210409113101.GA4499@sirena.org.uk> References: <705993ccb34a611c75cdae0a8cb1b40f9b218ebd> <20210405204313.21346-1-madvenka@linux.microsoft.com> <20210405204313.21346-4-madvenka@linux.microsoft.com> <20210408165825.GP4516@sirena.org.uk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="xHFwDpU9dbj6ez1V" Content-Disposition: inline In-Reply-To: X-Cookie: Ring around the collar. User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --xHFwDpU9dbj6ez1V Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Apr 08, 2021 at 02:23:39PM -0500, Madhavan T. Venkataraman wrote: > On 4/8/21 11:58 AM, Mark Brown wrote: > > This looks good to me however I'd really like someone who has a firmer > > understanding of what ftrace is doing to double check as it is entirely > > likely that I am missing cases here, it seems likely that if I am > > missing stuff it's extra stuff that needs to be added and we're not > > actually making use of the reliability information yet. > OK. So, do you have some specific reviewer(s) in mind? Apart from yourself, Mark Rutland and > Josh Poimboeuf, these are some reviewers I can think of (in alphabetical order): Mainly Mark Rutland, but generally someone else who has looked at ftrace on arm64 in detail. It was mainly a comment to say I wasn't going to do any kind of Reviewed-by but also hadn't spotted any issues. --xHFwDpU9dbj6ez1V Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmBwOvQACgkQJNaLcl1U h9C1ywf/Zbw1Z1QFQ9f8u2MHhFttf12fqFoSFd5iqQ9spEcbfaBlpTl2v8M/5H9h R6oBURNPeVfVCxvv/71t9Orzqyn9ARMB/OizAb2stUPdlFcnKAYcK+EGhOLqLKvu ROhmYPrJxYkjx9Qegny0xAZp5MrlJ6nmUDl8xOLJYYj706CxMFP5Ajsbx+iYk1ZE s3sEJFrMhNTcQGo/Ov6u8icSdzC5GmdnbLZLZQABGM2XGtLYaI4OEAg9ZwXD/fIK A97q5N6unW1DVvNGwOdKRGakFGw/B9JoLtSEvWjEpsDzePbgTOm5hiWQi1GZNR51 9te0IeS7HVke1UH7AXxDqXJPHrbPLg== =neW0 -----END PGP SIGNATURE----- --xHFwDpU9dbj6ez1V-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83244C433B4 for ; Fri, 9 Apr 2021 11:34:01 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 002AE610C8 for ; Fri, 9 Apr 2021 11:34:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 002AE610C8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Qnxtd9YI4aOLhaoANpnzqbdV0DIYjFWlg/0AXgPSIpA=; b=JES1GYq2sS3sc7wGxW/3KEzF9 FnQdji22fCzC8P/1p5BkZJ493yleLf9xFEnjD53yLhmEEKernFWGn4yQg53WD9vbi2TLXkUwy4don S+dA5PvU9f56MvXrCuclwNCMSDHfUOR7GKIhZqHhXxGP5IqysPNOchSawEtToScpMwW16Lzv/ehYC sU9qQaPAJ/ODChPJKLPFA775VWWhLO9V8fzlRYKVgNsba/xYbhP7+/eFlBgNe41TLW4ZVuOFkg5jy x12axgq9nHdYwX8buQburwjJflzL/cKOXhBKm4tgWdCqTjEzQpnw+JWb5X1gABzzpNMIxkSCWt+wT LQVaIaaZQ==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lUpMx-000cwq-4Y; Fri, 09 Apr 2021 11:32:11 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lUpMD-000cn0-HD for linux-arm-kernel@desiato.infradead.org; Fri, 09 Apr 2021 11:31:25 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=yWycNcX0JdLVzMu4Wozww3tYBFcxvyLw3rhDiPYVTyc=; b=Lu8ZnVpCMMK34pXkgQ20b4QAqm nHTVaANZzRsp8Cd/iX6QBcZa0pajtpGuLay55HmZjZ+3A4Dm/MnyrfILU5DnQcEb/5RZz80pRwdpD YUXiI5bv9Iw0ykbVEXb9UWHgY9W9FuY6w4HjQbWhkeHUsUiTFIWvHjozEHivHPMuYKa3BPcgaacHj PO5+o2ADkCCrcnB3mVWI8g/6ATodLBgw5eyX3h85a71KXsH/lDuvBEEh3/Pk4tBONqrNqpAaaKGJZ o63xtfHmFzgpsyR0bA3Y6Vl9rpcaPRMN0+IiFfimmikgKYx6knXlGYQfFKyfbP82weL1fPZLOk/0s 6kplX0SQ==; Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lUpMA-004TEw-RJ for linux-arm-kernel@lists.infradead.org; Fri, 09 Apr 2021 11:31:24 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 59CDA6113A; Fri, 9 Apr 2021 11:31:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1617967879; bh=fUp0KpjNQFEeNM0zf+0A70wkSLLCHLMN8TUpFFkE/Ck=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=trVdlCtfHEy41zGKMjob9ykuUD1Qjq3pGi4wPcrTsBrFrBpoFV4awRihVWa74ZlUO X8kaF5+9MazVIiXDLCW92DCjcVcZhoDXenOHyyH8bDyOy/4tZt+xBDGsJI36vTfVnp dtPmATsLtylovnLwq/Qhe4BxlcaKrL+UcXG7xFxmrb1U+FMYLHlqXxug7EcXWAiPN/ CW3vRWtgmbSTOe2BfHgpeNOODK74yeOtJYAcLf2e7NFmxBNbK8a6Fg/rA0FkeitLoy veTNJZoy0kbq0iKhae8l+lS7xLcGeHBDFkpUAvmmKlydcStoSjq5o47c4jzqFElZPA X95ZXrN1eLITw== Date: Fri, 9 Apr 2021 12:31:01 +0100 From: Mark Brown To: "Madhavan T. Venkataraman" Cc: mark.rutland@arm.com, jpoimboe@redhat.com, jthierry@redhat.com, catalin.marinas@arm.com, will@kernel.org, linux-arm-kernel@lists.infradead.org, live-patching@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH v2 3/4] arm64: Detect FTRACE cases that make the stack trace unreliable Message-ID: <20210409113101.GA4499@sirena.org.uk> References: <705993ccb34a611c75cdae0a8cb1b40f9b218ebd> <20210405204313.21346-1-madvenka@linux.microsoft.com> <20210405204313.21346-4-madvenka@linux.microsoft.com> <20210408165825.GP4516@sirena.org.uk> MIME-Version: 1.0 In-Reply-To: X-Cookie: Ring around the collar. User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210409_043122_926116_9FABAB8B X-CRM114-Status: GOOD ( 17.22 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============0264503356754361891==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============0264503356754361891== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="xHFwDpU9dbj6ez1V" Content-Disposition: inline --xHFwDpU9dbj6ez1V Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Apr 08, 2021 at 02:23:39PM -0500, Madhavan T. Venkataraman wrote: > On 4/8/21 11:58 AM, Mark Brown wrote: > > This looks good to me however I'd really like someone who has a firmer > > understanding of what ftrace is doing to double check as it is entirely > > likely that I am missing cases here, it seems likely that if I am > > missing stuff it's extra stuff that needs to be added and we're not > > actually making use of the reliability information yet. > OK. So, do you have some specific reviewer(s) in mind? Apart from yourself, Mark Rutland and > Josh Poimboeuf, these are some reviewers I can think of (in alphabetical order): Mainly Mark Rutland, but generally someone else who has looked at ftrace on arm64 in detail. It was mainly a comment to say I wasn't going to do any kind of Reviewed-by but also hadn't spotted any issues. --xHFwDpU9dbj6ez1V Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmBwOvQACgkQJNaLcl1U h9C1ywf/Zbw1Z1QFQ9f8u2MHhFttf12fqFoSFd5iqQ9spEcbfaBlpTl2v8M/5H9h R6oBURNPeVfVCxvv/71t9Orzqyn9ARMB/OizAb2stUPdlFcnKAYcK+EGhOLqLKvu ROhmYPrJxYkjx9Qegny0xAZp5MrlJ6nmUDl8xOLJYYj706CxMFP5Ajsbx+iYk1ZE s3sEJFrMhNTcQGo/Ov6u8icSdzC5GmdnbLZLZQABGM2XGtLYaI4OEAg9ZwXD/fIK A97q5N6unW1DVvNGwOdKRGakFGw/B9JoLtSEvWjEpsDzePbgTOm5hiWQi1GZNR51 9te0IeS7HVke1UH7AXxDqXJPHrbPLg== =neW0 -----END PGP SIGNATURE----- --xHFwDpU9dbj6ez1V-- --===============0264503356754361891== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============0264503356754361891==--