From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7633BC433ED for ; Fri, 9 Apr 2021 18:07:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 577D761182 for ; Fri, 9 Apr 2021 18:07:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234504AbhDISHn (ORCPT ); Fri, 9 Apr 2021 14:07:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48156 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234470AbhDISHk (ORCPT ); Fri, 9 Apr 2021 14:07:40 -0400 Received: from mail-io1-xd2a.google.com (mail-io1-xd2a.google.com [IPv6:2607:f8b0:4864:20::d2a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4CE95C061763 for ; Fri, 9 Apr 2021 11:07:27 -0700 (PDT) Received: by mail-io1-xd2a.google.com with SMTP id y4so6834788ioy.3 for ; Fri, 09 Apr 2021 11:07:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=JnilhBvwTKFOB8eP45oHTw3WFpUuibOH2Z94szBsA0s=; b=MeUbvvCi/wa25GZoZsYd289FvDyW0YKqubUv0JrufJTn7ovGBXVgC3YPF0osP/UOYC 5hKBW+2STVkl3JynCZjgU7xBDH2rXRSyM5nWyzGmtXOJ7BIr5UKycBZTGdCbMLw2xvZ4 iG7vBLd6B8ylhItCdXUNd3VwufqJoHGjAo1O6z0zooeou1hzSiqDgit4LiEzeTwEGSAe Ond5i4E7TtzvFqK2jvEIWQHzVKdShwLiZbNFSrq7E0iRWKvVYDBUQriybUAqt7zRhoM3 9/jf9qtUrfrtW8iZCFeN9rCjolzrMMTWwuYywz6rXzvK4D2E6CavNjqsAqw6xxEbQwLh FY3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=JnilhBvwTKFOB8eP45oHTw3WFpUuibOH2Z94szBsA0s=; b=P104AkwHzR78+SgxlEr+K0L3oAkHxC1qN2SQGU9zg1YDAmdhIdIm6LohdgRh0O5uYz oYWbzs5ToyNt4Vc20D4FUJ6RHoLvx8A0ytvqKVHeosVbY2bvKAT7b/CFElh20WuAbldm +iMJVP5u8eTheM51HINi0HCI8CNUYyOrOm7aVdp46tYUwwC6Ik4ftEU/Wp2WD7/kTqvj kO3PZuFRNrxbq0DUJ3CIPuOx6G4G/cDQgTaJzNSB9LhsU+PViDR9OVB5mtMvYCo8xkLn /Z32vG7cdQmkYISUi+mSlUmhjgdiks1NJRU2pBqH+T8YWg+hF8jzWRsJa1cCb6UBy0Ub OS0A== X-Gm-Message-State: AOAM533lJW6YvWVBpv1LEwaVYohuefK6Q3nIhMkELee3FyAgBYLpIqiF WlXCiWVO20W/MNRpWGRFCNYMbw== X-Google-Smtp-Source: ABdhPJwVL26EvD+H2wFW+TfBCEaj9PM9ShBXYk6h22RSks103URiCoOL2QlTmXYxQOh448eJvPypmg== X-Received: by 2002:a5e:c809:: with SMTP id y9mr12770689iol.192.1617991646747; Fri, 09 Apr 2021 11:07:26 -0700 (PDT) Received: from presto.localdomain (c-73-185-129-58.hsd1.mn.comcast.net. [73.185.129.58]) by smtp.gmail.com with ESMTPSA id g12sm1412786ile.71.2021.04.09.11.07.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 09 Apr 2021 11:07:26 -0700 (PDT) From: Alex Elder To: davem@davemloft.net, kuba@kernel.org Cc: bjorn.andersson@linaro.org, evgreen@chromium.org, cpratapa@codeaurora.org, subashab@codeaurora.org, elder@kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH net-next 1/7] net: ipa: relax pool entry size requirement Date: Fri, 9 Apr 2021 13:07:16 -0500 Message-Id: <20210409180722.1176868-2-elder@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210409180722.1176868-1-elder@linaro.org> References: <20210409180722.1176868-1-elder@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I no longer know why a validation check ensured the size of an entry passed to gsi_trans_pool_init() was restricted to be a multiple of 8. For 32-bit builds, this condition doesn't always hold, and for DMA pools, the size is rounded up to a power of 2 anyway. Remove this restriction. Signed-off-by: Alex Elder --- drivers/net/ipa/gsi_trans.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ipa/gsi_trans.c b/drivers/net/ipa/gsi_trans.c index 70c2b585f98d6..8c795a6a85986 100644 --- a/drivers/net/ipa/gsi_trans.c +++ b/drivers/net/ipa/gsi_trans.c @@ -91,7 +91,7 @@ int gsi_trans_pool_init(struct gsi_trans_pool *pool, size_t size, u32 count, void *virt; #ifdef IPA_VALIDATE - if (!size || size % 8) + if (!size) return -EINVAL; if (count < max_alloc) return -EINVAL; @@ -141,7 +141,7 @@ int gsi_trans_pool_init_dma(struct device *dev, struct gsi_trans_pool *pool, void *virt; #ifdef IPA_VALIDATE - if (!size || size % 8) + if (!size) return -EINVAL; if (count < max_alloc) return -EINVAL; -- 2.27.0