From: Jakub Kicinski <kuba@kernel.org>
To: Heiner Kallweit <hkallweit1@gmail.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
Russell King - ARM Linux <linux@armlinux.org.uk>,
David Miller <davem@davemloft.net>,
Fugang Duan <fugang.duan@nxp.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Joakim Zhang <qiangqing.zhang@nxp.com>
Subject: Re: [PATCH net-next 0/3] net: make PHY PM ops a no-op if MAC driver manages PHY PM
Date: Fri, 9 Apr 2021 18:13:25 -0700 [thread overview]
Message-ID: <20210409181325.0c915f4d@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <9e695411-ab1d-34fe-8b90-3e8192ab84f6@gmail.com>
On Wed, 7 Apr 2021 17:50:46 +0200 Heiner Kallweit wrote:
> Resume callback of the PHY driver is called after the one for the MAC
> driver. The PHY driver resume callback calls phy_init_hw(), and this is
> potentially problematic if the MAC driver calls phy_start() in its resume
> callback. One issue was reported with the fec driver and a KSZ8081 PHY
> which seems to become unstable if a soft reset is triggered during aneg.
>
> The new flag allows MAC drivers to indicate that they take care of
> suspending/resuming the PHY. Then the MAC PM callbacks can handle
> any dependency between MAC and PHY PM.
Applied, thanks!
prev parent reply other threads:[~2021-04-10 1:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-07 15:50 [PATCH net-next 0/3] net: make PHY PM ops a no-op if MAC driver manages PHY PM Heiner Kallweit
2021-04-07 15:51 ` [PATCH net-next 1/3] net: phy: " Heiner Kallweit
2021-04-07 15:52 ` [PATCH net-next 2/3] net: fec: use mac-managed " Heiner Kallweit
2021-04-08 5:45 ` Joakim Zhang
2021-04-08 5:59 ` Heiner Kallweit
2021-04-08 6:21 ` Joakim Zhang
2021-04-07 15:53 ` [PATCH net-next 3/3] r8169: " Heiner Kallweit
2021-04-08 5:42 ` [PATCH net-next 0/3] net: make PHY PM ops a no-op if MAC driver manages " Joakim Zhang
2021-04-08 9:02 ` Heiner Kallweit
2021-04-09 9:23 ` Heiner Kallweit
2021-04-10 1:13 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210409181325.0c915f4d@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=fugang.duan@nxp.com \
--cc=hkallweit1@gmail.com \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=qiangqing.zhang@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.