From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA8A6C433B4 for ; Sat, 10 Apr 2021 13:57:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BE7A2611C1 for ; Sat, 10 Apr 2021 13:57:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234764AbhDJN53 (ORCPT ); Sat, 10 Apr 2021 09:57:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49574 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234377AbhDJN51 (ORCPT ); Sat, 10 Apr 2021 09:57:27 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5B434C06138A for ; Sat, 10 Apr 2021 06:57:13 -0700 (PDT) Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lVE6c-0008GH-JZ; Sat, 10 Apr 2021 15:56:58 +0200 Received: from ukl by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1lVE6c-0007Dp-7b; Sat, 10 Apr 2021 15:56:58 +0200 Date: Sat, 10 Apr 2021 15:56:58 +0200 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= To: Nobuhiro Iwamatsu Cc: Thierry Reding , Rob Herring , Lee Jones , devicetree@vger.kernel.org, linux-pwm@vger.kernel.org, punit1.agrawal@toshiba.co.jp, yuji2.ishikawa@toshiba.co.jp, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 2/2] pwm: visconti: Add Toshiba Visconti SoC PWM support Message-ID: <20210410135658.pf7eg5x5bdhndxkg@pengutronix.de> References: <20210409090709.1918021-1-nobuhiro1.iwamatsu@toshiba.co.jp> <20210409090709.1918021-3-nobuhiro1.iwamatsu@toshiba.co.jp> <20210409213455.6f25m4jyttqn75hf@toshiba.co.jp> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="yuj53qadwvlrvifp" Content-Disposition: inline In-Reply-To: <20210409213455.6f25m4jyttqn75hf@toshiba.co.jp> X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --yuj53qadwvlrvifp Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hello, On Sat, Apr 10, 2021 at 06:34:55AM +0900, Nobuhiro Iwamatsu wrote: > > > +static int visconti_pwm_remove(struct platform_device *pdev) > > > +{ > > > + struct visconti_pwm_chip *priv =3D platform_get_drvdata(pdev); > > > + > > > + return pwmchip_remove(&priv->chip); > >=20 > > I think Uwe would prefer this to be done separately because he's working > > towards removing the return value from pwmchip_remove() and if we start > > ignoring it in new drivers that will make life easier going forward. > >=20 > > So this should just be: > >=20 > > pwmchip_remove(&priv->chip); > >=20 > > return 0; >=20 > I understand your suggestion. > However, it looks like the pwmchip_remove() hasn't been updated yet. > I will wait for the update of pwmchip_remove. pwmchip_remove will always return 0 since b2c200e3f2fd which is in v5.3. So Thierry's suggestion is safe and indeed welcome. =20 Best regards Uwe --=20 Pengutronix e.K. | Uwe Kleine-K=F6nig | Industrial Linux Solutions | https://www.pengutronix.de/ | --yuj53qadwvlrvifp Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEfnIqFpAYrP8+dKQLwfwUeK3K7AkFAmBxrqcACgkQwfwUeK3K 7An+hQgAj2qaimHxOZxUmLVDVonb3IXjlqjNIUaxsPEkWqsxkVe0Qft4EEJuw0zr XXHF54BLbK163akwKdlIiRbXBWr2wa8weVst/QyhjvLZC3SK1aarrxetSCt+ySFU Ujq0EerNvC8JR9Npxq2p3wwo5FgOMCzuPAfCVqH2YT7hpdEAj3IxtJS516rFeUFr L3mVCtN6IHxhsYbx74xaQ5aARALCw3CTOwNTFIXY3ash9u3Rq2MhiWMjTnpiwcge UsGOKlJkhauN6uUy7M2lBL0ccL2d/JZKVv1iKcBGdx8v4eH7HAWz5utoH60h+EEL XZa5gLu0WNXUnCi37W8DUQGL4xIzFQ== =3NT8 -----END PGP SIGNATURE----- --yuj53qadwvlrvifp-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06F19C433B4 for ; Sat, 10 Apr 2021 13:58:46 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9C0BF61002 for ; Sat, 10 Apr 2021 13:58:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9C0BF61002 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=P0rMjXS1PS4z8skY0OFrx2W4zFfDmA8D6KWXW6h3A70=; b=COZEXBY2n9zFDf9MIb04j/8Ye bkVfV9u/0EkFNrneKt/cvCEtBqfTTRBDCSzWGzKJLTxFMoebBAW6Ifi4KaZdaCpbHucgFE9F9C1Bn k4yvcrwYuELw3gViRo3UIZVOKT2bBVH6FJhzes/pGIazgqKYvTGL/P1634ZI7O1tyeAwnWZc0R2To 5g2QDJVAKkE1cAo1hBHsYnMkcofJUC18NKTzv2KBpSBc4VCErx0/K1paS8tTy83ZGj0fCSxATMhPt y3NzmHsh0O1jdjcsPjsw8V40GG1k0rLzMXskB62Sc06c9YbinXcha5fe2jx3D8UcdTHj/0jc4xr8v PJv4FOuYw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lVE6t-002vJM-HP; Sat, 10 Apr 2021 13:57:15 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lVE6q-002vJ2-D5 for linux-arm-kernel@desiato.infradead.org; Sat, 10 Apr 2021 13:57:12 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=rHSSU5pZFQxv2/UYBBw3Pu9pBgiUqHz4oxaJgVdaIHc=; b=caX8okwba1ZcIXx87CEeI/brDI /1TTfEB6d0EYz75SpMzFaOYKwUY/mQv8jhNbQ915eNRsYuRoKS4YWL51lQcFQ4jKNwTSLPvwPc4Bo J7QIq/mhpEPkDxeu/Gh00W4uLadqY7cCZ7DSOHax4Uc1a4q/MMvQjTquFNzS8Ziq+Xq5W0HIfv9P7 O5W0KR1eBU6Ar7311wnk3+T01vPtcUIp/y9hW/JgGveLZo3Y/ZNGozijEU/Oik+Ni0DEyHNZm4DLM VLCKdptQDvGbSFCT9eWuOrRxxxGjqSNSWN1LpnQLszMvRo9dWY1kkU7YhimMisNB+0uWh/gfYepIa VjtD9CZQ==; Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lVE6n-0057rr-Pa for linux-arm-kernel@lists.infradead.org; Sat, 10 Apr 2021 13:57:11 +0000 Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lVE6c-0008GH-JZ; Sat, 10 Apr 2021 15:56:58 +0200 Received: from ukl by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1lVE6c-0007Dp-7b; Sat, 10 Apr 2021 15:56:58 +0200 Date: Sat, 10 Apr 2021 15:56:58 +0200 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= To: Nobuhiro Iwamatsu Cc: Thierry Reding , Rob Herring , Lee Jones , devicetree@vger.kernel.org, linux-pwm@vger.kernel.org, punit1.agrawal@toshiba.co.jp, yuji2.ishikawa@toshiba.co.jp, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 2/2] pwm: visconti: Add Toshiba Visconti SoC PWM support Message-ID: <20210410135658.pf7eg5x5bdhndxkg@pengutronix.de> References: <20210409090709.1918021-1-nobuhiro1.iwamatsu@toshiba.co.jp> <20210409090709.1918021-3-nobuhiro1.iwamatsu@toshiba.co.jp> <20210409213455.6f25m4jyttqn75hf@toshiba.co.jp> MIME-Version: 1.0 In-Reply-To: <20210409213455.6f25m4jyttqn75hf@toshiba.co.jp> X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210410_065709_849283_1A4D85BD X-CRM114-Status: GOOD ( 21.45 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============9101878941017645268==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============9101878941017645268== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="yuj53qadwvlrvifp" Content-Disposition: inline --yuj53qadwvlrvifp Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hello, On Sat, Apr 10, 2021 at 06:34:55AM +0900, Nobuhiro Iwamatsu wrote: > > > +static int visconti_pwm_remove(struct platform_device *pdev) > > > +{ > > > + struct visconti_pwm_chip *priv =3D platform_get_drvdata(pdev); > > > + > > > + return pwmchip_remove(&priv->chip); > >=20 > > I think Uwe would prefer this to be done separately because he's working > > towards removing the return value from pwmchip_remove() and if we start > > ignoring it in new drivers that will make life easier going forward. > >=20 > > So this should just be: > >=20 > > pwmchip_remove(&priv->chip); > >=20 > > return 0; >=20 > I understand your suggestion. > However, it looks like the pwmchip_remove() hasn't been updated yet. > I will wait for the update of pwmchip_remove. pwmchip_remove will always return 0 since b2c200e3f2fd which is in v5.3. So Thierry's suggestion is safe and indeed welcome. =20 Best regards Uwe --=20 Pengutronix e.K. | Uwe Kleine-K=F6nig | Industrial Linux Solutions | https://www.pengutronix.de/ | --yuj53qadwvlrvifp Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEfnIqFpAYrP8+dKQLwfwUeK3K7AkFAmBxrqcACgkQwfwUeK3K 7An+hQgAj2qaimHxOZxUmLVDVonb3IXjlqjNIUaxsPEkWqsxkVe0Qft4EEJuw0zr XXHF54BLbK163akwKdlIiRbXBWr2wa8weVst/QyhjvLZC3SK1aarrxetSCt+ySFU Ujq0EerNvC8JR9Npxq2p3wwo5FgOMCzuPAfCVqH2YT7hpdEAj3IxtJS516rFeUFr L3mVCtN6IHxhsYbx74xaQ5aARALCw3CTOwNTFIXY3ash9u3Rq2MhiWMjTnpiwcge UsGOKlJkhauN6uUy7M2lBL0ccL2d/JZKVv1iKcBGdx8v4eH7HAWz5utoH60h+EEL XZa5gLu0WNXUnCi37W8DUQGL4xIzFQ== =3NT8 -----END PGP SIGNATURE----- --yuj53qadwvlrvifp-- --===============9101878941017645268== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============9101878941017645268==--