From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: linux-pwm@vger.kernel.org, Lee Jones <lee.jones@linaro.org>,
kernel@pengutronix.de
Subject: Re: [PATCH 1/3] pwm: lpss: Don't modify HW state in .remove callback
Date: Sat, 10 Apr 2021 23:26:12 +0200 [thread overview]
Message-ID: <20210410212612.xdnbdbfckszcvqqb@pengutronix.de> (raw)
In-Reply-To: <20210410134601.ccqhuor3gd6pm2fw@pengutronix.de>
[-- Attachment #1: Type: text/plain, Size: 1180 bytes --]
On Sat, Apr 10, 2021 at 03:46:01PM +0200, Uwe Kleine-König wrote:
> On Fri, Apr 09, 2021 at 03:21:40PM +0200, Thierry Reding wrote:
> > On Wed, Apr 07, 2021 at 10:01:53AM +0200, Uwe Kleine-König wrote:
> > > A consumer is expected to disable a PWM before calling pwm_put(). And if
> > > they didn't there is hopefully a good reason (or the consumer needs
> > > fixing). Also if disabling an enabled PWM was the right thing to do,
> > > this should better be done in the framework instead of in each low level
> > > driver.
> > >
> > > So drop the hardware modification from the .remove() callback.
> > >
> > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> > > ---
> > > drivers/pwm/pwm-lpss.c | 6 ------
> > > 1 file changed, 6 deletions(-)
> >
> > Applied, thanks.
>
> Great, but you didn't push yet. Is this still going through your own CI,
> or did you forget to push?
Oh, I thought you took the devm_pwmchip_add patch. I withdraw my
question.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2021-04-10 21:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-07 8:01 [PATCH 1/3] pwm: lpss: Don't modify HW state in .remove callback Uwe Kleine-König
2021-04-07 8:01 ` [PATCH 2/3] pwm: Add a devm managed function to add pwm_chips Uwe Kleine-König
2021-04-07 8:01 ` [PATCH 3/3] pwm: lpss: Simplify using devm_pwmchip_add Uwe Kleine-König
2021-04-09 13:28 ` Thierry Reding
2021-04-09 21:47 ` Uwe Kleine-König
2021-04-09 13:21 ` [PATCH 1/3] pwm: lpss: Don't modify HW state in .remove callback Thierry Reding
2021-04-10 13:46 ` Uwe Kleine-König
2021-04-10 21:26 ` Uwe Kleine-König [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210410212612.xdnbdbfckszcvqqb@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=kernel@pengutronix.de \
--cc=lee.jones@linaro.org \
--cc=linux-pwm@vger.kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.