From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF1FBC43461 for ; Mon, 12 Apr 2021 01:49:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BDF0F61027 for ; Mon, 12 Apr 2021 01:49:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236407AbhDLBt6 (ORCPT ); Sun, 11 Apr 2021 21:49:58 -0400 Received: from mo-csw1116.securemx.jp ([210.130.202.158]:35942 "EHLO mo-csw.securemx.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236080AbhDLBt4 (ORCPT ); Sun, 11 Apr 2021 21:49:56 -0400 Received: by mo-csw.securemx.jp (mx-mo-csw1116) id 13C1nDka031963; Mon, 12 Apr 2021 10:49:13 +0900 X-Iguazu-Qid: 2wHHmufQV2YIV0Vxxe X-Iguazu-QSIG: v=2; s=0; t=1618192152; q=2wHHmufQV2YIV0Vxxe; m=CyKWjpYjfiysteLqP0ka033bop3tkwAt3Qm0M4aNgoY= Received: from imx12-a.toshiba.co.jp (imx12-a.toshiba.co.jp [61.202.160.135]) by relay.securemx.jp (mx-mr1112) id 13C1nBLh020460 (version=TLSv1.2 cipher=AES128-GCM-SHA256 bits=128 verify=NOT); Mon, 12 Apr 2021 10:49:11 +0900 Received: from enc02.toshiba.co.jp (enc02.toshiba.co.jp [61.202.160.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by imx12-a.toshiba.co.jp (Postfix) with ESMTPS id A90921000B3; Mon, 12 Apr 2021 10:49:11 +0900 (JST) Received: from hop101.toshiba.co.jp ([133.199.85.107]) by enc02.toshiba.co.jp with ESMTP id 13C1nAJe003560; Mon, 12 Apr 2021 10:49:11 +0900 Date: Mon, 12 Apr 2021 10:49:10 +0900 From: Nobuhiro Iwamatsu To: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= Cc: Thierry Reding , Rob Herring , Lee Jones , devicetree@vger.kernel.org, linux-pwm@vger.kernel.org, punit1.agrawal@toshiba.co.jp, yuji2.ishikawa@toshiba.co.jp, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 2/2] pwm: visconti: Add Toshiba Visconti SoC PWM support X-TSB-HOP: ON Message-ID: <20210412014910.b5zo3dgpyiwmprot@toshiba.co.jp> References: <20210409090709.1918021-1-nobuhiro1.iwamatsu@toshiba.co.jp> <20210409090709.1918021-3-nobuhiro1.iwamatsu@toshiba.co.jp> <20210409213455.6f25m4jyttqn75hf@toshiba.co.jp> <20210410135658.pf7eg5x5bdhndxkg@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210410135658.pf7eg5x5bdhndxkg@pengutronix.de> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Sat, Apr 10, 2021 at 03:56:58PM +0200, Uwe Kleine-König wrote: > Hello, > > On Sat, Apr 10, 2021 at 06:34:55AM +0900, Nobuhiro Iwamatsu wrote: > > > > +static int visconti_pwm_remove(struct platform_device *pdev) > > > > +{ > > > > + struct visconti_pwm_chip *priv = platform_get_drvdata(pdev); > > > > + > > > > + return pwmchip_remove(&priv->chip); > > > > > > I think Uwe would prefer this to be done separately because he's working > > > towards removing the return value from pwmchip_remove() and if we start > > > ignoring it in new drivers that will make life easier going forward. > > > > > > So this should just be: > > > > > > pwmchip_remove(&priv->chip); > > > > > > return 0; > > > > I understand your suggestion. > > However, it looks like the pwmchip_remove() hasn't been updated yet. > > I will wait for the update of pwmchip_remove. > > pwmchip_remove will always return 0 since b2c200e3f2fd which is in v5.3. > So Thierry's suggestion is safe and indeed welcome. Sorry, I was looking at a different function. I will fix this. Best regards, Nobuhiro From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37B8FC433B4 for ; Mon, 12 Apr 2021 01:51:06 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CAD2D61027 for ; Mon, 12 Apr 2021 01:51:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CAD2D61027 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=toshiba.co.jp Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=X9KmdCBKjEt2cxXi99nZCnj5Hib6lwnVE73dRqRNjzY=; b=fCtEJIH1k7tWrZYGqSsxJNnVQ nSm+25DnTdBzTgjxLhd8Nwv1rhGxJSNiwiO562vShpJQwxI/m2cSeDXF/zM38b5D7wCiz6ZbhSyqp Zpuz8/vwTMRJm8mj+w8GjaPyDTHUWhG+nBGF6duXXzBb1plB0S1ueWmZRSqFItXZyHrzkDTMGE07Z aduDUdqJr6499F/CNL99CsF33LV9Hud9AX4WZPyrZ+3eU/P5xF1HpaznT6+ekKrzJNWduNREYjsT8 lTvX/ehTxTHpLMBtwgjWKCRRvHdUXi/4V4Z2uLsu7977eujF5Aqe4izEir9eqYh5Ww1ttaPmuw+s3 7jciUOcuw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lVlhl-005SfY-Ok; Mon, 12 Apr 2021 01:49:33 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lVlhi-005SfK-L9 for linux-arm-kernel@desiato.infradead.org; Mon, 12 Apr 2021 01:49:30 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Transfer-Encoding :Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=+DtgusuAhhsyuuZWdhPwPExUcIroqAF6PVgt59dWLJ8=; b=MD3O7vk/yIKl53dtT7ISxr3GGI +/Ld2xVzOsniVH8f5eTOtizADG+eAbIfbVjdrXQCESrl2H2KKgdxpZaEEZ5Il+na8owOJMlg9Iylp iqVxZU++QCTO+VHfYjMUkDpMzXTGGXf0XBT0a8mtjHRLoo1ZChW793ZFOBZ0IicEO0Q5r+449qDQC CTH1LlKUuLfR4AhlUvJf8hiafoBkDPx4KUKRZGxJuurppx89+ogwYQCbBT0ClphL7jG1QKXgKInPP F7cK0KOK+2rdwdJn39e/9yhLRoWYIuEgWtpjGDK/eUeoqSWDKvPfhBCK5LFgFD67MDGHBhkmYI8+L 76fL6sRg==; Received: from mo-csw1116.securemx.jp ([210.130.202.158] helo=mo-csw.securemx.jp) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lVlhe-005pZF-UY for linux-arm-kernel@lists.infradead.org; Mon, 12 Apr 2021 01:49:28 +0000 Received: by mo-csw.securemx.jp (mx-mo-csw1116) id 13C1nDka031963; Mon, 12 Apr 2021 10:49:13 +0900 X-Iguazu-Qid: 2wHHmufQV2YIV0Vxxe X-Iguazu-QSIG: v=2; s=0; t=1618192152; q=2wHHmufQV2YIV0Vxxe; m=CyKWjpYjfiysteLqP0ka033bop3tkwAt3Qm0M4aNgoY= Received: from imx12-a.toshiba.co.jp (imx12-a.toshiba.co.jp [61.202.160.135]) by relay.securemx.jp (mx-mr1112) id 13C1nBLh020460 (version=TLSv1.2 cipher=AES128-GCM-SHA256 bits=128 verify=NOT); Mon, 12 Apr 2021 10:49:11 +0900 Received: from enc02.toshiba.co.jp (enc02.toshiba.co.jp [61.202.160.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by imx12-a.toshiba.co.jp (Postfix) with ESMTPS id A90921000B3; Mon, 12 Apr 2021 10:49:11 +0900 (JST) Received: from hop101.toshiba.co.jp ([133.199.85.107]) by enc02.toshiba.co.jp with ESMTP id 13C1nAJe003560; Mon, 12 Apr 2021 10:49:11 +0900 Date: Mon, 12 Apr 2021 10:49:10 +0900 From: Nobuhiro Iwamatsu To: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= Cc: Thierry Reding , Rob Herring , Lee Jones , devicetree@vger.kernel.org, linux-pwm@vger.kernel.org, punit1.agrawal@toshiba.co.jp, yuji2.ishikawa@toshiba.co.jp, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 2/2] pwm: visconti: Add Toshiba Visconti SoC PWM support X-TSB-HOP: ON Message-ID: <20210412014910.b5zo3dgpyiwmprot@toshiba.co.jp> References: <20210409090709.1918021-1-nobuhiro1.iwamatsu@toshiba.co.jp> <20210409090709.1918021-3-nobuhiro1.iwamatsu@toshiba.co.jp> <20210409213455.6f25m4jyttqn75hf@toshiba.co.jp> <20210410135658.pf7eg5x5bdhndxkg@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210410135658.pf7eg5x5bdhndxkg@pengutronix.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210411_184927_275807_95FADA2F X-CRM114-Status: GOOD ( 20.72 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, On Sat, Apr 10, 2021 at 03:56:58PM +0200, Uwe Kleine-K=F6nig wrote: > Hello, > = > On Sat, Apr 10, 2021 at 06:34:55AM +0900, Nobuhiro Iwamatsu wrote: > > > > +static int visconti_pwm_remove(struct platform_device *pdev) > > > > +{ > > > > + struct visconti_pwm_chip *priv =3D platform_get_drvdata(pdev); > > > > + > > > > + return pwmchip_remove(&priv->chip); > > > = > > > I think Uwe would prefer this to be done separately because he's work= ing > > > towards removing the return value from pwmchip_remove() and if we sta= rt > > > ignoring it in new drivers that will make life easier going forward. > > > = > > > So this should just be: > > > = > > > pwmchip_remove(&priv->chip); > > > = > > > return 0; > > = > > I understand your suggestion. > > However, it looks like the pwmchip_remove() hasn't been updated yet. > > I will wait for the update of pwmchip_remove. > = > pwmchip_remove will always return 0 since b2c200e3f2fd which is in v5.3. > So Thierry's suggestion is safe and indeed welcome. Sorry, I was looking at a different function. I will fix this. Best regards, Nobuhiro _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel