From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38EF9C43461 for ; Mon, 12 Apr 2021 03:05:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0D33761207 for ; Mon, 12 Apr 2021 03:05:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236642AbhDLDFs (ORCPT ); Sun, 11 Apr 2021 23:05:48 -0400 Received: from mo-csw1514.securemx.jp ([210.130.202.153]:55006 "EHLO mo-csw.securemx.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236411AbhDLDFr (ORCPT ); Sun, 11 Apr 2021 23:05:47 -0400 Received: by mo-csw.securemx.jp (mx-mo-csw1514) id 13C354xU001261; Mon, 12 Apr 2021 12:05:04 +0900 X-Iguazu-Qid: 34trpShQI277aZkbf5 X-Iguazu-QSIG: v=2; s=0; t=1618196704; q=34trpShQI277aZkbf5; m=lP9cfn233k75Uk+XzofdsciNBCS2CP+P5GkJetk8OSo= Received: from imx12-a.toshiba.co.jp (imx12-a.toshiba.co.jp [61.202.160.135]) by relay.securemx.jp (mx-mr1513) id 13C353JR017710 (version=TLSv1.2 cipher=AES128-GCM-SHA256 bits=128 verify=NOT); Mon, 12 Apr 2021 12:05:03 +0900 Received: from enc02.toshiba.co.jp (enc02.toshiba.co.jp [61.202.160.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by imx12-a.toshiba.co.jp (Postfix) with ESMTPS id 324491000A7; Mon, 12 Apr 2021 12:05:03 +0900 (JST) Received: from hop101.toshiba.co.jp ([133.199.85.107]) by enc02.toshiba.co.jp with ESMTP id 13C352MU012428; Mon, 12 Apr 2021 12:05:02 +0900 Date: Mon, 12 Apr 2021 12:04:58 +0900 From: Nobuhiro Iwamatsu To: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= Cc: Rob Herring , Thierry Reding , Lee Jones , devicetree@vger.kernel.org, linux-pwm@vger.kernel.org, punit1.agrawal@toshiba.co.jp, yuji2.ishikawa@toshiba.co.jp, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 2/2] pwm: visconti: Add Toshiba Visconti SoC PWM support X-TSB-HOP: ON Message-ID: <20210412030458.t2vhg4nxwyi5yp4o@toshiba.co.jp> References: <20210409230837.1919744-1-nobuhiro1.iwamatsu@toshiba.co.jp> <20210409230837.1919744-3-nobuhiro1.iwamatsu@toshiba.co.jp> <20210410185222.4tfpgm2hcka26e6g@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210410185222.4tfpgm2hcka26e6g@pengutronix.de> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Sat, Apr 10, 2021 at 08:52:22PM +0200, Uwe Kleine-König wrote: > Hello, > > one more comment: > > On Sat, Apr 10, 2021 at 08:08:37AM +0900, Nobuhiro Iwamatsu wrote: > > +static inline struct visconti_pwm_chip *to_visconti_chip(struct pwm_chip *chip) > > all functions but this one start have the common prefix "visconti_pwm_". > I like the concept of a common prefix and so you could rename this > function to visconti_pwm_from_chip or similar. OK, I will change. > > Best regards > Uwe > Best regards, Nobuhiro From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17F53C433B4 for ; Mon, 12 Apr 2021 03:06:45 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9A09D61207 for ; Mon, 12 Apr 2021 03:06:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9A09D61207 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=toshiba.co.jp Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=rlVGPOdJMfXLtE1xltCsoQ9GZjX+dlFTHBdT0SuVgU0=; b=WCtFRCR1I86grCPPrBwi4awQE KP8HuHJ4/U/8EvdG94tufkPHD804VnH4fA2VET88DQ7AuVXMJeOhi/puiyAB8FlPm6mgYtx/PXlKm gEJ766SX5WYZDGF3M4aLncNZmj+zl6NvCIRvC84NLOHWOjqmSpG9/WgSZoahP5ubhCMlhoG2f/fjB +FYSbl76TqUSxF+ySyxJ4N4LBO6I0PPyR2IwGlsr1E6zuCNgepIyNZMRL6LF30zFwxbFGA9V5hFaH Q2Yj45Ea9nW0Qg1Z9Bu1egCNdf064aQ0/OUADlyZ3ujTvFWwokDfc1Ihy8FkWE7q6XMlOziaZdd+m kO6uh98BA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lVmt6-005ZJD-Cr; Mon, 12 Apr 2021 03:05:20 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lVmt4-005ZJ7-OM for linux-arm-kernel@desiato.infradead.org; Mon, 12 Apr 2021 03:05:18 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Transfer-Encoding :Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=pXLm8Sxx9clQPQn4BK/YVoYYcveyE+EtdsL7lpCmyGI=; b=PAL6Kdqgqu7D4Vh96x0J+eBlz6 FG24M3YdkIZiVbq+o/skaXlsqbjZimGGM8otS28URmhXyWbo51sf2stJQv81ZcdjOtBDUzIY9nJiZ eiCqVZ7k8dhNBdRjhtKgkSx4Vm4Ne5trOsNpg6Y9oTdSwO9PyBk1Kp9k21b6H5DPfArIkUu1Q2xUg vLBZEGBVGCc9Z3g+2tbPBQMkDFk4q5fXXtQDsrPb3ERI5tRFewWTUkVZE5LGxXvqb6mmJKyHzsG8K 2iSh1cpyvEWivBFlprAOPtju7d9l9gcFREb6AsK8FIFw8VjL4hr3HK+bGI3JmmPit2DrQFWcJ439y I3/YwA+w==; Received: from mo-csw1514.securemx.jp ([210.130.202.153] helo=mo-csw.securemx.jp) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lVmt1-005qu8-Lc for linux-arm-kernel@lists.infradead.org; Mon, 12 Apr 2021 03:05:17 +0000 Received: by mo-csw.securemx.jp (mx-mo-csw1514) id 13C354xU001261; Mon, 12 Apr 2021 12:05:04 +0900 X-Iguazu-Qid: 34trpShQI277aZkbf5 X-Iguazu-QSIG: v=2; s=0; t=1618196704; q=34trpShQI277aZkbf5; m=lP9cfn233k75Uk+XzofdsciNBCS2CP+P5GkJetk8OSo= Received: from imx12-a.toshiba.co.jp (imx12-a.toshiba.co.jp [61.202.160.135]) by relay.securemx.jp (mx-mr1513) id 13C353JR017710 (version=TLSv1.2 cipher=AES128-GCM-SHA256 bits=128 verify=NOT); Mon, 12 Apr 2021 12:05:03 +0900 Received: from enc02.toshiba.co.jp (enc02.toshiba.co.jp [61.202.160.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by imx12-a.toshiba.co.jp (Postfix) with ESMTPS id 324491000A7; Mon, 12 Apr 2021 12:05:03 +0900 (JST) Received: from hop101.toshiba.co.jp ([133.199.85.107]) by enc02.toshiba.co.jp with ESMTP id 13C352MU012428; Mon, 12 Apr 2021 12:05:02 +0900 Date: Mon, 12 Apr 2021 12:04:58 +0900 From: Nobuhiro Iwamatsu To: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= Cc: Rob Herring , Thierry Reding , Lee Jones , devicetree@vger.kernel.org, linux-pwm@vger.kernel.org, punit1.agrawal@toshiba.co.jp, yuji2.ishikawa@toshiba.co.jp, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 2/2] pwm: visconti: Add Toshiba Visconti SoC PWM support X-TSB-HOP: ON Message-ID: <20210412030458.t2vhg4nxwyi5yp4o@toshiba.co.jp> References: <20210409230837.1919744-1-nobuhiro1.iwamatsu@toshiba.co.jp> <20210409230837.1919744-3-nobuhiro1.iwamatsu@toshiba.co.jp> <20210410185222.4tfpgm2hcka26e6g@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210410185222.4tfpgm2hcka26e6g@pengutronix.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210411_200515_936177_CDABD6C2 X-CRM114-Status: GOOD ( 14.14 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, On Sat, Apr 10, 2021 at 08:52:22PM +0200, Uwe Kleine-K=F6nig wrote: > Hello, > = > one more comment: > = > On Sat, Apr 10, 2021 at 08:08:37AM +0900, Nobuhiro Iwamatsu wrote: > > +static inline struct visconti_pwm_chip *to_visconti_chip(struct pwm_ch= ip *chip) > = > all functions but this one start have the common prefix "visconti_pwm_". > I like the concept of a common prefix and so you could rename this > function to visconti_pwm_from_chip or similar. OK, I will change. = > = > Best regards > Uwe > = Best regards, Nobuhiro _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel