From: Christoph Hellwig <hch@lst.de>
To: Christian Brauner <christian.brauner@ubuntu.com>
Cc: Eryu Guan <guan@eryu.me>, Christian Brauner <brauner@kernel.org>,
fstests@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
"Darrick J . Wong" <djwong@kernel.org>,
David Howells <dhowells@redhat.com>,
Amir Goldstein <amir73il@gmail.com>
Subject: Re: [PATCH v12 2/6] generic/632: add fstests for idmapped mounts
Date: Mon, 12 Apr 2021 09:22:41 +0200 [thread overview]
Message-ID: <20210412072241.GA3246@lst.de> (raw)
In-Reply-To: <20210411153223.vhcegiklrwoczy55@wittgenstein>
On Sun, Apr 11, 2021 at 05:32:23PM +0200, Christian Brauner wrote:
> > > And it should actually skip the tests on all filesystems that don't
> > > support idmapped mounts which is every fs apart from xfs and ext4.
> >
> > Yeah, looks like that's the case. So it seems the _require idmapped
>
> Ah, ok I didn't know this needed to go in there. I thinke the following
> might be enough. Are you able to simply apply it on top?
No, this is broken. It needs to do feature detection, not some arbitrary
whitelists. And I'm pretty sure we got that right at some point by
doing the _notrun when mounting with the idmap option was not supported.
next prev parent reply other threads:[~2021-04-12 7:22 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-28 22:33 [PATCH v12 0/6] fstests: add idmapped mounts tests Christian Brauner
2021-03-28 22:33 ` [PATCH v12 1/6] generic/631: add test for detached mount propagation Christian Brauner
2021-03-28 22:33 ` [PATCH v12 3/6] common/rc: add _scratch_{u}mount_idmapped() helpers Christian Brauner
2021-03-28 22:33 ` [PATCH v12 4/6] common/quota: move _qsetup() helper to common code Christian Brauner
2021-03-28 22:33 ` [PATCH v12 5/6] xfs/529: quotas and idmapped mounts Christian Brauner
2021-03-28 22:34 ` [PATCH v12 6/6] xfs/530: quotas on " Christian Brauner
[not found] ` <20210328223400.1800301-3-brauner@kernel.org>
2021-04-11 14:30 ` [PATCH v12 2/6] generic/632: add fstests for " Eryu Guan
2021-04-11 15:12 ` Christian Brauner
2021-04-11 15:18 ` Christian Brauner
2021-04-11 15:21 ` Eryu Guan
2021-04-11 15:32 ` Christian Brauner
2021-04-12 0:40 ` Theodore Ts'o
2021-04-12 11:54 ` Christian Brauner
2021-04-12 22:41 ` Theodore Ts'o
2021-04-14 20:47 ` [PATCH -RFC] ext4: add feature file to advertise that ext4 supports " Theodore Ts'o
2021-04-15 5:54 ` Christoph Hellwig
2021-04-15 7:49 ` Christian Brauner
2021-04-15 7:55 ` Christoph Hellwig
2021-04-15 8:13 ` Christian Brauner
2021-04-15 14:59 ` Theodore Ts'o
2021-04-12 7:22 ` Christoph Hellwig [this message]
2021-04-12 7:30 ` [PATCH v12 2/6] generic/632: add fstests for " Christian Brauner
2021-04-11 15:19 ` Eryu Guan
2021-04-11 14:37 ` [PATCH v12 0/6] fstests: add idmapped mounts tests Eryu Guan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210412072241.GA3246@lst.de \
--to=hch@lst.de \
--cc=amir73il@gmail.com \
--cc=brauner@kernel.org \
--cc=christian.brauner@ubuntu.com \
--cc=dhowells@redhat.com \
--cc=djwong@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=guan@eryu.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.