From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30C8CC433B4 for ; Mon, 12 Apr 2021 10:19:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EAAF061357 for ; Mon, 12 Apr 2021 10:19:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237319AbhDLKUF (ORCPT ); Mon, 12 Apr 2021 06:20:05 -0400 Received: from fgw21-7.mail.saunalahti.fi ([62.142.5.82]:20359 "EHLO fgw21-7.mail.saunalahti.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237743AbhDLKUA (ORCPT ); Mon, 12 Apr 2021 06:20:00 -0400 Received: from localhost (88-115-248-186.elisa-laajakaista.fi [88.115.248.186]) by fgw21.mail.saunalahti.fi (Halon) with ESMTP id 97175cf6-9b78-11eb-9eb8-005056bdd08f; Mon, 12 Apr 2021 13:19:40 +0300 (EEST) From: Andy Shevchenko To: Jonathan Cameron , Cristian Pop , Lars-Peter Clausen , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Michael Hennerich , Jonathan Cameron , Andy Shevchenko Subject: [PATCH v1 1/1] iio: adc: ad7768-1: Keep fwnode reference count balanced Date: Mon, 12 Apr 2021 13:19:04 +0300 Message-Id: <20210412101904.2054406-1-andy.shevchenko@gmail.com> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The commit 75ed0be7200d ("iio: adc: ad7768-1: Add channel labels.") missed the point that loop counter should be put after use. Otherwise the reference count of it will become unbalanced. Fixes: 75ed0be7200d ("iio: adc: ad7768-1: Add channel labels.") Cc: Cristian Pop Signed-off-by: Andy Shevchenko --- drivers/iio/adc/ad7768-1.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/iio/adc/ad7768-1.c b/drivers/iio/adc/ad7768-1.c index c945f1349623..c488bd4bfeba 100644 --- a/drivers/iio/adc/ad7768-1.c +++ b/drivers/iio/adc/ad7768-1.c @@ -565,6 +565,7 @@ static int ad7768_set_channel_label(struct iio_dev *indio_dev, st->labels[crt_ch] = label; } + fwnode_handle_put(fwnode); return 0; } -- 2.31.1