From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A349AC43460 for ; Mon, 12 Apr 2021 21:52:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8479961220 for ; Mon, 12 Apr 2021 21:52:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343550AbhDLVwy (ORCPT ); Mon, 12 Apr 2021 17:52:54 -0400 Received: from mga07.intel.com ([134.134.136.100]:39873 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238235AbhDLVwt (ORCPT ); Mon, 12 Apr 2021 17:52:49 -0400 IronPort-SDR: tVVVDg3BtGV/RqLK7k90l7HA+CvLRUhB6pTXKhIZJogHfbR9CUMOeMLtJkAiZ8LXoi9tOQ6H4h NK/v6Voge4pw== X-IronPort-AV: E=McAfee;i="6200,9189,9952"; a="258258469" X-IronPort-AV: E=Sophos;i="5.82,216,1613462400"; d="scan'208";a="258258469" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Apr 2021 14:52:30 -0700 IronPort-SDR: Ugajkcg4kpyTgldYpmDYHk1wsdq5uz1gdmgJUT5RCDufOQ7/9YWsf2RVDDq2Rorp/Qk2GWDif4 bHd0BlTbXuog== X-IronPort-AV: E=Sophos;i="5.82,216,1613462400"; d="scan'208";a="532037371" Received: from jbrandeb-mobl4.amr.corp.intel.com (HELO localhost) ([10.209.61.192]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Apr 2021 14:52:29 -0700 Date: Mon, 12 Apr 2021 14:52:29 -0700 From: Jesse Brandeburg To: kerneljasonxing@gmail.com Cc: anthony.l.nguyen@intel.com, davem@davemloft.net, kuba@kernel.org, ast@kernel.org, daniel@iogearbox.net, hawk@kernel.org, john.fastabend@gmail.com, andrii@kernel.org, kafai@fb.com, songliubraving@fb.com, yhs@fb.com, kpsingh@kernel.org, intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org, Jason Xing , Shujin Li Subject: Re: [PATCH] i40e: fix the panic when running bpf in xdpdrv mode Message-ID: <20210412145229.00003e5d@intel.com> In-Reply-To: <20210412065759.2907-1-kerneljasonxing@gmail.com> References: <20210412065759.2907-1-kerneljasonxing@gmail.com> X-Mailer: Claws Mail 3.12.0 (GTK+ 2.24.28; i686-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org kerneljasonxing@gmail.com wrote: > From: Jason Xing > > Re: [PATCH] i40e: fix the panic when running bpf in xdpdrv mode Please use netdev style subject lines when patching net kernel to indicate which kernel tree this is targeted at, "net" or "net-next" [PATCH net v2] i40e: ... > Fix this by add more rules to calculate the value of @rss_size_max which Fix this panic by adding ... > could be used in allocating the queues when bpf is loaded, which, however, > could cause the failure and then triger the NULL pointer of vsi->rx_rings. trigger > Prio to this fix, the machine doesn't care about how many cpus are online > and then allocates 256 queues on the machine with 32 cpus online > actually. > > Once the load of bpf begins, the log will go like this "failed to get > tracking for 256 queues for VSI 0 err -12" and this "setup of MAIN VSI > failed". > > Thus, I attach the key information of the crash-log here. > > BUG: unable to handle kernel NULL pointer dereference at > 0000000000000000 > RIP: 0010:i40e_xdp+0xdd/0x1b0 [i40e] > Call Trace: > [2160294.717292] ? i40e_reconfig_rss_queues+0x170/0x170 [i40e] > [2160294.717666] dev_xdp_install+0x4f/0x70 > [2160294.718036] dev_change_xdp_fd+0x11f/0x230 > [2160294.718380] ? dev_disable_lro+0xe0/0xe0 > [2160294.718705] do_setlink+0xac7/0xe70 > [2160294.719035] ? __nla_parse+0xed/0x120 > [2160294.719365] rtnl_newlink+0x73b/0x860 > > Signed-off-by: Jason Xing > Signed-off-by: Shujin Li if you send to "net" - I suspect you should supply a Fixes: line, above the sign-offs. In this case however, this bug has been here since the beginning of the driver, but the patch will easily apply, so please supply Fixes: 41c445ff0f48 ("i40e: main driver core") > --- > drivers/net/ethernet/intel/i40e/i40e_main.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c > index 521ea9d..4e9a247 100644 > --- a/drivers/net/ethernet/intel/i40e/i40e_main.c > +++ b/drivers/net/ethernet/intel/i40e/i40e_main.c > @@ -11867,6 +11867,7 @@ static int i40e_sw_init(struct i40e_pf *pf) > { > int err = 0; > int size; > + u16 pow; > > /* Set default capability flags */ > pf->flags = I40E_FLAG_RX_CSUM_ENABLED | > @@ -11885,6 +11886,11 @@ static int i40e_sw_init(struct i40e_pf *pf) > pf->rss_table_size = pf->hw.func_caps.rss_table_size; > pf->rss_size_max = min_t(int, pf->rss_size_max, > pf->hw.func_caps.num_tx_qp); > + > + /* find the next higher power-of-2 of num cpus */ > + pow = roundup_pow_of_two(num_online_cpus()); > + pf->rss_size_max = min_t(int, pf->rss_size_max, pow); > + The fix itself is fine, and is correct as far as I can tell, thank you for sending the patch! > if (pf->hw.func_caps.rss) { > pf->flags |= I40E_FLAG_RSS_ENABLED; > pf->alloc_rss_size = min_t(int, pf->rss_size_max, From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jesse Brandeburg Date: Mon, 12 Apr 2021 14:52:29 -0700 Subject: [Intel-wired-lan] [PATCH] i40e: fix the panic when running bpf in xdpdrv mode In-Reply-To: <20210412065759.2907-1-kerneljasonxing@gmail.com> References: <20210412065759.2907-1-kerneljasonxing@gmail.com> Message-ID: <20210412145229.00003e5d@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: intel-wired-lan@osuosl.org List-ID: kerneljasonxing at gmail.com wrote: > From: Jason Xing > > Re: [PATCH] i40e: fix the panic when running bpf in xdpdrv mode Please use netdev style subject lines when patching net kernel to indicate which kernel tree this is targeted at, "net" or "net-next" [PATCH net v2] i40e: ... > Fix this by add more rules to calculate the value of @rss_size_max which Fix this panic by adding ... > could be used in allocating the queues when bpf is loaded, which, however, > could cause the failure and then triger the NULL pointer of vsi->rx_rings. trigger > Prio to this fix, the machine doesn't care about how many cpus are online > and then allocates 256 queues on the machine with 32 cpus online > actually. > > Once the load of bpf begins, the log will go like this "failed to get > tracking for 256 queues for VSI 0 err -12" and this "setup of MAIN VSI > failed". > > Thus, I attach the key information of the crash-log here. > > BUG: unable to handle kernel NULL pointer dereference at > 0000000000000000 > RIP: 0010:i40e_xdp+0xdd/0x1b0 [i40e] > Call Trace: > [2160294.717292] ? i40e_reconfig_rss_queues+0x170/0x170 [i40e] > [2160294.717666] dev_xdp_install+0x4f/0x70 > [2160294.718036] dev_change_xdp_fd+0x11f/0x230 > [2160294.718380] ? dev_disable_lro+0xe0/0xe0 > [2160294.718705] do_setlink+0xac7/0xe70 > [2160294.719035] ? __nla_parse+0xed/0x120 > [2160294.719365] rtnl_newlink+0x73b/0x860 > > Signed-off-by: Jason Xing > Signed-off-by: Shujin Li if you send to "net" - I suspect you should supply a Fixes: line, above the sign-offs. In this case however, this bug has been here since the beginning of the driver, but the patch will easily apply, so please supply Fixes: 41c445ff0f48 ("i40e: main driver core") > --- > drivers/net/ethernet/intel/i40e/i40e_main.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c > index 521ea9d..4e9a247 100644 > --- a/drivers/net/ethernet/intel/i40e/i40e_main.c > +++ b/drivers/net/ethernet/intel/i40e/i40e_main.c > @@ -11867,6 +11867,7 @@ static int i40e_sw_init(struct i40e_pf *pf) > { > int err = 0; > int size; > + u16 pow; > > /* Set default capability flags */ > pf->flags = I40E_FLAG_RX_CSUM_ENABLED | > @@ -11885,6 +11886,11 @@ static int i40e_sw_init(struct i40e_pf *pf) > pf->rss_table_size = pf->hw.func_caps.rss_table_size; > pf->rss_size_max = min_t(int, pf->rss_size_max, > pf->hw.func_caps.num_tx_qp); > + > + /* find the next higher power-of-2 of num cpus */ > + pow = roundup_pow_of_two(num_online_cpus()); > + pf->rss_size_max = min_t(int, pf->rss_size_max, pow); > + The fix itself is fine, and is correct as far as I can tell, thank you for sending the patch! > if (pf->hw.func_caps.rss) { > pf->flags |= I40E_FLAG_RSS_ENABLED; > pf->alloc_rss_size = min_t(int, pf->rss_size_max,