From: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
To: Nathan Chancellor <nathan@kernel.org>
Cc: Paul Burton <paulburton@kernel.org>,
Tom Rini <trini@konsulko.com>, Simon Glass <sjg@chromium.org>,
linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH] MIPS: generic: Update node names to avoid unit addresses
Date: Mon, 12 Apr 2021 17:05:29 +0200 [thread overview]
Message-ID: <20210412150529.GB23632@alpha.franken.de> (raw)
In-Reply-To: <20210409192128.3998606-1-nathan@kernel.org>
On Fri, Apr 09, 2021 at 12:21:28PM -0700, Nathan Chancellor wrote:
> With the latest mkimage from U-Boot 2021.04, the generic defconfigs no
> longer build, failing with:
>
> /usr/bin/mkimage: verify_header failed for FIT Image support with exit code 1
>
> This is expected after the linked U-Boot commits because '@' is
> forbidden in the node names due to the way that libfdt treats nodes with
> the same prefix but different unit addresses.
>
> Switch the '@' in the node name to '-'. Drop the unit addresses from the
> hash and kernel child nodes because there is only one node so they do
> not need to have a number to differentiate them.
>
> Cc: stable@vger.kernel.org
> Link: https://source.denx.de/u-boot/u-boot/-/commit/79af75f7776fc20b0d7eb6afe1e27c00fdb4b9b4
> Link: https://source.denx.de/u-boot/u-boot/-/commit/3f04db891a353f4b127ed57279279f851c6b4917
> Suggested-by: Simon Glass <sjg@chromium.org>
> Signed-off-by: Nathan Chancellor <nathan@kernel.org>
> ---
> arch/mips/generic/board-boston.its.S | 10 +++++-----
> arch/mips/generic/board-jaguar2.its.S | 16 ++++++++--------
> arch/mips/generic/board-luton.its.S | 8 ++++----
> arch/mips/generic/board-ni169445.its.S | 10 +++++-----
> arch/mips/generic/board-ocelot.its.S | 20 ++++++++++----------
> arch/mips/generic/board-serval.its.S | 8 ++++----
> arch/mips/generic/board-xilfpga.its.S | 10 +++++-----
> arch/mips/generic/vmlinux.its.S | 10 +++++-----
> 8 files changed, 46 insertions(+), 46 deletions(-)
applied to mips-next.
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
prev parent reply other threads:[~2021-04-12 15:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-08 18:22 mkimage regression when building ARCH=mips defconfig Linux kernel Nathan Chancellor
2021-04-08 18:22 ` Nathan Chancellor
2021-04-08 23:55 ` Simon Glass
2021-04-08 23:55 ` Simon Glass
2021-04-09 17:47 ` Tom Rini
2021-04-09 17:47 ` Tom Rini
2021-04-09 19:21 ` [PATCH] MIPS: generic: Update node names to avoid unit addresses Nathan Chancellor
2021-04-09 19:41 ` Tom Rini
2021-04-12 15:05 ` Thomas Bogendoerfer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210412150529.GB23632@alpha.franken.de \
--to=tsbogend@alpha.franken.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=nathan@kernel.org \
--cc=paulburton@kernel.org \
--cc=sjg@chromium.org \
--cc=stable@vger.kernel.org \
--cc=trini@konsulko.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.