From: Borislav Petkov <bp@alien8.de>
To: Wei Yongjun <weiyongjun1@huawei.com>
Cc: Jarkko Sakkinen <jarkko@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>,
Sean Christopherson <sean.j.christopherson@intel.com>,
x86@kernel.org, linux-sgx@vger.kernel.org,
kernel-janitors@vger.kernel.org, Hulk Robot <hulkci@huawei.com>
Subject: Re: [PATCH -next] x86/sgx: Make symbol 'sgx_vepc_vm_ops' static
Date: Mon, 12 Apr 2021 19:46:49 +0200 [thread overview]
Message-ID: <20210412174649.GG24283@zn.tnic> (raw)
In-Reply-To: <20210412160023.193850-1-weiyongjun1@huawei.com>
On Mon, Apr 12, 2021 at 04:00:23PM +0000, Wei Yongjun wrote:
> The sparse tool complains as follows:
>
> arch/x86/kernel/cpu/sgx/virt.c:95:35: warning:
> symbol 'sgx_vepc_vm_ops' was not declared. Should it be static?
>
> This symbol is not used outside of virt.c, so this
> commit marks it static.
For the future:
Avoid having "This patch" or "This commit" in the commit message. It is
tautologically useless.
Also, do
$ git grep 'This patch' Documentation/process
for more details.
Thx.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
next prev parent reply other threads:[~2021-04-12 17:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-12 16:00 [PATCH -next] x86/sgx: Make symbol 'sgx_vepc_vm_ops' static Wei Yongjun
2021-04-12 17:46 ` Borislav Petkov [this message]
2021-04-13 7:19 ` 答复: " weiyongjun (A)
2021-04-12 18:00 ` [tip: x86/sgx] x86/sgx: Mark sgx_vepc_vm_ops static tip-bot2 for Wei Yongjun
2021-04-14 11:11 ` [PATCH -next] x86/sgx: Make symbol 'sgx_vepc_vm_ops' static Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210412174649.GG24283@zn.tnic \
--to=bp@alien8.de \
--cc=hulkci@huawei.com \
--cc=jarkko@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-sgx@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=sean.j.christopherson@intel.com \
--cc=tglx@linutronix.de \
--cc=weiyongjun1@huawei.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.