From: Tom Seewald <tseewald@gmail.com>
To: stable@vger.kernel.org
Cc: tseewald@gmail.com,
--reply-to=20210410004930.17411-1-tseewald@gmail.com,
Shuah Khan <skhan@linuxfoundation.org>,
Colin Ian King <colin.king@canonical.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Valentina Manea <valentina.manea.m@gmail.com>,
Shuah Khan <shuah@kernel.org>
Subject: [PATCH] usbip: Fix incorrect double assignment to udc->ud.tcp_rx
Date: Mon, 12 Apr 2021 13:59:02 -0500 [thread overview]
Message-ID: <20210412185902.27755-1-tseewald@gmail.com> (raw)
commit 9858af27e69247c5d04c3b093190a93ca365f33d upstream.
Currently udc->ud.tcp_rx is being assigned twice, the second assignment
is incorrect, it should be to udc->ud.tcp_tx instead of rx. Fix this.
Fixes: 46613c9dfa96 ("usbip: fix vudc usbip_sockfd_store races leading to gpf")
Acked-by: Shuah Khan <skhan@linuxfoundation.org>
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Cc: stable <stable@vger.kernel.org>
Addresses-Coverity: ("Unused value")
Link: https://lore.kernel.org/r/20210311104445.7811-1-colin.king@canonical.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Tom Seewald <tseewald@gmail.com>
---
drivers/usb/usbip/vudc_sysfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/usbip/vudc_sysfs.c b/drivers/usb/usbip/vudc_sysfs.c
index f44d98eeb36a..51cc5258b63e 100644
--- a/drivers/usb/usbip/vudc_sysfs.c
+++ b/drivers/usb/usbip/vudc_sysfs.c
@@ -187,7 +187,7 @@ static ssize_t store_sockfd(struct device *dev,
udc->ud.tcp_socket = socket;
udc->ud.tcp_rx = tcp_rx;
- udc->ud.tcp_rx = tcp_tx;
+ udc->ud.tcp_tx = tcp_tx;
udc->ud.status = SDEV_ST_USED;
spin_unlock_irq(&udc->ud.lock);
--
2.20.1
next reply other threads:[~2021-04-12 18:59 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-12 18:59 Tom Seewald [this message]
2021-04-12 19:06 ` [PATCH] usbip: Fix incorrect double assignment to udc->ud.tcp_rx Tom Seewald
2021-04-12 19:25 ` Shuah Khan
2021-04-12 19:50 ` Shuah Khan
2021-04-13 7:30 ` Greg Kroah-Hartman
2021-04-13 15:13 ` Shuah Khan
2021-04-16 15:32 ` Shuah Khan
2021-04-16 15:34 ` Shuah Khan
2021-04-19 12:25 ` Greg Kroah-Hartman
2021-04-19 22:06 ` Shuah Khan
2021-04-20 11:50 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210412185902.27755-1-tseewald@gmail.com \
--to=tseewald@gmail.com \
--cc=--reply-to=20210410004930.17411-1-tseewald@gmail.com \
--cc=colin.king@canonical.com \
--cc=gregkh@linuxfoundation.org \
--cc=shuah@kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=stable@vger.kernel.org \
--cc=valentina.manea.m@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.