From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x1033.google.com (mail-pj1-x1033.google.com [IPv6:2607:f8b0:4864:20::1033]) by gabe.freedesktop.org (Postfix) with ESMTPS id CF2E76E1B7 for ; Tue, 13 Apr 2021 03:54:01 +0000 (UTC) Received: by mail-pj1-x1033.google.com with SMTP id s14so2927228pjl.5 for ; Mon, 12 Apr 2021 20:54:01 -0700 (PDT) From: Jason Ekstrand Date: Mon, 12 Apr 2021 22:52:40 -0500 Message-Id: <20210413035350.261794-5-jason@jlekstrand.net> In-Reply-To: <20210413035350.261794-1-jason@jlekstrand.net> References: <20210413035350.261794-1-jason@jlekstrand.net> MIME-Version: 1.0 Subject: [igt-dev] [PATCH i-g-t 04/74] tests/i915/gem_ctx_param: Drop the zeromap subtests List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: igt-dev@lists.freedesktop.org List-ID: The idea behind this param is to support OpenCL drivers with relocations because OpenCL reserves 0x0 for NULL and, if we placed memory there, it would confuse CL kernels. It was originally sent out as part of a patch series including libdrm [1] and Beignet [2] support. However, the libdrm and Beignet patches never landed in their respective upstream projects so this API has never been used. It's never been used in Mesa or any other driver, either. This means that these IGT tests are the only userspace for NO_ZEROMAP which has ever really existed. Let's drop them and drop support from i915 as well. [1]: https://lists.freedesktop.org/archives/intel-gfx/2015-May/067030.html [2]: https://lists.freedesktop.org/archives/intel-gfx/2015-May/067031.html Signed-off-by: Jason Ekstrand Reviewed-by: Daniel Vetter --- tests/i915/gem_ctx_param.c | 33 --------------------------------- 1 file changed, 33 deletions(-) diff --git a/tests/i915/gem_ctx_param.c b/tests/i915/gem_ctx_param.c index ab0e3007..47fea06d 100644 --- a/tests/i915/gem_ctx_param.c +++ b/tests/i915/gem_ctx_param.c @@ -335,39 +335,6 @@ igt_main gem_context_set_param(fd, &arg); } - arg.param = I915_CONTEXT_PARAM_NO_ZEROMAP; - - igt_describe("Validates context set param ioctl in non root mode with param " - "set to no zeromap"); - igt_subtest("non-root-set-no-zeromap") { - igt_fork(child, 1) { - igt_drop_root(); - - arg.ctx_id = ctx; - gem_context_get_param(fd, &arg); - arg.value--; - gem_context_set_param(fd, &arg); - } - - igt_waitchildren(); - } - - igt_describe("Tests the context set param ioctl with no zeromap enabled in root mode"); - igt_subtest("root-set-no-zeromap-enabled") { - arg.ctx_id = ctx; - gem_context_get_param(fd, &arg); - arg.value = 1; - gem_context_set_param(fd, &arg); - } - - igt_describe("Tests the context set param ioctl with no zeromap disabled in root mode"); - igt_subtest("root-set-no-zeromap-disabled") { - arg.ctx_id = ctx; - gem_context_get_param(fd, &arg); - arg.value = 0; - gem_context_set_param(fd, &arg); - } - igt_describe("Tests that multiple contexts can share the same VMA"); igt_subtest("vm") test_vm(fd); -- 2.31.1 _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev