From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48BDEC433ED for ; Tue, 13 Apr 2021 11:38:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 20A1D61029 for ; Tue, 13 Apr 2021 11:38:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238148AbhDMLie (ORCPT ); Tue, 13 Apr 2021 07:38:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49454 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244674AbhDMLib (ORCPT ); Tue, 13 Apr 2021 07:38:31 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DD227C061574 for ; Tue, 13 Apr 2021 04:38:11 -0700 (PDT) Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lWHMs-0000xm-0y; Tue, 13 Apr 2021 13:38:06 +0200 Received: from ukl by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1lWHMr-0007JF-BA; Tue, 13 Apr 2021 13:38:05 +0200 Date: Tue, 13 Apr 2021 13:38:05 +0200 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= To: Clemens Gruber Cc: linux-pwm@vger.kernel.org, Thierry Reding , Sven Van Asbroeck , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Rob Herring Subject: Re: [PATCH v8 4/8] dt-bindings: pwm: Support new PWM_USAGE_POWER flag Message-ID: <20210413113805.mjft5jxt3qhsxg6e@pengutronix.de> References: <20210412132745.76609-1-clemens.gruber@pqgruber.com> <20210412132745.76609-4-clemens.gruber@pqgruber.com> <20210412162723.7hlhgqp6wlfbkeky@pengutronix.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="6ylyknhukjyy5n3f" Content-Disposition: inline In-Reply-To: X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --6ylyknhukjyy5n3f Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hello, On Mon, Apr 12, 2021 at 06:46:51PM +0200, Clemens Gruber wrote: > On Mon, Apr 12, 2021 at 06:27:23PM +0200, Uwe Kleine-K=F6nig wrote: > > On Mon, Apr 12, 2021 at 03:27:41PM +0200, Clemens Gruber wrote: > > > Add the flag and corresponding documentation for PWM_USAGE_POWER. > >=20 > > My concern here in the previous round was that PWM_USAGE_POWER isn't a > > name that intuitively suggests its semantic. Do you disagree? >=20 > No. It is more abstract and requires documentation. But I also didn't > want to waste too much time on discussing names, so I used Thierry's > suggestion. If you introduce API thinking about the name before actually introducing it is a good idea in general. (OK, the name doesn't become part of the (binary) dt API, but we don't even agree about its semantic here.) And IMHO a bad name with a good documentation isn't good enough. Otherwise we can better just agree on using plain numbers in the .dts files. Best regards Uwe --=20 Pengutronix e.K. | Uwe Kleine-K=F6nig | Industrial Linux Solutions | https://www.pengutronix.de/ | --6ylyknhukjyy5n3f Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEfnIqFpAYrP8+dKQLwfwUeK3K7AkFAmB1gpoACgkQwfwUeK3K 7AnlhQf+LbijeNL99k/BA6DLPwjCqv1BwTNIbQYP8NQWZ+wHI2T36hTFTTkCckKB MHq5AsWUyTAlD680U+Ya+BStulu3Tw+0NE52w+XHC6d2sK1MtKQxeUvt6px8ynUP lwtMGi4ceVcGXxlToJtJSRYwO/aOG/aezHdYOqrQ6CQoW1tK6Qux471FY6I3eRx6 oy+X+YZ+eEB6gEj8FdCk46x5Tq/jjLZ5CiW22yppoY6GJH03LsJC/wyKgfhxQBQg 22v2otHIiOxX5jjb2E0ISFh37Oid16PICWEZU7l6aZSYe1Q9nOFjl6L1r8zaqh2g gxolPAqWjxMlpQnuUNQ+gOrESy3WOA== =69Rv -----END PGP SIGNATURE----- --6ylyknhukjyy5n3f--