From: Steven Rostedt <rostedt@goodmis.org>
To: Dietmar Eggemann <dietmar.eggemann@arm.com>
Cc: Hui Su <suhui@zeku.com>,
mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com,
vincent.guittot@linaro.org, bsegall@google.com, mgorman@suse.de,
bristot@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sched: remove the redundant comments
Date: Tue, 13 Apr 2021 12:28:04 -0400 [thread overview]
Message-ID: <20210413122804.2d69fca6@gandalf.local.home> (raw)
In-Reply-To: <d9c447fd-d3f5-cb66-b3a9-7f7002594ccc@arm.com>
On Tue, 13 Apr 2021 10:36:07 +0200
Dietmar Eggemann <dietmar.eggemann@arm.com> wrote:
> > @@ -897,11 +897,6 @@ DECLARE_STATIC_KEY_FALSE(sched_uclamp_used);
> > struct rq {
> > /* runqueue lock: */
> > raw_spinlock_t lock;
> > -
> > - /*
> > - * nr_running and cpu_load should be in the same cacheline because
> > - * remote CPUs use both these fields when doing load calculation.
> > - */
> > unsigned int nr_running;
> > #ifdef CONFIG_NUMA_BALANCING
> > unsigned int nr_numa_running;
>
> I forgot to remove this snippet back then. LGTM.
>
> Add a
>
> Fixes: 55627e3cd22c ("sched/core: Remove rq->cpu_load[]")
>
> line.
It's just removing a comment. Should it really need a "Fixes" tag, which
will cause many people to look at it to determine if it should be
backported to stable?
-- Steve
next prev parent reply other threads:[~2021-04-13 16:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-12 7:39 [PATCH] sched: remove the redundant comments Hui Su
2021-04-13 8:36 ` Dietmar Eggemann
2021-04-13 16:28 ` Steven Rostedt [this message]
2021-04-13 17:14 ` Dietmar Eggemann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210413122804.2d69fca6@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=bristot@redhat.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=suhui@zeku.com \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.