From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3423C433B4 for ; Tue, 13 Apr 2021 14:54:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8EA55613B1 for ; Tue, 13 Apr 2021 14:54:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231775AbhDMOzJ (ORCPT ); Tue, 13 Apr 2021 10:55:09 -0400 Received: from wnew2-smtp.messagingengine.com ([64.147.123.27]:45321 "EHLO wnew2-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231721AbhDMOzJ (ORCPT ); Tue, 13 Apr 2021 10:55:09 -0400 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailnew.west.internal (Postfix) with ESMTP id A48B22D5; Tue, 13 Apr 2021 10:54:47 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Tue, 13 Apr 2021 10:54:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; s=fm2; bh=WTTxhz7TT0y6m FK14ROq7Hd8G4QJsosdSX03P/4q+SQ=; b=W1f+iG5AQRFA7Rqci6l/PLRA3pk/j 3ii7OB73GBXFjrjnd5SVrIAQtDcJqASqW/3lX7lQQS3oFBKUk1jWYmJxIYlmpUE8 o3O05Hwj2IcMqD8tmQNqOrE8GqSfLOGMGwDgnmS73yTftsP35bLr9XZPsRS8DMby VJNXDsKPTkeiGpWRWENkI0kpCjEgvHl9lQkcBUxAKMUtgSC8jecoVWOG0wJvYj45 xPQcbpVeRK+auS3VK1F43sae6UGbt2jP76cheV6JaKXVAFq5BtMMks84oZNcmDMx oJI39MhIOZ0u/qZf84UJzkOtxmNNdREh+Mzhh8ck6ukCcgp9bkm/R16qg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:date:from :in-reply-to:message-id:mime-version:references:subject:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; bh=WTTxhz7TT0y6mFK14ROq7Hd8G4QJsosdSX03P/4q+SQ=; b=Ei1JX/Bf bStkwigCilkmw9rKo2AuX748DFFs+lyM7RaFM3RY+NlXOhpc5RQpG1FcCqaUbJl5 uaDiR+sBI9gnDFe2jB8HUSd6vDwqWyt4/kQSN2LY8xm7rddefhSnrs0KC+HYICto e1uYEBhoLPwT6gEvIZ2reIqw7r75imKq/ajYtS0VGNxfnkDcV+ojuuW1pNvhtYMQ 03AqR5sa45CZmytS2ZB1JKrDXPcCnjM6xF5Q388JmDGNTqRRCKOFWxDJ+f5lBdwF dr1FmCCprXKQv3diYtiz/RSz7n/b7w9HWO5TDs4rhBJFaM8zoqgavOgoaaGdLdPv 7n+x+zoXN1AIfg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudekledgkedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkffojghfggfgsedtkeertdertddtnecuhfhrohhmpeforgigihhm vgcutfhiphgrrhguuceomhgrgihimhgvsegtvghrnhhordhtvggthheqnecuggftrfgrth htvghrnhepvdekleevfeffkeejhfffueelteelfeduieefheduudfggffhhfffheevveeh hedvnecukfhppeeltddrkeelrdeikedrjeeinecuvehluhhsthgvrhfuihiivgeptdenuc frrghrrghmpehmrghilhhfrhhomhepmhgrgihimhgvsegtvghrnhhordhtvggthh X-ME-Proxy: Received: from localhost (lfbn-tou-1-1502-76.w90-89.abo.wanadoo.fr [90.89.68.76]) by mail.messagingengine.com (Postfix) with ESMTPA id DB31F24005E; Tue, 13 Apr 2021 10:54:45 -0400 (EDT) From: Maxime Ripard To: dri-devel@lists.freedesktop.org, Maarten Lankhorst , Thomas Zimmermann , Maxime Ripard Cc: Phil Elwell , Nicolas Saenz Julienne , Tim Gover , linux-rpi-kernel@lists.infradead.org, Dave Stevenson , Daniel Vetter , David Airlie , bcm-kernel-feedback-list@broadcom.com, stable@vger.kernel.org Subject: [PATCH v3 1/9] drm/vc4: txp: Properly set the possible_crtcs mask Date: Tue, 13 Apr 2021 16:54:33 +0200 Message-Id: <20210413145441.483977-2-maxime@cerno.tech> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210413145441.483977-1-maxime@cerno.tech> References: <20210413145441.483977-1-maxime@cerno.tech> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org The current code does a binary OR on the possible_crtcs variable of the TXP encoder, while we want to set it to that value instead. Cc: # v5.9+ Fixes: 39fcb2808376 ("drm/vc4: txp: Turn the TXP into a CRTC of its own") Acked-by: Thomas Zimmermann Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/vc4_txp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/vc4/vc4_txp.c b/drivers/gpu/drm/vc4/vc4_txp.c index c0122d83b651..2fc7f4b5fa09 100644 --- a/drivers/gpu/drm/vc4/vc4_txp.c +++ b/drivers/gpu/drm/vc4/vc4_txp.c @@ -507,7 +507,7 @@ static int vc4_txp_bind(struct device *dev, struct device *master, void *data) return ret; encoder = &txp->connector.encoder; - encoder->possible_crtcs |= drm_crtc_mask(crtc); + encoder->possible_crtcs = drm_crtc_mask(crtc); ret = devm_request_irq(dev, irq, vc4_txp_interrupt, 0, dev_name(dev), txp); -- 2.30.2 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EFA4CC43461 for ; Tue, 13 Apr 2021 14:54:53 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B393F60551 for ; Tue, 13 Apr 2021 14:54:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B393F60551 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cerno.tech Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 132776E526; Tue, 13 Apr 2021 14:54:53 +0000 (UTC) Received: from wnew2-smtp.messagingengine.com (wnew2-smtp.messagingengine.com [64.147.123.27]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6D0D16E526 for ; Tue, 13 Apr 2021 14:54:50 +0000 (UTC) Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailnew.west.internal (Postfix) with ESMTP id A48B22D5; Tue, 13 Apr 2021 10:54:47 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Tue, 13 Apr 2021 10:54:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; s=fm2; bh=WTTxhz7TT0y6m FK14ROq7Hd8G4QJsosdSX03P/4q+SQ=; b=W1f+iG5AQRFA7Rqci6l/PLRA3pk/j 3ii7OB73GBXFjrjnd5SVrIAQtDcJqASqW/3lX7lQQS3oFBKUk1jWYmJxIYlmpUE8 o3O05Hwj2IcMqD8tmQNqOrE8GqSfLOGMGwDgnmS73yTftsP35bLr9XZPsRS8DMby VJNXDsKPTkeiGpWRWENkI0kpCjEgvHl9lQkcBUxAKMUtgSC8jecoVWOG0wJvYj45 xPQcbpVeRK+auS3VK1F43sae6UGbt2jP76cheV6JaKXVAFq5BtMMks84oZNcmDMx oJI39MhIOZ0u/qZf84UJzkOtxmNNdREh+Mzhh8ck6ukCcgp9bkm/R16qg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:date:from :in-reply-to:message-id:mime-version:references:subject:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; bh=WTTxhz7TT0y6mFK14ROq7Hd8G4QJsosdSX03P/4q+SQ=; b=Ei1JX/Bf bStkwigCilkmw9rKo2AuX748DFFs+lyM7RaFM3RY+NlXOhpc5RQpG1FcCqaUbJl5 uaDiR+sBI9gnDFe2jB8HUSd6vDwqWyt4/kQSN2LY8xm7rddefhSnrs0KC+HYICto e1uYEBhoLPwT6gEvIZ2reIqw7r75imKq/ajYtS0VGNxfnkDcV+ojuuW1pNvhtYMQ 03AqR5sa45CZmytS2ZB1JKrDXPcCnjM6xF5Q388JmDGNTqRRCKOFWxDJ+f5lBdwF dr1FmCCprXKQv3diYtiz/RSz7n/b7w9HWO5TDs4rhBJFaM8zoqgavOgoaaGdLdPv 7n+x+zoXN1AIfg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudekledgkedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkffojghfggfgsedtkeertdertddtnecuhfhrohhmpeforgigihhm vgcutfhiphgrrhguuceomhgrgihimhgvsegtvghrnhhordhtvggthheqnecuggftrfgrth htvghrnhepvdekleevfeffkeejhfffueelteelfeduieefheduudfggffhhfffheevveeh hedvnecukfhppeeltddrkeelrdeikedrjeeinecuvehluhhsthgvrhfuihiivgeptdenuc frrghrrghmpehmrghilhhfrhhomhepmhgrgihimhgvsegtvghrnhhordhtvggthh X-ME-Proxy: Received: from localhost (lfbn-tou-1-1502-76.w90-89.abo.wanadoo.fr [90.89.68.76]) by mail.messagingengine.com (Postfix) with ESMTPA id DB31F24005E; Tue, 13 Apr 2021 10:54:45 -0400 (EDT) From: Maxime Ripard To: dri-devel@lists.freedesktop.org, Maarten Lankhorst , Thomas Zimmermann , Maxime Ripard Subject: [PATCH v3 1/9] drm/vc4: txp: Properly set the possible_crtcs mask Date: Tue, 13 Apr 2021 16:54:33 +0200 Message-Id: <20210413145441.483977-2-maxime@cerno.tech> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210413145441.483977-1-maxime@cerno.tech> References: <20210413145441.483977-1-maxime@cerno.tech> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tim Gover , Dave Stevenson , David Airlie , stable@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, linux-rpi-kernel@lists.infradead.org, Daniel Vetter , Phil Elwell , Nicolas Saenz Julienne Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" The current code does a binary OR on the possible_crtcs variable of the TXP encoder, while we want to set it to that value instead. Cc: # v5.9+ Fixes: 39fcb2808376 ("drm/vc4: txp: Turn the TXP into a CRTC of its own") Acked-by: Thomas Zimmermann Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/vc4_txp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/vc4/vc4_txp.c b/drivers/gpu/drm/vc4/vc4_txp.c index c0122d83b651..2fc7f4b5fa09 100644 --- a/drivers/gpu/drm/vc4/vc4_txp.c +++ b/drivers/gpu/drm/vc4/vc4_txp.c @@ -507,7 +507,7 @@ static int vc4_txp_bind(struct device *dev, struct device *master, void *data) return ret; encoder = &txp->connector.encoder; - encoder->possible_crtcs |= drm_crtc_mask(crtc); + encoder->possible_crtcs = drm_crtc_mask(crtc); ret = devm_request_irq(dev, irq, vc4_txp_interrupt, 0, dev_name(dev), txp); -- 2.30.2 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel