From: Rob Herring <robh@kernel.org>
To: Ikjoon Jang <ikjn@chromium.org>
Cc: linux-input@vger.kernel.org, devicetree@vger.kernel.org,
Hsin-Yi Wang <hsinyi@chromium.org>,
Dmitry Torokhov <dtor@chromium.org>,
Nicolas Boichat <drinkcat@chromium.org>,
Benson Leung <bleung@chromium.org>,
Enric Balletbo i Serra <enric.balletbo@collabora.com>,
Guenter Roeck <groeck@chromium.org>,
Lee Jones <lee.jones@linaro.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 1/2] mfd: google,cros-ec: add DT bindings for a baseboard's switch device
Date: Tue, 13 Apr 2021 09:57:30 -0500 [thread overview]
Message-ID: <20210413145730.GA1667299@robh.at.kernel.org> (raw)
In-Reply-To: <20210412113020.2724134-2-ikjn@chromium.org>
On Mon, Apr 12, 2021 at 07:30:19PM +0800, Ikjoon Jang wrote:
> This is for ChromeOS tablets which have a 'cros_cbas' switch device
> in the "Whiskers" base board. This device can be instantiated only by
> device tree on ARM platforms. ChromeOS EC doesn't provide a way to
> probe the device.
>
> Signed-off-by: Ikjoon Jang <ikjn@chromium.org>
>
> ---
>
> Changes in v4:
> Define cros-cbase bindings inside google,cros-ec.yaml instead of
> a seperated binding document.
>
> .../devicetree/bindings/mfd/google,cros-ec.yaml | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml b/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml
> index 76bf16ee27ec..c76809cd9f7f 100644
> --- a/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml
> +++ b/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml
> @@ -127,6 +127,18 @@ patternProperties:
> type: object
> $ref: "/schemas/extcon/extcon-usbc-cros-ec.yaml#"
>
> + "^cbas$":
Not a pattern, put under 'properties'.
> + type: object
> + properties:
> + compatible:
> + const: google,cros-cbas
Blank line
> + required:
> + - compatible
Blank line
> + additionalProperties: false
> + description:
Make this 1st or at least before 'properties'.
> + This device is used to signal when a detachable base is attached
> + to a Chrome OS tablet.
This can't happen at runtime?
> +
> required:
> - compatible
>
> @@ -180,6 +192,10 @@ examples:
> interrupts = <99 0>;
> interrupt-parent = <&gpio7>;
> spi-max-frequency = <5000000>;
> +
> + base_detection: cbas {
> + compatible = "google,cros-cbas";
> + };
> };
> };
>
> --
> 2.31.1.295.g9ea45b61b8-goog
>
next prev parent reply other threads:[~2021-04-13 14:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-12 11:30 [PATCH v4 0/2] HID: google: add device tree bindings for Whiskers switch device Ikjoon Jang
2021-04-12 11:30 ` [PATCH v4 1/2] mfd: google,cros-ec: add DT bindings for a baseboard's " Ikjoon Jang
2021-04-13 14:57 ` Rob Herring [this message]
2021-04-14 4:15 ` Ikjoon Jang
2021-04-12 11:30 ` [PATCH v4 2/2] HID: google: Add of_match table to Whiskers " Ikjoon Jang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210413145730.GA1667299@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=bleung@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=drinkcat@chromium.org \
--cc=dtor@chromium.org \
--cc=enric.balletbo@collabora.com \
--cc=groeck@chromium.org \
--cc=hsinyi@chromium.org \
--cc=ikjn@chromium.org \
--cc=lee.jones@linaro.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.