All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Helge Deller <deller@gmx.de>
Cc: Christoph Hellwig <hch@lst.de>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
	Heiko Carstens <hca@linux.ibm.com>,
	Vasily Gorbik <gor@linux.ibm.com>,
	Christian Borntraeger <borntraeger@de.ibm.com>,
	"David S. Miller" <davem@davemloft.net>,
	Arnd Bergmann <arnd@arndb.de>,
	linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org
Subject: Re: [PATCH 4/5] uapi: always define F_GETLK64/F_SETLK64/F_SETLKW64 in fcntl.h
Date: Tue, 13 Apr 2021 17:46:46 +0200	[thread overview]
Message-ID: <20210413154646.GC27287@lst.de> (raw)
In-Reply-To: <da779585-60c6-2f4b-feaf-db45e1eef262@gmx.de>

On Tue, Apr 13, 2021 at 05:43:18PM +0200, Helge Deller wrote:
> On 4/12/21 10:55 AM, Christoph Hellwig wrote:
>> The F_GETLK64/F_SETLK64/F_SETLKW64 commands are only implemented for
>> 32-bit syscall APIs, but we also need them for compat handling on 64-bit
>> kernels.
>
> Ok.
>
>> Given that redefining them is rather error prone, as shown by parisc
>> getting the opcodes wrong currently, just use the existing definitions
>> for the compat handling.
>
> Can you please show me where parisc gets it currently wrong?
> I'm somehow blind to see it and of course I'd like to fix it in
> stable kernel series if that's true...

Looking again I think my comment was wrong, I thought parisc would
fall back to the asm-generic version with different code points for
the compat case, but parisc actually already defines the constants
unconditionally like this patch does for everyone else.  So I'll
retract that part of the comment.

  reply	other threads:[~2021-04-13 15:46 UTC|newest]

Thread overview: 87+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-12  8:55 consolidate the flock uapi definitions Christoph Hellwig
2021-04-12  8:55 ` Christoph Hellwig
2021-04-12  8:55 ` Christoph Hellwig
2021-04-12  8:55 ` [PATCH 1/5] uapi: remove the unused HAVE_ARCH_STRUCT_FLOCK64 define Christoph Hellwig
2021-04-12  8:55   ` Christoph Hellwig
2021-04-12  8:55   ` Christoph Hellwig
2021-04-12  9:55   ` Arnd Bergmann
2021-04-12  9:55     ` Arnd Bergmann
2021-04-12  9:55     ` Arnd Bergmann
2021-04-14  6:45     ` Stephen Rothwell
2021-04-14  6:45       ` Stephen Rothwell
2021-04-14  6:45       ` Stephen Rothwell
2021-04-12  8:55 ` [PATCH 2/5] uapi: simplify __ARCH_FLOCK{,64}_PAD a little Christoph Hellwig
2021-04-12  8:55   ` Christoph Hellwig
2021-04-12  8:55   ` Christoph Hellwig
2021-04-12  8:55 ` [PATCH 3/5] uapi: merge the 32-bit mips struct flock into the generic one Christoph Hellwig
2021-04-12  8:55   ` Christoph Hellwig
2021-04-12  8:55   ` Christoph Hellwig
2021-04-12  8:55 ` [PATCH 4/5] uapi: always define F_GETLK64/F_SETLK64/F_SETLKW64 in fcntl.h Christoph Hellwig
2021-04-12  8:55   ` Christoph Hellwig
2021-04-12  8:55   ` Christoph Hellwig
2021-04-13 15:43   ` Helge Deller
2021-04-13 15:46     ` Christoph Hellwig [this message]
2021-04-13 15:58       ` Helge Deller
2021-04-12  8:55 ` [PATCH 5/5] compat: consolidate the compat_flock{,64} definition Christoph Hellwig
2021-04-12  8:55   ` Christoph Hellwig
2021-04-12  8:55   ` Christoph Hellwig
2021-04-12  9:37   ` David Laight
2021-04-12  9:37     ` David Laight
2021-04-12  9:37     ` David Laight
2021-04-12 10:53     ` David Laight
2021-04-12 10:53       ` David Laight
2021-04-12 10:53       ` David Laight
2021-04-12 11:26       ` Arnd Bergmann
2021-04-12 11:26         ` Arnd Bergmann
2021-04-12 11:26         ` Arnd Bergmann
2021-04-12 13:11         ` David Laight
2021-04-12 13:11           ` David Laight
2021-04-12 13:11           ` David Laight
2021-04-12 10:03 ` consolidate the flock uapi definitions Arnd Bergmann
2021-04-12 10:03   ` Arnd Bergmann
2021-04-12 10:03   ` Arnd Bergmann
2021-04-12 10:22   ` David Laight
2021-04-12 10:22     ` David Laight
2021-04-12 10:22     ` David Laight
2021-04-12 11:07     ` Arnd Bergmann
2021-04-12 11:07       ` Arnd Bergmann
2021-04-12 11:07       ` Arnd Bergmann
2021-04-15 12:20 ` Heiko Carstens
2021-04-15 12:20   ` Heiko Carstens
2021-04-15 12:20   ` Heiko Carstens
2022-01-11  8:35 consolidate the compat fcntl definitions Christoph Hellwig
2022-01-11  8:35 ` [PATCH 4/5] uapi: always define F_GETLK64/F_SETLK64/F_SETLKW64 in fcntl.h Christoph Hellwig
2022-01-11  8:35   ` Christoph Hellwig
2022-01-11  8:35   ` Christoph Hellwig
2022-01-11 15:33   ` Arnd Bergmann
2022-01-11 15:33     ` Arnd Bergmann
2022-01-11 15:33     ` Arnd Bergmann
2022-01-12  2:08     ` Guo Ren
2022-01-12  2:08       ` Guo Ren
2022-01-12  2:08       ` Guo Ren
2022-01-12  7:56     ` Christoph Hellwig
2022-01-12  7:56       ` Christoph Hellwig
2022-01-12  7:56       ` Christoph Hellwig
2022-01-12  8:28       ` Arnd Bergmann
2022-01-12  8:28         ` Arnd Bergmann
2022-01-12  8:28         ` Arnd Bergmann
2022-01-12 11:15         ` Jeff Layton
2022-01-12 11:15           ` Jeff Layton
2022-01-12 11:15           ` Jeff Layton
2022-01-12 12:08           ` Arnd Bergmann
2022-01-12 12:08             ` Arnd Bergmann
2022-01-12 12:08             ` Arnd Bergmann
2022-01-12 16:09             ` Christoph Hellwig
2022-01-12 16:09               ` Christoph Hellwig
2022-01-12 16:09               ` Christoph Hellwig
2022-01-31  6:49 consolidate the compat fcntl definitions v2 Christoph Hellwig
2022-01-31  6:49 ` [PATCH 4/5] uapi: always define F_GETLK64/F_SETLK64/F_SETLKW64 in fcntl.h Christoph Hellwig
2022-01-31  6:49   ` Christoph Hellwig
2022-01-31  6:49   ` Christoph Hellwig
2022-01-31 13:38   ` Guo Ren
2022-01-31 13:38     ` Guo Ren
2022-01-31 13:38     ` Guo Ren
2022-02-01  3:02   ` Guo Ren
2022-02-01  3:02     ` Guo Ren
2022-02-01  3:02     ` Guo Ren
2022-02-01  3:07     ` Guo Ren
2022-02-01  3:07       ` Guo Ren
2022-02-01  3:07       ` Guo Ren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210413154646.GC27287@lst.de \
    --to=hch@lst.de \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=arnd@arndb.de \
    --cc=borntraeger@de.ibm.com \
    --cc=catalin.marinas@arm.com \
    --cc=davem@davemloft.net \
    --cc=deller@gmx.de \
    --cc=gor@linux.ibm.com \
    --cc=hca@linux.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=tsbogend@alpha.franken.de \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.