From: Michael Zaidman <michael.zaidman@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Jiri Kosina <jikos@kernel.org>,
Benjamin Tissoires <benjamin.tissoires@redhat.com>,
linux-i2c@vger.kernel.org, linux-input@vger.kernel.org
Subject: Re: [bug report] HID: ft260: add usb hid to i2c host bridge driver
Date: Tue, 13 Apr 2021 18:52:54 +0300 [thread overview]
Message-ID: <20210413155254.GA2470@michael-VirtualBox> (raw)
In-Reply-To: <20210412091151.GV6048@kadam>
On Mon, Apr 12, 2021 at 12:11:51PM +0300, Dan Carpenter wrote:
> On Sun, Apr 11, 2021 at 12:04:25AM +0300, Michael Zaidman wrote:
> >
> > Oh, you are right. Despite that the SMbus block transaction limits the maximum
> > number of bytes to 32, nothing prevents a user from specifying via ioctl a larger
> > data size than the ft260 can handle in a single transfer.
> >
> > I am going to fix it in the ft260_smbus_write (with your Signed-off-by), but
> > perhaps we should fix it in the first place, in the i2cdev_ioctl_smbus routine?
> > What do you think?
>
> Could you just give me a Reported-by tag? Thanks!
>
> regards,
> dan carpenter
Done, thanks!
next prev parent reply other threads:[~2021-04-13 15:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-09 12:32 [bug report] HID: ft260: add usb hid to i2c host bridge driver Dan Carpenter
2021-04-10 12:27 ` Michael Zaidman
2021-04-10 15:37 ` Dan Carpenter
2021-04-10 21:04 ` Michael Zaidman
2021-04-12 9:11 ` Dan Carpenter
2021-04-13 15:52 ` Michael Zaidman [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-03-18 10:39 Dan Carpenter
2021-03-19 16:33 ` Michael Zaidman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210413155254.GA2470@michael-VirtualBox \
--to=michael.zaidman@gmail.com \
--cc=benjamin.tissoires@redhat.com \
--cc=dan.carpenter@oracle.com \
--cc=jikos@kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.