From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39890C43460 for ; Tue, 13 Apr 2021 17:32:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0A4E5613B7 for ; Tue, 13 Apr 2021 17:32:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347184AbhDMRcg (ORCPT ); Tue, 13 Apr 2021 13:32:36 -0400 Received: from mail-pf1-f178.google.com ([209.85.210.178]:37746 "EHLO mail-pf1-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1347202AbhDMRcf (ORCPT ); Tue, 13 Apr 2021 13:32:35 -0400 Received: by mail-pf1-f178.google.com with SMTP id o123so11883493pfb.4 for ; Tue, 13 Apr 2021 10:32:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=YMM/4xDA/XuveKLA+4AHcwRECrJjIXlnjy/ORkscS5U=; b=f1UjMDAWvQupgZFDW4liQWuJILKSuu5fkmdWlYe+YSSqK919UYPh1yivPwQs3B5cVP PrxWAeeDLMBTIKdQJkrUcwkwL+vnp4zGAqn1N0L7n9Gn3WyM6L13PVHZ7lnkLTpXHQU5 SlsFG/7P2VgeOVZ1biXi7Cvl96CKUCF0mxUEFzGQ9+LG/h+Qn/MqoDswB93JEjRnZA1W d+9z9U7WQDueuKrL9XegzZZcanv0bN4oPx8WX5R4SF3wDZtfXiXYqXB0jkZprzU/523Z /bLbIuYNeZo62rG8FujZF41FP8nsZ47PJZiZpO1EyDgZlEjkNB35g/Al9S1TKZLqpsDy C8Rw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=YMM/4xDA/XuveKLA+4AHcwRECrJjIXlnjy/ORkscS5U=; b=oFDAs0OL4n7DUOJk/iwPmbp7+3plmo9DXhh0fy+6hdZjiMqrjPjv3MLhXNl4Qo6jQQ 146iiKIZwd09LoIaQ0eV3ETxejsHAQISnogry2xCRWoYRTVygYtU080sQVEDX6c67wSb DgVo1fHw8y9KHkscV21ynzQ5op+ZF6QdUvPaHGg+ZB9tpLwDsTHWrloD/rE8I5roMgMm 9HpO1PGQ06BB1PimAZIE6oq8FZKn92ql4RSXy+sWNCGKxC3EmYHw64PSWwcbgWLUw6/j 3rOu+9qTGIdACNBVTKpejJ9ZduyoKbU44FbTXn9ICaa3jKhJb59/zwqnLSwQa/JfLByV F8Vw== X-Gm-Message-State: AOAM531GgYRIAba27mXpFiSbxyAPtoYX2ge2BB+//D0hS4+9yURlXWlI bCia0VqCdZNft8T0KBCNXwGuvQ== X-Google-Smtp-Source: ABdhPJzFM5tjdD483851MUzDbE+ToSODkBCl/jpHesj1gTMPOMk1WSMgj55e9vYKOekET9+lOcbVfg== X-Received: by 2002:a65:5c42:: with SMTP id v2mr33772698pgr.339.1618335075427; Tue, 13 Apr 2021 10:31:15 -0700 (PDT) Received: from xps15 (S0106889e681aac74.cg.shawcable.net. [68.147.0.187]) by smtp.gmail.com with ESMTPSA id y193sm13468809pfc.72.2021.04.13.10.31.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Apr 2021 10:31:15 -0700 (PDT) Date: Tue, 13 Apr 2021 11:31:13 -0600 From: Mathieu Poirier To: peng.fan@oss.nxp.com Cc: ohad@wizery.com, bjorn.andersson@linaro.org, o.rempel@pengutronix.de, robh+dt@kernel.org, devicetree@vger.kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-remoteproc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Peng Fan Subject: Re: [PATCH V3 5/8] remoteproc: imx_rproc: parse fsl,auto-boot Message-ID: <20210413173113.GC750651@xps15> References: <1617846898-13662-1-git-send-email-peng.fan@oss.nxp.com> <1617846898-13662-6-git-send-email-peng.fan@oss.nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1617846898-13662-6-git-send-email-peng.fan@oss.nxp.com> Precedence: bulk List-ID: X-Mailing-List: linux-remoteproc@vger.kernel.org On Thu, Apr 08, 2021 at 09:54:55AM +0800, peng.fan@oss.nxp.com wrote: > From: Peng Fan > > Parse fsl,auto-boot to indicate whether need remoteproc framework > auto boot or not. > > When remote processor is booted before Linux Kernel up, do not parse > fsl,auto-boot. So add an entry to store the working mode of remote > processor. Currently only IMX_RPROC_NORMAL, IMX_RPROC_EARLY_BOOT. > > Signed-off-by: Peng Fan > --- > drivers/remoteproc/imx_rproc.c | 20 +++++++++++++++++++- > 1 file changed, 19 insertions(+), 1 deletion(-) > > diff --git a/drivers/remoteproc/imx_rproc.c b/drivers/remoteproc/imx_rproc.c > index ca17f520d904..c576e12d3817 100644 > --- a/drivers/remoteproc/imx_rproc.c > +++ b/drivers/remoteproc/imx_rproc.c > @@ -83,6 +83,16 @@ struct imx_rproc_dcfg { > size_t att_size; > }; > > +enum imx_rproc_mode { > + /* Linux load/kick remote core */ > + IMX_RPROC_NORMAL, > + /* > + * remote core booted before kicking Linux, and remote core > + * could be stopped & restarted by Linux > + */ > + IMX_RPROC_EARLY_BOOT, > +}; > + As far as I can see a new mode to track the state of the remote processor is not needed. rproc->state can do that for you. > struct imx_rproc { > struct device *dev; > struct regmap *regmap; > @@ -96,6 +106,7 @@ struct imx_rproc { > struct work_struct rproc_work; > struct workqueue_struct *workqueue; > void __iomem *rsc_table; > + enum imx_rproc_mode mode; > }; > > static const struct imx_rproc_att imx_rproc_att_imx8mq[] = { > @@ -565,14 +576,18 @@ static int imx_rproc_detect_mode(struct imx_rproc *priv) > int ret; > u32 val; > > + priv->mode = IMX_RPROC_NORMAL; > + > ret = regmap_read(priv->regmap, dcfg->src_reg, &val); > if (ret) { > dev_err(dev, "Failed to read src\n"); > return ret; > } > > - if (!(val & dcfg->src_stop)) > + if (!(val & dcfg->src_stop)) { > + priv->mode = IMX_RPROC_EARLY_BOOT; > priv->rproc->state = RPROC_DETACHED; > + } > > return 0; > } > @@ -654,6 +669,9 @@ static int imx_rproc_probe(struct platform_device *pdev) > > INIT_WORK(&priv->rproc_work, imx_rproc_vq_work); > > + if (priv->mode == IMX_RPROC_NORMAL) > + rproc->auto_boot = of_property_read_bool(np, "fsl,auto-boot"); > + if (rproc->state == RPROC_DETACHED) > ret = rproc_add(rproc); > if (ret) { > dev_err(dev, "rproc_add failed\n"); > -- > 2.30.0 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C36F6C433B4 for ; Tue, 13 Apr 2021 17:34:31 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3BB95611CC for ; Tue, 13 Apr 2021 17:34:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3BB95611CC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=qSVJoxOdkxv3hY8vp+10GtJO2Q7i9TlP2UjemRUQn5Y=; b=cjCYSCmH1FWgwMwoOOx9PU4cG k6AearAxC9OJDPFR1V3offrl3TeAVfJonr/lPe9KHw4dqqi0fsE0DoWNE77dnjQrA2WeGSZOLOnzQ hIO5q7Gknyn+0pIvLe+DXQ5BXnB/UWi9CJ0S9WEu238jqvwDGUAZsVJao2ak7lujqKBT0yemYXonA jSnBpry3zdL3ruE69xNDhCveA7jA/XgCzBURv/9nIXzYOcigVu8WXBRgziFX1yynDPR+MGYEMMdsn GPDz58mlSYiwGCZpM+TWhcBP+SDs8gxZJd9PItr63rl60db/P2e/91HLrKV2Oi8GP2LsX9gyaQ9BV lpqrA7+6Q==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lWMsm-009yIR-Gs; Tue, 13 Apr 2021 17:31:24 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lWMsi-009yHh-Is for linux-arm-kernel@desiato.infradead.org; Tue, 13 Apr 2021 17:31:20 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=YMM/4xDA/XuveKLA+4AHcwRECrJjIXlnjy/ORkscS5U=; b=kj3wm9mEPTqJTJVzwhzRDjk52C I3u7nfTkwRPMsCABAErfhIf3lQk+SN4ksipsiCurYZ9eqrauxzlaX2mdgXU0ziM3xVuV6l5JdEJLi KPD5dWkX5n32QeF4DIJ6tcf5kVfhA0GKvLAkM3xbb1esMMSh6EJ3S2tdsoffRK6twtyE3Tco92aIK 7d/yfoXZYIbagTGwq1AftctySebFnvMGhyL3m6IxynuQHiebBdVUJoPRGcoQlGo9nRXTpcgvtwP3G qJYMbcjyLNE8FLNo6WSP/QxWYwUlH1clpI3h8qMXlHTPVJuw/V14T6rrfZ/Ar0RVl574UyWFFrP5h TJkgeQRw==; Received: from mail-pg1-x52e.google.com ([2607:f8b0:4864:20::52e]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lWMsf-007Dlk-Uk for linux-arm-kernel@lists.infradead.org; Tue, 13 Apr 2021 17:31:19 +0000 Received: by mail-pg1-x52e.google.com with SMTP id b17so12444254pgh.7 for ; Tue, 13 Apr 2021 10:31:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=YMM/4xDA/XuveKLA+4AHcwRECrJjIXlnjy/ORkscS5U=; b=f1UjMDAWvQupgZFDW4liQWuJILKSuu5fkmdWlYe+YSSqK919UYPh1yivPwQs3B5cVP PrxWAeeDLMBTIKdQJkrUcwkwL+vnp4zGAqn1N0L7n9Gn3WyM6L13PVHZ7lnkLTpXHQU5 SlsFG/7P2VgeOVZ1biXi7Cvl96CKUCF0mxUEFzGQ9+LG/h+Qn/MqoDswB93JEjRnZA1W d+9z9U7WQDueuKrL9XegzZZcanv0bN4oPx8WX5R4SF3wDZtfXiXYqXB0jkZprzU/523Z /bLbIuYNeZo62rG8FujZF41FP8nsZ47PJZiZpO1EyDgZlEjkNB35g/Al9S1TKZLqpsDy C8Rw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=YMM/4xDA/XuveKLA+4AHcwRECrJjIXlnjy/ORkscS5U=; b=lt9H1iROs9/Ny74gveNHrOxQKJOrHPPImf4ONshMp5NbvsYCLWs+6jGAPk0oTcLfCb 6aVXKNVNBag18jVyJIiPESinpINo2U0mn15TEsiLxBkjxBKXKnIFB61zHeERGSLG+/ut VFCV30K80J3wzbZsf1O8Pr0H7nzNxjg7jWaI8zwPywE6i0Dt8uNDEm9R5Uy1agNsra2K Fhny0UsB9ushvEcQBIRiXf4RV9nVrCrhi5l86nPBLdjU3LEvO2O4vmo2nCKSmmbesE5c hRVbEBsZ46PbA1HKi10OSpSi+biV9cTb+eQUISy4Ivg9YN26zf0JU8tW86Vh1hKIyOAN fY0A== X-Gm-Message-State: AOAM533vdgK3cvtLKS7t9d7q/rX6RC1zwG3SaXnmP8Y3MuI5gOUmorvr IeZmZdrMjq4B4XMfBSmW4/gtlw== X-Google-Smtp-Source: ABdhPJzFM5tjdD483851MUzDbE+ToSODkBCl/jpHesj1gTMPOMk1WSMgj55e9vYKOekET9+lOcbVfg== X-Received: by 2002:a65:5c42:: with SMTP id v2mr33772698pgr.339.1618335075427; Tue, 13 Apr 2021 10:31:15 -0700 (PDT) Received: from xps15 (S0106889e681aac74.cg.shawcable.net. [68.147.0.187]) by smtp.gmail.com with ESMTPSA id y193sm13468809pfc.72.2021.04.13.10.31.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Apr 2021 10:31:15 -0700 (PDT) Date: Tue, 13 Apr 2021 11:31:13 -0600 From: Mathieu Poirier To: peng.fan@oss.nxp.com Cc: ohad@wizery.com, bjorn.andersson@linaro.org, o.rempel@pengutronix.de, robh+dt@kernel.org, devicetree@vger.kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-remoteproc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Peng Fan Subject: Re: [PATCH V3 5/8] remoteproc: imx_rproc: parse fsl,auto-boot Message-ID: <20210413173113.GC750651@xps15> References: <1617846898-13662-1-git-send-email-peng.fan@oss.nxp.com> <1617846898-13662-6-git-send-email-peng.fan@oss.nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1617846898-13662-6-git-send-email-peng.fan@oss.nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210413_103118_019026_A32DAAF0 X-CRM114-Status: GOOD ( 26.61 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Apr 08, 2021 at 09:54:55AM +0800, peng.fan@oss.nxp.com wrote: > From: Peng Fan > > Parse fsl,auto-boot to indicate whether need remoteproc framework > auto boot or not. > > When remote processor is booted before Linux Kernel up, do not parse > fsl,auto-boot. So add an entry to store the working mode of remote > processor. Currently only IMX_RPROC_NORMAL, IMX_RPROC_EARLY_BOOT. > > Signed-off-by: Peng Fan > --- > drivers/remoteproc/imx_rproc.c | 20 +++++++++++++++++++- > 1 file changed, 19 insertions(+), 1 deletion(-) > > diff --git a/drivers/remoteproc/imx_rproc.c b/drivers/remoteproc/imx_rproc.c > index ca17f520d904..c576e12d3817 100644 > --- a/drivers/remoteproc/imx_rproc.c > +++ b/drivers/remoteproc/imx_rproc.c > @@ -83,6 +83,16 @@ struct imx_rproc_dcfg { > size_t att_size; > }; > > +enum imx_rproc_mode { > + /* Linux load/kick remote core */ > + IMX_RPROC_NORMAL, > + /* > + * remote core booted before kicking Linux, and remote core > + * could be stopped & restarted by Linux > + */ > + IMX_RPROC_EARLY_BOOT, > +}; > + As far as I can see a new mode to track the state of the remote processor is not needed. rproc->state can do that for you. > struct imx_rproc { > struct device *dev; > struct regmap *regmap; > @@ -96,6 +106,7 @@ struct imx_rproc { > struct work_struct rproc_work; > struct workqueue_struct *workqueue; > void __iomem *rsc_table; > + enum imx_rproc_mode mode; > }; > > static const struct imx_rproc_att imx_rproc_att_imx8mq[] = { > @@ -565,14 +576,18 @@ static int imx_rproc_detect_mode(struct imx_rproc *priv) > int ret; > u32 val; > > + priv->mode = IMX_RPROC_NORMAL; > + > ret = regmap_read(priv->regmap, dcfg->src_reg, &val); > if (ret) { > dev_err(dev, "Failed to read src\n"); > return ret; > } > > - if (!(val & dcfg->src_stop)) > + if (!(val & dcfg->src_stop)) { > + priv->mode = IMX_RPROC_EARLY_BOOT; > priv->rproc->state = RPROC_DETACHED; > + } > > return 0; > } > @@ -654,6 +669,9 @@ static int imx_rproc_probe(struct platform_device *pdev) > > INIT_WORK(&priv->rproc_work, imx_rproc_vq_work); > > + if (priv->mode == IMX_RPROC_NORMAL) > + rproc->auto_boot = of_property_read_bool(np, "fsl,auto-boot"); > + if (rproc->state == RPROC_DETACHED) > ret = rproc_add(rproc); > if (ret) { > dev_err(dev, "rproc_add failed\n"); > -- > 2.30.0 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel