From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51430C43460 for ; Thu, 15 Apr 2021 02:06:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 36214601FC for ; Thu, 15 Apr 2021 02:06:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229669AbhDOCHR (ORCPT ); Wed, 14 Apr 2021 22:07:17 -0400 Received: from mga04.intel.com ([192.55.52.120]:14866 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229449AbhDOCHP (ORCPT ); Wed, 14 Apr 2021 22:07:15 -0400 IronPort-SDR: OAj1+TXC/xDBgbGHh87mJqGcG+AeH130Sdv57AwUnKGs+gMlaGX7hXN7gg5nBbfomPG4Pj6/UG nfDStuembbcg== X-IronPort-AV: E=McAfee;i="6200,9189,9954"; a="192648863" X-IronPort-AV: E=Sophos;i="5.82,223,1613462400"; d="scan'208";a="192648863" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Apr 2021 19:06:53 -0700 IronPort-SDR: XfNeBLI887Qp5AIn4Mtpvqr7TMGB4r1tIYsEOb/+S1DvwzmWZLsPyymzajdWHKDKLzvsRaQDpc FaMdnn/wDzVw== X-IronPort-AV: E=Sophos;i="5.82,223,1613462400"; d="scan'208";a="383874988" Received: from jbrandeb-mobl4.amr.corp.intel.com (HELO localhost) ([10.209.19.126]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Apr 2021 19:06:52 -0700 Date: Wed, 14 Apr 2021 19:06:52 -0700 From: Jesse Brandeburg To: kerneljasonxing@gmail.com, davem@davemloft.net, kuba@kernel.org Cc: anthony.l.nguyen@intel.com, ast@kernel.org, daniel@iogearbox.net, hawk@kernel.org, john.fastabend@gmail.com, andrii@kernel.org, kafai@fb.com, songliubraving@fb.com, yhs@fb.com, kpsingh@kernel.org, intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org, Jason Xing , Shujin Li Subject: Re: [PATCH net v3] i40e: fix the panic when running bpf in xdpdrv mode Message-ID: <20210414190652.00006680@intel.com> In-Reply-To: <20210414023428.10121-1-kerneljasonxing@gmail.com> References: <20210413025011.1251-1-kerneljasonxing@gmail.com> <20210414023428.10121-1-kerneljasonxing@gmail.com> X-Mailer: Claws Mail 3.12.0 (GTK+ 2.24.28; i686-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org kerneljasonxing@gmail.com wrote: > From: Jason Xing > > Fix this panic by adding more rules to calculate the value of @rss_size_max > which could be used in allocating the queues when bpf is loaded, which, > however, could cause the failure and then trigger the NULL pointer of > vsi->rx_rings. Prio to this fix, the machine doesn't care about how many > cpus are online and then allocates 256 queues on the machine with 32 cpus > online actually. > > Once the load of bpf begins, the log will go like this "failed to get > tracking for 256 queues for VSI 0 err -12" and this "setup of MAIN VSI > failed". > > Thus, I attach the key information of the crash-log here. > > BUG: unable to handle kernel NULL pointer dereference at > 0000000000000000 > RIP: 0010:i40e_xdp+0xdd/0x1b0 [i40e] > Call Trace: > [2160294.717292] ? i40e_reconfig_rss_queues+0x170/0x170 [i40e] > [2160294.717666] dev_xdp_install+0x4f/0x70 > [2160294.718036] dev_change_xdp_fd+0x11f/0x230 > [2160294.718380] ? dev_disable_lro+0xe0/0xe0 > [2160294.718705] do_setlink+0xac7/0xe70 > [2160294.719035] ? __nla_parse+0xed/0x120 > [2160294.719365] rtnl_newlink+0x73b/0x860 > > Fixes: 41c445ff0f48 ("i40e: main driver core") > Co-developed-by: Shujin Li > Signed-off-by: Shujin Li > Signed-off-by: Jason Xing Reviewed-by: Jesse Brandeburg @Jakub/@DaveM - feel free to apply this directly. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jesse Brandeburg Date: Wed, 14 Apr 2021 19:06:52 -0700 Subject: [Intel-wired-lan] [PATCH net v3] i40e: fix the panic when running bpf in xdpdrv mode In-Reply-To: <20210414023428.10121-1-kerneljasonxing@gmail.com> References: <20210413025011.1251-1-kerneljasonxing@gmail.com> <20210414023428.10121-1-kerneljasonxing@gmail.com> Message-ID: <20210414190652.00006680@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: intel-wired-lan@osuosl.org List-ID: kerneljasonxing at gmail.com wrote: > From: Jason Xing > > Fix this panic by adding more rules to calculate the value of @rss_size_max > which could be used in allocating the queues when bpf is loaded, which, > however, could cause the failure and then trigger the NULL pointer of > vsi->rx_rings. Prio to this fix, the machine doesn't care about how many > cpus are online and then allocates 256 queues on the machine with 32 cpus > online actually. > > Once the load of bpf begins, the log will go like this "failed to get > tracking for 256 queues for VSI 0 err -12" and this "setup of MAIN VSI > failed". > > Thus, I attach the key information of the crash-log here. > > BUG: unable to handle kernel NULL pointer dereference at > 0000000000000000 > RIP: 0010:i40e_xdp+0xdd/0x1b0 [i40e] > Call Trace: > [2160294.717292] ? i40e_reconfig_rss_queues+0x170/0x170 [i40e] > [2160294.717666] dev_xdp_install+0x4f/0x70 > [2160294.718036] dev_change_xdp_fd+0x11f/0x230 > [2160294.718380] ? dev_disable_lro+0xe0/0xe0 > [2160294.718705] do_setlink+0xac7/0xe70 > [2160294.719035] ? __nla_parse+0xed/0x120 > [2160294.719365] rtnl_newlink+0x73b/0x860 > > Fixes: 41c445ff0f48 ("i40e: main driver core") > Co-developed-by: Shujin Li > Signed-off-by: Shujin Li > Signed-off-by: Jason Xing Reviewed-by: Jesse Brandeburg @Jakub/@DaveM - feel free to apply this directly.