Hi Mike,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on mkp-scsi/for-next]
[also build test WARNING on scsi/for-next rdma/for-next v5.12-rc7 next-20210413]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Mike-Christie/scsi-libicsi-and-qedi-tmf-fixes/20210414-072516
base:   https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git for-next
config: x86_64-randconfig-m001-20210414 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

smatch warnings:
drivers/scsi/qedi/qedi_iscsi.c:1401 qedi_cleanup_task() warn: always true condition '(cmd->task_id != -1) => (0-u16max != (-1))'

vim +1401 drivers/scsi/qedi/qedi_iscsi.c

  1386	
  1387	static void qedi_cleanup_task(struct iscsi_task *task)
  1388	{
  1389		struct qedi_cmd *cmd;
  1390	
  1391		if (task->state == ISCSI_TASK_PENDING) {
  1392			QEDI_INFO(NULL, QEDI_LOG_IO, "Returning ref_cnt=%d\n",
  1393				  refcount_read(&task->refcount));
  1394			return;
  1395		}
  1396	
  1397		if (task->sc)
  1398			qedi_iscsi_unmap_sg_list(task->dd_data);
  1399	
  1400		cmd = task->dd_data;
> 1401		if (cmd->task_id != -1)
  1402			qedi_clear_task_idx(iscsi_host_priv(task->conn->session->host),
  1403					    cmd->task_id);
  1404	
  1405		cmd->task_id = -1;
  1406		cmd->scsi_cmd = NULL;
  1407	}
  1408	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org