[meta-virtualization][PATCH v2 1/6] xen-tools: fix 32-bit x86 build by setting pvshim configure flags

[meta-virtualization][PATCH v2 1/6] xen-tools: fix 32-bit x86 build by setting pvshim configure flags

[Christopher Clark]

Enable building the PV shim for x86_64 only.

Signed-off-by: Christopher Clark <christopher.w.clark@gmail.com>
---
 recipes-extended/xen/xen.inc | 1 +
 1 file changed, 1 insertion(+)

diff --git a/recipes-extended/xen/xen.inc b/recipes-extended/xen/xen.inc
index 9e8fcad..2fbdb3a 100644
--- a/recipes-extended/xen/xen.inc
+++ b/recipes-extended/xen/xen.inc
@@ -125,6 +125,7 @@ EXTRA_OECONF += " \
     --disable-rombios \
     --disable-ocamltools \
     --disable-qemu-traditional \
+    ${@bb.utils.contains('XEN_TARGET_ARCH', 'x86_64', '--enable-pvshim', '--disable-pvshim', d)} \
     "
 
 EXTRA_OEMAKE += "STDVGA_ROM=${STAGING_DIR_HOST}/usr/share/firmware/vgabios-0.7a.bin"
-- 
2.25.1

[meta-virtualization][PATCH v2 2/6] xen, xen-tools: add recipes for new stable Xen 4.15 release

[Christopher Clark]

Added as non-default, retaining the Xen 4.14 recipes as the default
preferred version for the Hardknott release.

Signed-off-by: Christopher Clark <christopher.w.clark@gmail.com>
---
 recipes-extended/xen/xen-tools_4.15.bb | 20 ++++++++++++++++++++
 recipes-extended/xen/xen_4.15.bb       | 21 +++++++++++++++++++++
 2 files changed, 41 insertions(+)
 create mode 100644 recipes-extended/xen/xen-tools_4.15.bb
 create mode 100644 recipes-extended/xen/xen_4.15.bb

diff --git a/recipes-extended/xen/xen-tools_4.15.bb b/recipes-extended/xen/xen-tools_4.15.bb
new file mode 100644
index 0000000..d8cb846
--- /dev/null
+++ b/recipes-extended/xen/xen-tools_4.15.bb
@@ -0,0 +1,20 @@
+SRCREV ?= "e25aa9939ae0cd8317605be3d5c5611b76bc4ab4"
+
+XEN_REL ?= "4.15"
+XEN_BRANCH ?= "stable-${XEN_REL}"
+
+SRC_URI = " \
+    git://xenbits.xen.org/xen.git;branch=${XEN_BRANCH} \
+    file://0001-python-pygrub-pass-DISTUTILS-xen-4.15.patch \
+    "
+
+LIC_FILES_CHKSUM ?= "file://COPYING;md5=419739e325a50f3d7b4501338e44a4e5"
+
+PV = "${XEN_REL}+stable${SRCPV}"
+
+S = "${WORKDIR}/git"
+
+DEFAULT_PREFERENCE ??= "-1"
+
+require xen.inc
+require xen-tools.inc
diff --git a/recipes-extended/xen/xen_4.15.bb b/recipes-extended/xen/xen_4.15.bb
new file mode 100644
index 0000000..49268cc
--- /dev/null
+++ b/recipes-extended/xen/xen_4.15.bb
@@ -0,0 +1,21 @@
+SRCREV ?= "e25aa9939ae0cd8317605be3d5c5611b76bc4ab4"
+
+XEN_REL ?= "4.15"
+XEN_BRANCH ?= "stable-${XEN_REL}"
+
+SRC_URI = " \
+    git://xenbits.xen.org/xen.git;branch=${XEN_BRANCH} \
+    file://xen-arm64-implement-atomic-fetch-add.patch \
+    file://0001-menuconfig-mconf-cfg-Allow-specification-of-ncurses-location.patch \
+    "
+
+LIC_FILES_CHKSUM ?= "file://COPYING;md5=419739e325a50f3d7b4501338e44a4e5"
+
+PV = "${XEN_REL}+stable${SRCPV}"
+
+S = "${WORKDIR}/git"
+
+DEFAULT_PREFERENCE ??= "-1"
+
+require xen.inc
+require xen-hypervisor.inc
-- 
2.25.1

[meta-virtualization][PATCH v2 3/6] xen, xen-tools: uprev git recipes after 4.15 release

[Christopher Clark]

Updated to the branch point for 4.16 development.

Signed-off-by: Christopher Clark <christopher.w.clark@gmail.com>
---
 recipes-extended/xen/xen-tools_git.bb | 4 ++--
 recipes-extended/xen/xen_git.bb       | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/recipes-extended/xen/xen-tools_git.bb b/recipes-extended/xen/xen-tools_git.bb
index 71850ee..0188bdd 100644
--- a/recipes-extended/xen/xen-tools_git.bb
+++ b/recipes-extended/xen/xen-tools_git.bb
@@ -1,6 +1,6 @@
-SRCREV ?= "9dc687f155a57216b83b17f9cde55dd43e06b0cd"
+SRCREV ?= "e680cc48b7184d3489873d6776f84ba1fc238ced"
 
-XEN_REL ?= "4.15"
+XEN_REL ?= "4.16"
 XEN_BRANCH ?= "master"
 
 SRC_URI = " \
diff --git a/recipes-extended/xen/xen_git.bb b/recipes-extended/xen/xen_git.bb
index 2b62c5c..eaf3956 100644
--- a/recipes-extended/xen/xen_git.bb
+++ b/recipes-extended/xen/xen_git.bb
@@ -1,6 +1,6 @@
-SRCREV ?= "9dc687f155a57216b83b17f9cde55dd43e06b0cd"
+SRCREV ?= "e680cc48b7184d3489873d6776f84ba1fc238ced"
 
-XEN_REL ?= "4.15"
+XEN_REL ?= "4.16"
 XEN_BRANCH ?= "master"
 
 SRC_URI = " \
-- 
2.25.1

[meta-virtualization][PATCH v2 4/6] xen, xen-tools: Document the version update process in README

[Christopher Clark]

Describes the versions of Xen to be included in meta-virtualization
and recipe maintenance in release branches.

Signed-off-by: Christopher Clark <christopher.w.clark@gmail.com>
---
 recipes-extended/xen/README | 50 +++++++++++++++++++++++++++++++++++++
 1 file changed, 50 insertions(+)

diff --git a/recipes-extended/xen/README b/recipes-extended/xen/README
index f286bb5..b9117f0 100644
--- a/recipes-extended/xen/README
+++ b/recipes-extended/xen/README
@@ -36,3 +36,53 @@ as XSAs (http://xenbits.xen.org/xsa/). The easiest way to include those is to
 drop patches in 'recipes-extened/xen/files' and create a bbappend adding those
 patches to SRC_URI and they will be applied. Alternatively, you can override
 the SRC_URI to a git repo you provide that contains the patches.
+
+recipe maintenance
+------------------
+
+# Xen version update
+
+The following rules shall be followed to define which versions of Xen have
+recipes in meta-virtualization:
+
+- Before a Yocto release meta-virtualization shall have recipes for:
+    - the latest stable major version of Xen, and
+
+    - the current version of the Xen master branch (known as the git recipes)
+
+    - In addition, there may also be recipes included for the previous stable
+      major version of Xen, in the case where the latest stable major version
+      is new and the prior stable major version of Xen is to be the preferred
+      version for the Yocto release
+
+- On Yocto LTS and the latest stable Yocto release branch, the preferred Xen
+  major version that is present when the Yocto release is issued must stay
+  supported and the recipes shall be regularly updated to follow updates
+  available in the Xen stable branch for that Xen major release.
+
+- On Yocto LTS and the latest stable Yocto release branch, the recipes for the
+  latest Xen major version shall also be regularly updated to follow updates
+  available in the Xen stable branch for that Xen major release.
+
+- On the master / in-development Yocto branch, new Xen recipes shall be added
+  when there is a new Xen major release.
+
+    - depending on the timing of the next Yocto release, the new recipes may
+      be preferred, or the prior major version recipes may remain preferred
+      until after the Yocto release
+
+    - the recipes for the previous Xen stable major version shall be removed
+      from the branch when it is no longer the preferred Xen version
+
+- On Yocto LTS and the latest stable Yocto release branch, new Xen recipes
+  shall be added when there is a new Xen major release.
+
+    - The preferred version of the Xen recipes shall always stay at the same
+      Xen major version once a Yocto release has been issued, and shall receive
+      regular updates to track the stable Xen branch of that Xen release.
+
+    - When new Xen recipes are added to a Yocto branch for a new Xen major
+      version, then any older Xen recipes present, except for the original
+      preferred version recipes, shall be marked as not updated anymore by
+      adding a comment inside the recipes. The older recipes will not receive
+      any build tests or be updated to follow the Xen branch.
-- 
2.25.1

[meta-virtualization][PATCH v2 5/6] xtf: introduce recipe for the Xen Test Framework

[Christopher Clark]

Signed-off-by: Christopher Clark <christopher.w.clark@gmail.com>
---
 recipes-extended/xen/xtf_git.bb | 72 +++++++++++++++++++++++++++++++++
 1 file changed, 72 insertions(+)
 create mode 100644 recipes-extended/xen/xtf_git.bb

diff --git a/recipes-extended/xen/xtf_git.bb b/recipes-extended/xen/xtf_git.bb
new file mode 100644
index 0000000..db08643
--- /dev/null
+++ b/recipes-extended/xen/xtf_git.bb
@@ -0,0 +1,72 @@
+SUMMARY = "Xen Test Framework"
+HOMEPAGE = "https://xenbits.xenproject.org/docs/xtf/"
+LICENSE = "BSD-2-Clause"
+
+# For additional reference on XTF, please see:
+# https://static.sched.com/hosted_files/xendeveloperanddesignsummit2017/79/xtf.pdf
+
+SRC_URI = "git://xenbits.xen.org/xtf"
+SRCREV = "8ab15139728a8efd3ebbb60beb16a958a6a93fa1"
+
+COMPATIBLE_HOST = '(x86_64.*).*-linux'
+
+LIC_FILES_CHKSUM = "file://COPYING;md5=a5680865974e05cf0510615ee1d745d8"
+
+PV = "0+git${SRCPV}"
+
+S = "${WORKDIR}/git"
+
+inherit python3native
+
+# To build 32-bit binaries some files from 32-bit glibc are needed.
+# To enable multilib, please add the following to your local.conf -:
+#
+#    require conf/multilib.conf
+#    MULTILIBS = "multilib:lib32"
+#    DEFAULTTUNE_virtclass-multilib-lib32 = "x86"
+
+# Use this multilib prefix for x86 32-bit to match local.conf:
+MLPREFIX32 = "lib32-"
+# Add the multilib 32-bit glibc to DEPENDS only when necessary:
+# The DEPENDS on a multilib 32-bit glibc is only added when target is x86-64
+# This x86-64 override is never intended for native use, so clear that.
+GLIBC32 = ""
+GLIBC32_x86-64 = "${MLPREFIX32}glibc"
+GLIBC32_class-native = ""
+DEPENDS += "${GLIBC32}"
+
+PACKAGES = "${PN}"
+
+FILES_${PN} = " \
+    ${libexecdir}/* \
+    "
+
+RDEPENDS_${PN} = " \
+    xen-tools-xl \
+    python3 \
+    "
+
+do_compile() {
+    oe_runmake CC="${TARGET_PREFIX}gcc ${TOOLCHAIN_OPTIONS} -I${RECIPE_SYSROOT}/../${MLPREFIX32}recipe-sysroot/usr/include" \
+               CPP="${CPP}" \
+               OBJCOPY="${OBJCOPY}" \
+               PYTHON="${PYTHON}"
+    # switch the shebang to python3
+    sed 's,^\(#!/usr/bin/env python\)$,\13,' -i "${B}/xtf-runner"
+}
+
+do_install() {
+    # packaging: rpmbuild can package the XTF test unikernels when they are
+    # installed as non-executable files (they are run within VMs anyway).
+    oe_runmake install DESTDIR="${D}" \
+                       xtfdir="${libexecdir}/${BPN}" \
+                       PYTHON="${PYTHON}" \
+                       INSTALL_PROGRAM="install -m 644 -p"
+    install -m 755 -p "${B}/xtf-runner" "${D}${libexecdir}/${BPN}/xtf-runner"
+}
+
+INSANE_SKIP = "arch"
+# xen-tools-xl is a runtime but not build time dependency
+INSANE_SKIP_${PN} = "build-deps"
+INHIBIT_PACKAGE_STRIP = "1"
+INHIBIT_PACKAGE_DEBUG_SPLIT = "1"
-- 
2.25.1

[meta-virtualization][PATCH v2 6/6] xtf-image: add a new image for the Xen Test Framework

[Christopher Clark]

Testing the Xen hypervisor, with the qemux86-64 MACHINE:
    runqemu xtf-image nographic slirp
        (login as root)
        cd /usr/libexec/xtf
        ./xtf-runner --list pv
        # run an example test:
        ./xtf-runner test-pv64-livepatch-priv-check

Signed-off-by: Christopher Clark <christopher.w.clark@gmail.com>
---
 recipes-extended/images/xtf-image.bb | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)
 create mode 100644 recipes-extended/images/xtf-image.bb

diff --git a/recipes-extended/images/xtf-image.bb b/recipes-extended/images/xtf-image.bb
new file mode 100644
index 0000000..3f9af25
--- /dev/null
+++ b/recipes-extended/images/xtf-image.bb
@@ -0,0 +1,24 @@
+require recipes-extended/images/xen-image-minimal.bb
+DESCRIPTION = "A minimal Xen Test Framework (XTF) image for testing the Xen hypervisor"
+
+# To run XTF tests with an image built for the qemux86-64 MACHINE:
+#
+#   runqemu xtf-image nographic slirp
+#       (login as root)
+#       # xtf-runner expects to be run from the top of the tests directory:
+#       cd /usr/libexec/xtf
+#       # list the tests available for PV guest types:
+#       ./xtf-runner --list pv
+#       # run an example test:
+#       ./xtf-runner test-pv64-livepatch-priv-check
+
+IMAGE_NAME="xtf"
+
+IMAGE_INSTALL_append = " xtf"
+
+QB_DEFAULT_FSTYPE = "wic"
+
+# Set the dom0 memory level lower than that assigned to qemu so that Xen has
+# some available memory for allocating to the XTF microkernel guests to run:
+QB_MEM = "-m 400"
+SYSLINUX_XEN_ARGS_append = " dom0_mem=256M"
-- 
2.25.1

Re: [meta-virtualization][PATCH v2 2/6] xen, xen-tools: add recipes for new stable Xen 4.15 release

[Bertrand Marquis]

Hi Christopher,

> On 15 Apr 2021, at 00:39, Christopher Clark via lists.yoctoproject.org <christopher.w.clark=gmail.com@lists.yoctoproject.org> wrote:
>
> Added as non-default, retaining the Xen 4.14 recipes as the default
> preferred version for the Hardknott release.
>
> Signed-off-by: Christopher Clark <christopher.w.clark@gmail.com>
> ---
> recipes-extended/xen/xen-tools_4.15.bb | 20 ++++++++++++++++++++
> recipes-extended/xen/xen_4.15.bb       | 21 +++++++++++++++++++++
> 2 files changed, 41 insertions(+)
> create mode 100644 recipes-extended/xen/xen-tools_4.15.bb
> create mode 100644 recipes-extended/xen/xen_4.15.bb
>
> diff --git a/recipes-extended/xen/xen-tools_4.15.bb b/recipes-extended/xen/xen-tools_4.15.bb
> new file mode 100644
> index 0000000..d8cb846
> --- /dev/null
> +++ b/recipes-extended/xen/xen-tools_4.15.bb
> @@ -0,0 +1,20 @@
> +SRCREV ?= "e25aa9939ae0cd8317605be3d5c5611b76bc4ab4"
> +
> +XEN_REL ?= "4.15"
> +XEN_BRANCH ?= "stable-${XEN_REL}"
> +
> +SRC_URI = " \
> +    git://xenbits.xen.org/xen.git;branch=${XEN_BRANCH} \
> +    file://0001-python-pygrub-pass-DISTUTILS-xen-4.15.patch \
> +    "
> +
> +LIC_FILES_CHKSUM ?= "file://COPYING;md5=419739e325a50f3d7b4501338e44a4e5"
> +
> +PV = "${XEN_REL}+stable${SRCPV}"
> +
> +S = "${WORKDIR}/git"
> +
> +DEFAULT_PREFERENCE ??= "-1"

we have a file meta-virt-default-versions.inc in conf/distro/include

Shouldn’t we use that file and set PREFERRED_VERSION instead of using default
preference in each recipe ?

Something like:
PREFERRED_VERSION_xen ?= "4.14%"
PREFERRED_VERSION_xen-tools ?= "4.14%"

This would prevent modifying the recipes when we change the default version.

Cheers
Bertrand

> +
> +require xen.inc
> +require xen-tools.inc
> diff --git a/recipes-extended/xen/xen_4.15.bb b/recipes-extended/xen/xen_4.15.bb
> new file mode 100644
> index 0000000..49268cc
> --- /dev/null
> +++ b/recipes-extended/xen/xen_4.15.bb
> @@ -0,0 +1,21 @@
> +SRCREV ?= "e25aa9939ae0cd8317605be3d5c5611b76bc4ab4"
> +
> +XEN_REL ?= "4.15"
> +XEN_BRANCH ?= "stable-${XEN_REL}"
> +
> +SRC_URI = " \
> +    git://xenbits.xen.org/xen.git;branch=${XEN_BRANCH} \
> +    file://xen-arm64-implement-atomic-fetch-add.patch \
> +    file://0001-menuconfig-mconf-cfg-Allow-specification-of-ncurses-location.patch \
> +    "
> +
> +LIC_FILES_CHKSUM ?= "file://COPYING;md5=419739e325a50f3d7b4501338e44a4e5"
> +
> +PV = "${XEN_REL}+stable${SRCPV}"
> +
> +S = "${WORKDIR}/git"
> +
> +DEFAULT_PREFERENCE ??= "-1"
> +
> +require xen.inc
> +require xen-hypervisor.inc
> --
> 2.25.1
>
>
> 
>

IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.

Re: [meta-virtualization][PATCH v2 1/6] xen-tools: fix 32-bit x86 build by setting pvshim configure flags

[Bertrand Marquis]

Hi Christopher,

> On 15 Apr 2021, at 00:39, Christopher Clark via lists.yoctoproject.org <christopher.w.clark=gmail.com@lists.yoctoproject.org> wrote:
>
> Enable building the PV shim for x86_64 only.
>
> Signed-off-by: Christopher Clark <christopher.w.clark@gmail.com>
Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>

Cheers
Bertrand

> ---
> recipes-extended/xen/xen.inc | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/recipes-extended/xen/xen.inc b/recipes-extended/xen/xen.inc
> index 9e8fcad..2fbdb3a 100644
> --- a/recipes-extended/xen/xen.inc
> +++ b/recipes-extended/xen/xen.inc
> @@ -125,6 +125,7 @@ EXTRA_OECONF += " \
>     --disable-rombios \
>     --disable-ocamltools \
>     --disable-qemu-traditional \
> +    ${@bb.utils.contains('XEN_TARGET_ARCH', 'x86_64', '--enable-pvshim', '--disable-pvshim', d)} \
>     "
>
> EXTRA_OEMAKE += "STDVGA_ROM=${STAGING_DIR_HOST}/usr/share/firmware/vgabios-0.7a.bin"
> --
> 2.25.1
>
>
> 
>

IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.

Re: [meta-virtualization][PATCH v2 3/6] xen, xen-tools: uprev git recipes after 4.15 release

[Bertrand Marquis]

Hi,

> On 15 Apr 2021, at 00:39, Christopher Clark via lists.yoctoproject.org <christopher.w.clark=gmail.com@lists.yoctoproject.org> wrote:
> 
> Updated to the branch point for 4.16 development.
> 
> Signed-off-by: Christopher Clark <christopher.w.clark@gmail.com>
Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>

Cheers
Bertrand

> ---
> recipes-extended/xen/xen-tools_git.bb | 4 ++--
> recipes-extended/xen/xen_git.bb       | 4 ++--
> 2 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/recipes-extended/xen/xen-tools_git.bb b/recipes-extended/xen/xen-tools_git.bb
> index 71850ee..0188bdd 100644
> --- a/recipes-extended/xen/xen-tools_git.bb
> +++ b/recipes-extended/xen/xen-tools_git.bb
> @@ -1,6 +1,6 @@
> -SRCREV ?= "9dc687f155a57216b83b17f9cde55dd43e06b0cd"
> +SRCREV ?= "e680cc48b7184d3489873d6776f84ba1fc238ced"
> 
> -XEN_REL ?= "4.15"
> +XEN_REL ?= "4.16"
> XEN_BRANCH ?= "master"
> 
> SRC_URI = " \
> diff --git a/recipes-extended/xen/xen_git.bb b/recipes-extended/xen/xen_git.bb
> index 2b62c5c..eaf3956 100644
> --- a/recipes-extended/xen/xen_git.bb
> +++ b/recipes-extended/xen/xen_git.bb
> @@ -1,6 +1,6 @@
> -SRCREV ?= "9dc687f155a57216b83b17f9cde55dd43e06b0cd"
> +SRCREV ?= "e680cc48b7184d3489873d6776f84ba1fc238ced"
> 
> -XEN_REL ?= "4.15"
> +XEN_REL ?= "4.16"
> XEN_BRANCH ?= "master"
> 
> SRC_URI = " \
> -- 
> 2.25.1
> 
> 
> 
> 

Re: [meta-virtualization][PATCH v2 4/6] xen, xen-tools: Document the version update process in README

[Bertrand Marquis]

Hi,

> On 15 Apr 2021, at 00:39, Christopher Clark via lists.yoctoproject.org <christopher.w.clark=gmail.com@lists.yoctoproject.org> wrote:
>
> Describes the versions of Xen to be included in meta-virtualization
> and recipe maintenance in release branches.
>
> Signed-off-by: Christopher Clark <christopher.w.clark@gmail.com>
Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>

Cheers
Bertrand

> ---
> recipes-extended/xen/README | 50 +++++++++++++++++++++++++++++++++++++
> 1 file changed, 50 insertions(+)
>
> diff --git a/recipes-extended/xen/README b/recipes-extended/xen/README
> index f286bb5..b9117f0 100644
> --- a/recipes-extended/xen/README
> +++ b/recipes-extended/xen/README
> @@ -36,3 +36,53 @@ as XSAs (http://xenbits.xen.org/xsa/). The easiest way to include those is to
> drop patches in 'recipes-extened/xen/files' and create a bbappend adding those
> patches to SRC_URI and they will be applied. Alternatively, you can override
> the SRC_URI to a git repo you provide that contains the patches.
> +
> +recipe maintenance
> +------------------
> +
> +# Xen version update
> +
> +The following rules shall be followed to define which versions of Xen have
> +recipes in meta-virtualization:
> +
> +- Before a Yocto release meta-virtualization shall have recipes for:
> +    - the latest stable major version of Xen, and
> +
> +    - the current version of the Xen master branch (known as the git recipes)
> +
> +    - In addition, there may also be recipes included for the previous stable
> +      major version of Xen, in the case where the latest stable major version
> +      is new and the prior stable major version of Xen is to be the preferred
> +      version for the Yocto release
> +
> +- On Yocto LTS and the latest stable Yocto release branch, the preferred Xen
> +  major version that is present when the Yocto release is issued must stay
> +  supported and the recipes shall be regularly updated to follow updates
> +  available in the Xen stable branch for that Xen major release.
> +
> +- On Yocto LTS and the latest stable Yocto release branch, the recipes for the
> +  latest Xen major version shall also be regularly updated to follow updates
> +  available in the Xen stable branch for that Xen major release.
> +
> +- On the master / in-development Yocto branch, new Xen recipes shall be added
> +  when there is a new Xen major release.
> +
> +    - depending on the timing of the next Yocto release, the new recipes may
> +      be preferred, or the prior major version recipes may remain preferred
> +      until after the Yocto release
> +
> +    - the recipes for the previous Xen stable major version shall be removed
> +      from the branch when it is no longer the preferred Xen version
> +
> +- On Yocto LTS and the latest stable Yocto release branch, new Xen recipes
> +  shall be added when there is a new Xen major release.
> +
> +    - The preferred version of the Xen recipes shall always stay at the same
> +      Xen major version once a Yocto release has been issued, and shall receive
> +      regular updates to track the stable Xen branch of that Xen release.
> +
> +    - When new Xen recipes are added to a Yocto branch for a new Xen major
> +      version, then any older Xen recipes present, except for the original
> +      preferred version recipes, shall be marked as not updated anymore by
> +      adding a comment inside the recipes. The older recipes will not receive
> +      any build tests or be updated to follow the Xen branch.
> --
> 2.25.1
>
>
> 
>

IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.

Re: [meta-virtualization][PATCH v2 5/6] xtf: introduce recipe for the Xen Test Framework

[Bertrand Marquis]

Hi,

> On 15 Apr 2021, at 00:39, Christopher Clark via lists.yoctoproject.org <christopher.w.clark=gmail.com@lists.yoctoproject.org> wrote:
> 
> Signed-off-by: Christopher Clark <christopher.w.clark@gmail.com>
Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>

All is now building properly on my side :-)

Cheers
Bertrand

> ---
> recipes-extended/xen/xtf_git.bb | 72 +++++++++++++++++++++++++++++++++
> 1 file changed, 72 insertions(+)
> create mode 100644 recipes-extended/xen/xtf_git.bb
> 
> diff --git a/recipes-extended/xen/xtf_git.bb b/recipes-extended/xen/xtf_git.bb
> new file mode 100644
> index 0000000..db08643
> --- /dev/null
> +++ b/recipes-extended/xen/xtf_git.bb
> @@ -0,0 +1,72 @@
> +SUMMARY = "Xen Test Framework"
> +HOMEPAGE = "https://xenbits.xenproject.org/docs/xtf/"
> +LICENSE = "BSD-2-Clause"
> +
> +# For additional reference on XTF, please see:
> +# https://static.sched.com/hosted_files/xendeveloperanddesignsummit2017/79/xtf.pdf
> +
> +SRC_URI = "git://xenbits.xen.org/xtf"
> +SRCREV = "8ab15139728a8efd3ebbb60beb16a958a6a93fa1"
> +
> +COMPATIBLE_HOST = '(x86_64.*).*-linux'
> +
> +LIC_FILES_CHKSUM = "file://COPYING;md5=a5680865974e05cf0510615ee1d745d8"
> +
> +PV = "0+git${SRCPV}"
> +
> +S = "${WORKDIR}/git"
> +
> +inherit python3native
> +
> +# To build 32-bit binaries some files from 32-bit glibc are needed.
> +# To enable multilib, please add the following to your local.conf -:
> +#
> +#    require conf/multilib.conf
> +#    MULTILIBS = "multilib:lib32"
> +#    DEFAULTTUNE_virtclass-multilib-lib32 = "x86"
> +
> +# Use this multilib prefix for x86 32-bit to match local.conf:
> +MLPREFIX32 = "lib32-"
> +# Add the multilib 32-bit glibc to DEPENDS only when necessary:
> +# The DEPENDS on a multilib 32-bit glibc is only added when target is x86-64
> +# This x86-64 override is never intended for native use, so clear that.
> +GLIBC32 = ""
> +GLIBC32_x86-64 = "${MLPREFIX32}glibc"
> +GLIBC32_class-native = ""
> +DEPENDS += "${GLIBC32}"
> +
> +PACKAGES = "${PN}"
> +
> +FILES_${PN} = " \
> +    ${libexecdir}/* \
> +    "
> +
> +RDEPENDS_${PN} = " \
> +    xen-tools-xl \
> +    python3 \
> +    "
> +
> +do_compile() {
> +    oe_runmake CC="${TARGET_PREFIX}gcc ${TOOLCHAIN_OPTIONS} -I${RECIPE_SYSROOT}/../${MLPREFIX32}recipe-sysroot/usr/include" \
> +               CPP="${CPP}" \
> +               OBJCOPY="${OBJCOPY}" \
> +               PYTHON="${PYTHON}"
> +    # switch the shebang to python3
> +    sed 's,^\(#!/usr/bin/env python\)$,\13,' -i "${B}/xtf-runner"
> +}
> +
> +do_install() {
> +    # packaging: rpmbuild can package the XTF test unikernels when they are
> +    # installed as non-executable files (they are run within VMs anyway).
> +    oe_runmake install DESTDIR="${D}" \
> +                       xtfdir="${libexecdir}/${BPN}" \
> +                       PYTHON="${PYTHON}" \
> +                       INSTALL_PROGRAM="install -m 644 -p"
> +    install -m 755 -p "${B}/xtf-runner" "${D}${libexecdir}/${BPN}/xtf-runner"
> +}
> +
> +INSANE_SKIP = "arch"
> +# xen-tools-xl is a runtime but not build time dependency
> +INSANE_SKIP_${PN} = "build-deps"
> +INHIBIT_PACKAGE_STRIP = "1"
> +INHIBIT_PACKAGE_DEBUG_SPLIT = "1"
> -- 
> 2.25.1
> 
> 
> 
> 

Re: [meta-virtualization][PATCH v2 6/6] xtf-image: add a new image for the Xen Test Framework

[Bertrand Marquis]

Hi,

> On 15 Apr 2021, at 00:39, Christopher Clark <christopher.w.clark@gmail.com> wrote:
> 
> Testing the Xen hypervisor, with the qemux86-64 MACHINE:
>    runqemu xtf-image nographic slirp
>        (login as root)
>        cd /usr/libexec/xtf
>        ./xtf-runner --list pv
>        # run an example test:
>        ./xtf-runner test-pv64-livepatch-priv-check
> 
> Signed-off-by: Christopher Clark <christopher.w.clark@gmail.com>

NIT: Maybe the image could also be filtered for x86.

Funnily i get an error when doing bitbake xtf-image on arm64 as xtf
is not compatible but when doing it for arm32 it is packing something
even though bitbake xtf is not working as expected.

Anyway not something blocking more a suggestion so:
Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>

Cheers
Bertrand

> ---
> recipes-extended/images/xtf-image.bb | 24 ++++++++++++++++++++++++
> 1 file changed, 24 insertions(+)
> create mode 100644 recipes-extended/images/xtf-image.bb
> 
> diff --git a/recipes-extended/images/xtf-image.bb b/recipes-extended/images/xtf-image.bb
> new file mode 100644
> index 0000000..3f9af25
> --- /dev/null
> +++ b/recipes-extended/images/xtf-image.bb
> @@ -0,0 +1,24 @@
> +require recipes-extended/images/xen-image-minimal.bb
> +DESCRIPTION = "A minimal Xen Test Framework (XTF) image for testing the Xen hypervisor"
> +
> +# To run XTF tests with an image built for the qemux86-64 MACHINE:
> +#
> +#   runqemu xtf-image nographic slirp
> +#       (login as root)
> +#       # xtf-runner expects to be run from the top of the tests directory:
> +#       cd /usr/libexec/xtf
> +#       # list the tests available for PV guest types:
> +#       ./xtf-runner --list pv
> +#       # run an example test:
> +#       ./xtf-runner test-pv64-livepatch-priv-check
> +
> +IMAGE_NAME="xtf"
> +
> +IMAGE_INSTALL_append = " xtf"
> +
> +QB_DEFAULT_FSTYPE = "wic"
> +
> +# Set the dom0 memory level lower than that assigned to qemu so that Xen has
> +# some available memory for allocating to the XTF microkernel guests to run:
> +QB_MEM = "-m 400"
> +SYSLINUX_XEN_ARGS_append = " dom0_mem=256M"
> -- 
> 2.25.1
> 

Re: [meta-virtualization][PATCH v2 2/6] xen, xen-tools: add recipes for new stable Xen 4.15 release

[Christopher Clark]

On Thu, Apr 15, 2021 at 2:12 AM Bertrand Marquis
<Bertrand.Marquis@arm.com> wrote:
>
> Hi Christopher,
>
> > On 15 Apr 2021, at 00:39, Christopher Clark via lists.yoctoproject.org <christopher.w.clark=gmail.com@lists.yoctoproject.org> wrote:
> >
> > Added as non-default, retaining the Xen 4.14 recipes as the default
> > preferred version for the Hardknott release.
> >
> > Signed-off-by: Christopher Clark <christopher.w.clark@gmail.com>
> > ---
> > recipes-extended/xen/xen-tools_4.15.bb | 20 ++++++++++++++++++++
> > recipes-extended/xen/xen_4.15.bb       | 21 +++++++++++++++++++++
> > 2 files changed, 41 insertions(+)
> > create mode 100644 recipes-extended/xen/xen-tools_4.15.bb
> > create mode 100644 recipes-extended/xen/xen_4.15.bb
> >
> > diff --git a/recipes-extended/xen/xen-tools_4.15.bb b/recipes-extended/xen/xen-tools_4.15.bb
> > new file mode 100644
> > index 0000000..d8cb846
> > --- /dev/null
> > +++ b/recipes-extended/xen/xen-tools_4.15.bb
> > @@ -0,0 +1,20 @@
> > +SRCREV ?= "e25aa9939ae0cd8317605be3d5c5611b76bc4ab4"
> > +
> > +XEN_REL ?= "4.15"
> > +XEN_BRANCH ?= "stable-${XEN_REL}"
> > +
> > +SRC_URI = " \
> > +    git://xenbits.xen.org/xen.git;branch=${XEN_BRANCH} \
> > +    file://0001-python-pygrub-pass-DISTUTILS-xen-4.15.patch \
> > +    "
> > +
> > +LIC_FILES_CHKSUM ?= "file://COPYING;md5=419739e325a50f3d7b4501338e44a4e5"
> > +
> > +PV = "${XEN_REL}+stable${SRCPV}"
> > +
> > +S = "${WORKDIR}/git"
> > +
> > +DEFAULT_PREFERENCE ??= "-1"
>
> we have a file meta-virt-default-versions.inc in conf/distro/include
>
> Shouldn’t we use that file and set PREFERRED_VERSION instead of using default
> preference in each recipe ?

I wasn't aware of that file so hadn't considered it -- it's not
obvious as a place to look to understand how the version of Xen is
being set, or that it will change the default version of Xen according
to whether the DISTRO_FEATURES includes 'virtualization'. So I am not
sure that we should do that.
(As an aside, there's meta-virt-xen.inc in that directory that I would
like to retire and remove by making improvements elsewhere, for
similar reasons.)

> Something like:
> PREFERRED_VERSION_xen ?= "4.14%"
> PREFERRED_VERSION_xen-tools ?= "4.14%"
>
> This would prevent modifying the recipes when we change the default version.

I think I would prefer to modify the recipes when the default version
is changed, to make it a clear localized change in the Xen recipe
directory.
Would that be acceptable?

Christopher

>
> Cheers
> Bertrand
>
> > +
> > +require xen.inc
> > +require xen-tools.inc
> > diff --git a/recipes-extended/xen/xen_4.15.bb b/recipes-extended/xen/xen_4.15.bb
> > new file mode 100644
> > index 0000000..49268cc
> > --- /dev/null
> > +++ b/recipes-extended/xen/xen_4.15.bb
> > @@ -0,0 +1,21 @@
> > +SRCREV ?= "e25aa9939ae0cd8317605be3d5c5611b76bc4ab4"
> > +
> > +XEN_REL ?= "4.15"
> > +XEN_BRANCH ?= "stable-${XEN_REL}"
> > +
> > +SRC_URI = " \
> > +    git://xenbits.xen.org/xen.git;branch=${XEN_BRANCH} \
> > +    file://xen-arm64-implement-atomic-fetch-add.patch \
> > +    file://0001-menuconfig-mconf-cfg-Allow-specification-of-ncurses-location.patch \
> > +    "
> > +
> > +LIC_FILES_CHKSUM ?= "file://COPYING;md5=419739e325a50f3d7b4501338e44a4e5"
> > +
> > +PV = "${XEN_REL}+stable${SRCPV}"
> > +
> > +S = "${WORKDIR}/git"
> > +
> > +DEFAULT_PREFERENCE ??= "-1"
> > +
> > +require xen.inc
> > +require xen-hypervisor.inc
> > --
> > 2.25.1
> >
> >
> > 
> >
>
> IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.

Re: [meta-virtualization][PATCH v2 2/6] xen, xen-tools: add recipes for new stable Xen 4.15 release

[Bruce Ashfield]

On Thu, Apr 15, 2021 at 3:24 PM Christopher Clark
<christopher.w.clark@gmail.com> wrote:
>
> On Thu, Apr 15, 2021 at 2:12 AM Bertrand Marquis
> <Bertrand.Marquis@arm.com> wrote:
> >
> > Hi Christopher,
> >
> > > On 15 Apr 2021, at 00:39, Christopher Clark via lists.yoctoproject.org <christopher.w.clark=gmail.com@lists.yoctoproject.org> wrote:
> > >
> > > Added as non-default, retaining the Xen 4.14 recipes as the default
> > > preferred version for the Hardknott release.
> > >
> > > Signed-off-by: Christopher Clark <christopher.w.clark@gmail.com>
> > > ---
> > > recipes-extended/xen/xen-tools_4.15.bb | 20 ++++++++++++++++++++
> > > recipes-extended/xen/xen_4.15.bb       | 21 +++++++++++++++++++++
> > > 2 files changed, 41 insertions(+)
> > > create mode 100644 recipes-extended/xen/xen-tools_4.15.bb
> > > create mode 100644 recipes-extended/xen/xen_4.15.bb
> > >
> > > diff --git a/recipes-extended/xen/xen-tools_4.15.bb b/recipes-extended/xen/xen-tools_4.15.bb
> > > new file mode 100644
> > > index 0000000..d8cb846
> > > --- /dev/null
> > > +++ b/recipes-extended/xen/xen-tools_4.15.bb
> > > @@ -0,0 +1,20 @@
> > > +SRCREV ?= "e25aa9939ae0cd8317605be3d5c5611b76bc4ab4"
> > > +
> > > +XEN_REL ?= "4.15"
> > > +XEN_BRANCH ?= "stable-${XEN_REL}"
> > > +
> > > +SRC_URI = " \
> > > +    git://xenbits.xen.org/xen.git;branch=${XEN_BRANCH} \
> > > +    file://0001-python-pygrub-pass-DISTUTILS-xen-4.15.patch \
> > > +    "
> > > +
> > > +LIC_FILES_CHKSUM ?= "file://COPYING;md5=419739e325a50f3d7b4501338e44a4e5"
> > > +
> > > +PV = "${XEN_REL}+stable${SRCPV}"
> > > +
> > > +S = "${WORKDIR}/git"
> > > +
> > > +DEFAULT_PREFERENCE ??= "-1"
> >
> > we have a file meta-virt-default-versions.inc in conf/distro/include
> >
> > Shouldn’t we use that file and set PREFERRED_VERSION instead of using default
> > preference in each recipe ?
>
> I wasn't aware of that file so hadn't considered it -- it's not
> obvious as a place to look to understand how the version of Xen is
> being set, or that it will change the default version of Xen according
> to whether the DISTRO_FEATURES includes 'virtualization'. So I am not
> sure that we should do that.

Having .inc files with lists of centralized versions is historically
what has been done and tcmode-default.inc still does.

We actually do only want those preferred versions to kick in when a
distro feature is set (xen, virtualization .. whatever), since that
means we can include the layer and it won't change anything unless the
features are turned on.

> (As an aside, there's meta-virt-xen.inc in that directory that I would
> like to retire and remove by making improvements elsewhere, for
> similar reasons.)
>
> > Something like:
> > PREFERRED_VERSION_xen ?= "4.14%"
> > PREFERRED_VERSION_xen-tools ?= "4.14%"
> >
> > This would prevent modifying the recipes when we change the default version.
>
> I think I would prefer to modify the recipes when the default version
> is changed, to make it a clear localized change in the Xen recipe
> directory.

I can see the advantage of both approaches.

The problem with the DEFAULT_PREFERENCE, is that just as many people
have no idea what it does, how layer ordering does (or doesn't) impact
it, etc.  It is a bit harder to grok than an explicitly listed version
(and you'll get a warning if a requested version isn't available,
etc).  But of course DEFAULT_PREFERENCE exists for a reason .. and
this is one of them. I think it does come down to preference and
consistency.

I do lean towards the .inc myself, since we need them for other
coordinating features in the layer(s), but I'm far from insisting on
that approach.

Bruce

> Would that be acceptable?
>
> Christopher
>
> >
> > Cheers
> > Bertrand
> >
> > > +
> > > +require xen.inc
> > > +require xen-tools.inc
> > > diff --git a/recipes-extended/xen/xen_4.15.bb b/recipes-extended/xen/xen_4.15.bb
> > > new file mode 100644
> > > index 0000000..49268cc
> > > --- /dev/null
> > > +++ b/recipes-extended/xen/xen_4.15.bb
> > > @@ -0,0 +1,21 @@
> > > +SRCREV ?= "e25aa9939ae0cd8317605be3d5c5611b76bc4ab4"
> > > +
> > > +XEN_REL ?= "4.15"
> > > +XEN_BRANCH ?= "stable-${XEN_REL}"
> > > +
> > > +SRC_URI = " \
> > > +    git://xenbits.xen.org/xen.git;branch=${XEN_BRANCH} \
> > > +    file://xen-arm64-implement-atomic-fetch-add.patch \
> > > +    file://0001-menuconfig-mconf-cfg-Allow-specification-of-ncurses-location.patch \
> > > +    "
> > > +
> > > +LIC_FILES_CHKSUM ?= "file://COPYING;md5=419739e325a50f3d7b4501338e44a4e5"
> > > +
> > > +PV = "${XEN_REL}+stable${SRCPV}"
> > > +
> > > +S = "${WORKDIR}/git"
> > > +
> > > +DEFAULT_PREFERENCE ??= "-1"
> > > +
> > > +require xen.inc
> > > +require xen-hypervisor.inc
> > > --
> > > 2.25.1
> > >
> > >
> > > 
> > >
> >
> > IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.



-- 
- Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end
- "Use the force Harry" - Gandalf, Star Trek II

Re: [meta-virtualization][PATCH v2 2/6] xen, xen-tools: add recipes for new stable Xen 4.15 release

[Christopher Clark]

On Thu, Apr 15, 2021 at 7:24 PM Bruce Ashfield <bruce.ashfield@gmail.com> wrote:
>
> On Thu, Apr 15, 2021 at 3:24 PM Christopher Clark
> <christopher.w.clark@gmail.com> wrote:
> >
> > On Thu, Apr 15, 2021 at 2:12 AM Bertrand Marquis
> > <Bertrand.Marquis@arm.com> wrote:
> > >
> > > Hi Christopher,
> > >
> > > > On 15 Apr 2021, at 00:39, Christopher Clark via lists.yoctoproject.org <christopher.w.clark=gmail.com@lists.yoctoproject.org> wrote:
> > > >
> > > > Added as non-default, retaining the Xen 4.14 recipes as the default
> > > > preferred version for the Hardknott release.
> > > >
> > > > Signed-off-by: Christopher Clark <christopher.w.clark@gmail.com>
> > > > ---
> > > > recipes-extended/xen/xen-tools_4.15.bb | 20 ++++++++++++++++++++
> > > > recipes-extended/xen/xen_4.15.bb       | 21 +++++++++++++++++++++
> > > > 2 files changed, 41 insertions(+)
> > > > create mode 100644 recipes-extended/xen/xen-tools_4.15.bb
> > > > create mode 100644 recipes-extended/xen/xen_4.15.bb
> > > >
> > > > diff --git a/recipes-extended/xen/xen-tools_4.15.bb b/recipes-extended/xen/xen-tools_4.15.bb
> > > > new file mode 100644
> > > > index 0000000..d8cb846
> > > > --- /dev/null
> > > > +++ b/recipes-extended/xen/xen-tools_4.15.bb
> > > > @@ -0,0 +1,20 @@
> > > > +SRCREV ?= "e25aa9939ae0cd8317605be3d5c5611b76bc4ab4"
> > > > +
> > > > +XEN_REL ?= "4.15"
> > > > +XEN_BRANCH ?= "stable-${XEN_REL}"
> > > > +
> > > > +SRC_URI = " \
> > > > +    git://xenbits.xen.org/xen.git;branch=${XEN_BRANCH} \
> > > > +    file://0001-python-pygrub-pass-DISTUTILS-xen-4.15.patch \
> > > > +    "
> > > > +
> > > > +LIC_FILES_CHKSUM ?= "file://COPYING;md5=419739e325a50f3d7b4501338e44a4e5"
> > > > +
> > > > +PV = "${XEN_REL}+stable${SRCPV}"
> > > > +
> > > > +S = "${WORKDIR}/git"
> > > > +
> > > > +DEFAULT_PREFERENCE ??= "-1"
> > >
> > > we have a file meta-virt-default-versions.inc in conf/distro/include
> > >
> > > Shouldn’t we use that file and set PREFERRED_VERSION instead of using default
> > > preference in each recipe ?
> >
> > I wasn't aware of that file so hadn't considered it -- it's not
> > obvious as a place to look to understand how the version of Xen is
> > being set, or that it will change the default version of Xen according
> > to whether the DISTRO_FEATURES includes 'virtualization'. So I am not
> > sure that we should do that.
>
> Having .inc files with lists of centralized versions is historically
> what has been done and tcmode-default.inc still does.
>
> We actually do only want those preferred versions to kick in when a
> distro feature is set (xen, virtualization .. whatever), since that
> means we can include the layer and it won't change anything unless the
> features are turned on.

I see - that does make a difference then.

> > (As an aside, there's meta-virt-xen.inc in that directory that I would
> > like to retire and remove by making improvements elsewhere, for
> > similar reasons.)
> >
> > > Something like:
> > > PREFERRED_VERSION_xen ?= "4.14%"
> > > PREFERRED_VERSION_xen-tools ?= "4.14%"
> > >
> > > This would prevent modifying the recipes when we change the default version.
> >
> > I think I would prefer to modify the recipes when the default version
> > is changed, to make it a clear localized change in the Xen recipe
> > directory.
>
> I can see the advantage of both approaches.
>
> The problem with the DEFAULT_PREFERENCE, is that just as many people
> have no idea what it does, how layer ordering does (or doesn't) impact
> it, etc.  It is a bit harder to grok than an explicitly listed version
> (and you'll get a warning if a requested version isn't available,
> etc).  But of course DEFAULT_PREFERENCE exists for a reason .. and
> this is one of them. I think it does come down to preference and
> consistency.
>
> I do lean towards the .inc myself, since we need them for other
> coordinating features in the layer(s), but I'm far from insisting on
> that approach.

OK -- I'll make the change.

Christopher


>
> Bruce
>
> > Would that be acceptable?
> >
> > Christopher
> >
> > >
> > > Cheers
> > > Bertrand
> > >
> > > > +
> > > > +require xen.inc
> > > > +require xen-tools.inc
> > > > diff --git a/recipes-extended/xen/xen_4.15.bb b/recipes-extended/xen/xen_4.15.bb
> > > > new file mode 100644
> > > > index 0000000..49268cc
> > > > --- /dev/null
> > > > +++ b/recipes-extended/xen/xen_4.15.bb
> > > > @@ -0,0 +1,21 @@
> > > > +SRCREV ?= "e25aa9939ae0cd8317605be3d5c5611b76bc4ab4"
> > > > +
> > > > +XEN_REL ?= "4.15"
> > > > +XEN_BRANCH ?= "stable-${XEN_REL}"
> > > > +
> > > > +SRC_URI = " \
> > > > +    git://xenbits.xen.org/xen.git;branch=${XEN_BRANCH} \
> > > > +    file://xen-arm64-implement-atomic-fetch-add.patch \
> > > > +    file://0001-menuconfig-mconf-cfg-Allow-specification-of-ncurses-location.patch \
> > > > +    "
> > > > +
> > > > +LIC_FILES_CHKSUM ?= "file://COPYING;md5=419739e325a50f3d7b4501338e44a4e5"
> > > > +
> > > > +PV = "${XEN_REL}+stable${SRCPV}"
> > > > +
> > > > +S = "${WORKDIR}/git"
> > > > +
> > > > +DEFAULT_PREFERENCE ??= "-1"
> > > > +
> > > > +require xen.inc
> > > > +require xen-hypervisor.inc
> > > > --
> > > > 2.25.1
> > > >
> > > >
> > > > 
> > > >
> > >
> > > IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
>
>
>
> --
> - Thou shalt not follow the NULL pointer, for chaos and madness await
> thee at its end
> - "Use the force Harry" - Gandalf, Star Trek II

Re: [meta-virtualization][PATCH v2 2/6] xen, xen-tools: add recipes for new stable Xen 4.15 release

[Bertrand Marquis]

Hi,

> On 16 Apr 2021, at 03:24, Bruce Ashfield <bruce.ashfield@gmail.com> wrote:
>
> On Thu, Apr 15, 2021 at 3:24 PM Christopher Clark
> <christopher.w.clark@gmail.com> wrote:
>>
>> On Thu, Apr 15, 2021 at 2:12 AM Bertrand Marquis
>> <Bertrand.Marquis@arm.com> wrote:
>>>
>>> Hi Christopher,
>>>
>>>> On 15 Apr 2021, at 00:39, Christopher Clark via lists.yoctoproject.org <christopher.w.clark=gmail.com@lists.yoctoproject.org> wrote:
>>>>
>>>> Added as non-default, retaining the Xen 4.14 recipes as the default
>>>> preferred version for the Hardknott release.
>>>>
>>>> Signed-off-by: Christopher Clark <christopher.w.clark@gmail.com>
>>>> ---
>>>> recipes-extended/xen/xen-tools_4.15.bb | 20 ++++++++++++++++++++
>>>> recipes-extended/xen/xen_4.15.bb       | 21 +++++++++++++++++++++
>>>> 2 files changed, 41 insertions(+)
>>>> create mode 100644 recipes-extended/xen/xen-tools_4.15.bb
>>>> create mode 100644 recipes-extended/xen/xen_4.15.bb
>>>>
>>>> diff --git a/recipes-extended/xen/xen-tools_4.15.bb b/recipes-extended/xen/xen-tools_4.15.bb
>>>> new file mode 100644
>>>> index 0000000..d8cb846
>>>> --- /dev/null
>>>> +++ b/recipes-extended/xen/xen-tools_4.15.bb
>>>> @@ -0,0 +1,20 @@
>>>> +SRCREV ?= "e25aa9939ae0cd8317605be3d5c5611b76bc4ab4"
>>>> +
>>>> +XEN_REL ?= "4.15"
>>>> +XEN_BRANCH ?= "stable-${XEN_REL}"
>>>> +
>>>> +SRC_URI = " \
>>>> +    git://xenbits.xen.org/xen.git;branch=${XEN_BRANCH} \
>>>> +    file://0001-python-pygrub-pass-DISTUTILS-xen-4.15.patch \
>>>> +    "
>>>> +
>>>> +LIC_FILES_CHKSUM ?= "file://COPYING;md5=419739e325a50f3d7b4501338e44a4e5"
>>>> +
>>>> +PV = "${XEN_REL}+stable${SRCPV}"
>>>> +
>>>> +S = "${WORKDIR}/git"
>>>> +
>>>> +DEFAULT_PREFERENCE ??= "-1"
>>>
>>> we have a file meta-virt-default-versions.inc in conf/distro/include
>>>
>>> Shouldn’t we use that file and set PREFERRED_VERSION instead of using default
>>> preference in each recipe ?
>>
>> I wasn't aware of that file so hadn't considered it -- it's not
>> obvious as a place to look to understand how the version of Xen is
>> being set, or that it will change the default version of Xen according
>> to whether the DISTRO_FEATURES includes 'virtualization'. So I am not
>> sure that we should do that.
>
> Having .inc files with lists of centralized versions is historically
> what has been done and tcmode-default.inc still does.
>
> We actually do only want those preferred versions to kick in when a
> distro feature is set (xen, virtualization .. whatever), since that
> means we can include the layer and it won't change anything unless the
> features are turned on.
>
>> (As an aside, there's meta-virt-xen.inc in that directory that I would
>> like to retire and remove by making improvements elsewhere, for
>> similar reasons.)
>>
>>> Something like:
>>> PREFERRED_VERSION_xen ?= "4.14%"
>>> PREFERRED_VERSION_xen-tools ?= "4.14%"
>>>
>>> This would prevent modifying the recipes when we change the default version.
>>
>> I think I would prefer to modify the recipes when the default version
>> is changed, to make it a clear localized change in the Xen recipe
>> directory.
>
> I can see the advantage of both approaches.
>
> The problem with the DEFAULT_PREFERENCE, is that just as many people
> have no idea what it does, how layer ordering does (or doesn't) impact
> it, etc.  It is a bit harder to grok than an explicitly listed version
> (and you'll get a warning if a requested version isn't available,
> etc).  But of course DEFAULT_PREFERENCE exists for a reason .. and
> this is one of them. I think it does come down to preference and
> consistency.
>
> I do lean towards the .inc myself, since we need them for other
> coordinating features in the layer(s), but I'm far from insisting on
> that approach.

I do think that the DEFAULT_PREFERENCE is kind of implicit so hard
to get for a user.
Where the PREFERRED_VERSION is clear and easy to overload in
your local.conf when you want to use something different.

Cheers
Bertrand

>
> Bruce
>
>> Would that be acceptable?
>>
>> Christopher
>>
>>>
>>> Cheers
>>> Bertrand
>>>
>>>> +
>>>> +require xen.inc
>>>> +require xen-tools.inc
>>>> diff --git a/recipes-extended/xen/xen_4.15.bb b/recipes-extended/xen/xen_4.15.bb
>>>> new file mode 100644
>>>> index 0000000..49268cc
>>>> --- /dev/null
>>>> +++ b/recipes-extended/xen/xen_4.15.bb
>>>> @@ -0,0 +1,21 @@
>>>> +SRCREV ?= "e25aa9939ae0cd8317605be3d5c5611b76bc4ab4"
>>>> +
>>>> +XEN_REL ?= "4.15"
>>>> +XEN_BRANCH ?= "stable-${XEN_REL}"
>>>> +
>>>> +SRC_URI = " \
>>>> +    git://xenbits.xen.org/xen.git;branch=${XEN_BRANCH} \
>>>> +    file://xen-arm64-implement-atomic-fetch-add.patch \
>>>> +    file://0001-menuconfig-mconf-cfg-Allow-specification-of-ncurses-location.patch \
>>>> +    "
>>>> +
>>>> +LIC_FILES_CHKSUM ?= "file://COPYING;md5=419739e325a50f3d7b4501338e44a4e5"
>>>> +
>>>> +PV = "${XEN_REL}+stable${SRCPV}"
>>>> +
>>>> +S = "${WORKDIR}/git"
>>>> +
>>>> +DEFAULT_PREFERENCE ??= "-1"
>>>> +
>>>> +require xen.inc
>>>> +require xen-hypervisor.inc
>>>> --
>>>> 2.25.1
>>>>
>>>>
>>>> 
>>>>
>>>
>>> IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
>
>
>
> --
> - Thou shalt not follow the NULL pointer, for chaos and madness await
> thee at its end
> - "Use the force Harry" - Gandalf, Star Trek II

IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.

Re: [meta-virtualization][PATCH v2 2/6] xen, xen-tools: add recipes for new stable Xen 4.15 release

[Bertrand Marquis]

Hi,

> On 16 Apr 2021, at 07:18, Christopher Clark via lists.yoctoproject.org <christopher.w.clark=gmail.com@lists.yoctoproject.org> wrote:
>
> On Thu, Apr 15, 2021 at 7:24 PM Bruce Ashfield <bruce.ashfield@gmail.com> wrote:
>>
>> On Thu, Apr 15, 2021 at 3:24 PM Christopher Clark
>> <christopher.w.clark@gmail.com> wrote:
>>>
>>> On Thu, Apr 15, 2021 at 2:12 AM Bertrand Marquis
>>> <Bertrand.Marquis@arm.com> wrote:
>>>>
>>>> Hi Christopher,
>>>>
>>>>> On 15 Apr 2021, at 00:39, Christopher Clark via lists.yoctoproject.org <christopher.w.clark=gmail.com@lists.yoctoproject.org> wrote:
>>>>>
>>>>> Added as non-default, retaining the Xen 4.14 recipes as the default
>>>>> preferred version for the Hardknott release.
>>>>>
>>>>> Signed-off-by: Christopher Clark <christopher.w.clark@gmail.com>
>>>>> ---
>>>>> recipes-extended/xen/xen-tools_4.15.bb | 20 ++++++++++++++++++++
>>>>> recipes-extended/xen/xen_4.15.bb       | 21 +++++++++++++++++++++
>>>>> 2 files changed, 41 insertions(+)
>>>>> create mode 100644 recipes-extended/xen/xen-tools_4.15.bb
>>>>> create mode 100644 recipes-extended/xen/xen_4.15.bb
>>>>>
>>>>> diff --git a/recipes-extended/xen/xen-tools_4.15.bb b/recipes-extended/xen/xen-tools_4.15.bb
>>>>> new file mode 100644
>>>>> index 0000000..d8cb846
>>>>> --- /dev/null
>>>>> +++ b/recipes-extended/xen/xen-tools_4.15.bb
>>>>> @@ -0,0 +1,20 @@
>>>>> +SRCREV ?= "e25aa9939ae0cd8317605be3d5c5611b76bc4ab4"
>>>>> +
>>>>> +XEN_REL ?= "4.15"
>>>>> +XEN_BRANCH ?= "stable-${XEN_REL}"
>>>>> +
>>>>> +SRC_URI = " \
>>>>> +    git://xenbits.xen.org/xen.git;branch=${XEN_BRANCH} \
>>>>> +    file://0001-python-pygrub-pass-DISTUTILS-xen-4.15.patch \
>>>>> +    "
>>>>> +
>>>>> +LIC_FILES_CHKSUM ?= "file://COPYING;md5=419739e325a50f3d7b4501338e44a4e5"
>>>>> +
>>>>> +PV = "${XEN_REL}+stable${SRCPV}"
>>>>> +
>>>>> +S = "${WORKDIR}/git"
>>>>> +
>>>>> +DEFAULT_PREFERENCE ??= "-1"
>>>>
>>>> we have a file meta-virt-default-versions.inc in conf/distro/include
>>>>
>>>> Shouldn’t we use that file and set PREFERRED_VERSION instead of using default
>>>> preference in each recipe ?
>>>
>>> I wasn't aware of that file so hadn't considered it -- it's not
>>> obvious as a place to look to understand how the version of Xen is
>>> being set, or that it will change the default version of Xen according
>>> to whether the DISTRO_FEATURES includes 'virtualization'. So I am not
>>> sure that we should do that.
>>
>> Having .inc files with lists of centralized versions is historically
>> what has been done and tcmode-default.inc still does.
>>
>> We actually do only want those preferred versions to kick in when a
>> distro feature is set (xen, virtualization .. whatever), since that
>> means we can include the layer and it won't change anything unless the
>> features are turned on.
>
> I see - that does make a difference then.
>
>>> (As an aside, there's meta-virt-xen.inc in that directory that I would
>>> like to retire and remove by making improvements elsewhere, for
>>> similar reasons.)
>>>
>>>> Something like:
>>>> PREFERRED_VERSION_xen ?= "4.14%"
>>>> PREFERRED_VERSION_xen-tools ?= "4.14%"
>>>>
>>>> This would prevent modifying the recipes when we change the default version.
>>>
>>> I think I would prefer to modify the recipes when the default version
>>> is changed, to make it a clear localized change in the Xen recipe
>>> directory.
>>
>> I can see the advantage of both approaches.
>>
>> The problem with the DEFAULT_PREFERENCE, is that just as many people
>> have no idea what it does, how layer ordering does (or doesn't) impact
>> it, etc.  It is a bit harder to grok than an explicitly listed version
>> (and you'll get a warning if a requested version isn't available,
>> etc).  But of course DEFAULT_PREFERENCE exists for a reason .. and
>> this is one of them. I think it does come down to preference and
>> consistency.
>>
>> I do lean towards the .inc myself, since we need them for other
>> coordinating features in the layer(s), but I'm far from insisting on
>> that approach.
>
> OK -- I'll make the change.

Great, thanks a lot.

Cheers
Bertrand

>
> Christopher
>
>
>>
>> Bruce
>>
>>> Would that be acceptable?
>>>
>>> Christopher
>>>
>>>>
>>>> Cheers
>>>> Bertrand
>>>>
>>>>> +
>>>>> +require xen.inc
>>>>> +require xen-tools.inc
>>>>> diff --git a/recipes-extended/xen/xen_4.15.bb b/recipes-extended/xen/xen_4.15.bb
>>>>> new file mode 100644
>>>>> index 0000000..49268cc
>>>>> --- /dev/null
>>>>> +++ b/recipes-extended/xen/xen_4.15.bb
>>>>> @@ -0,0 +1,21 @@
>>>>> +SRCREV ?= "e25aa9939ae0cd8317605be3d5c5611b76bc4ab4"
>>>>> +
>>>>> +XEN_REL ?= "4.15"
>>>>> +XEN_BRANCH ?= "stable-${XEN_REL}"
>>>>> +
>>>>> +SRC_URI = " \
>>>>> +    git://xenbits.xen.org/xen.git;branch=${XEN_BRANCH} \
>>>>> +    file://xen-arm64-implement-atomic-fetch-add.patch \
>>>>> +    file://0001-menuconfig-mconf-cfg-Allow-specification-of-ncurses-location.patch \
>>>>> +    "
>>>>> +
>>>>> +LIC_FILES_CHKSUM ?= "file://COPYING;md5=419739e325a50f3d7b4501338e44a4e5"
>>>>> +
>>>>> +PV = "${XEN_REL}+stable${SRCPV}"
>>>>> +
>>>>> +S = "${WORKDIR}/git"
>>>>> +
>>>>> +DEFAULT_PREFERENCE ??= "-1"
>>>>> +
>>>>> +require xen.inc
>>>>> +require xen-hypervisor.inc
>>>>> --
>>>>> 2.25.1
>>>>>
>>>>>
>>>>>
>>>>>
>>>>
>>>> IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
>>
>>
>>
>> --
>> - Thou shalt not follow the NULL pointer, for chaos and madness await
>> thee at its end
>> - "Use the force Harry" - Gandalf, Star Trek II
>
> 

IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.