All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v5 0/2] HID: google: add device tree bindings for Whiskers switch device
@ 2021-04-15  3:29 Ikjoon Jang
  2021-04-15  3:29 ` [PATCH v5 1/2] mfd: google,cros-ec: add DT bindings for a baseboard's " Ikjoon Jang
                   ` (2 more replies)
  0 siblings, 3 replies; 12+ messages in thread
From: Ikjoon Jang @ 2021-04-15  3:29 UTC (permalink / raw)
  To: linux-input, devicetree
  Cc: Dmitry Torokhov, Hsin-Yi Wang, Nicolas Boichat, Ikjoon Jang,
	Benjamin Tissoires, Benson Leung, Enric Balletbo i Serra,
	Guenter Roeck, Jiri Kosina, Lee Jones, Rob Herring, linux-kernel

Add device a tree binding for a "cros-cbas" switch device of
ChromeOS tablets with Whiskers base board.

Changes in v5:
 - Add missing blank lines and change the description property's position.
 - Add a note to description: "this device cannot be detected at runtime."

Changes in v4:
Define cros-cbase bindings inside google,cros-ec.yaml instead of
a separated binding document.

Ikjoon Jang (2):
  mfd: google,cros-ec: add DT bindings for a baseboard's switch device
  HID: google: Add of_match table to Whiskers switch device.

 .../bindings/mfd/google,cros-ec.yaml          | 20 +++++++++++++++++++
 drivers/hid/hid-google-hammer.c               | 10 ++++++++++
 2 files changed, 30 insertions(+)

-- 
2.31.1.295.g9ea45b61b8-goog


^ permalink raw reply	[flat|nested] 12+ messages in thread

* [PATCH v5 1/2] mfd: google,cros-ec: add DT bindings for a baseboard's switch device
  2021-04-15  3:29 [PATCH v5 0/2] HID: google: add device tree bindings for Whiskers switch device Ikjoon Jang
@ 2021-04-15  3:29 ` Ikjoon Jang
  2021-04-15 16:19   ` Rob Herring
                     ` (2 more replies)
  2021-04-15  3:29 ` [PATCH v5 2/2] HID: google: Add of_match table to Whiskers " Ikjoon Jang
  2021-05-05  9:51 ` [PATCH v5 0/2] HID: google: add device tree bindings for " Ikjoon Jang
  2 siblings, 3 replies; 12+ messages in thread
From: Ikjoon Jang @ 2021-04-15  3:29 UTC (permalink / raw)
  To: linux-input, devicetree
  Cc: Dmitry Torokhov, Hsin-Yi Wang, Nicolas Boichat, Ikjoon Jang,
	Benson Leung, Enric Balletbo i Serra, Guenter Roeck, Lee Jones,
	Rob Herring, linux-kernel

This is for ChromeOS tablets which have a 'cros_cbas' switch device
in the "Whiskers" base board. This device can be instantiated only by
device tree on ARM platforms. ChromeOS EC doesn't provide a way to
probe the device.

Signed-off-by: Ikjoon Jang <ikjn@chromium.org>

---

Changes in v5:
 - Add missing blank lines and change the description property's position.
 - Add a note to description: "this device cannot be detected at runtime."

Changes in v4:
Define cros-cbase bindings inside google,cros-ec.yaml instead of
a separated binding document.

 .../bindings/mfd/google,cros-ec.yaml          | 20 +++++++++++++++++++
 1 file changed, 20 insertions(+)

diff --git a/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml b/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml
index 76bf16ee27ec..8dcce176b72e 100644
--- a/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml
+++ b/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml
@@ -114,6 +114,22 @@ properties:
       - "#address-cells"
       - "#size-cells"
 
+  cbas:
+    type: object
+
+    description:
+      This device is used to signal when a detachable base is attached
+      to a Chrome OS tablet. This device cannot be detected at runtime.
+
+    properties:
+      compatible:
+        const: google,cros-cbas
+
+    required:
+      - compatible
+
+    additionalProperties: false
+
 patternProperties:
   "^i2c-tunnel[0-9]*$":
     type: object
@@ -180,6 +196,10 @@ examples:
             interrupts = <99 0>;
             interrupt-parent = <&gpio7>;
             spi-max-frequency = <5000000>;
+
+            base_detection: cbas {
+                compatible = "google,cros-cbas";
+            };
         };
     };
 
-- 
2.31.1.295.g9ea45b61b8-goog


^ permalink raw reply related	[flat|nested] 12+ messages in thread

* [PATCH v5 2/2] HID: google: Add of_match table to Whiskers switch device.
  2021-04-15  3:29 [PATCH v5 0/2] HID: google: add device tree bindings for Whiskers switch device Ikjoon Jang
  2021-04-15  3:29 ` [PATCH v5 1/2] mfd: google,cros-ec: add DT bindings for a baseboard's " Ikjoon Jang
@ 2021-04-15  3:29 ` Ikjoon Jang
  2021-05-05 12:35   ` Jiri Kosina
  2021-05-05  9:51 ` [PATCH v5 0/2] HID: google: add device tree bindings for " Ikjoon Jang
  2 siblings, 1 reply; 12+ messages in thread
From: Ikjoon Jang @ 2021-04-15  3:29 UTC (permalink / raw)
  To: linux-input, devicetree
  Cc: Dmitry Torokhov, Hsin-Yi Wang, Nicolas Boichat, Ikjoon Jang,
	Dmitry Torokhov, Jiri Kosina, Benjamin Tissoires, Jiri Kosina,
	linux-kernel

Add a device tree match table for "cros-cbas" switch device.

Signed-off-by: Ikjoon Jang <ikjn@chromium.org>
Reviewed-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Acked-by: Jiri Kosina <jkosina@suse.cz>

---

(no changes since v1)

Please note that v3 was submitted in 28 Oct 2019, 1.5yrs ago.
Link(v2): https://patchwork.kernel.org/project/linux-input/patch/20191021030158.32464-1-ikjn@chromium.org/

---
 drivers/hid/hid-google-hammer.c | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/drivers/hid/hid-google-hammer.c b/drivers/hid/hid-google-hammer.c
index d9319622da44..be4f9f3dbbba 100644
--- a/drivers/hid/hid-google-hammer.c
+++ b/drivers/hid/hid-google-hammer.c
@@ -17,6 +17,7 @@
 #include <linux/hid.h>
 #include <linux/leds.h>
 #include <linux/module.h>
+#include <linux/of.h>
 #include <linux/platform_data/cros_ec_commands.h>
 #include <linux/platform_data/cros_ec_proto.h>
 #include <linux/platform_device.h>
@@ -272,12 +273,21 @@ static const struct acpi_device_id cbas_ec_acpi_ids[] = {
 };
 MODULE_DEVICE_TABLE(acpi, cbas_ec_acpi_ids);
 
+#ifdef CONFIG_OF
+static const struct of_device_id cbas_ec_of_match[] = {
+	{ .compatible = "google,cros-cbas" },
+	{ },
+};
+MODULE_DEVICE_TABLE(of, cbas_ec_of_match);
+#endif
+
 static struct platform_driver cbas_ec_driver = {
 	.probe = cbas_ec_probe,
 	.remove = cbas_ec_remove,
 	.driver = {
 		.name = "cbas_ec",
 		.acpi_match_table = ACPI_PTR(cbas_ec_acpi_ids),
+		.of_match_table = of_match_ptr(cbas_ec_of_match),
 		.pm = &cbas_ec_pm_ops,
 	},
 };
-- 
2.31.1.295.g9ea45b61b8-goog


^ permalink raw reply related	[flat|nested] 12+ messages in thread

* Re: [PATCH v5 1/2] mfd: google,cros-ec: add DT bindings for a baseboard's switch device
  2021-04-15  3:29 ` [PATCH v5 1/2] mfd: google,cros-ec: add DT bindings for a baseboard's " Ikjoon Jang
@ 2021-04-15 16:19   ` Rob Herring
  2021-04-16  5:37   ` Enric Balletbo Serra
  2021-05-12 10:08   ` [PATCH v6] " Ikjoon Jang
  2 siblings, 0 replies; 12+ messages in thread
From: Rob Herring @ 2021-04-15 16:19 UTC (permalink / raw)
  To: Ikjoon Jang
  Cc: linux-kernel, linux-input, Rob Herring, Guenter Roeck, Lee Jones,
	Enric Balletbo i Serra, Benson Leung, devicetree,
	Nicolas Boichat, Hsin-Yi Wang, Dmitry Torokhov

On Thu, 15 Apr 2021 11:29:57 +0800, Ikjoon Jang wrote:
> This is for ChromeOS tablets which have a 'cros_cbas' switch device
> in the "Whiskers" base board. This device can be instantiated only by
> device tree on ARM platforms. ChromeOS EC doesn't provide a way to
> probe the device.
> 
> Signed-off-by: Ikjoon Jang <ikjn@chromium.org>
> 
> ---
> 
> Changes in v5:
>  - Add missing blank lines and change the description property's position.
>  - Add a note to description: "this device cannot be detected at runtime."
> 
> Changes in v4:
> Define cros-cbase bindings inside google,cros-ec.yaml instead of
> a separated binding document.
> 
>  .../bindings/mfd/google,cros-ec.yaml          | 20 +++++++++++++++++++
>  1 file changed, 20 insertions(+)
> 

Reviewed-by: Rob Herring <robh@kernel.org>

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH v5 1/2] mfd: google,cros-ec: add DT bindings for a baseboard's switch device
  2021-04-15  3:29 ` [PATCH v5 1/2] mfd: google,cros-ec: add DT bindings for a baseboard's " Ikjoon Jang
  2021-04-15 16:19   ` Rob Herring
@ 2021-04-16  5:37   ` Enric Balletbo Serra
  2021-04-16 13:30     ` Rob Herring
  2021-05-12 10:08   ` [PATCH v6] " Ikjoon Jang
  2 siblings, 1 reply; 12+ messages in thread
From: Enric Balletbo Serra @ 2021-04-16  5:37 UTC (permalink / raw)
  To: Ikjoon Jang
  Cc: linux-input, devicetree, Dmitry Torokhov, Hsin-Yi Wang,
	Nicolas Boichat, Benson Leung, Enric Balletbo i Serra,
	Guenter Roeck, Lee Jones, Rob Herring, linux-kernel

Hi Ikjoon,

Thank you for your patch.

Missatge de Ikjoon Jang <ikjn@chromium.org> del dia dj., 15 d’abr.
2021 a les 5:32:
>
> This is for ChromeOS tablets which have a 'cros_cbas' switch device
> in the "Whiskers" base board. This device can be instantiated only by
> device tree on ARM platforms. ChromeOS EC doesn't provide a way to
> probe the device.
>
> Signed-off-by: Ikjoon Jang <ikjn@chromium.org>
>
> ---
>
> Changes in v5:
>  - Add missing blank lines and change the description property's position.
>  - Add a note to description: "this device cannot be detected at runtime."
>
> Changes in v4:
> Define cros-cbase bindings inside google,cros-ec.yaml instead of
> a separated binding document.
>
>  .../bindings/mfd/google,cros-ec.yaml          | 20 +++++++++++++++++++
>  1 file changed, 20 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml b/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml
> index 76bf16ee27ec..8dcce176b72e 100644
> --- a/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml
> +++ b/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml
> @@ -114,6 +114,22 @@ properties:
>        - "#address-cells"
>        - "#size-cells"
>
> +  cbas:
> +    type: object
> +
> +    description:
> +      This device is used to signal when a detachable base is attached
> +      to a Chrome OS tablet. This device cannot be detected at runtime.
> +
> +    properties:
> +      compatible:
> +        const: google,cros-cbas
> +
> +    required:
> +      - compatible
> +
> +    additionalProperties: false
> +
>  patternProperties:
>    "^i2c-tunnel[0-9]*$":
>      type: object
> @@ -180,6 +196,10 @@ examples:
>              interrupts = <99 0>;
>              interrupt-parent = <&gpio7>;
>              spi-max-frequency = <5000000>;
> +
> +            base_detection: cbas {

nit: Rob, shouldn't this be just cbas?

> +                compatible = "google,cros-cbas";
> +            };
>          };
>      };
>
> --
> 2.31.1.295.g9ea45b61b8-goog
>

Acked-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH v5 1/2] mfd: google,cros-ec: add DT bindings for a baseboard's switch device
  2021-04-16  5:37   ` Enric Balletbo Serra
@ 2021-04-16 13:30     ` Rob Herring
  2021-05-11  8:55       ` Ikjoon Jang
  0 siblings, 1 reply; 12+ messages in thread
From: Rob Herring @ 2021-04-16 13:30 UTC (permalink / raw)
  To: Enric Balletbo Serra
  Cc: Ikjoon Jang, Linux Input, devicetree, Dmitry Torokhov,
	Hsin-Yi Wang, Nicolas Boichat, Benson Leung,
	Enric Balletbo i Serra, Guenter Roeck, Lee Jones, linux-kernel

On Fri, Apr 16, 2021 at 12:37 AM Enric Balletbo Serra
<eballetbo@gmail.com> wrote:
>
> Hi Ikjoon,
>
> Thank you for your patch.
>
> Missatge de Ikjoon Jang <ikjn@chromium.org> del dia dj., 15 d’abr.
> 2021 a les 5:32:
> >
> > This is for ChromeOS tablets which have a 'cros_cbas' switch device
> > in the "Whiskers" base board. This device can be instantiated only by
> > device tree on ARM platforms. ChromeOS EC doesn't provide a way to
> > probe the device.
> >
> > Signed-off-by: Ikjoon Jang <ikjn@chromium.org>
> >
> > ---
> >
> > Changes in v5:
> >  - Add missing blank lines and change the description property's position.
> >  - Add a note to description: "this device cannot be detected at runtime."
> >
> > Changes in v4:
> > Define cros-cbase bindings inside google,cros-ec.yaml instead of
> > a separated binding document.
> >
> >  .../bindings/mfd/google,cros-ec.yaml          | 20 +++++++++++++++++++
> >  1 file changed, 20 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml b/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml
> > index 76bf16ee27ec..8dcce176b72e 100644
> > --- a/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml
> > +++ b/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml
> > @@ -114,6 +114,22 @@ properties:
> >        - "#address-cells"
> >        - "#size-cells"
> >
> > +  cbas:
> > +    type: object
> > +
> > +    description:
> > +      This device is used to signal when a detachable base is attached
> > +      to a Chrome OS tablet. This device cannot be detected at runtime.
> > +
> > +    properties:
> > +      compatible:
> > +        const: google,cros-cbas
> > +
> > +    required:
> > +      - compatible
> > +
> > +    additionalProperties: false
> > +
> >  patternProperties:
> >    "^i2c-tunnel[0-9]*$":
> >      type: object
> > @@ -180,6 +196,10 @@ examples:
> >              interrupts = <99 0>;
> >              interrupt-parent = <&gpio7>;
> >              spi-max-frequency = <5000000>;
> > +
> > +            base_detection: cbas {
>
> nit: Rob, shouldn't this be just cbas?

Yes.

>
> > +                compatible = "google,cros-cbas";
> > +            };
> >          };
> >      };
> >
> > --
> > 2.31.1.295.g9ea45b61b8-goog
> >
>
> Acked-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH v5 0/2] HID: google: add device tree bindings for Whiskers switch device
  2021-04-15  3:29 [PATCH v5 0/2] HID: google: add device tree bindings for Whiskers switch device Ikjoon Jang
  2021-04-15  3:29 ` [PATCH v5 1/2] mfd: google,cros-ec: add DT bindings for a baseboard's " Ikjoon Jang
  2021-04-15  3:29 ` [PATCH v5 2/2] HID: google: Add of_match table to Whiskers " Ikjoon Jang
@ 2021-05-05  9:51 ` Ikjoon Jang
  2 siblings, 0 replies; 12+ messages in thread
From: Ikjoon Jang @ 2021-05-05  9:51 UTC (permalink / raw)
  To: linux-input, open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS
  Cc: Dmitry Torokhov, Hsin-Yi Wang, Nicolas Boichat,
	Benjamin Tissoires, Benson Leung, Enric Balletbo i Serra,
	Guenter Roeck, Jiri Kosina, Lee Jones, Rob Herring, open list

Hi Jiri,

Genting ping on this series.

On Thu, Apr 15, 2021 at 11:30 AM Ikjoon Jang <ikjn@chromium.org> wrote:
>
> Add device a tree binding for a "cros-cbas" switch device of
> ChromeOS tablets with Whiskers base board.
>
> Changes in v5:
>  - Add missing blank lines and change the description property's position.
>  - Add a note to description: "this device cannot be detected at runtime."
>
> Changes in v4:
> Define cros-cbase bindings inside google,cros-ec.yaml instead of
> a separated binding document.
>
> Ikjoon Jang (2):
>   mfd: google,cros-ec: add DT bindings for a baseboard's switch device
>   HID: google: Add of_match table to Whiskers switch device.
>
>  .../bindings/mfd/google,cros-ec.yaml          | 20 +++++++++++++++++++
>  drivers/hid/hid-google-hammer.c               | 10 ++++++++++
>  2 files changed, 30 insertions(+)
>

Can this be queued up to hid.git?

Thanks!



> --
> 2.31.1.295.g9ea45b61b8-goog
>

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH v5 2/2] HID: google: Add of_match table to Whiskers switch device.
  2021-04-15  3:29 ` [PATCH v5 2/2] HID: google: Add of_match table to Whiskers " Ikjoon Jang
@ 2021-05-05 12:35   ` Jiri Kosina
  2021-05-10  7:51     ` Ikjoon Jang
  0 siblings, 1 reply; 12+ messages in thread
From: Jiri Kosina @ 2021-05-05 12:35 UTC (permalink / raw)
  To: Ikjoon Jang
  Cc: linux-input, devicetree, Dmitry Torokhov, Hsin-Yi Wang,
	Nicolas Boichat, Dmitry Torokhov, Benjamin Tissoires,
	linux-kernel

On Thu, 15 Apr 2021, Ikjoon Jang wrote:

> Add a device tree match table for "cros-cbas" switch device.

Applied, sorry for the delay.

-- 
Jiri Kosina
SUSE Labs


^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH v5 2/2] HID: google: Add of_match table to Whiskers switch device.
  2021-05-05 12:35   ` Jiri Kosina
@ 2021-05-10  7:51     ` Ikjoon Jang
  0 siblings, 0 replies; 12+ messages in thread
From: Ikjoon Jang @ 2021-05-10  7:51 UTC (permalink / raw)
  To: Jiri Kosina
  Cc: linux-input,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	Dmitry Torokhov, Hsin-Yi Wang, Nicolas Boichat, Dmitry Torokhov,
	Benjamin Tissoires, open list

On Wed, May 5, 2021 at 8:35 PM Jiri Kosina <jikos@kernel.org> wrote:
>
> On Thu, 15 Apr 2021, Ikjoon Jang wrote:
>
> > Add a device tree match table for "cros-cbas" switch device.
>
> Applied, sorry for the delay.

Thanks a lot!

Sorry for bothering you again but I can't find
a device tree binding patch [1] in your trees.

I think dt-binding should go first before the driver part.
Can it also be applied to hid tree (or am I missing something)?

[1] http://patchwork.kernel.org/patch/12204197
     [v5,1/2] mfd: google,cros-ec: add DT bindings for a baseboard's
switch device

>
> --
> Jiri Kosina
> SUSE Labs
>

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH v5 1/2] mfd: google,cros-ec: add DT bindings for a baseboard's switch device
  2021-04-16 13:30     ` Rob Herring
@ 2021-05-11  8:55       ` Ikjoon Jang
  0 siblings, 0 replies; 12+ messages in thread
From: Ikjoon Jang @ 2021-05-11  8:55 UTC (permalink / raw)
  To: Rob Herring, Jiri Kosina
  Cc: Enric Balletbo Serra, Linux Input, devicetree, Dmitry Torokhov,
	Hsin-Yi Wang, Benson Leung, Enric Balletbo i Serra,
	Guenter Roeck, Lee Jones, linux-kernel

On Fri, Apr 16, 2021 at 9:30 PM Rob Herring <robh+dt@kernel.org> wrote:
>
> On Fri, Apr 16, 2021 at 12:37 AM Enric Balletbo Serra
> <eballetbo@gmail.com> wrote:
> >
> > Hi Ikjoon,
> >
> > Thank you for your patch.
> >
> > Missatge de Ikjoon Jang <ikjn@chromium.org> del dia dj., 15 d’abr.
> > 2021 a les 5:32:
> > >
> > > This is for ChromeOS tablets which have a 'cros_cbas' switch device
> > > in the "Whiskers" base board. This device can be instantiated only by
> > > device tree on ARM platforms. ChromeOS EC doesn't provide a way to
> > > probe the device.
> > >
> > > Signed-off-by: Ikjoon Jang <ikjn@chromium.org>
> > >
> > > ---
> > >
> > > Changes in v5:
> > >  - Add missing blank lines and change the description property's position.
> > >  - Add a note to description: "this device cannot be detected at runtime."
> > >
> > > Changes in v4:
> > > Define cros-cbase bindings inside google,cros-ec.yaml instead of
> > > a separated binding document.
> > >
> > >  .../bindings/mfd/google,cros-ec.yaml          | 20 +++++++++++++++++++
> > >  1 file changed, 20 insertions(+)
> > >
> > > diff --git a/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml b/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml
> > > index 76bf16ee27ec..8dcce176b72e 100644
> > > --- a/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml
> > > +++ b/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml
> > > @@ -114,6 +114,22 @@ properties:
> > >        - "#address-cells"
> > >        - "#size-cells"
> > >
> > > +  cbas:
> > > +    type: object
> > > +
> > > +    description:
> > > +      This device is used to signal when a detachable base is attached
> > > +      to a Chrome OS tablet. This device cannot be detected at runtime.
> > > +
> > > +    properties:
> > > +      compatible:
> > > +        const: google,cros-cbas
> > > +
> > > +    required:
> > > +      - compatible
> > > +
> > > +    additionalProperties: false
> > > +
> > >  patternProperties:
> > >    "^i2c-tunnel[0-9]*$":
> > >      type: object
> > > @@ -180,6 +196,10 @@ examples:
> > >              interrupts = <99 0>;
> > >              interrupt-parent = <&gpio7>;
> > >              spi-max-frequency = <5000000>;
> > > +
> > > +            base_detection: cbas {
> >
> > nit: Rob, shouldn't this be just cbas?
>
> Yes.

Sorry, I'm a bit confused here.
'base_detection: cbas' in example should be just 'cbas'?
Maybe that's because cbas doesn't need to have a phandle or just by
its definition in schema?

Please let me upload v6 if this needs to be fixed.

Thanks for reviewing!



>
> >
> > > +                compatible = "google,cros-cbas";
> > > +            };
> > >          };
> > >      };
> > >
> > > --
> > > 2.31.1.295.g9ea45b61b8-goog
> > >
> >
> > Acked-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>

^ permalink raw reply	[flat|nested] 12+ messages in thread

* [PATCH v6] mfd: google,cros-ec: add DT bindings for a baseboard's switch device
  2021-04-15  3:29 ` [PATCH v5 1/2] mfd: google,cros-ec: add DT bindings for a baseboard's " Ikjoon Jang
  2021-04-15 16:19   ` Rob Herring
  2021-04-16  5:37   ` Enric Balletbo Serra
@ 2021-05-12 10:08   ` Ikjoon Jang
  2021-05-19 12:28     ` Lee Jones
  2 siblings, 1 reply; 12+ messages in thread
From: Ikjoon Jang @ 2021-05-12 10:08 UTC (permalink / raw)
  To: devicetree, linux-input
  Cc: Jiri Kosina, Ikjoon Jang, Rob Herring, Enric Balletbo i Serra,
	Benson Leung, Guenter Roeck, Lee Jones, Rob Herring,
	linux-kernel

This is for ChromeOS tablets which have a 'cros_cbas' switch device
in the "Whiskers" base board. This device can be instantiated only by
device tree on ARM platforms. ChromeOS EC doesn't provide a way to
probe the device.

Signed-off-by: Ikjoon Jang <ikjn@chromium.org>
Reviewed-by: Rob Herring <robh@kernel.org>
Acked-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>

---

Changes in v6:
 - Remove a label from cbas node in an example

Changes in v5:
 - Add missing blank lines and change the description property's position.
 - Add a note to description: "this device cannot be detected at runtime."

Changes in v4:
Define cros-cbase bindings inside google,cros-ec.yaml instead of
a separated binding document.

 .../bindings/mfd/google,cros-ec.yaml          | 20 +++++++++++++++++++
 1 file changed, 20 insertions(+)

diff --git a/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml b/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml
index 76bf16ee27ec..929c17552d8b 100644
--- a/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml
+++ b/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml
@@ -114,6 +114,22 @@ properties:
       - "#address-cells"
       - "#size-cells"
 
+  cbas:
+    type: object
+
+    description:
+      This device is used to signal when a detachable base is attached
+      to a Chrome OS tablet. This device cannot be detected at runtime.
+
+    properties:
+      compatible:
+        const: google,cros-cbas
+
+    required:
+      - compatible
+
+    additionalProperties: false
+
 patternProperties:
   "^i2c-tunnel[0-9]*$":
     type: object
@@ -180,6 +196,10 @@ examples:
             interrupts = <99 0>;
             interrupt-parent = <&gpio7>;
             spi-max-frequency = <5000000>;
+
+            cbas {
+                compatible = "google,cros-cbas";
+            };
         };
     };
 
-- 
2.31.1.607.g51e8a6a459-goog


^ permalink raw reply related	[flat|nested] 12+ messages in thread

* Re: [PATCH v6] mfd: google,cros-ec: add DT bindings for a baseboard's switch device
  2021-05-12 10:08   ` [PATCH v6] " Ikjoon Jang
@ 2021-05-19 12:28     ` Lee Jones
  0 siblings, 0 replies; 12+ messages in thread
From: Lee Jones @ 2021-05-19 12:28 UTC (permalink / raw)
  To: Ikjoon Jang
  Cc: devicetree, linux-input, Jiri Kosina, Rob Herring,
	Enric Balletbo i Serra, Benson Leung, Guenter Roeck, Rob Herring,
	linux-kernel

On Wed, 12 May 2021, Ikjoon Jang wrote:

> This is for ChromeOS tablets which have a 'cros_cbas' switch device
> in the "Whiskers" base board. This device can be instantiated only by
> device tree on ARM platforms. ChromeOS EC doesn't provide a way to
> probe the device.
> 
> Signed-off-by: Ikjoon Jang <ikjn@chromium.org>
> Reviewed-by: Rob Herring <robh@kernel.org>
> Acked-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
> 
> ---
> 
> Changes in v6:
>  - Remove a label from cbas node in an example
> 
> Changes in v5:
>  - Add missing blank lines and change the description property's position.
>  - Add a note to description: "this device cannot be detected at runtime."
> 
> Changes in v4:
> Define cros-cbase bindings inside google,cros-ec.yaml instead of
> a separated binding document.
> 
>  .../bindings/mfd/google,cros-ec.yaml          | 20 +++++++++++++++++++
>  1 file changed, 20 insertions(+)

Applied, thanks.

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog

^ permalink raw reply	[flat|nested] 12+ messages in thread

end of thread, other threads:[~2021-05-19 12:28 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-15  3:29 [PATCH v5 0/2] HID: google: add device tree bindings for Whiskers switch device Ikjoon Jang
2021-04-15  3:29 ` [PATCH v5 1/2] mfd: google,cros-ec: add DT bindings for a baseboard's " Ikjoon Jang
2021-04-15 16:19   ` Rob Herring
2021-04-16  5:37   ` Enric Balletbo Serra
2021-04-16 13:30     ` Rob Herring
2021-05-11  8:55       ` Ikjoon Jang
2021-05-12 10:08   ` [PATCH v6] " Ikjoon Jang
2021-05-19 12:28     ` Lee Jones
2021-04-15  3:29 ` [PATCH v5 2/2] HID: google: Add of_match table to Whiskers " Ikjoon Jang
2021-05-05 12:35   ` Jiri Kosina
2021-05-10  7:51     ` Ikjoon Jang
2021-05-05  9:51 ` [PATCH v5 0/2] HID: google: add device tree bindings for " Ikjoon Jang

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.