From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f54.google.com (mail-ed1-f54.google.com [209.85.208.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4AC356D32 for ; Thu, 15 Apr 2021 08:34:25 +0000 (UTC) Received: by mail-ed1-f54.google.com with SMTP id bx20so25865254edb.12 for ; Thu, 15 Apr 2021 01:34:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=ZyVMtB+Nhk/j05dUGtiYl/caXyuaDDioIx3PMH1ZaCA=; b=naLW0P4Ai2XWFnG907DDslAfgqi9342d+6FeiQJtUOyeSNRjrH5JAohGjPG0vAIggy 5Qc08B71vRYqy2ThHwu2Weat4a+ue/4GPnjsOMmjxL80uzNBL9BUYvfH3pRT/BmxEseS w96N1g5ikdayQRR5+tASLuh+MfPmeh4cOPQE1VMgHxqa29Yc/ZR9mOJFzRUrlLUj+l0b wIYV+X9mfzbBVRGihlNs1vPdVAaD32FnS5YQPq6IZr3Twhr4/okgEaosoFrXDJHWNXdB mbjCrnF05ThBG3U0a3FXnCFU/nc25cFAJjJT7k8raSYl5KqEjmN6yxHPI0eajix+AVL0 AYRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=ZyVMtB+Nhk/j05dUGtiYl/caXyuaDDioIx3PMH1ZaCA=; b=h8r35F00F0JRgDeczChlLv3YkhHCC3RtyJjL+bZu2TU/tgVWrbMtomvKE2PiMdec/p oAvtKoKLkFD7sMJvL/uIUBYMvYVKgUG/Wo+TmT//msVXQ211/1RvMAR1hvA92r2heyVT /jM+v+RvKnSvQP6/5vXgIXv8G0Miwfx1iLZqjCTvsa3wYwHYQv6BvY/mKvO9JvAJUlil 2MrpF2qCLAkfsrKo0VeiT3s+YNZ68cVab9GbbghKWGdp2VafB6S2WZ1+wTfxMK2e+ItC FewpGnomJUBjQPf421dG5VWCbBynFGMqhALiNUAUNPl6IOEDijSVFc+DaitHCO5Dwqmb QDSA== X-Gm-Message-State: AOAM532egYMAYRvBgmCc4qk+jlxpjxTAPi2DdpN0jmVoaNSbW3SnD31r iBQagfzWroDYnEnB+hXAiDZ06X/Irpw7IA== X-Google-Smtp-Source: ABdhPJwLmMWmf+ln8LvRE/mNvq23RtHXHlEDyfNtjD/7wInU0hwZ7xbtoSw2dnp+tn/FZturSlY2SQ== X-Received: by 2002:a05:6402:485:: with SMTP id k5mr2721724edv.211.1618475663896; Thu, 15 Apr 2021 01:34:23 -0700 (PDT) Received: from dell ([91.110.221.215]) by smtp.gmail.com with ESMTPSA id t14sm1358659ejj.77.2021.04.15.01.34.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Apr 2021 01:34:23 -0700 (PDT) Date: Thu, 15 Apr 2021 09:34:21 +0100 From: Lee Jones To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Cc: linux-kernel@vger.kernel.org, Ian Abbott , H Hartley Sweeten , Greg Kroah-Hartman , Thierry Reding , "David A. Schleef" , Mori Hess , Truxton Fulton , linux-staging@lists.linux.dev, linux-pwm@vger.kernel.org Subject: Re: [PATCH 55/57] staging: comedi: drivers: ni_mio_common: Move 'range_ni_E_ao_ext' to where it is used Message-ID: <20210415083421.GV4869@dell> References: <20210414181129.1628598-1-lee.jones@linaro.org> <20210414181129.1628598-56-lee.jones@linaro.org> <20210415065535.eff56u7nhfhrcnl3@pengutronix.de> X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210415065535.eff56u7nhfhrcnl3@pengutronix.de> On Thu, 15 Apr 2021, Uwe Kleine-König wrote: > Hello Lee, > > nitpick: You move range_ni_E_ao_ext to the header. However that header > doesn't use range_ni_E_ao_ext, so the subject is technically wrong. It's implicitly used by the users of the header. But I know what you mean. I'll see if I can make the subject line a little more clear. > On Wed, Apr 14, 2021 at 07:11:27PM +0100, Lee Jones wrote: > > ... and mark it as __maybe_unused since not all users of the > > header file reference it. > > > > Fixes the following W=1 kernel build warning(s): > > > > drivers/staging/comedi/drivers/ni_mio_common.c:163:35: warning: ‘range_ni_E_ao_ext’ defined but not used [-Wunused-const-variable=] > > > > Cc: Ian Abbott > > Cc: H Hartley Sweeten > > Cc: Greg Kroah-Hartman > > Cc: Thierry Reding > > Cc: "Uwe Kleine-König" > > Cc: Lee Jones > > Cc: "David A. Schleef" > > Cc: Mori Hess > > Cc: Truxton Fulton > > Cc: linux-staging@lists.linux.dev > > Cc: linux-pwm@vger.kernel.org > > Signed-off-by: Lee Jones > > --- > > drivers/staging/comedi/drivers/ni_mio_common.c | 9 --------- > > drivers/staging/comedi/drivers/ni_stc.h | 9 ++++++++- > > 2 files changed, 8 insertions(+), 10 deletions(-) -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog