From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9368C433B4 for ; Thu, 15 Apr 2021 20:37:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B403F61132 for ; Thu, 15 Apr 2021 20:37:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235574AbhDOUiD (ORCPT ); Thu, 15 Apr 2021 16:38:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34546 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235251AbhDOUiB (ORCPT ); Thu, 15 Apr 2021 16:38:01 -0400 Received: from mail-pf1-x429.google.com (mail-pf1-x429.google.com [IPv6:2607:f8b0:4864:20::429]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 52D97C061574 for ; Thu, 15 Apr 2021 13:37:37 -0700 (PDT) Received: by mail-pf1-x429.google.com with SMTP id p67so11911453pfp.10 for ; Thu, 15 Apr 2021 13:37:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=vObk5zpfxMuIbD3QrtDnjfXIj3YNa+wCetzq4YqI/Ys=; b=jFuHk7s+f9q7wrY3o3n5mT6FaLvMYQsuXRb9E4r2sVuVSavAoOQE97qyAqwGwSHPjL cxyNkCn51HFKKfiQg4YuflgIVh/sU+5/TJTLTNXy88r4eCREQ6yOPW5iVGc8/M1UwFNf dNotMU2eu0pi6gYuk5WEDtEIrI2ef5JDgprKeTwKMurZg4MMlt0Cq58NToqv7Xne0En6 SstFDcQUu2WaoGHmxixsZJ1E5O/3RQN77l22m4uYjtIMP7D4k4kFrNkhGjh+amrlo/Gn WsW/ETiiioEpndHSdUOzl+M6mEAkWVPCz+/YMErQnbXH4vx6UNXfNHGDarQis8Kjkooz TQjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=vObk5zpfxMuIbD3QrtDnjfXIj3YNa+wCetzq4YqI/Ys=; b=V7A40mxxn0+/AYI+IpIcWp6KA2M/NBGBGmt7LO/OGztfTpQ1hltx/IVRe6jE0zRzZb S5yquauLxLVimuOfoTl4y8B5RYIVDWmg0YLIAadNQJGo5D8p6mQcZKSow/ineEHyVHI8 K/wSngVjclEwG94exKx4i8HM3i8HbWHSnCADfLYPhOzpgjvCZEiZEQari4D5cVQdl21u vRjS5VlBfR4vpzyIU74/d2ji7huvpiCEtLbkH5EMuKRmjEiojHg1n7YHVdUSqxVfJWVz 6StMZE7z4/uaneTadYSKxRtDuv4rEV+bezTqCtlbJb0b9lsYyv2XCTKT2QEUcGnflrXH qgmQ== X-Gm-Message-State: AOAM533NylNH9izmHpzu4LJyUvrVpTE5lry4VKG3T4XK+34OMgQc/4Qp qLmiikDQuSVn1IdL4oZ+bxpYKg== X-Google-Smtp-Source: ABdhPJyfg2R+ssZa5r6cIL/CR4EUg2vTi5YKkIspyQJx2qSZYuKvfHn4PzCtsx/al20OzOj0WXdsGg== X-Received: by 2002:a63:fb15:: with SMTP id o21mr5024855pgh.337.1618519056848; Thu, 15 Apr 2021 13:37:36 -0700 (PDT) Received: from xps15 (S0106889e681aac74.cg.shawcable.net. [68.147.0.187]) by smtp.gmail.com with ESMTPSA id g18sm2828703pfb.178.2021.04.15.13.37.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Apr 2021 13:37:30 -0700 (PDT) Date: Thu, 15 Apr 2021 14:37:28 -0600 From: Mathieu Poirier To: James Clark Cc: coresight@lists.linaro.org, al.grant@arm.com, branislav.rankov@arm.com, denik@chromium.org, suzuki.poulose@arm.com, Mike Leach , Leo Yan , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , John Garry , Will Deacon , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/7] Split Coresight decode by aux records Message-ID: <20210415203728.GD937505@xps15> References: <20210212144513.31765-1-james.clark@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210212144513.31765-1-james.clark@arm.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi James, On Fri, Feb 12, 2021 at 04:45:06PM +0200, James Clark wrote: > Hi All, > > Since my previous RFC, I've fixed --per-thread mode and solved > most of the open questions. I've also changed --dump-raw-trace > to use the same code path so it's also working now. > > I think the only open questions are: > * General approach > * If aux records need to be saved, or if they can be pulled > from elsewhere. > > I've also tested perf inject which is now working with troublesome > files. > This patchset is now at the top of the coresight review list. I suggest you rebase this on top of your two timestamp related patches and send another revision. > Thanks > James > > James Clark (7): > perf cs-etm: Split up etm queue setup function > perf cs-etm: Only search timestamp in current sample's queue. > perf cs-etm: Save aux records in each etm queue > perf cs-etm: don't process queues until cs_etm__flush_events > perf cs-etm: split decode by aux records. > perf cs-etm: Use existing decode code path for --dump-raw-trace > perf cs-etm: Suppress printing when resetting decoder > > .../perf/util/cs-etm-decoder/cs-etm-decoder.c | 10 +- > tools/perf/util/cs-etm.c | 300 ++++++++++-------- > 2 files changed, 168 insertions(+), 142 deletions(-) > > -- > 2.28.0 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8125C43460 for ; Thu, 15 Apr 2021 20:39:51 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3AC2F61132 for ; Thu, 15 Apr 2021 20:39:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3AC2F61132 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Slq6Jx2CdeFrVHsiY8gU1xOPP8ofrrQbvn+ACVoWc1o=; b=Jo3Z7+ZV91QX4TNmxxabfL4Bl twQz2swuNPSRVVPvjPk7YyID41PxrKyuZMJlOZf+ERbB8KK6IYgo6xqkFc0dDe2eBVQ2WiWKL7q19 TmGo5sBTUY6SxHeJFYKfE99VEwPWbYt0s9enQoq8txEzDOfqIMQhQzOV/bDzSK3klJqIRH7enwo4+ W9SdED+xVoGlWXsuiiYWGZiFAZWPmei76Z1xG8p1Bm2wtiLikI3/5eaIiH4SZfhvm6VrwQvj9Ide7 uDSfh477uUDMzQs9sS98L3/AwZKWjO6yFDXEoAJw29JL+Kwv6MhHAp93NhMzbuqAwqf6IEuhkvYjg ZLOsVI8Aw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lX8kU-00HHgJ-3V; Thu, 15 Apr 2021 20:38:02 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lX8k8-00HHcm-O0 for linux-arm-kernel@desiato.infradead.org; Thu, 15 Apr 2021 20:37:43 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=vObk5zpfxMuIbD3QrtDnjfXIj3YNa+wCetzq4YqI/Ys=; b=mI8pCrC0QTEDkmE/rRMyxzVDW+ tn4U+rosmH+sZFvPqCQgk9mjozWho4KxV9XMl9qLEFQDXlaW3BaLlMgXEOJZAtLc58RsOUb7GDhGz yHIJKCmXJcUA6/73VGnVl8y++Dxw2611musGkkCuAEahmNeGdcaYTgaiGon3YgG3saOUYPf1Tpc9e NaRuXpyy8NFdoP4G6GVetdXFu3JZqPPpKczg+OzZemDE4o720URd43sj5dN+fgxee5/IZ1ugNl5Fi wccMCKVP0/oqWOfHJP42uPSSokTpl2RJ+tExFhjpwDrPNsU8artM3AIziGRUClYhrwAyFNbNEq131 YTzBWnIw==; Received: from mail-pf1-x42b.google.com ([2607:f8b0:4864:20::42b]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lX8k6-008sgv-6z for linux-arm-kernel@lists.infradead.org; Thu, 15 Apr 2021 20:37:39 +0000 Received: by mail-pf1-x42b.google.com with SMTP id d124so16826521pfa.13 for ; Thu, 15 Apr 2021 13:37:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=vObk5zpfxMuIbD3QrtDnjfXIj3YNa+wCetzq4YqI/Ys=; b=jFuHk7s+f9q7wrY3o3n5mT6FaLvMYQsuXRb9E4r2sVuVSavAoOQE97qyAqwGwSHPjL cxyNkCn51HFKKfiQg4YuflgIVh/sU+5/TJTLTNXy88r4eCREQ6yOPW5iVGc8/M1UwFNf dNotMU2eu0pi6gYuk5WEDtEIrI2ef5JDgprKeTwKMurZg4MMlt0Cq58NToqv7Xne0En6 SstFDcQUu2WaoGHmxixsZJ1E5O/3RQN77l22m4uYjtIMP7D4k4kFrNkhGjh+amrlo/Gn WsW/ETiiioEpndHSdUOzl+M6mEAkWVPCz+/YMErQnbXH4vx6UNXfNHGDarQis8Kjkooz TQjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=vObk5zpfxMuIbD3QrtDnjfXIj3YNa+wCetzq4YqI/Ys=; b=HY6wvyTr+TL8YIDCn2NXqOqpnZPvSigP1bCoex5AaD5jha/IGlV0kwQLy9rsKZ7t26 3Zqag4HEvW+m2mNUHXHnlORnzwAmIBSDBjzq+beLEkfSGnDpsP4yNPccNaCEDV+xvwPt YuDgxZfsjdoFNkEVrUUfR3yO61q0fVlu8/Gr7x7wj6riM7N16E63Il3LeB32yflbwCqC 53rNUgIVjv9IPM3OXAWAtvk3KkYW6djSERswk1+DL2OK6RSpKhqEpkKPZG7EpYjIGtch zuwBYTZsTfD82EsuL65X/3boUhv11yWTPTls/mu9CmPrpWzVyMbYhsJWL8MJijNH7QiT LOiw== X-Gm-Message-State: AOAM532S4N7WH0H/zg16byP1HtNLCI7buNfAV/h6pEN/f5D6nqSCVN8f XIZjaumSfxAkgeBBHh35k8//UQ== X-Google-Smtp-Source: ABdhPJyfg2R+ssZa5r6cIL/CR4EUg2vTi5YKkIspyQJx2qSZYuKvfHn4PzCtsx/al20OzOj0WXdsGg== X-Received: by 2002:a63:fb15:: with SMTP id o21mr5024855pgh.337.1618519056848; Thu, 15 Apr 2021 13:37:36 -0700 (PDT) Received: from xps15 (S0106889e681aac74.cg.shawcable.net. [68.147.0.187]) by smtp.gmail.com with ESMTPSA id g18sm2828703pfb.178.2021.04.15.13.37.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Apr 2021 13:37:30 -0700 (PDT) Date: Thu, 15 Apr 2021 14:37:28 -0600 From: Mathieu Poirier To: James Clark Cc: coresight@lists.linaro.org, al.grant@arm.com, branislav.rankov@arm.com, denik@chromium.org, suzuki.poulose@arm.com, Mike Leach , Leo Yan , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , John Garry , Will Deacon , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/7] Split Coresight decode by aux records Message-ID: <20210415203728.GD937505@xps15> References: <20210212144513.31765-1-james.clark@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210212144513.31765-1-james.clark@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210415_133738_279143_DC6A76FF X-CRM114-Status: GOOD ( 18.10 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi James, On Fri, Feb 12, 2021 at 04:45:06PM +0200, James Clark wrote: > Hi All, > > Since my previous RFC, I've fixed --per-thread mode and solved > most of the open questions. I've also changed --dump-raw-trace > to use the same code path so it's also working now. > > I think the only open questions are: > * General approach > * If aux records need to be saved, or if they can be pulled > from elsewhere. > > I've also tested perf inject which is now working with troublesome > files. > This patchset is now at the top of the coresight review list. I suggest you rebase this on top of your two timestamp related patches and send another revision. > Thanks > James > > James Clark (7): > perf cs-etm: Split up etm queue setup function > perf cs-etm: Only search timestamp in current sample's queue. > perf cs-etm: Save aux records in each etm queue > perf cs-etm: don't process queues until cs_etm__flush_events > perf cs-etm: split decode by aux records. > perf cs-etm: Use existing decode code path for --dump-raw-trace > perf cs-etm: Suppress printing when resetting decoder > > .../perf/util/cs-etm-decoder/cs-etm-decoder.c | 10 +- > tools/perf/util/cs-etm.c | 300 ++++++++++-------- > 2 files changed, 168 insertions(+), 142 deletions(-) > > -- > 2.28.0 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel