From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D470C433B4 for ; Fri, 16 Apr 2021 09:43:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E2DC16115B for ; Fri, 16 Apr 2021 09:43:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235349AbhDPJoD (ORCPT ); Fri, 16 Apr 2021 05:44:03 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:60465 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235027AbhDPJoD (ORCPT ); Fri, 16 Apr 2021 05:44:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1618566218; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=0tOmO2L7ffsG3OHqCgxG9Ex0uvhoWJPoKZqPNeCsosE=; b=jO+0+x0s/trfIV/AT2c4dCt2XPdJSQGVix+HgC+/skfCJcXcgm9nWtp1Ga45GtmZk9wogY BKuWZuwJhmwABoQyt9ZBcwN2tvfczQGe58rXyyI/aTwWQKSjv6N5e/tUnlpMEc2x86gkkf UYkDerx8g2FX2g6ztQ1rB0+X7QKk0H8= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-157-NQK4CrDJPaWKXSaDjWc14A-1; Fri, 16 Apr 2021 05:43:36 -0400 X-MC-Unique: NQK4CrDJPaWKXSaDjWc14A-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 1596DCC624; Fri, 16 Apr 2021 09:43:35 +0000 (UTC) Received: from dhcp-27-174.brq.redhat.com (unknown [10.40.193.62]) by smtp.corp.redhat.com (Postfix) with SMTP id AA49169FA4; Fri, 16 Apr 2021 09:43:27 +0000 (UTC) Received: by dhcp-27-174.brq.redhat.com (nbSMTP-1.00) for uid 1000 oleg@redhat.com; Fri, 16 Apr 2021 11:43:34 +0200 (CEST) Date: Fri, 16 Apr 2021 11:43:25 +0200 From: Oleg Nesterov To: He Zhe Cc: catalin.marinas@arm.com, will@kernel.org, linux-arm-kernel@lists.infradead.org, paul@paul-moore.com, eparis@redhat.com, linux-audit@redhat.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/3] arm64: syscall.h: Add sign extension handling in syscall_get_return_value for compat Message-ID: <20210416094324.GA1962@redhat.com> References: <20210416075533.7720-1-zhe.he@windriver.com> <20210416075533.7720-2-zhe.he@windriver.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210416075533.7720-2-zhe.he@windriver.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/16, He Zhe wrote: > > --- a/arch/arm64/include/asm/syscall.h > +++ b/arch/arm64/include/asm/syscall.h > @@ -44,7 +44,12 @@ static inline long syscall_get_error(struct task_struct *task, > static inline long syscall_get_return_value(struct task_struct *task, > struct pt_regs *regs) > { > - return regs->regs[0]; > + long val = regs->regs[0]; > + > + if (is_compat_thread(task_thread_info(task))) > + val = sign_extend64(val, 31); > + > + return val; > } I can't really review these arm-specific patches, but with this change both syscall_get_error() and is_syscall_success() can use syscall_get_return_value() to avoid the code duplication. Oleg. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14EE5C433B4 for ; Fri, 16 Apr 2021 09:43:48 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A31FA610C8 for ; Fri, 16 Apr 2021 09:43:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A31FA610C8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=tempfail smtp.mailfrom=linux-audit-bounces@redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1618566226; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=OQ06O2PQcEPFGqISNMCvLMLOHcp6sCsd+HOVAwzVBHw=; b=KeP6dUGukkaIvvKa6ngJ6XrPhF9DNoD9yltyozmNnZy6dxCcju1HJkHCc45e3XpWfqfUE2 yZtT/fB5gsAyRhago1/6NEHjIg5VcsosiZhxJ9O9Od3vNFbcSZPuuvpdyZhNyPQFkvRfZQ 6BT2xqovyUvINloNN7VmgUK1kDVyosk= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-25-JDbhBkbYOMKcJTUZOpgpyg-1; Fri, 16 Apr 2021 05:43:44 -0400 X-MC-Unique: JDbhBkbYOMKcJTUZOpgpyg-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 0DE6C18957FF; Fri, 16 Apr 2021 09:43:40 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4305E5C8AA; Fri, 16 Apr 2021 09:43:39 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 45B4C9995; Fri, 16 Apr 2021 09:43:37 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 13G9hZbk006770 for ; Fri, 16 Apr 2021 05:43:35 -0400 Received: by smtp.corp.redhat.com (Postfix) id 1470E5945A; Fri, 16 Apr 2021 09:43:35 +0000 (UTC) Received: from dhcp-27-174.brq.redhat.com (unknown [10.40.193.62]) by smtp.corp.redhat.com (Postfix) with SMTP id AA49169FA4; Fri, 16 Apr 2021 09:43:27 +0000 (UTC) Received: by dhcp-27-174.brq.redhat.com (nbSMTP-1.00) for uid 1000 oleg@redhat.com; Fri, 16 Apr 2021 11:43:34 +0200 (CEST) Date: Fri, 16 Apr 2021 11:43:25 +0200 From: Oleg Nesterov To: He Zhe Subject: Re: [PATCH 2/3] arm64: syscall.h: Add sign extension handling in syscall_get_return_value for compat Message-ID: <20210416094324.GA1962@redhat.com> References: <20210416075533.7720-1-zhe.he@windriver.com> <20210416075533.7720-2-zhe.he@windriver.com> MIME-Version: 1.0 In-Reply-To: <20210416075533.7720-2-zhe.he@windriver.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-loop: linux-audit@redhat.com Cc: catalin.marinas@arm.com, linux-kernel@vger.kernel.org, linux-audit@redhat.com, will@kernel.org, linux-arm-kernel@lists.infradead.org X-BeenThere: linux-audit@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Linux Audit Discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-audit-bounces@redhat.com Errors-To: linux-audit-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=linux-audit-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On 04/16, He Zhe wrote: > > --- a/arch/arm64/include/asm/syscall.h > +++ b/arch/arm64/include/asm/syscall.h > @@ -44,7 +44,12 @@ static inline long syscall_get_error(struct task_struct *task, > static inline long syscall_get_return_value(struct task_struct *task, > struct pt_regs *regs) > { > - return regs->regs[0]; > + long val = regs->regs[0]; > + > + if (is_compat_thread(task_thread_info(task))) > + val = sign_extend64(val, 31); > + > + return val; > } I can't really review these arm-specific patches, but with this change both syscall_get_error() and is_syscall_success() can use syscall_get_return_value() to avoid the code duplication. Oleg. -- Linux-audit mailing list Linux-audit@redhat.com https://listman.redhat.com/mailman/listinfo/linux-audit From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E845C433ED for ; Fri, 16 Apr 2021 09:55:45 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 366CC6115B for ; Fri, 16 Apr 2021 09:55:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 366CC6115B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=7hD1XL5ztBO7F+17UG/GDAeVAscLvHzJ5uMAxe/9aoQ=; b=GJoqadaGbAxI8JcAN4F6m8FEu cc/QS/acWtMDzw9PNyt1DMlFAFid+8zxWzNEdIBD63KbHjkl0IteScKc+sN8Ntj/UCWprrwyQVSnC NIPFyzL8Re5pW1yFq5tMuHkH2//mvD0mkvjH4QYDNgC7RSJnq0+bM4pnSOmaTR5FVKkdBAT0qSHTT wCS6EhT3BgWtmu/1qU/dx4eriwLYPyrIWvgrQ0AfNv/U7haeSvfweuq4SeoePC+B7347oYXz2ffs1 ZTZTjJLHYj1ej64RA3ziGEva6/nkp84zdHrj0SdiXdZrtq+VR5KHJLdvQjxwBT0vTOCwzbHoRcJCG y0ZeKm92g==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lXLAP-001d6d-1m; Fri, 16 Apr 2021 09:53:37 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lXL0r-001aeY-Vi for linux-arm-kernel@desiato.infradead.org; Fri, 16 Apr 2021 09:43:51 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=0tOmO2L7ffsG3OHqCgxG9Ex0uvhoWJPoKZqPNeCsosE=; b=Gjd+WoC42HTk5x0NyU/LDevPvP EeG8yaZlLEt3hp7MQbRA+7w/Vfg1OECVe2KP1Ya3iOPviRDuHwiCHnoigg5vdvptYx/F130BspzuO p4Ri9y1mg7GSuSJrkZC1WeIs0fogvog/Ugu7M4746VmWN5/sXfCEhCVotQ316pgfn4BcUe/gnqkSQ ksCbvbJg4YXmNnDX78etbibn0CUjFj+zFN/ISrUaSjD0Zjns4j6HG7aTAO/ZVIcu9kZcyi+RUgztG tttGRooRnQ8OGd0SMxig51bZNher/dDSemWESxLgfc04bfjUH8THOn6rkQeoOg7Bm5WoWhTPa6Z7k F9/IoTDw==; Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lXL0p-009Fc0-FG for linux-arm-kernel@lists.infradead.org; Fri, 16 Apr 2021 09:43:44 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1618566218; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=0tOmO2L7ffsG3OHqCgxG9Ex0uvhoWJPoKZqPNeCsosE=; b=jO+0+x0s/trfIV/AT2c4dCt2XPdJSQGVix+HgC+/skfCJcXcgm9nWtp1Ga45GtmZk9wogY BKuWZuwJhmwABoQyt9ZBcwN2tvfczQGe58rXyyI/aTwWQKSjv6N5e/tUnlpMEc2x86gkkf UYkDerx8g2FX2g6ztQ1rB0+X7QKk0H8= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-157-NQK4CrDJPaWKXSaDjWc14A-1; Fri, 16 Apr 2021 05:43:36 -0400 X-MC-Unique: NQK4CrDJPaWKXSaDjWc14A-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 1596DCC624; Fri, 16 Apr 2021 09:43:35 +0000 (UTC) Received: from dhcp-27-174.brq.redhat.com (unknown [10.40.193.62]) by smtp.corp.redhat.com (Postfix) with SMTP id AA49169FA4; Fri, 16 Apr 2021 09:43:27 +0000 (UTC) Received: by dhcp-27-174.brq.redhat.com (nbSMTP-1.00) for uid 1000 oleg@redhat.com; Fri, 16 Apr 2021 11:43:34 +0200 (CEST) Date: Fri, 16 Apr 2021 11:43:25 +0200 From: Oleg Nesterov To: He Zhe Cc: catalin.marinas@arm.com, will@kernel.org, linux-arm-kernel@lists.infradead.org, paul@paul-moore.com, eparis@redhat.com, linux-audit@redhat.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/3] arm64: syscall.h: Add sign extension handling in syscall_get_return_value for compat Message-ID: <20210416094324.GA1962@redhat.com> References: <20210416075533.7720-1-zhe.he@windriver.com> <20210416075533.7720-2-zhe.he@windriver.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210416075533.7720-2-zhe.he@windriver.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210416_024343_604416_6C533B8B X-CRM114-Status: GOOD ( 12.69 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 04/16, He Zhe wrote: > > --- a/arch/arm64/include/asm/syscall.h > +++ b/arch/arm64/include/asm/syscall.h > @@ -44,7 +44,12 @@ static inline long syscall_get_error(struct task_struct *task, > static inline long syscall_get_return_value(struct task_struct *task, > struct pt_regs *regs) > { > - return regs->regs[0]; > + long val = regs->regs[0]; > + > + if (is_compat_thread(task_thread_info(task))) > + val = sign_extend64(val, 31); > + > + return val; > } I can't really review these arm-specific patches, but with this change both syscall_get_error() and is_syscall_success() can use syscall_get_return_value() to avoid the code duplication. Oleg. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel