From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19AC9C433B4 for ; Fri, 16 Apr 2021 15:07:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F31C661001 for ; Fri, 16 Apr 2021 15:07:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245546AbhDPPHk (ORCPT ); Fri, 16 Apr 2021 11:07:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52306 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245035AbhDPPHi (ORCPT ); Fri, 16 Apr 2021 11:07:38 -0400 Received: from mail-pj1-x102b.google.com (mail-pj1-x102b.google.com [IPv6:2607:f8b0:4864:20::102b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 24688C061574 for ; Fri, 16 Apr 2021 08:07:12 -0700 (PDT) Received: by mail-pj1-x102b.google.com with SMTP id f2-20020a17090a4a82b02900c67bf8dc69so16567051pjh.1 for ; Fri, 16 Apr 2021 08:07:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=qvRPd9mJKRx11Shv+OyTN/o/Bvjy/gaC5xNSiISaZwo=; b=g08ANfEZT2d6VY2y52OdJOvS9/b1mZSA7c+Jo1sA2FPH8q9i+09GskgqqXvKUdkSOx iu+y+gK8WpaNyA1V6z0XT0TBhreeLBI7aJM7oeDrKwdaeWEZN6vY54tnEpTmqK/obSTe FaAi9VsJM5SHEqfam9+6cCvsCAwwlmwgC79oYHhb9WdD5i0K59EdQBXEXyodLndfRBpl NnCacMIFBKoZUTG0epfo1NbtUn19WXN8yAIuY6Ob1faQMb/6Tn3pYntUNub3bnIYMauj Qd1WSq8tp28qVml5F7HkyqUVX0qR89M3nUTMTlpCXCANmB2Z5DBKQDc5T/lLxCag8Nq2 eE1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=qvRPd9mJKRx11Shv+OyTN/o/Bvjy/gaC5xNSiISaZwo=; b=le/U5uRRGw8LXTs1NYjIs7igOYmUzrzWkHww3aomYqsuXgxM1VlCXOJ5MAVDbuWgwB DGtkSvez4Ps/VBO3w0XSBUbpMHxRfHOI8TE1GnYUjUzB8l9W46YRMStqKm7SaEJf1aZe nPW3FqlpkkFnlXKtqevULYTufrAj31Uvavk051ezNkjx2zUxG8DMhUuQ58F/3u9ZHFz3 nKHYAqLkdhpxZAErkmBAMsJxx9fpGpovUSI3PO3NbTVcWIZUQUkDrcpuClX1bw07WR6F IOQQehV1tRSGLSFJOlNpERhfmzXyDJADPaolS+Y7g3Xn7OycrDyBht7zBh6MKGZx51EA ZhBw== X-Gm-Message-State: AOAM531wfaiDy8f2+NA/Qe5yMa8PWtaUx3lTxAn/+aahU1joxHcscSQs FBs6r26q/TDA14cAy8DoynV7Ug== X-Google-Smtp-Source: ABdhPJw/TvRlw4eu+nGgPjVquPv+r/N1Q8Ytb4wzK/E+5VbvXcS28/9OfbX37TdfIIoycQvIdJO+/Q== X-Received: by 2002:a17:903:2310:b029:eb:73d5:3e4e with SMTP id d16-20020a1709032310b02900eb73d53e4emr9661606plh.66.1618585631641; Fri, 16 Apr 2021 08:07:11 -0700 (PDT) Received: from xps15 (S0106889e681aac74.cg.shawcable.net. [68.147.0.187]) by smtp.gmail.com with ESMTPSA id t184sm5196525pgt.32.2021.04.16.08.07.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Apr 2021 08:07:11 -0700 (PDT) Date: Fri, 16 Apr 2021 09:07:09 -0600 From: Mathieu Poirier To: James Clark Cc: coresight@lists.linaro.org, acme@kernel.org, al.grant@arm.com, branislav.rankov@arm.com, denik@chromium.org, suzuki.poulose@arm.com, Mike Leach , Leo Yan , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , John Garry , Will Deacon , linux-arm-kernel@lists.infradead.org, linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 0/2] perf cs-etm: Set time on synthesised samples to preserve ordering Message-ID: <20210416150709.GA1046932@xps15> References: <20210416105632.8771-1-james.clark@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210416105632.8771-1-james.clark@arm.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi James, On Fri, Apr 16, 2021 at 01:56:30PM +0300, James Clark wrote: > Changes since v1: > * Improved variable name from etm_timestamp -> cs_timestamp > * Fixed ordering of Signed-off-by > You forgot to add the RB and AB you received. Since Arnaldo is responsible for the perf tools subsystem, please send another revision. Thanks, Mathieu > James Clark (2): > perf cs-etm: Refactor timestamp variable names > perf cs-etm: Set time on synthesised samples to preserve ordering > > .../perf/util/cs-etm-decoder/cs-etm-decoder.c | 18 +++---- > tools/perf/util/cs-etm.c | 52 ++++++++++--------- > tools/perf/util/cs-etm.h | 4 +- > 3 files changed, 39 insertions(+), 35 deletions(-) > > -- > 2.28.0 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52B7CC433ED for ; Fri, 16 Apr 2021 15:09:38 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C5AE261001 for ; Fri, 16 Apr 2021 15:09:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C5AE261001 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=oNbo8uBh1z/laVrDgeFxpT4Bcb/cJZ5DYebhG2wgF7Q=; b=M6ZNSOjYN+4XMOnC48eSiQb+j HUF1Eal3j3ayqTGq5IKGFg24ZoQWvZvQYQCi5qKeCeb7HiWpMBtlGuVRfgoUTvJCRRkSpmr/DI91R LlssXDLL/xIrz6oPENAvjjTPSYmPcwAlt3uK58Us32Y2xkMQo1+3qh0Gcdo0H2Z9GTol1zfm8ke4S xsovKmb2KZnoevEt6B1WcRnN3Zaz/EDYx3CafLqNT7fEAUzVOu5NltR5dyPhR3CMowb38tOMjv34d OF6KdloNt97N/z6nWOvvNuqsW5b93s9IxoVMHcy6Pnthu5PrZqrrnKosd0GEa85GApu2X5NBMF4IA eJR89qTLQ==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lXQ41-002YYH-K9; Fri, 16 Apr 2021 15:07:21 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lXQ3y-002YXc-8Q for linux-arm-kernel@desiato.infradead.org; Fri, 16 Apr 2021 15:07:18 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=qvRPd9mJKRx11Shv+OyTN/o/Bvjy/gaC5xNSiISaZwo=; b=GS7YFRv4ubRhHM5MJ0RdNgFcjS JpFMrpNHOyNxMIlyx9m7MC0Lg/hIYYlJBdYg+ID+Y32Fp6lptQET77IKrwcPf1kjJmjORarYdVSvc hlw98QfpP44dwqqbUv5EEcO9y6TC/6NuDNjFoEH2C4NQeYthEaHGUT1JrM9jb+V7uIL6jMnHl8Zqo dyX1cRfvvR2ljZNC3Mt2Cn40LsgFfpg07dEsq6W5ACzGCvkbAIP/swqttjkW39qdvliLLKpMQTKyb LHYzDgC8WPVLdFFrW8WdSFdpHXbUHT29Wws5WE4dqXlsTQc6i6btX8c/Z8nGVbqX57p84Ntf9Cc0N FHDKaByw==; Received: from mail-pl1-x62c.google.com ([2607:f8b0:4864:20::62c]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lXQ3t-009UNm-0M for linux-arm-kernel@lists.infradead.org; Fri, 16 Apr 2021 15:07:16 +0000 Received: by mail-pl1-x62c.google.com with SMTP id u7so12320073plr.6 for ; Fri, 16 Apr 2021 08:07:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=qvRPd9mJKRx11Shv+OyTN/o/Bvjy/gaC5xNSiISaZwo=; b=g08ANfEZT2d6VY2y52OdJOvS9/b1mZSA7c+Jo1sA2FPH8q9i+09GskgqqXvKUdkSOx iu+y+gK8WpaNyA1V6z0XT0TBhreeLBI7aJM7oeDrKwdaeWEZN6vY54tnEpTmqK/obSTe FaAi9VsJM5SHEqfam9+6cCvsCAwwlmwgC79oYHhb9WdD5i0K59EdQBXEXyodLndfRBpl NnCacMIFBKoZUTG0epfo1NbtUn19WXN8yAIuY6Ob1faQMb/6Tn3pYntUNub3bnIYMauj Qd1WSq8tp28qVml5F7HkyqUVX0qR89M3nUTMTlpCXCANmB2Z5DBKQDc5T/lLxCag8Nq2 eE1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=qvRPd9mJKRx11Shv+OyTN/o/Bvjy/gaC5xNSiISaZwo=; b=BFd5WPKxx0iwstM0E0xR+6h+H9SRQiK+4ueje7LSNXI2QQ8/ne/HcgBHEHYShk/dpT LhVB7Vm32RdV+3ESdaTsd1cOOFmaB3F8hjbkK2EzkKbyOXEB0Zvocgbii6nov+P91g88 cPiZxiRxAb3AHSk83lyfmxayHHZlxPNxGtnw3oh6YzazoD3xNMed91Ql+P+iQvwyNe5o WfkDXfTk8u8rQbwt/bwT/9hZ+xbvfTYhRjFmCxgBBXKcCDEZNTEDI/4ags3ZQULSC/aa z+iLWVtd1wjBVDCBNVq2b/Er/iRTb+uyNeKWUKFm/+qn5ks10++E3W08oGhm7hxrvK/h H2Pg== X-Gm-Message-State: AOAM531Ke0VLc8LBWmngTOss8yBqHQIhJ9sDiLvnurq7CdrdND903EVX PwrXMbOQ0V7j3ykuTVPWwvIswQ== X-Google-Smtp-Source: ABdhPJw/TvRlw4eu+nGgPjVquPv+r/N1Q8Ytb4wzK/E+5VbvXcS28/9OfbX37TdfIIoycQvIdJO+/Q== X-Received: by 2002:a17:903:2310:b029:eb:73d5:3e4e with SMTP id d16-20020a1709032310b02900eb73d53e4emr9661606plh.66.1618585631641; Fri, 16 Apr 2021 08:07:11 -0700 (PDT) Received: from xps15 (S0106889e681aac74.cg.shawcable.net. [68.147.0.187]) by smtp.gmail.com with ESMTPSA id t184sm5196525pgt.32.2021.04.16.08.07.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Apr 2021 08:07:11 -0700 (PDT) Date: Fri, 16 Apr 2021 09:07:09 -0600 From: Mathieu Poirier To: James Clark Cc: coresight@lists.linaro.org, acme@kernel.org, al.grant@arm.com, branislav.rankov@arm.com, denik@chromium.org, suzuki.poulose@arm.com, Mike Leach , Leo Yan , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , John Garry , Will Deacon , linux-arm-kernel@lists.infradead.org, linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 0/2] perf cs-etm: Set time on synthesised samples to preserve ordering Message-ID: <20210416150709.GA1046932@xps15> References: <20210416105632.8771-1-james.clark@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210416105632.8771-1-james.clark@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210416_080713_070404_A6C0EBB7 X-CRM114-Status: GOOD ( 12.33 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi James, On Fri, Apr 16, 2021 at 01:56:30PM +0300, James Clark wrote: > Changes since v1: > * Improved variable name from etm_timestamp -> cs_timestamp > * Fixed ordering of Signed-off-by > You forgot to add the RB and AB you received. Since Arnaldo is responsible for the perf tools subsystem, please send another revision. Thanks, Mathieu > James Clark (2): > perf cs-etm: Refactor timestamp variable names > perf cs-etm: Set time on synthesised samples to preserve ordering > > .../perf/util/cs-etm-decoder/cs-etm-decoder.c | 18 +++---- > tools/perf/util/cs-etm.c | 52 ++++++++++--------- > tools/perf/util/cs-etm.h | 4 +- > 3 files changed, 39 insertions(+), 35 deletions(-) > > -- > 2.28.0 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel