From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4E3BC43461 for ; Fri, 16 Apr 2021 15:16:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 99255611AC for ; Fri, 16 Apr 2021 15:16:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343565AbhDPPQT (ORCPT ); Fri, 16 Apr 2021 11:16:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53968 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245607AbhDPPPe (ORCPT ); Fri, 16 Apr 2021 11:15:34 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BEBE5C061760 for ; Fri, 16 Apr 2021 08:14:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=PU2zCwS/Qv6b1mmm7MYSjXwyl88SOWkJFLmy1YTNvpE=; b=fr40blTGBi0mReACgRFRj3i5CK EQVXGvjjGqbONfxml7WrtbWkmAR4pV7AI/4ul9rsLP9yYLxFrEuJ6+2uOQ75IcyAkOdMTov9veWaD KO0ebU/XHJl8QPmWTTWgKjhMURNQYfp5LmHzTPfiY2rmN8vRYt9ZXhz+xMntJBA4GHmGybJfjFiAc USk7WVZoRGmJWCuraGfL+yNV0WfiXlU758/v1mNHGvbeR0E8zXF8VGCaGoisiToPVW5UwYagLh4J/ ZvABEcJUcduS3tuupbWnYaELU62BS6CI+hST0lNV2ryMHXdkMg9hOkyzeE2k6ebcT9Cldi8ZJjd/W jX4V0jKQ==; Received: from willy by casper.infradead.org with local (Exim 4.94 #2 (Red Hat Linux)) id 1lXQAX-00A6WF-Pv; Fri, 16 Apr 2021 15:14:07 +0000 Date: Fri, 16 Apr 2021 16:14:05 +0100 From: Matthew Wilcox To: Mike Marshall Cc: David Howells , linux-fsdevel Subject: Re: [RFC PATCH v2] implement orangefs_readahead Message-ID: <20210416151405.GK2531743@casper.infradead.org> References: <20210327135659.GH1719932@casper.infradead.org> <20210327155630.GJ1719932@casper.infradead.org> <1720948.1617010659@warthog.procyon.org.uk> <1268214.1618326494@warthog.procyon.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Fri, Apr 16, 2021 at 10:36:52AM -0400, Mike Marshall wrote: > So... I think all your stuff is working well from my perspective > and that I need to figure out why my orangefs_readahead patch > is causing the regressions I listed. My readahead implementation (via your > readahead_expand) is really fast, but it is bare-bones... I'm probably > leaving out some important stuff... I see other filesystem's > readahead implementations doing stuff like avoiding doing readahead > on pages that have yet to be written back for example. You do?! Actual readahead implementations, or people still implementing the old ->readpages() method? The ->readahead() method is _only_ called for pages which are freshly allocated, Locked and !Uptodate. If you ever see a page which is Dirty or Writeback, something has gone very wrong. Could you tell me which filesystem you saw that bogosity in? > The top two commits at https://github.com/hubcapsc/linux/tree/readahead_v3 > is the current state of my readahead implementation. > > Please do add > Tested-by: Mike Marshall > > -Mike > > On Tue, Apr 13, 2021 at 11:08 AM David Howells wrote: > > > > Mike Marshall wrote: > > > > > Hi David... I've been gone on a motorcycle adventure, > > > sorry for the delay... here's my public branch... > > > > > > https://github.com/hubcapsc/linux/tree/readahead_v3 > > > > That seems to have all of my fscache-iter branch in it. I thought you'd said > > you'd dropped them because they were causing problems. > > > > Anyway, I've distilled the basic netfs lib patches, including the readahead > > expansion patch and ITER_XARRAY patch here: > > > > https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git/log/?h=netfs-lib > > > > if that's of use to you? > > > > If you're using any of these patches, would it be possible to get a Tested-by > > for them that I can add? > > > > David > >