From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 478F0C43611 for ; Fri, 16 Apr 2021 22:41:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A4455613D5 for ; Fri, 16 Apr 2021 22:41:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235144AbhDPWlg (ORCPT ); Fri, 16 Apr 2021 18:41:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39882 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235081AbhDPWlc (ORCPT ); Fri, 16 Apr 2021 18:41:32 -0400 Received: from mail-pg1-x533.google.com (mail-pg1-x533.google.com [IPv6:2607:f8b0:4864:20::533]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D6B8CC061761 for ; Fri, 16 Apr 2021 15:41:06 -0700 (PDT) Received: by mail-pg1-x533.google.com with SMTP id w10so20145364pgh.5 for ; Fri, 16 Apr 2021 15:41:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ymf7bx9leANTZpwnVQiZwmb6scbgdaMgrPOZD8Is/h4=; b=jc6u9p8ciGL2bCqxuj4ZDGRafg8l47hR2Cs2zA5qqs87Co5cL2GIT6wd1jW3ZFwgMQ fALkWO05ogZ8dPwsvZTobEUsF0bYwmWTGWnFCJjI6KZOg+KEQVV0n/eQoXZLNeNes1Oc OGxst+KbPqkPj54qMo8EqB5YA5IOBUJjERAHs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ymf7bx9leANTZpwnVQiZwmb6scbgdaMgrPOZD8Is/h4=; b=uD0FmYXk8vYYtkis7HtTcPY2KAIYdwVqoQQrpEMthTNaQjI08IQyOAtRrHQWo7z/Cv KvBgBEilWEz/IZhXdzxXTDpsZ+RiL5vmCdtNpIB6M0sbib94hWyAbvyrhANcAH1rofhq NI4EVbtabe/w0zRIXICE177csYliW8LbJ82bEjRMhdpD/Jqubo4pb5AGIvIoCpio9MJg bcQuKrJKV/aedch7Wo5rAndXNleEf0EX+AS9Ex8Htzo9nmgAZeEDQDbjs1m7TcCSLg7Z E9PPl4w8Tp6QrY2JfAzeZQ40uaAirBypCRb+uIfCWDK3shcJ/qvM0r4KejG4+G2UKWdu Modw== X-Gm-Message-State: AOAM5313ahJ8KlgO9b6iNyRa8fIZha0H7913xHaMM1dIn1da57jgYUAB J90rkt4y5HYrGXnfNVVQRxlV9A== X-Google-Smtp-Source: ABdhPJx1npPfUlgCJtqDACAIBggvwNfmcoJ69MZjwE/kobRR/im0peXQHe7607NtYRxqMjQGTcmx3A== X-Received: by 2002:a63:164a:: with SMTP id 10mr1164348pgw.186.1618612866448; Fri, 16 Apr 2021 15:41:06 -0700 (PDT) Received: from tictac2.mtv.corp.google.com ([2620:15c:202:201:dc8a:c9d0:aa5b:5386]) by smtp.gmail.com with ESMTPSA id r6sm5633659pgp.64.2021.04.16.15.41.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Apr 2021 15:41:06 -0700 (PDT) From: Douglas Anderson To: Andrzej Hajda , Neil Armstrong , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Sam Ravnborg , Wolfram Sang Cc: Stephen Boyd , robdclark@chromium.org, Maarten Lankhorst , Stanislav Lisovskiy , Steev Klimaszewski , Bjorn Andersson , linux-arm-msm@vger.kernel.org, Linus W , Douglas Anderson , Daniel Vetter , David Airlie , Robert Foss , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH v4 12/27] drm/bridge: ti-sn65dsi86: Cleanup managing of drvdata Date: Fri, 16 Apr 2021 15:39:35 -0700 Message-Id: <20210416153909.v4.12.If5d4d4e22e97bebcd493b76765c1759527705620@changeid> X-Mailer: git-send-email 2.31.1.368.gbe11c130af-goog In-Reply-To: <20210416223950.3586967-1-dianders@chromium.org> References: <20210416223950.3586967-1-dianders@chromium.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Let's: - Set the drvdata as soon as it's allocated. This just sets up a pointer so there's no downside here. - Remove the useless call to i2c_set_clientdata() which is literally the same thing as dev_set_drvdata(). No functional changes intended. Signed-off-by: Douglas Anderson --- (no changes since v1) drivers/gpu/drm/bridge/ti-sn65dsi86.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi86.c b/drivers/gpu/drm/bridge/ti-sn65dsi86.c index 2cbf619fbd27..a200e88fd006 100644 --- a/drivers/gpu/drm/bridge/ti-sn65dsi86.c +++ b/drivers/gpu/drm/bridge/ti-sn65dsi86.c @@ -1238,6 +1238,8 @@ static int ti_sn65dsi86_probe(struct i2c_client *client, pdata = devm_kzalloc(dev, sizeof(struct ti_sn65dsi86), GFP_KERNEL); if (!pdata) return -ENOMEM; + dev_set_drvdata(dev, pdata); + pdata->dev = dev; pdata->regmap = devm_regmap_init_i2c(client, &ti_sn65dsi86_regmap_config); @@ -1246,16 +1248,12 @@ static int ti_sn65dsi86_probe(struct i2c_client *client, return PTR_ERR(pdata->regmap); } - pdata->dev = dev; - ret = drm_of_find_panel_or_bridge(dev->of_node, 1, 0, &pdata->panel, NULL); if (ret) { DRM_ERROR("could not find any panel node\n"); return ret; } - dev_set_drvdata(dev, pdata); - pdata->enable_gpio = devm_gpiod_get(dev, "enable", GPIOD_OUT_LOW); if (IS_ERR(pdata->enable_gpio)) { DRM_ERROR("failed to get enable gpio from DT\n"); @@ -1287,8 +1285,6 @@ static int ti_sn65dsi86_probe(struct i2c_client *client, return ret; } - i2c_set_clientdata(client, pdata); - pdata->aux.name = "ti-sn65dsi86-aux"; pdata->aux.dev = dev; pdata->aux.transfer = ti_sn_aux_transfer; -- 2.31.1.368.gbe11c130af-goog From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F08AC43617 for ; Fri, 16 Apr 2021 22:41:16 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D8F6C613CD for ; Fri, 16 Apr 2021 22:41:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D8F6C613CD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0E9AC6ECF3; Fri, 16 Apr 2021 22:41:08 +0000 (UTC) Received: from mail-pg1-x52d.google.com (mail-pg1-x52d.google.com [IPv6:2607:f8b0:4864:20::52d]) by gabe.freedesktop.org (Postfix) with ESMTPS id D13AF6ECE9 for ; Fri, 16 Apr 2021 22:41:06 +0000 (UTC) Received: by mail-pg1-x52d.google.com with SMTP id y32so20129824pga.11 for ; Fri, 16 Apr 2021 15:41:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ymf7bx9leANTZpwnVQiZwmb6scbgdaMgrPOZD8Is/h4=; b=jc6u9p8ciGL2bCqxuj4ZDGRafg8l47hR2Cs2zA5qqs87Co5cL2GIT6wd1jW3ZFwgMQ fALkWO05ogZ8dPwsvZTobEUsF0bYwmWTGWnFCJjI6KZOg+KEQVV0n/eQoXZLNeNes1Oc OGxst+KbPqkPj54qMo8EqB5YA5IOBUJjERAHs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ymf7bx9leANTZpwnVQiZwmb6scbgdaMgrPOZD8Is/h4=; b=N+ed1M//Z2+JXSRiip5Zbbi59vBm4+xJ2F8HjsJ46LnlrHdSLD31wPrqPSden5LZNX VAuIUCB69BMSertg8+2IB2AfnmJ9ooBMmGY3lJdkLdFuvNMPty0Q38wcQy8nFfxZjaDk HL2KqiffhQQIGoch4Xunegm0O8NSn3vxX1bmGOJvSD+cXKbNy6xkWwDZB9d2Gi7vYMxX jQlzl5o9vGhRdzLzf3SKx6foeaKtfLrgSWcXMWdxK3t9fFhXUGl3wCt5v/rnMbW1A99h TgMHQp56AjyVev3aHzJE+5EAmJQiO3axosx8TU8Z0QEcUJin0RS10/5p0O1cP0gyndAa 1sQw== X-Gm-Message-State: AOAM5325ruj85gOuk5o5Q7Q6hyBCKIzT0VjX9eck72qDOuqZiCjHv3tN /yN665Kq/ZM3gVU0sew537cqDA== X-Google-Smtp-Source: ABdhPJx1npPfUlgCJtqDACAIBggvwNfmcoJ69MZjwE/kobRR/im0peXQHe7607NtYRxqMjQGTcmx3A== X-Received: by 2002:a63:164a:: with SMTP id 10mr1164348pgw.186.1618612866448; Fri, 16 Apr 2021 15:41:06 -0700 (PDT) Received: from tictac2.mtv.corp.google.com ([2620:15c:202:201:dc8a:c9d0:aa5b:5386]) by smtp.gmail.com with ESMTPSA id r6sm5633659pgp.64.2021.04.16.15.41.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Apr 2021 15:41:06 -0700 (PDT) From: Douglas Anderson To: Andrzej Hajda , Neil Armstrong , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Sam Ravnborg , Wolfram Sang Subject: [PATCH v4 12/27] drm/bridge: ti-sn65dsi86: Cleanup managing of drvdata Date: Fri, 16 Apr 2021 15:39:35 -0700 Message-Id: <20210416153909.v4.12.If5d4d4e22e97bebcd493b76765c1759527705620@changeid> X-Mailer: git-send-email 2.31.1.368.gbe11c130af-goog In-Reply-To: <20210416223950.3586967-1-dianders@chromium.org> References: <20210416223950.3586967-1-dianders@chromium.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: robdclark@chromium.org, dri-devel@lists.freedesktop.org, David Airlie , linux-arm-msm@vger.kernel.org, Douglas Anderson , Steev Klimaszewski , Bjorn Andersson , Stanislav Lisovskiy , Robert Foss , Stephen Boyd , linux-kernel@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Let's: - Set the drvdata as soon as it's allocated. This just sets up a pointer so there's no downside here. - Remove the useless call to i2c_set_clientdata() which is literally the same thing as dev_set_drvdata(). No functional changes intended. Signed-off-by: Douglas Anderson --- (no changes since v1) drivers/gpu/drm/bridge/ti-sn65dsi86.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi86.c b/drivers/gpu/drm/bridge/ti-sn65dsi86.c index 2cbf619fbd27..a200e88fd006 100644 --- a/drivers/gpu/drm/bridge/ti-sn65dsi86.c +++ b/drivers/gpu/drm/bridge/ti-sn65dsi86.c @@ -1238,6 +1238,8 @@ static int ti_sn65dsi86_probe(struct i2c_client *client, pdata = devm_kzalloc(dev, sizeof(struct ti_sn65dsi86), GFP_KERNEL); if (!pdata) return -ENOMEM; + dev_set_drvdata(dev, pdata); + pdata->dev = dev; pdata->regmap = devm_regmap_init_i2c(client, &ti_sn65dsi86_regmap_config); @@ -1246,16 +1248,12 @@ static int ti_sn65dsi86_probe(struct i2c_client *client, return PTR_ERR(pdata->regmap); } - pdata->dev = dev; - ret = drm_of_find_panel_or_bridge(dev->of_node, 1, 0, &pdata->panel, NULL); if (ret) { DRM_ERROR("could not find any panel node\n"); return ret; } - dev_set_drvdata(dev, pdata); - pdata->enable_gpio = devm_gpiod_get(dev, "enable", GPIOD_OUT_LOW); if (IS_ERR(pdata->enable_gpio)) { DRM_ERROR("failed to get enable gpio from DT\n"); @@ -1287,8 +1285,6 @@ static int ti_sn65dsi86_probe(struct i2c_client *client, return ret; } - i2c_set_clientdata(client, pdata); - pdata->aux.name = "ti-sn65dsi86-aux"; pdata->aux.dev = dev; pdata->aux.transfer = ti_sn_aux_transfer; -- 2.31.1.368.gbe11c130af-goog _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel