From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE175C43603 for ; Fri, 16 Apr 2021 22:41:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A13836137D for ; Fri, 16 Apr 2021 22:41:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235176AbhDPWmA (ORCPT ); Fri, 16 Apr 2021 18:42:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39868 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235262AbhDPWlo (ORCPT ); Fri, 16 Apr 2021 18:41:44 -0400 Received: from mail-pj1-x1035.google.com (mail-pj1-x1035.google.com [IPv6:2607:f8b0:4864:20::1035]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BDC68C061760 for ; Fri, 16 Apr 2021 15:41:17 -0700 (PDT) Received: by mail-pj1-x1035.google.com with SMTP id j21-20020a17090ae615b02901505b998b45so1854921pjy.0 for ; Fri, 16 Apr 2021 15:41:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=WRxEiBxo2TK9eYFaE6Z8QmjhtPKi2ZOYbG3MBiDbq5Q=; b=dMXdGHRO1j71y2Iv2+48IjAI9YY8qkW+j1r2PquWxQUiBGEQRIkzBbRh2GOWbOacTc MtacNteNbERfxUY2N6QuKbKfYAwXWwb9TlSzfQqVWzhYjzbrpdsxY/g5qnlaq+jX8Qtz BJGuMy3uVZxA6SGPfmYi3n+73r1YGoNx1Fe1c= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=WRxEiBxo2TK9eYFaE6Z8QmjhtPKi2ZOYbG3MBiDbq5Q=; b=bDw5Jxx7o6s0sSnZUUHDkSJ/udigTPc7gsAq8BDK+QfxWA/DlwSboTu6NSC/LX+Aoo YLMx7UEcPszw5CbloqgG+3lsFyPoS/RLu4rJiZwPqtuHG52X0XC5RL+87LHn27dwf3Tm zfs38pK5xM5+G8vWMtwcA3lWlW7tdopywLpO7SKyJDJU+ypKeGBx2FI6IJRFLx9TLF5o 9ifSt5VrazguQZELFEYGstt8G3L+HqlsJ1QUhQ/lY/jkpz8cmDfXntXF/t95bhzIaSX+ M2x3kFuZGzDK71uf6M++8YA5ONHmrrjsRMqNUcfEXw3Qg7tJrZDx7G0bRxfxhPVMBqCX QorA== X-Gm-Message-State: AOAM533ryJErzUZpvd6B3v/cASQxArkSbw4zwG8cw1JftLpVXJXrDsjX 1HVjTPr/jMzs0Pg5Nc06CDrKvg== X-Google-Smtp-Source: ABdhPJyWnRznUdTyIvfS7dug/lUV2TaYTjzVaxsnEcIWBHeIiVhb9ryAZZH4fGMUWj2xhxmdm+R7Nw== X-Received: by 2002:a17:90b:344a:: with SMTP id lj10mr12317920pjb.101.1618612877403; Fri, 16 Apr 2021 15:41:17 -0700 (PDT) Received: from tictac2.mtv.corp.google.com ([2620:15c:202:201:dc8a:c9d0:aa5b:5386]) by smtp.gmail.com with ESMTPSA id r6sm5633659pgp.64.2021.04.16.15.41.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Apr 2021 15:41:17 -0700 (PDT) From: Douglas Anderson To: Andrzej Hajda , Neil Armstrong , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Sam Ravnborg , Wolfram Sang Cc: Stephen Boyd , robdclark@chromium.org, Maarten Lankhorst , Stanislav Lisovskiy , Steev Klimaszewski , Bjorn Andersson , linux-arm-msm@vger.kernel.org, Linus W , Douglas Anderson , Daniel Vetter , David Airlie , Thierry Reding , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH v4 22/27] drm/panel: panel-simple: Remove extra call: drm_connector_update_edid_property() Date: Fri, 16 Apr 2021 15:39:45 -0700 Message-Id: <20210416153909.v4.22.Icb581b0273d95cc33ca38676c61ae6d7d2e75357@changeid> X-Mailer: git-send-email 2.31.1.368.gbe11c130af-goog In-Reply-To: <20210416223950.3586967-1-dianders@chromium.org> References: <20210416223950.3586967-1-dianders@chromium.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org As of commit 5186421cbfe2 ("drm: Introduce epoch counter to drm_connector") the drm_get_edid() function calls drm_connector_update_edid_property() for us. There's no reason for us to call it again. Signed-off-by: Douglas Anderson --- As Laurent pointed out [1] this is actually a pretty common problem. His suggestion to do this more broadly is a good idea but this series is probably a bit ambitious already so I would suggest that be taken up separately. [1] https://lore.kernel.org/r/YGphgcESWsozCi1y@pendragon.ideasonboard.com (no changes since v1) drivers/gpu/drm/panel/panel-simple.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c index 90a17ca79d06..c91e8aa108f7 100644 --- a/drivers/gpu/drm/panel/panel-simple.c +++ b/drivers/gpu/drm/panel/panel-simple.c @@ -512,7 +512,6 @@ static int panel_simple_get_modes(struct drm_panel *panel, if (p->ddc) { struct edid *edid = drm_get_edid(connector, p->ddc); - drm_connector_update_edid_property(connector, edid); if (edid) { num += drm_add_edid_modes(connector, edid); kfree(edid); -- 2.31.1.368.gbe11c130af-goog From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 817B7C433ED for ; Fri, 16 Apr 2021 22:41:35 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4E5AA60241 for ; Fri, 16 Apr 2021 22:41:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4E5AA60241 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 03B096ECFF; Fri, 16 Apr 2021 22:41:22 +0000 (UTC) Received: from mail-pj1-x1033.google.com (mail-pj1-x1033.google.com [IPv6:2607:f8b0:4864:20::1033]) by gabe.freedesktop.org (Postfix) with ESMTPS id BFDAD6ECFA for ; Fri, 16 Apr 2021 22:41:17 +0000 (UTC) Received: by mail-pj1-x1033.google.com with SMTP id ot17-20020a17090b3b51b0290109c9ac3c34so17162706pjb.4 for ; Fri, 16 Apr 2021 15:41:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=WRxEiBxo2TK9eYFaE6Z8QmjhtPKi2ZOYbG3MBiDbq5Q=; b=dMXdGHRO1j71y2Iv2+48IjAI9YY8qkW+j1r2PquWxQUiBGEQRIkzBbRh2GOWbOacTc MtacNteNbERfxUY2N6QuKbKfYAwXWwb9TlSzfQqVWzhYjzbrpdsxY/g5qnlaq+jX8Qtz BJGuMy3uVZxA6SGPfmYi3n+73r1YGoNx1Fe1c= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=WRxEiBxo2TK9eYFaE6Z8QmjhtPKi2ZOYbG3MBiDbq5Q=; b=qk1Gw8ML6JenRPBQgsKf25zcTuPjcyL+WhO9s8bsE2xmimfl/aNJiQILG0aguA6JRc bUgRyJgvj2YZQAtDIs2kHO8sQgip+X3DGzg1UuiFoL4DpdnS6d/wWzMBoay3nrVpsAMY h5sL9oG/iAGXjk8nt51V21kfzIIl1YXl0B3VU7oJIvlm0V4vY3+xSwM0Sq9LqdMXg1yZ he8577sY7+UKlRyswaW7YJ9NPyNshcC51W8G881C/8fP4yDDmjIqPJF+U29KCIb9r7pO 6LcW+IZN5ED4yfDi5RgSVKdGJRNgl8e1/Tf37G6ZwdeN0NJHXSkKRLiaO7b7hA2CYtE8 wu3A== X-Gm-Message-State: AOAM532Guay6ReSCWQaCMUcuWdBqoNyEqdxEtTyD85CkspMCtNamnOc/ Reh1i/s3yIlDpn8R9P1jwJn+mg== X-Google-Smtp-Source: ABdhPJyWnRznUdTyIvfS7dug/lUV2TaYTjzVaxsnEcIWBHeIiVhb9ryAZZH4fGMUWj2xhxmdm+R7Nw== X-Received: by 2002:a17:90b:344a:: with SMTP id lj10mr12317920pjb.101.1618612877403; Fri, 16 Apr 2021 15:41:17 -0700 (PDT) Received: from tictac2.mtv.corp.google.com ([2620:15c:202:201:dc8a:c9d0:aa5b:5386]) by smtp.gmail.com with ESMTPSA id r6sm5633659pgp.64.2021.04.16.15.41.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Apr 2021 15:41:17 -0700 (PDT) From: Douglas Anderson To: Andrzej Hajda , Neil Armstrong , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Sam Ravnborg , Wolfram Sang Subject: [PATCH v4 22/27] drm/panel: panel-simple: Remove extra call: drm_connector_update_edid_property() Date: Fri, 16 Apr 2021 15:39:45 -0700 Message-Id: <20210416153909.v4.22.Icb581b0273d95cc33ca38676c61ae6d7d2e75357@changeid> X-Mailer: git-send-email 2.31.1.368.gbe11c130af-goog In-Reply-To: <20210416223950.3586967-1-dianders@chromium.org> References: <20210416223950.3586967-1-dianders@chromium.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: robdclark@chromium.org, David Airlie , linux-arm-msm@vger.kernel.org, Douglas Anderson , Steev Klimaszewski , Bjorn Andersson , Stanislav Lisovskiy , Thierry Reding , dri-devel@lists.freedesktop.org, Stephen Boyd , linux-kernel@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" As of commit 5186421cbfe2 ("drm: Introduce epoch counter to drm_connector") the drm_get_edid() function calls drm_connector_update_edid_property() for us. There's no reason for us to call it again. Signed-off-by: Douglas Anderson --- As Laurent pointed out [1] this is actually a pretty common problem. His suggestion to do this more broadly is a good idea but this series is probably a bit ambitious already so I would suggest that be taken up separately. [1] https://lore.kernel.org/r/YGphgcESWsozCi1y@pendragon.ideasonboard.com (no changes since v1) drivers/gpu/drm/panel/panel-simple.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c index 90a17ca79d06..c91e8aa108f7 100644 --- a/drivers/gpu/drm/panel/panel-simple.c +++ b/drivers/gpu/drm/panel/panel-simple.c @@ -512,7 +512,6 @@ static int panel_simple_get_modes(struct drm_panel *panel, if (p->ddc) { struct edid *edid = drm_get_edid(connector, p->ddc); - drm_connector_update_edid_property(connector, edid); if (edid) { num += drm_add_edid_modes(connector, edid); kfree(edid); -- 2.31.1.368.gbe11c130af-goog _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel