From: Mark Brown <broonie@kernel.org>
To: Joe Burmeister <joe.burmeister@devtank.co.uk>
Cc: linux-spi@vger.kernel.org
Subject: Re: Multi driver SPI chip select count unenforced.
Date: Fri, 16 Apr 2021 16:54:05 +0100 [thread overview]
Message-ID: <20210416155405.GF5560@sirena.org.uk> (raw)
In-Reply-To: <6a6c9d49-9064-4bbe-0330-87f92623d669@devtank.co.uk>
[-- Attachment #1: Type: text/plain, Size: 982 bytes --]
On Fri, Apr 16, 2021 at 11:55:45AM +0100, Joe Burmeister wrote:
> I think I've stubbled into an issue with some SPI drivers.
Like Lukas says you need to copy the maintainers of those drivers.
> Even if the driver did enforce its limit, the returned status could be ignored.
> Patch for that also attached.
See submitting-patches.rst for how to submit a patch to the kernel,
Lukas flagged up most of the issues here.
> So question is, what is the fix. Currently num_chipselect is not only not enforced
> but changed to what is in the device tree by_spi_get_gpio_numbers and
> spi_get_gpio_descs. Some drivers may not really have a limit anyway.
It's really driver specific if it needs or uses the property so any
issues should be at the driver level. Ideally the property should be
completely redundant, we can figure out how many chip selects we need to
handle based on knowing what devices are connected and what the
controller is but the binding was standardised ages ago.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2021-04-16 15:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-16 10:55 Multi driver SPI chip select count unenforced Joe Burmeister
2021-04-16 15:30 ` Lukas Wunner
2021-04-19 12:56 ` Joe Burmeister
2021-04-16 15:54 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210416155405.GF5560@sirena.org.uk \
--to=broonie@kernel.org \
--cc=joe.burmeister@devtank.co.uk \
--cc=linux-spi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.