From: Ville Syrjala <ville.syrjala@linux.intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [PATCH i-g-t 2/6] tests/kms_flip_scaled_crc: Don't leak the fbs between subtests
Date: Fri, 16 Apr 2021 20:53:08 +0300 [thread overview]
Message-ID: <20210416175312.25190-3-ville.syrjala@linux.intel.com> (raw)
In-Reply-To: <20210416175312.25190-1-ville.syrjala@linux.intel.com>
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
Clean up the fbs properly before starting the next subtest, otherwise
it'll keep using the old fb and not even testing what it claims to be
testing.
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
tests/kms_flip_scaled_crc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/kms_flip_scaled_crc.c b/tests/kms_flip_scaled_crc.c
index 8153fb890a17..2b3087eb7b54 100644
--- a/tests/kms_flip_scaled_crc.c
+++ b/tests/kms_flip_scaled_crc.c
@@ -223,11 +223,11 @@ igt_main
for (int index = 0; index < ARRAY_SIZE(flip_scenario_test); index++) {
igt_describe(flip_scenario_test[index].describe);
igt_subtest(flip_scenario_test[index].name) {
+ free_fbs(&data);
for_each_pipe_with_single_output(&data.display, pipe,
output)
test_flip_to_scaled(&data, index, pipe, output);
- free_fbs(&data);
}
}
igt_fixture {
--
2.26.3
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2021-04-16 17:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-16 17:53 [igt-dev] [PATCH i-g-t 0/6] tests/kms_flip_scaled_crc: Fix a bunch of fail Ville Syrjala
2021-04-16 17:53 ` [igt-dev] [PATCH i-g-t 1/6] tests/kms_flip_scaled_crc: Remove open coded igt_create_color_fb() Ville Syrjala
2021-04-16 17:53 ` Ville Syrjala [this message]
2021-04-16 17:53 ` [igt-dev] [PATCH i-g-t 3/6] tests/kms_flip_scaled_crc: Use igt_assert_crc_equal() Ville Syrjala
2021-04-16 17:53 ` [igt-dev] [PATCH i-g-t 4/6] tests/kms_flip_scaled_crc: Clean up pipe crc before subtest Ville Syrjala
2021-04-16 17:53 ` [igt-dev] [PATCH i-g-t 5/6] tests/kms_flip_scaled_crc: Check that the plane supports the format+modifier Ville Syrjala
2021-04-16 17:53 ` [igt-dev] [PATCH i-g-t 6/6] tests/kms_flip_scaled_crc: Limit pipe output to 8bpc Ville Syrjala
2021-04-16 19:17 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_flip_scaled_crc: Fix a bunch of fail Patchwork
2021-04-16 20:59 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2021-04-20 12:21 ` [igt-dev] [PATCH i-g-t 0/6] " Juha-Pekka Heikkila
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210416175312.25190-3-ville.syrjala@linux.intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.